Protobuf Team Bot
1eaba72b7c
Auto-generate files after cl/606340283
1 year ago
Protobuf Team Bot
52f9ea88d8
No longer allow minidescriptors to accept message fields tagged as proto3 scalar (implicit presence)
...
PiperOrigin-RevId: 606340283
1 year ago
Protobuf Team Bot
9473beb76c
Up the upb scratch space from 64000 bytes to 65536 bytes since 64 KiB is the maximum supported message size in upb.
...
PiperOrigin-RevId: 606321230
1 year ago
Joshua Haberman
776d072fa1
Removed obsolete TODO.
...
PiperOrigin-RevId: 606317655
1 year ago
Sandy Zhang
b9273fa7c7
Fix CMake regex escaping.
...
CMake documentation (https://cmake.org/cmake/help/latest/command/string.html#regex-replace ) indicates subexpressions are actually referenced via \1 not $1 in cmake.
PiperOrigin-RevId: 606307156
1 year ago
Protobuf Team Bot
78a3f8a8cb
Correct error message to indicate user should provide experimental-codegen=enabled to --rust_opt
...
PiperOrigin-RevId: 606306382
1 year ago
Protobuf Team Bot
b184cdd59d
Auto-generate files after cl/606282881
1 year ago
Eric Salo
a5d9b0522c
upb: delete upb_Message_IsExactlyEqual()
...
PiperOrigin-RevId: 606282881
1 year ago
Protobuf Team Bot
56409303b1
Auto-generate files after cl/606262924
1 year ago
Eric Salo
b5957f108a
upb: implement _upb_Arena_Contains()
...
PiperOrigin-RevId: 606262924
1 year ago
Protobuf Team Bot
2dd2dfaca3
Rename use_cpp_toolchain in protos/bazel/cc_proto_library.bzl, for consistency.
...
This now matches the upb_use_cpp_toolchain function name in the equivalent function in third_party/upb/bazel/upb_proto_library_internal/cc_library_func.bzl.
PiperOrigin-RevId: 606257428
1 year ago
Marcel Hlopko
73769a030d
Fix msan issue in Map<bool,*>
...
PiperOrigin-RevId: 606164792
1 year ago
Protobuf Team Bot
e3dcdfddcf
Auto-generate files after cl/605718863
1 year ago
Eric Salo
c69ed472cd
upb: implement minitable-based field iterators
...
PiperOrigin-RevId: 605718863
1 year ago
Protobuf Team Bot
833451eaf3
Protoc Internal changes.
...
PiperOrigin-RevId: 605658497
1 year ago
Protobuf Team Bot
5e55d11bcd
Auto-generate files after cl/605625455
1 year ago
Protobuf Team Bot
d7885ebc37
Add direct-to-table support for MessageSet types.
...
PiperOrigin-RevId: 605625455
1 year ago
Marcel Hlopko
5842cc9c3d
Implement support for messages as map values
...
PiperOrigin-RevId: 605581725
1 year ago
Protobuf Team Bot
7da29c6a13
Minor cleanup: IWYU, etc.
...
PiperOrigin-RevId: 605475996
1 year ago
Sandy Zhang
e62243482e
Escape _from_dir in install.cmake for regex special characters (e.g. c++) before REGEX REPLACE.
...
PiperOrigin-RevId: 605469982
1 year ago
Protobuf Team Bot
f82c2ef0db
Minor cleanup: whitelist --> allowlist
...
PiperOrigin-RevId: 605439980
1 year ago
Protobuf Team Bot
b3878b5ae3
Auto-generate files after cl/605413999
1 year ago
Eric Salo
b0d3a787cc
upb: Simplify inline functions in mini_table/ and mem/ and wire/ and message/
...
PiperOrigin-RevId: 605413999
1 year ago
Protobuf Team Bot
5427138178
Remove rust proto libraries from the editions/BUILD file.
...
PiperOrigin-RevId: 605397582
1 year ago
Protobuf Team Bot
9443f08fad
Auto-generate files after cl/605368710
1 year ago
Protobuf Team Bot
2fc7022879
Adds string view fields whose accessors are absl::string_view based.
...
PiperOrigin-RevId: 605368710
1 year ago
Protobuf Team Bot
55e50ba406
C#: Ignore invalid enum string values in JSON, when invalid fields are being ignored.
...
PiperOrigin-RevId: 605310357
1 year ago
Protobuf Team Bot
959e5df20f
Minor cleanup: IWYU, clang-tidy.
...
PiperOrigin-RevId: 605131702
1 year ago
Adam Cozzette
220548f30c
Add missing alias targets for C++ util libraries
...
Until recently, these targets were dependencies of `//:protobuf` and could thus
be accessed through that target. But now that we are adhering to the layering
check, we need to provide proper access in a way that respects that check. This
change uses top-level alias targets following the existing pattern.
PiperOrigin-RevId: 605123979
1 year ago
Protobuf Team Bot
4767a309d3
Auto-generate files after cl/605097398
1 year ago
Joshua Haberman
49fdc9d1cd
Rewrote the comment about the `java_string_check_utf8` option to fix a few errors and omissions.
...
- The comment stated that the option does not affect lite, but this appears to be false: in my testing the option affects both lite and full protos.
- The comment failed to mention that the option has no effect when set explicitly to false. It can only be used to opt proto2 into extra checking, it cannot opt proto3 out of the checks.
PiperOrigin-RevId: 605097398
1 year ago
Protobuf Team Bot
afd1c0d653
Add a test that when using an Arena from a single thread, objects are destroyed in reverse order from construction.
...
PiperOrigin-RevId: 605085198
1 year ago
Protobuf Team Bot
31920e9548
Auto-generate files after cl/605067418
1 year ago
Ilya Tokar
948ca2e0f3
Add software prefetch to ByteSizeLong
...
Mkaes ByteSizeLong faster:
BM_ByteSizeLong 15.7µs ± 4% 14.9µs ± 6% -5.17% (p=0.000 n=20+20)
PiperOrigin-RevId: 605067418
1 year ago
Protobuf Team Bot
85a80488ff
Fix unnecessary generation of PostLoopHandler when tracking is on, but
...
OnDeserialize is disabled.
PiperOrigin-RevId: 605060804
1 year ago
Matt Kulukundis
38c0f6d01c
Switch rank structs to be consistent with written guidance in go/ranked-overloads
...
PiperOrigin-RevId: 605015758
1 year ago
Joshua Haberman
ffd7e1702a
Updated freshness on several docs, and made some minor updates to the content.
...
PiperOrigin-RevId: 604993985
1 year ago
Protobuf Team Bot
f55a9b4936
Use the post-loop hook to invoke the tracker when parsing via TcParser.
...
PiperOrigin-RevId: 604780875
1 year ago
Protobuf Team Bot
a2cdf59778
Adding Edition 2023 z_generated_example.
...
PiperOrigin-RevId: 604754130
1 year ago
Alyssa Haroldsen
a522a47120
Validate that map keys are copied
...
PiperOrigin-RevId: 604716574
1 year ago
Alyssa Haroldsen
398508287e
Correct ExactSizeIterator impl for RepeatedIter
...
- size_hint must be implemented as described in the docs
- len/size_hint must return the number of items remaining in the iterator, not the size of the container
PiperOrigin-RevId: 604704172
1 year ago
Alyssa Haroldsen
3ccccdb855
Copy repeated string/bytes in upb when pushing/setting/copying
...
This memory management should be handled by Rust.
I've confirmed this works by running the new included tests with msan.
The sanitizer is necessary to detect an incorrect copy_from impl
that uses-after-free from the upb arena.
PiperOrigin-RevId: 604689154
1 year ago
Adam Cozzette
e8535e70da
Internal change
...
PiperOrigin-RevId: 604672870
1 year ago
Alyssa Haroldsen
01312f9c34
Add RepeatedIter to public protobuf items
...
PiperOrigin-RevId: 604554509
1 year ago
Alyssa Haroldsen
a9bcb60dc5
Remove RepeatedIterMut
...
Mutator access in repeated and map is a 1.0 feature.
PiperOrigin-RevId: 604554490
1 year ago
Éamonn McManus
3c2fa8f21c
Internal change.
...
PiperOrigin-RevId: 604537991
1 year ago
Mariano Simone
11eab86cc0
[Ruby] Delegate difference, intersection, union from RepeatedField to Array ( #15652 )
...
Coming from [[protobuf/issues/15180] [Ruby] Support for currently ignored Array methods in `RepeatedField`](https://github.com/protocolbuffers/protobuf/issues/15180 )
This adds a couple of `Array` methods to what gets delegated from `RepeatedField`.
- `intersection`, because `|` was already delegated
- `union`, because `&` was already delegated
- `difference`, because `-` was already delegated
Closes #15652
COPYBARA_INTEGRATE_REVIEW=https://github.com/protocolbuffers/protobuf/pull/15652 from marianosimone:delegate_rb_array_methods 2971981338
PiperOrigin-RevId: 604534655
1 year ago
Jiri Pechanec
c98bdc2bdc
Add missing generated file ( #15693 )
...
The proto file is required for Java test. Otherwise it fails with
```
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.6.1:testCompile (default-testCompile) on project protobuf-java: Compilation failure: Compilation failure:
[ERROR] /tmp/protocolbuffers-protobuf-3.25.2/java/core/src/test/java/com/google/protobuf/DescriptorsTest.java:[46,25] cannot find symbol
[ERROR] symbol: class UnittestRetention
[ERROR] location: package protobuf_unittest
[ERROR] /tmp/protocolbuffers-protobuf-3.25.2/java/core/src/test/java/com/google/protobuf/DescriptorsTest.java:[550,27] cannot find symbol
[ERROR] symbol: variable UnittestRetention
[ERROR] location: class com.google.protobuf.DescriptorsTest
[ERROR] /tmp/protocolbuffers-protobuf-3.25.2/java/core/src/test/java/com/google/protobuf/DescriptorsTest.java:[551,37] cannot find symbol
[ERROR] symbol: variable UnittestRetention
[ERROR] location: class com.google.protobuf.DescriptorsTest
[ERROR] /tmp/protocolbuffers-protobuf-3.25.2/java/core/src/test/java/com/google/protobuf/DescriptorsTest.java:[552,37] cannot find symbol
[ERROR] symbol: variable UnittestRetention
[ERROR] location: class com.google.protobuf.DescriptorsTest
[ERROR] /tmp/protocolbuffers-protobuf-3.25.2/java/core/src/test/java/com/google/protobuf/DescriptorsTest.java:[553,37] cannot find symbol
[ERROR] symbol: variable UnittestRetention
[ERROR] location: class com.google.protobuf.DescriptorsTest
[ERROR] -> [Help 1]
```
Closes #15693
COPYBARA_INTEGRATE_REVIEW=https://github.com/protocolbuffers/protobuf/pull/15693 from jpechane:add-missing-file 9293fabf1f
PiperOrigin-RevId: 604518500
1 year ago
Luke Sandberg
5d4fd7ef84
Clarify docs on MapFieldReflectionAccessorInternal and add tests for the mutability of lists returned from `getAllFields()`
...
PiperOrigin-RevId: 604508075
1 year ago
Alyssa Haroldsen
d445953603
Add map key and value iterators
...
PiperOrigin-RevId: 604495084
1 year ago