From fdcb5d17b9fad351b730677025a9b19743cba2b7 Mon Sep 17 00:00:00 2001 From: Mike Kruskal Date: Wed, 11 Oct 2023 09:22:49 -0700 Subject: [PATCH] Use large runners for ASAN and MSAN builds These tests were right near the threshold for disk space on default runners, and recently got pushed over (~18G). The cheapest large runner has 150G of SSD storage, and won't likely hit this issue again. PiperOrigin-RevId: 572596499 --- .github/workflows/test_cpp.yml | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/.github/workflows/test_cpp.yml b/.github/workflows/test_cpp.yml index 9da5018773..511f9ec189 100644 --- a/.github/workflows/test_cpp.yml +++ b/.github/workflows/test_cpp.yml @@ -19,9 +19,8 @@ jobs: config: - { name: Optimized, flags: --config=opt } - { name: Debug, flags: --config=dbg } - # TODO Re-enable these once the disk space issues have been resolved. - #- { name: ASAN, flags: --config=asan } - #- { name: MSAN, flags: --config=docker-msan } + - { name: ASAN, flags: --config=asan, runner: ubuntu-22-large } + - { name: MSAN, flags: --config=docker-msan, runner: ubuntu-22-large } - { name: TSAN, flags: --config=tsan } - { name: UBSAN, flags: --config=ubsan } - { name: No-RTTI, flags: --cxxopt=-fno-rtti } @@ -38,7 +37,7 @@ jobs: targets: "//src/... //src/google/protobuf/compiler:protoc_aarch64_test" image: "us-docker.pkg.dev/protobuf-build/containers/test/linux/emulation:aarch64-63dd26c0c7a808d92673a3e52e848189d4ab0f17" name: Linux ${{ matrix.config.name }} - runs-on: ubuntu-latest + runs-on: ${{ matrix.config.runner || 'ubuntu-latest' }} steps: - name: Checkout pending changes uses: protocolbuffers/protobuf-ci/checkout@v2