From fc75bf3fdc68c31d1000bf3dbde34b275fb3366a Mon Sep 17 00:00:00 2001 From: Eric Salo Date: Thu, 21 Sep 2023 09:37:33 -0700 Subject: [PATCH] upb: fix most of the ClangTidy warnings in util/required_fields.? PiperOrigin-RevId: 567333328 --- upb/upb/util/BUILD | 2 ++ upb/upb/util/required_fields.c | 10 ++++++++++ upb/upb/util/required_fields.h | 2 ++ 3 files changed, 14 insertions(+) diff --git a/upb/upb/util/BUILD b/upb/upb/util/BUILD index dc9f4eca2f..46b852153b 100644 --- a/upb/upb/util/BUILD +++ b/upb/upb/util/BUILD @@ -97,7 +97,9 @@ cc_library( hdrs = ["required_fields.h"], visibility = ["//visibility:public"], deps = [ + "//upb:base", "//upb:collections", + "//upb:message_types", "//upb:port", "//upb:reflection", ], diff --git a/upb/upb/util/required_fields.c b/upb/upb/util/required_fields.c index d0e0557985..7059786944 100644 --- a/upb/upb/util/required_fields.c +++ b/upb/upb/util/required_fields.c @@ -30,11 +30,21 @@ #include "upb/upb/util/required_fields.h" +#include #include +#include #include +#include +#include +#include +#include +#include "upb/upb/base/descriptor_constants.h" +#include "upb/upb/collections/array.h" #include "upb/upb/collections/map.h" +#include "upb/upb/message/types.h" #include "upb/upb/port/vsnprintf_compat.h" +#include "upb/upb/reflection/def.h" #include "upb/upb/reflection/message.h" // Must be last. diff --git a/upb/upb/util/required_fields.h b/upb/upb/util/required_fields.h index c7aa5d537c..e8c3763bc1 100644 --- a/upb/upb/util/required_fields.h +++ b/upb/upb/util/required_fields.h @@ -31,6 +31,8 @@ #ifndef UPB_UTIL_REQUIRED_FIELDS_H_ #define UPB_UTIL_REQUIRED_FIELDS_H_ +#include + #include "upb/upb/reflection/def.h" #include "upb/upb/reflection/message.h"