Expand LazySerializerEmitter to cover proto3 cases.

This should provide some performance wins for proto3, similar to the ones added years ago for proto2.

PiperOrigin-RevId: 513853367
pull/12133/head
Mike Kruskal 2 years ago committed by Copybara-Service
parent eaa8f24aa6
commit fab7f928b5
  1. 8
      src/google/protobuf/compiler/cpp/message.cc

@ -3639,8 +3639,6 @@ void MessageGenerator::GenerateSerializeWithCachedSizesBody(io::Printer* p) {
LazySerializerEmitter(MessageGenerator* mg, io::Printer* p) LazySerializerEmitter(MessageGenerator* mg, io::Printer* p)
: mg_(mg), : mg_(mg),
p_(p), p_(p),
eager_(mg->descriptor_->file()->syntax() ==
FileDescriptor::SYNTAX_PROTO3),
cached_has_bit_index_(kNoHasbit) {} cached_has_bit_index_(kNoHasbit) {}
~LazySerializerEmitter() { Flush(); } ~LazySerializerEmitter() { Flush(); }
@ -3649,13 +3647,14 @@ void MessageGenerator::GenerateSerializeWithCachedSizesBody(io::Printer* p) {
// oneof, and handle them at the next Flush(). // oneof, and handle them at the next Flush().
void Emit(const FieldDescriptor* field) { void Emit(const FieldDescriptor* field) {
Formatter format(p_); Formatter format(p_);
if (eager_ || MustFlush(field)) {
if (!field->has_presence() || MustFlush(field)) {
Flush(); Flush();
} }
if (!field->real_containing_oneof()) { if (!field->real_containing_oneof()) {
// TODO(ckennelly): Defer non-oneof fields similarly to oneof fields. // TODO(ckennelly): Defer non-oneof fields similarly to oneof fields.
if (!field->options().weak() && !field->is_repeated() && !eager_) { if (HasHasbit(field) && field->has_presence()) {
// We speculatively load the entire _has_bits_[index] contents, even // We speculatively load the entire _has_bits_[index] contents, even
// if it is for only one field. Deferring non-oneof emitting would // if it is for only one field. Deferring non-oneof emitting would
// allow us to determine whether this is going to be useful. // allow us to determine whether this is going to be useful.
@ -3699,7 +3698,6 @@ void MessageGenerator::GenerateSerializeWithCachedSizesBody(io::Printer* p) {
MessageGenerator* mg_; MessageGenerator* mg_;
io::Printer* p_; io::Printer* p_;
bool eager_;
std::vector<const FieldDescriptor*> v_; std::vector<const FieldDescriptor*> v_;
// cached_has_bit_index_ maintains that: // cached_has_bit_index_ maintains that:

Loading…
Cancel
Save