From 065d3c740988263ad4a8d7dd765d164506119b14 Mon Sep 17 00:00:00 2001 From: ArnoldZokas Date: Thu, 2 Dec 2010 19:40:32 +0000 Subject: [PATCH 1/6] Removed redundant shell script --- build/BuildBenchmark.ps1 | 13 ------------- 1 file changed, 13 deletions(-) delete mode 100644 build/BuildBenchmark.ps1 diff --git a/build/BuildBenchmark.ps1 b/build/BuildBenchmark.ps1 deleted file mode 100644 index c301a1ca32..0000000000 --- a/build/BuildBenchmark.ps1 +++ /dev/null @@ -1,13 +0,0 @@ -write-host `nRunning build. Please wait... - -$iterations = 10 - -for ($i=1; $i -le $iterations; $i++) -{ - $sw = [System.Diagnostics.StopWatch]::StartNew() - & E:\dotnet-protobufs\build\BuildAll.bat - $sw.Stop() - $msbuildTotalRunTime += $sw.ElapsedMilliseconds -} - -write-host `nMSBuild average speed over $iterations iterations: ($msbuildTotalRunTime/$iterations) milliseconds \ No newline at end of file From a02f9891d7abc2eff585dab544e287de39410822 Mon Sep 17 00:00:00 2001 From: ArnoldZokas Date: Thu, 2 Dec 2010 19:48:51 +0000 Subject: [PATCH 2/6] Added 'Any CPU' platform switch to all msbuild calls --- build/Build.bat | 2 +- build/BuildAll.bat | 4 ++-- build/BuildSilverlight2.bat | 2 +- build/GenerateCompletePackage.bat | 10 +++++----- build/GenerateReleasePackage.bat | 6 +++--- build/RunBenchmarks .bat | 2 +- 6 files changed, 13 insertions(+), 13 deletions(-) diff --git a/build/Build.bat b/build/Build.bat index f17fac9a9b..9cfce7c733 100644 --- a/build/Build.bat +++ b/build/Build.bat @@ -1,5 +1,5 @@ @echo off -%WINDIR%\Microsoft.NET\Framework\v4.0.30319\msbuild build.csproj /m /t:Build /p:BuildConfiguration=Debug +%WINDIR%\Microsoft.NET\Framework\v4.0.30319\msbuild build.csproj /m /t:Build /p:BuildConfiguration=Debug /p:Platform="Any CPU" pause \ No newline at end of file diff --git a/build/BuildAll.bat b/build/BuildAll.bat index 6e6e152862..9e0277480d 100644 --- a/build/BuildAll.bat +++ b/build/BuildAll.bat @@ -1,8 +1,8 @@ @ECHO OFF -%WINDIR%\Microsoft.NET\Framework\v4.0.30319\msbuild build.csproj /m /t:Build /p:BuildConfiguration=Debug +%WINDIR%\Microsoft.NET\Framework\v4.0.30319\msbuild build.csproj /m /t:Build /p:BuildConfiguration=Debug /p:Platform="Any CPU" IF ERRORLEVEL 1 GOTO END -%WINDIR%\Microsoft.NET\Framework\v4.0.30319\msbuild build.csproj /m /t:Build /p:BuildConfiguration=Debug_Silverlight2 +%WINDIR%\Microsoft.NET\Framework\v4.0.30319\msbuild build.csproj /m /t:Build /p:BuildConfiguration=Debug_Silverlight2 /p:Platform="Any CPU" :END PAUSE \ No newline at end of file diff --git a/build/BuildSilverlight2.bat b/build/BuildSilverlight2.bat index f875cf2e1b..bc1dd21e97 100644 --- a/build/BuildSilverlight2.bat +++ b/build/BuildSilverlight2.bat @@ -1,5 +1,5 @@ @echo off -%WINDIR%\Microsoft.NET\Framework\v4.0.30319\msbuild build.csproj /m /t:Build /p:BuildConfiguration=Debug_Silverlight2 +%WINDIR%\Microsoft.NET\Framework\v4.0.30319\msbuild build.csproj /m /t:Build /p:BuildConfiguration=Debug_Silverlight2 /p:Platform="Any CPU" pause \ No newline at end of file diff --git a/build/GenerateCompletePackage.bat b/build/GenerateCompletePackage.bat index d97ae9b9a4..63a0d29e93 100644 --- a/build/GenerateCompletePackage.bat +++ b/build/GenerateCompletePackage.bat @@ -1,17 +1,17 @@ @ECHO OFF -%WINDIR%\Microsoft.NET\Framework\v4.0.30319\msbuild build.csproj /m /t:Build;PreparePackageComponent /p:BuildConfiguration=Debug +%WINDIR%\Microsoft.NET\Framework\v4.0.30319\msbuild build.csproj /m /t:Build;PreparePackageComponent /p:BuildConfiguration=Debug /p:Platform="Any CPU" IF ERRORLEVEL 1 GOTO END -%WINDIR%\Microsoft.NET\Framework\v4.0.30319\msbuild build.csproj /m /t:Build;PreparePackageComponent /p:BuildConfiguration=Debug_Silverlight2 +%WINDIR%\Microsoft.NET\Framework\v4.0.30319\msbuild build.csproj /m /t:Build;PreparePackageComponent /p:BuildConfiguration=Debug_Silverlight2 /p:Platform="Any CPU" IF ERRORLEVEL 1 GOTO END -%WINDIR%\Microsoft.NET\Framework\v4.0.30319\msbuild build.csproj /m /t:Build;PreparePackageComponent /p:BuildConfiguration=Release +%WINDIR%\Microsoft.NET\Framework\v4.0.30319\msbuild build.csproj /m /t:Build;PreparePackageComponent /p:BuildConfiguration=Release /p:Platform="Any CPU" IF ERRORLEVEL 1 GOTO END -%WINDIR%\Microsoft.NET\Framework\v4.0.30319\msbuild build.csproj /m /t:Build;PreparePackageComponent /p:BuildConfiguration=Release_Silverlight2 +%WINDIR%\Microsoft.NET\Framework\v4.0.30319\msbuild build.csproj /m /t:Build;PreparePackageComponent /p:BuildConfiguration=Release_Silverlight2 /p:Platform="Any CPU" IF ERRORLEVEL 1 GOTO END -%WINDIR%\Microsoft.NET\Framework\v4.0.30319\msbuild build.csproj /m /t:GeneratePackage /p:PackageName=AllBinariesAndSource.zip +%WINDIR%\Microsoft.NET\Framework\v4.0.30319\msbuild build.csproj /m /t:GeneratePackage /p:PackageName=AllBinariesAndSource.zip /p:Platform="Any CPU" :END PAUSE \ No newline at end of file diff --git a/build/GenerateReleasePackage.bat b/build/GenerateReleasePackage.bat index f70d3288a4..30e05bad83 100644 --- a/build/GenerateReleasePackage.bat +++ b/build/GenerateReleasePackage.bat @@ -1,11 +1,11 @@ @ECHO OFF -%WINDIR%\Microsoft.NET\Framework\v4.0.30319\msbuild build.csproj /m /t:Build;PreparePackageComponent /p:BuildConfiguration=Release +%WINDIR%\Microsoft.NET\Framework\v4.0.30319\msbuild build.csproj /m /t:Build;PreparePackageComponent /p:BuildConfiguration=Release /p:Platform="Any CPU" IF ERRORLEVEL 1 GOTO END -%WINDIR%\Microsoft.NET\Framework\v4.0.30319\msbuild build.csproj /m /t:Build;PreparePackageComponent /p:BuildConfiguration=Release_Silverlight2 +%WINDIR%\Microsoft.NET\Framework\v4.0.30319\msbuild build.csproj /m /t:Build;PreparePackageComponent /p:BuildConfiguration=Release_Silverlight2 /p:Platform="Any CPU" IF ERRORLEVEL 1 GOTO END -%WINDIR%\Microsoft.NET\Framework\v4.0.30319\msbuild build.csproj /m /t:GeneratePackage /p:PackageName=ReleaseBinaries.zip +%WINDIR%\Microsoft.NET\Framework\v4.0.30319\msbuild build.csproj /m /t:GeneratePackage /p:PackageName=ReleaseBinaries.zip /p:Platform="Any CPU" :END PAUSE \ No newline at end of file diff --git a/build/RunBenchmarks .bat b/build/RunBenchmarks .bat index 5ac235bfcc..944e15aba9 100644 --- a/build/RunBenchmarks .bat +++ b/build/RunBenchmarks .bat @@ -1,5 +1,5 @@ @echo off -%WINDIR%\Microsoft.NET\Framework\v4.0.30319\msbuild build.csproj /m /t:RunBenchmarks /p:BuildConfiguration=Release +%WINDIR%\Microsoft.NET\Framework\v4.0.30319\msbuild build.csproj /m /t:RunBenchmarks /p:BuildConfiguration=Release /p:Platform="Any CPU" pause \ No newline at end of file From 649eb54a99166127d1f4ff2df4953ae204f7da13 Mon Sep 17 00:00:00 2001 From: ArnoldZokas Date: Wed, 8 Dec 2010 20:27:01 +0000 Subject: [PATCH 3/6] Fixed a bug in the build process that caused ReleaseBinaries package to be populated with redundant empty directories --- build/Common.targets | 11 ++++++++--- build/GenerateCompletePackage.bat | 3 +++ build/GenerateReleasePackage.bat | 3 +++ build/build.csproj | 1 + 4 files changed, 15 insertions(+), 3 deletions(-) diff --git a/build/Common.targets b/build/Common.targets index e26bc07a2c..8b4238731c 100644 --- a/build/Common.targets +++ b/build/Common.targets @@ -34,14 +34,19 @@ + + + + + + + + - - - diff --git a/build/GenerateCompletePackage.bat b/build/GenerateCompletePackage.bat index 63a0d29e93..959dc788b5 100644 --- a/build/GenerateCompletePackage.bat +++ b/build/GenerateCompletePackage.bat @@ -1,4 +1,7 @@ @ECHO OFF +%WINDIR%\Microsoft.NET\Framework\v4.0.30319\msbuild build.csproj /m /t:PrepareOutputDirectory +IF ERRORLEVEL 1 GOTO END + %WINDIR%\Microsoft.NET\Framework\v4.0.30319\msbuild build.csproj /m /t:Build;PreparePackageComponent /p:BuildConfiguration=Debug /p:Platform="Any CPU" IF ERRORLEVEL 1 GOTO END diff --git a/build/GenerateReleasePackage.bat b/build/GenerateReleasePackage.bat index 30e05bad83..70111b74c1 100644 --- a/build/GenerateReleasePackage.bat +++ b/build/GenerateReleasePackage.bat @@ -1,4 +1,7 @@ @ECHO OFF +%WINDIR%\Microsoft.NET\Framework\v4.0.30319\msbuild build.csproj /m /t:PrepareOutputDirectory +IF ERRORLEVEL 1 GOTO END + %WINDIR%\Microsoft.NET\Framework\v4.0.30319\msbuild build.csproj /m /t:Build;PreparePackageComponent /p:BuildConfiguration=Release /p:Platform="Any CPU" IF ERRORLEVEL 1 GOTO END diff --git a/build/build.csproj b/build/build.csproj index 50e2207a31..7bc65894f2 100644 --- a/build/build.csproj +++ b/build/build.csproj @@ -95,6 +95,7 @@ + From 8a13536f9b49d2f42477f320f678aab715b4e6ed Mon Sep 17 00:00:00 2001 From: Jon Skeet Date: Sun, 12 Dec 2010 12:55:18 +0000 Subject: [PATCH 4/6] Remove Silverlight targets for all but the main project. BuildAll now fails - asking Arnold for help! --- src/AddressBook/AddressBook.csproj | 21 ------- src/ProtoBench/ProtoBench.csproj | 21 ------- src/ProtoDump/ProtoDump.csproj | 21 ------- src/ProtoGen.Test/ProtoGen.Test.csproj | 21 ------- src/ProtoGen/ProtoGen.csproj | 21 ------- src/ProtoMunge/ProtoMunge.csproj | 21 ------- .../ProtocolBuffers.Test.csproj | 24 +------- src/ProtocolBuffers.sln | 56 +++++++++---------- src/ProtocolBuffers/ProtocolBuffers.csproj | 6 +- 9 files changed, 34 insertions(+), 178 deletions(-) diff --git a/src/AddressBook/AddressBook.csproj b/src/AddressBook/AddressBook.csproj index 96fc33652c..6024b807f7 100644 --- a/src/AddressBook/AddressBook.csproj +++ b/src/AddressBook/AddressBook.csproj @@ -53,27 +53,6 @@ 4 AllRules.ruleset - - true - full - false - bin\Debug_Silverlight2\ - DEBUG;TRACE;SILVERLIGHT2 - prompt - 4 - true - AllRules.ruleset - - - pdbonly - true - bin\Release_Silverlight2\ - TRACE;SILVERLIGHT2 - prompt - 4 - true - AllRules.ruleset - diff --git a/src/ProtoBench/ProtoBench.csproj b/src/ProtoBench/ProtoBench.csproj index b79b145fba..927a255702 100644 --- a/src/ProtoBench/ProtoBench.csproj +++ b/src/ProtoBench/ProtoBench.csproj @@ -53,27 +53,6 @@ 4 AllRules.ruleset - - true - full - false - bin\Debug_Silverlight2\ - DEBUG;TRACE;SILVERLIGHT2 - prompt - 4 - true - AllRules.ruleset - - - pdbonly - true - bin\Release_Silverlight2\ - TRACE;SILVERLIGHT2 - prompt - 4 - true - AllRules.ruleset - diff --git a/src/ProtoDump/ProtoDump.csproj b/src/ProtoDump/ProtoDump.csproj index 964498cba4..9e14573683 100644 --- a/src/ProtoDump/ProtoDump.csproj +++ b/src/ProtoDump/ProtoDump.csproj @@ -52,27 +52,6 @@ 4 AllRules.ruleset - - true - full - false - bin\Debug_Silverlight2\ - DEBUG;TRACE;SILVERLIGHT2 - prompt - 4 - true - AllRules.ruleset - - - pdbonly - true - bin\Release_Silverlight2\ - TRACE;SILVERLIGHT2 - prompt - 4 - true - AllRules.ruleset - diff --git a/src/ProtoGen.Test/ProtoGen.Test.csproj b/src/ProtoGen.Test/ProtoGen.Test.csproj index 869e731829..a3b372a221 100644 --- a/src/ProtoGen.Test/ProtoGen.Test.csproj +++ b/src/ProtoGen.Test/ProtoGen.Test.csproj @@ -54,27 +54,6 @@ 4 AllRules.ruleset - - true - full - false - bin\Debug_Silverlight2\ - DEBUG;TRACE;SILVERLIGHT2 - prompt - 4 - true - AllRules.ruleset - - - pdbonly - true - bin\Release_Silverlight2\ - TRACE;SILVERLIGHT2 - prompt - 4 - true - AllRules.ruleset - False diff --git a/src/ProtoGen/ProtoGen.csproj b/src/ProtoGen/ProtoGen.csproj index 6ddefa8ef9..e771d05581 100644 --- a/src/ProtoGen/ProtoGen.csproj +++ b/src/ProtoGen/ProtoGen.csproj @@ -55,27 +55,6 @@ 4 AllRules.ruleset - - true - full - false - bin\Debug_Silverlight2\ - DEBUG;TRACE;SILVERLIGHT2 - prompt - 4 - true - AllRules.ruleset - - - pdbonly - true - bin\Release_Silverlight2\ - TRACE;SILVERLIGHT2 - prompt - 4 - true - AllRules.ruleset - diff --git a/src/ProtoMunge/ProtoMunge.csproj b/src/ProtoMunge/ProtoMunge.csproj index 082a74672b..a04276cc99 100644 --- a/src/ProtoMunge/ProtoMunge.csproj +++ b/src/ProtoMunge/ProtoMunge.csproj @@ -52,27 +52,6 @@ 4 AllRules.ruleset - - true - full - false - bin\Debug_Silverlight2\ - DEBUG;TRACE;SILVERLIGHT2 - prompt - 4 - true - AllRules.ruleset - - - pdbonly - true - bin\Release_Silverlight2\ - TRACE;SILVERLIGHT2 - prompt - 4 - true - AllRules.ruleset - diff --git a/src/ProtocolBuffers.Test/ProtocolBuffers.Test.csproj b/src/ProtocolBuffers.Test/ProtocolBuffers.Test.csproj index 2f2f3ef69c..9caa9e9086 100644 --- a/src/ProtocolBuffers.Test/ProtocolBuffers.Test.csproj +++ b/src/ProtocolBuffers.Test/ProtocolBuffers.Test.csproj @@ -54,27 +54,6 @@ 4 AllRules.ruleset - - true - full - false - bin\Debug_Silverlight2\ - DEBUG;TRACE;SILVERLIGHT2 - prompt - 4 - true - AllRules.ruleset - - - pdbonly - true - bin\Release_Silverlight2\ - TRACE;SILVERLIGHT2 - prompt - 4 - true - AllRules.ruleset - False @@ -146,7 +125,8 @@ true - + +