[ObjC] Stop tracking the syntax within GPBFileDescriptor.

There is no longer any public api to access it, so stop tracking it.

PiperOrigin-RevId: 684835061
pull/18774/head
Thomas Van Lenten 5 months ago committed by Copybara-Service
parent b751b8147f
commit f64d63ca7a
  1. 23
      objectivec/GPBDescriptor.m
  2. 7
      objectivec/GPBDescriptor_PackagePrivate.h

@ -16,6 +16,11 @@
#import "GPBUtilities_PackagePrivate.h"
#import "GPBWireFormat.h"
@interface GPBFileDescriptor ()
- (instancetype)initWithPackage:(NSString *)package objcPrefix:(NSString *)objcPrefix;
- (instancetype)initWithPackage:(NSString *)package;
@end
@interface GPBDescriptor ()
- (instancetype)initWithClass:(Class)messageClass
messageName:(NSString *)messageName
@ -243,12 +248,10 @@ static NSArray *NewFieldsArrayForHasIndex(int hasIndex, NSArray *allMessageField
NSString *package = fileDescription_->package ? @(fileDescription_->package) : @"";
if (fileDescription_->prefix) {
result = [[GPBFileDescriptor alloc] initWithPackage:package
objcPrefix:@(fileDescription_->prefix)
syntax:fileDescription_->syntax];
objcPrefix:@(fileDescription_->prefix)];
} else {
result = [[GPBFileDescriptor alloc] initWithPackage:package
syntax:fileDescription_->syntax];
result = [[GPBFileDescriptor alloc] initWithPackage:package];
}
objc_setAssociatedObject(result, &kFileDescriptorCacheKey, result,
OBJC_ASSOCIATION_RETAIN_NONATOMIC);
@ -312,29 +315,24 @@ static NSArray *NewFieldsArrayForHasIndex(int hasIndex, NSArray *allMessageField
@implementation GPBFileDescriptor {
NSString *package_;
NSString *objcPrefix_;
GPBFileSyntax syntax_;
}
@synthesize package = package_;
@synthesize objcPrefix = objcPrefix_;
- (instancetype)initWithPackage:(NSString *)package
objcPrefix:(NSString *)objcPrefix
syntax:(GPBFileSyntax)syntax {
- (instancetype)initWithPackage:(NSString *)package objcPrefix:(NSString *)objcPrefix {
self = [super init];
if (self) {
package_ = [package copy];
objcPrefix_ = [objcPrefix copy];
syntax_ = syntax;
}
return self;
}
- (instancetype)initWithPackage:(NSString *)package syntax:(GPBFileSyntax)syntax {
- (instancetype)initWithPackage:(NSString *)package {
self = [super init];
if (self) {
package_ = [package copy];
syntax_ = syntax;
}
return self;
}
@ -354,7 +352,7 @@ static NSArray *NewFieldsArrayForHasIndex(int hasIndex, NSArray *allMessageField
}
GPBFileDescriptor *otherFile = other;
// objcPrefix can be nil, otherwise, straight up compare.
return (syntax_ == otherFile->syntax_ && [package_ isEqual:otherFile->package_] &&
return ([package_ isEqual:otherFile->package_] &&
(objcPrefix_ == otherFile->objcPrefix_ ||
(otherFile->objcPrefix_ && [objcPrefix_ isEqual:otherFile->objcPrefix_])));
}
@ -488,7 +486,6 @@ uint32_t GPBFieldAlternateTag(GPBFieldDescriptor *self) {
#endif // DEBUG
}
// Non map<>/repeated fields can have defaults in proto2 syntax.
BOOL isMapOrArray = GPBFieldIsMapOrArray(self);
if (!isMapOrArray && includesDefault) {
defaultValue_ = ((GPBMessageFieldDescriptionWithDefault *)description)->defaultValue;

@ -211,13 +211,6 @@ typedef NS_OPTIONS(uint32_t, GPBDescriptorInitializationFlags) {
@end
@interface GPBFileDescriptor ()
- (instancetype)initWithPackage:(NSString *)package
objcPrefix:(NSString *)objcPrefix
syntax:(GPBFileSyntax)syntax;
- (instancetype)initWithPackage:(NSString *)package syntax:(GPBFileSyntax)syntax;
@end
@interface GPBOneofDescriptor () {
@package
const char *name_;

Loading…
Cancel
Save