1) Remove CSharpOptions 2) A new version of DescriptorProtoFile (with manual changes from codegen - it would otherwise be Descriptor.cs) 3) Turn off CLS compliance (which we'll remove from the codebase entirely; I don't think it's actually relevant these days) 4) Add "public imports" to FileDescriptor, with code broadly copied from the Java codebase. Lots more changes to commit before it will build and tests run, but one step at a time...pull/313/head
parent
b977c3ed63
commit
f3504cf3b1
11 changed files with 10632 additions and 11390 deletions
@ -1,127 +0,0 @@ |
||||
#region Copyright notice and license |
||||
|
||||
// Protocol Buffers - Google's data interchange format |
||||
// Copyright 2008 Google Inc. All rights reserved. |
||||
// http://github.com/jskeet/dotnet-protobufs/ |
||||
// Original C++/Java/Python code: |
||||
// http://code.google.com/p/protobuf/ |
||||
// |
||||
// Redistribution and use in source and binary forms, with or without |
||||
// modification, are permitted provided that the following conditions are |
||||
// met: |
||||
// |
||||
// * Redistributions of source code must retain the above copyright |
||||
// notice, this list of conditions and the following disclaimer. |
||||
// * Redistributions in binary form must reproduce the above |
||||
// copyright notice, this list of conditions and the following disclaimer |
||||
// in the documentation and/or other materials provided with the |
||||
// distribution. |
||||
// * Neither the name of Google Inc. nor the names of its |
||||
// contributors may be used to endorse or promote products derived from |
||||
// this software without specific prior written permission. |
||||
// |
||||
// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS |
||||
// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT |
||||
// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR |
||||
// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT |
||||
// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, |
||||
// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT |
||||
// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, |
||||
// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY |
||||
// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT |
||||
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE |
||||
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. |
||||
|
||||
#endregion |
||||
|
||||
using Google.ProtocolBuffers.DescriptorProtos; |
||||
using Google.ProtocolBuffers.Descriptors; |
||||
using Microsoft.VisualStudio.TestTools.UnitTesting; |
||||
|
||||
namespace Google.ProtocolBuffers |
||||
{ |
||||
[TestClass] |
||||
public class DescriptorUtilTest |
||||
{ |
||||
[TestMethod] |
||||
public void ExplicitNamespace() |
||||
{ |
||||
FileDescriptorProto proto = new FileDescriptorProto.Builder |
||||
{ |
||||
Name = "x", |
||||
Package = "pack", |
||||
Options = |
||||
new FileOptions.Builder().SetExtension( |
||||
CSharpOptions.CSharpFileOptions, |
||||
new CSharpFileOptions.Builder {Namespace = "Foo.Bar"}.Build()). |
||||
Build() |
||||
}.Build(); |
||||
FileDescriptor descriptor = FileDescriptor.BuildFrom(proto, null); |
||||
Assert.AreEqual("Foo.Bar", descriptor.CSharpOptions.Namespace); |
||||
} |
||||
|
||||
[TestMethod] |
||||
public void NoNamespaceFallsBackToPackage() |
||||
{ |
||||
FileDescriptorProto proto = new FileDescriptorProto.Builder {Name = "x", Package = "pack"}.Build(); |
||||
FileDescriptor descriptor = FileDescriptor.BuildFrom(proto, null); |
||||
Assert.AreEqual("pack", descriptor.CSharpOptions.Namespace); |
||||
} |
||||
|
||||
[TestMethod] |
||||
public void NoNamespaceOrPackageFallsBackToEmptyString() |
||||
{ |
||||
FileDescriptorProto proto = new FileDescriptorProto.Builder {Name = "x"}.Build(); |
||||
FileDescriptor descriptor = FileDescriptor.BuildFrom(proto, null); |
||||
Assert.AreEqual("", descriptor.CSharpOptions.Namespace); |
||||
} |
||||
|
||||
[TestMethod] |
||||
public void ExplicitlyNamedFileClass() |
||||
{ |
||||
FileDescriptorProto proto = new FileDescriptorProto.Builder |
||||
{ |
||||
Name = "x", |
||||
Options = |
||||
new FileOptions.Builder().SetExtension( |
||||
CSharpOptions.CSharpFileOptions, |
||||
new CSharpFileOptions.Builder {UmbrellaClassname = "Foo"}.Build()) |
||||
.Build() |
||||
}.Build(); |
||||
FileDescriptor descriptor = FileDescriptor.BuildFrom(proto, null); |
||||
Assert.AreEqual("Foo", descriptor.CSharpOptions.UmbrellaClassname); |
||||
} |
||||
|
||||
[TestMethod] |
||||
public void ImplicitFileClassWithProtoSuffix() |
||||
{ |
||||
FileDescriptorProto proto = new FileDescriptorProto.Builder {Name = "foo_bar.proto"}.Build(); |
||||
FileDescriptor descriptor = FileDescriptor.BuildFrom(proto, null); |
||||
Assert.AreEqual("FooBar", descriptor.CSharpOptions.UmbrellaClassname); |
||||
} |
||||
|
||||
[TestMethod] |
||||
public void ImplicitFileClassWithProtoDevelSuffix() |
||||
{ |
||||
FileDescriptorProto proto = new FileDescriptorProto.Builder {Name = "foo_bar.protodevel"}.Build(); |
||||
FileDescriptor descriptor = FileDescriptor.BuildFrom(proto, null); |
||||
Assert.AreEqual("FooBar", descriptor.CSharpOptions.UmbrellaClassname); |
||||
} |
||||
|
||||
[TestMethod] |
||||
public void ImplicitFileClassWithNoSuffix() |
||||
{ |
||||
FileDescriptorProto proto = new FileDescriptorProto.Builder {Name = "foo_bar"}.Build(); |
||||
FileDescriptor descriptor = FileDescriptor.BuildFrom(proto, null); |
||||
Assert.AreEqual("FooBar", descriptor.CSharpOptions.UmbrellaClassname); |
||||
} |
||||
|
||||
[TestMethod] |
||||
public void ImplicitFileClassWithDirectoryStructure() |
||||
{ |
||||
FileDescriptorProto proto = new FileDescriptorProto.Builder {Name = "x/y/foo_bar"}.Build(); |
||||
FileDescriptor descriptor = FileDescriptor.BuildFrom(proto, null); |
||||
Assert.AreEqual("FooBar", descriptor.CSharpOptions.UmbrellaClassname); |
||||
} |
||||
} |
||||
} |
@ -1,72 +0,0 @@ |
||||
#region Copyright notice and license |
||||
|
||||
// Protocol Buffers - Google's data interchange format |
||||
// Copyright 2008 Google Inc. All rights reserved. |
||||
// http://github.com/jskeet/dotnet-protobufs/ |
||||
// Original C++/Java/Python code: |
||||
// http://code.google.com/p/protobuf/ |
||||
// |
||||
// Redistribution and use in source and binary forms, with or without |
||||
// modification, are permitted provided that the following conditions are |
||||
// met: |
||||
// |
||||
// * Redistributions of source code must retain the above copyright |
||||
// notice, this list of conditions and the following disclaimer. |
||||
// * Redistributions in binary form must reproduce the above |
||||
// copyright notice, this list of conditions and the following disclaimer |
||||
// in the documentation and/or other materials provided with the |
||||
// distribution. |
||||
// * Neither the name of Google Inc. nor the names of its |
||||
// contributors may be used to endorse or promote products derived from |
||||
// this software without specific prior written permission. |
||||
// |
||||
// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS |
||||
// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT |
||||
// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR |
||||
// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT |
||||
// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, |
||||
// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT |
||||
// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, |
||||
// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY |
||||
// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT |
||||
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE |
||||
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. |
||||
|
||||
#endregion |
||||
|
||||
using Microsoft.VisualStudio.TestTools.UnitTesting; |
||||
using Google.ProtocolBuffers.TestProtos; |
||||
|
||||
namespace Google.ProtocolBuffers.Descriptors |
||||
{ |
||||
[TestClass] |
||||
public class MessageDescriptorTest |
||||
{ |
||||
[TestMethod] |
||||
public void FindPropertyWithDefaultName() |
||||
{ |
||||
Assert.AreSame(OptionsMessage.Descriptor.FindFieldByNumber(OptionsMessage.NormalFieldNumber), |
||||
OptionsMessage.Descriptor.FindFieldByPropertyName("Normal")); |
||||
} |
||||
|
||||
[TestMethod] |
||||
public void FindPropertyWithAutoModifiedName() |
||||
{ |
||||
Assert.AreSame(OptionsMessage.Descriptor.FindFieldByNumber(OptionsMessage.OptionsMessage_FieldNumber), |
||||
OptionsMessage.Descriptor.FindFieldByPropertyName("OptionsMessage_")); |
||||
} |
||||
|
||||
[TestMethod] |
||||
public void FindPropertyWithCustomizedName() |
||||
{ |
||||
Assert.AreSame(OptionsMessage.Descriptor.FindFieldByNumber(OptionsMessage.CustomNameFieldNumber), |
||||
OptionsMessage.Descriptor.FindFieldByPropertyName("CustomName")); |
||||
} |
||||
|
||||
[TestMethod] |
||||
public void FindPropertyWithInvalidName() |
||||
{ |
||||
Assert.IsNull(OptionsMessage.Descriptor.FindFieldByPropertyName("Bogus")); |
||||
} |
||||
} |
||||
} |
File diff suppressed because it is too large
Load Diff
File diff suppressed because it is too large
Load Diff
Loading…
Reference in new issue