Merge pull request #1162 from brian-peloton/master

Avoid upcasting uninitialized pointers
9 years ago · f2b6dbb8b3
parent fe066bd514 96c2dd5dfc
commit f2b6dbb8b3
1 changed files with 2 additions and 2 deletions
--- a/src/google/protobuf/stubs/statusor.h
+++ b/src/google/protobuf/stubs/statusor.h
@ -224,14 +224,14 @@ inline StatusOr<T>& StatusOr<T>::operator=(const StatusOr<T>& other) {
 template<typename T>
 template<typename U>
 inline StatusOr<T>::StatusOr(const StatusOr<U>& other)
-    : status_(other.status_), value_(other.value_) {
+    : status_(other.status_), value_(other.status_.ok() ? other.value_ : NULL) {
 }

 template<typename T>
 template<typename U>
 inline StatusOr<T>& StatusOr<T>::operator=(const StatusOr<U>& other) {
  status_ = other.status_;
-  value_ = other.value_;
+  if (status_.ok()) value_ = other.value_;
  return *this;
 }