From ef3730c2df51aa227250cf4f28fd1e4839916877 Mon Sep 17 00:00:00 2001 From: "kenton@google.com" Date: Tue, 28 Apr 2009 00:49:36 +0000 Subject: [PATCH] Add test verifying that protoc accepts trailing backslashes on Windows, which some users claim doesn't work. Seems to work on my machine. --- .../command_line_interface_unittest.cc | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/src/google/protobuf/compiler/command_line_interface_unittest.cc b/src/google/protobuf/compiler/command_line_interface_unittest.cc index af765b8725..719771eb2e 100644 --- a/src/google/protobuf/compiler/command_line_interface_unittest.cc +++ b/src/google/protobuf/compiler/command_line_interface_unittest.cc @@ -539,6 +539,24 @@ TEST_F(CommandLineInterfaceTest, WindowsOutputPathAndParameter) { EXPECT_EQ("bar", generator->parameter_); } +TEST_F(CommandLineInterfaceTest, TrailingBackslash) { + // Test that the directories can end in backslashes. Some users claim this + // doesn't work on their system. + + RegisterGenerator("test_generator", "--test_out", + "output.test", "Test output."); + + CreateTempFile("foo.proto", + "syntax = \"proto2\";\n" + "message Foo {}\n"); + + Run("protocol_compiler --test_out=$tmpdir\\ " + "--proto_path=$tmpdir\\ foo.proto"); + + ExpectNoErrors(); + ExpectGenerated("test_generator", "", "foo.proto", "Foo", "output.test"); +} + #endif // defined(_WIN32) || defined(__CYGWIN__) TEST_F(CommandLineInterfaceTest, PathLookup) {