Expect fail when serialize inf and nan for Value.number_value in json format. fixes #11259

Implemented in java, c++, python and upb. Also added conformance test.

https://developers.google.com/protocol-buffers/docs/reference/google.protobuf#google.protobuf.Value
where it says:
attempting to serialize NaN or Infinity results in error. (We can't serialize these as string "NaN" or "Infinity" values like we do for regular fields, because they would parse as string_value, not number_value).

PiperOrigin-RevId: 500139380
pull/13171/head
Jie Luo 2 years ago committed by Copybara-Service
parent 0e286b4037
commit e6c38af972
  1. 6
      upb/json/encode.c

@ -533,6 +533,12 @@ static void jsonenc_value(jsonenc* e, const upb_Message* msg,
jsonenc_putstr(e, "null");
break;
case 2:
if (upb_JsonEncode_HandleSpecialDoubles(e, val.double_val)) {
jsonenc_err(
e,
"google.protobuf.Value cannot encode double values for "
"infinity or nan, because they would be parsed as a string");
}
upb_JsonEncode_Double(e, val.double_val);
break;
case 3:

Loading…
Cancel
Save