Chiebot-Mirror
/
protobuf
mirror of https://github.com/protocolbuffers/protobuf.git
8
0
Fork 0
Code Issues Projects Releases Wiki Activity

Update CONTRIBUTING.md

Browse Source
pull/6202/head
Hao Nguyen 6 years ago
parent 74f4f594cf
commit e06c5ff780
1 changed files with 4 additions and 1 deletions
Whitespace
Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL
Unified View
Diff Options
Show Stats Download Patch File Download Diff File
  1. 5
      CONTRIBUTING.md

5
CONTRIBUTING.md
Unescape View File

@ -83,6 +83,10 @@ the final release.
Ultimately, the green signal will be provided by our testing infrastructure. Ultimately, the green signal will be provided by our testing infrastructure.
The reviewer will help you if there are test failures that seem not related The reviewer will help you if there are test failures that seem not related
to the change you are making. to the change you are making.
## Reviewer Guidelines
* Make sure that all tests are passing before approval.
* Apply the "release notes: yes" label if the pull request's description should * Apply the "release notes: yes" label if the pull request's description should
be included in the next release (e.g., any new feature / bug fix). be included in the next release (e.g., any new feature / bug fix).
Apply the "release notes: no" label if the pull request's description should Apply the "release notes: no" label if the pull request's description should
@ -92,4 +96,3 @@ the final release.
pull request. This will make it easier to identify which languages the pull pull request. This will make it easier to identify which languages the pull
request affects, allowing us to better identify appropriate reviewer, create request affects, allowing us to better identify appropriate reviewer, create
a better release note, and make it easier to identify issues in the future. a better release note, and make it easier to identify issues in the future.

Write Preview
Loading…
Cancel
Save