From dd9dd86fbca3ab5c1c7f0aa2534dc5da61530711 Mon Sep 17 00:00:00 2001 From: Jie Luo Date: Mon, 27 Feb 2023 17:40:03 -0800 Subject: [PATCH] Raise warnings for MessageFactory class usages PiperOrigin-RevId: 512779287 --- python/google/protobuf/message_factory.py | 23 ++++++++++------------- 1 file changed, 10 insertions(+), 13 deletions(-) diff --git a/python/google/protobuf/message_factory.py b/python/google/protobuf/message_factory.py index fac1165c51..74dd4a676c 100644 --- a/python/google/protobuf/message_factory.py +++ b/python/google/protobuf/message_factory.py @@ -163,10 +163,9 @@ class MessageFactory(object): Returns: A class describing the passed in descriptor. """ - # TODO(b/258832141): add this warning - # warnings.warn('MessageFactory class is deprecated. Please use ' - # 'GetMessageClass() instead of MessageFactory.GetPrototype. ' - # 'MessageFactory class will be removed after 2024.') + warnings.warn('MessageFactory class is deprecated. Please use ' + 'GetMessageClass() instead of MessageFactory.GetPrototype. ' + 'MessageFactory class will be removed after 2024.') return GetMessageClass(descriptor) def CreatePrototype(self, descriptor): @@ -181,10 +180,9 @@ class MessageFactory(object): Returns: A class describing the passed in descriptor. """ - # TODO(b/258832141): add this warning - # warnings.warn('Directly call CreatePrototype is wrong. Please use ' - # 'GetMessageClass() method instead. Directly use ' - # 'CreatePrototype will raise error after July 2023.') + warnings.warn('Directly call CreatePrototype is wrong. Please use ' + 'GetMessageClass() method instead. Directly use ' + 'CreatePrototype will raise error after July 2023.') return _InternalCreateMessageClass(descriptor) def GetMessages(self, files): @@ -201,11 +199,10 @@ class MessageFactory(object): any dependent messages as well as any messages defined in the same file as a specified message. """ - # TODO(b/258832141): add this warning - # warnings.warn('MessageFactory class is deprecated. Please use ' - # 'GetMessageClassesForFiles() instead of ' - # 'MessageFactory.GetMessages(). MessageFactory class ' - # 'will be removed after 2024.') + warnings.warn('MessageFactory class is deprecated. Please use ' + 'GetMessageClassesForFiles() instead of ' + 'MessageFactory.GetMessages(). MessageFactory class ' + 'will be removed after 2024.') return GetMessageClassesForFiles(files, self.pool)