Add a TODO to clean-up the LITTLE_ENDIAN macro.

pull/749/head
Feng Xiao 9 years ago
parent b47bf4c930
commit d9f4636818
  1. 3
      src/google/protobuf/stubs/port.h

@ -47,6 +47,9 @@
#undef PROTOBUF_LITTLE_ENDIAN #undef PROTOBUF_LITTLE_ENDIAN
#ifdef _WIN32 #ifdef _WIN32
// Assuming windows is always little-endian. // Assuming windows is always little-endian.
// TODO(xiaofeng): The PROTOBUF_LITTLE_ENDIAN is not only used for
// optimization but also for correctness. We should define an
// different macro to test the big-endian code path in coded_stream.
#if !defined(PROTOBUF_DISABLE_LITTLE_ENDIAN_OPT_FOR_TEST) #if !defined(PROTOBUF_DISABLE_LITTLE_ENDIAN_OPT_FOR_TEST)
#define PROTOBUF_LITTLE_ENDIAN 1 #define PROTOBUF_LITTLE_ENDIAN 1
#endif #endif

Loading…
Cancel
Save