Some Makefile cleanup.

pull/13171/head
Joshua Haberman 13 years ago
parent 7935b702c5
commit d5324d1d5c
  1. 37
      Makefile
  2. 3
      tests/test_stream.c
  3. 4
      upb/pb/encoder.c
  4. 4
      upb/pb/encoder.h

@ -65,17 +65,14 @@ endif
# Unfortuantely we can't easily generate deps for benchmarks or tests because # Unfortuantely we can't easily generate deps for benchmarks or tests because
# of the scheme we use that compiles the same source file multiple times with # of the scheme we use that compiles the same source file multiple times with
# different -D options, which can include different header files. # different -D options, which can include different header files.
deps: gen-deps.sh Makefile $(CORE) $(STREAM) ALLSRC=$(shell find . -name '*.c' -print | grep -v perf-tmp)
$(Q) CPPFLAGS="$(CPPFLAGS)" ./gen-deps.sh $(CORE) $(STREAM) deps: gen-deps.sh Makefile $(ALLSRC)
$(Q) CPPFLAGS="$(CPPFLAGS)" ./gen-deps.sh $(ALLSRC)
$(E) Regenerating dependencies for upb/... $(E) Regenerating dependencies for upb/...
$(ALLSRC): perf-cppflags
# Source files. ############################################################### # Source files. ###############################################################
# Every source file used in upb should appear here.
# The core library. # The core library.
CORE= \ CORE= \
upb/upb.c \ upb/upb.c \
@ -93,26 +90,6 @@ PB= \
upb/pb/glue.c \ upb/pb/glue.c \
upb/pb/textprinter.c \ upb/pb/textprinter.c \
# Parts of core that are yet to be converted.
OTHERSRC=upb/pb/encoder.c
BENCHMARKS_SRC= \
benchmarks/main.c \
benchmarks/parsestream.upb.c \
benchmarks/parsetostruct.upb.c
TESTS_SRC= \
tests/test_decoder.c \
tests/test_def.c \
tests/tests.c \
tests/tests_varint.c \
#tests/test_vs_proto2.cc
#tests/test_stream.c \
ALLSRC=$(CORE) $(STREAM) $(BENCHMARKS_SRC) $(TESTS_SRC)
# Rules. ####################################################################### # Rules. #######################################################################
@ -188,8 +165,6 @@ endif
# Function to expand a wildcard pattern recursively. # Function to expand a wildcard pattern recursively.
rwildcard=$(strip $(foreach d,$(wildcard $1*),$(call rwildcard,$d/,$2)$(filter $(subst *,%,$2),$d))) rwildcard=$(strip $(foreach d,$(wildcard $1*),$(call rwildcard,$d/,$2)$(filter $(subst *,%,$2),$d)))
# Regenerating the auto-generated files in upb/. # Regenerating the auto-generated files in upb/.
upb/descriptor.pb: upb/descriptor.proto upb/descriptor.pb: upb/descriptor.proto
@# TODO: replace with upbc @# TODO: replace with upbc
@ -316,6 +291,12 @@ benchmarks/google_messages.proto.pb: benchmarks/google_messages.proto
benchmarks/google_messages.pb.cc: benchmarks/google_messages.proto benchmarks/google_messages.pb.cc: benchmarks/google_messages.proto
protoc benchmarks/google_messages.proto --cpp_out=. protoc benchmarks/google_messages.proto --cpp_out=.
# This basic idea is useful (varying the benchmarks' setup by recompiling
# several times with different #defines) but the implementation in this
# Makefile is verbose and error-prone. Open to better ideas here. I don't
# want to make these command-line parameters -- it makes it more annoying to
# debug or profile them.
benchmarks/b.parsetostruct_googlemessage1.upb_table_byval \ benchmarks/b.parsetostruct_googlemessage1.upb_table_byval \
benchmarks/b.parsetostruct_googlemessage2.upb_table_byval: \ benchmarks/b.parsetostruct_googlemessage2.upb_table_byval: \
benchmarks/parsetostruct.upb.c $(LIBUPB) benchmarks/google_messages.proto.pb benchmarks/parsetostruct.upb.c $(LIBUPB) benchmarks/google_messages.proto.pb

@ -1,7 +1,6 @@
#undef NDEBUG /* ensure tests always assert. */ #undef NDEBUG /* ensure tests always assert. */
#include "upb_stream.h" #include "upb/handlers.h"
#include "upb_string.h"
typedef struct { typedef struct {
upb_string *str; upb_string *str;

@ -5,10 +5,10 @@
* Author: Josh Haberman <jhaberman@gmail.com> * Author: Josh Haberman <jhaberman@gmail.com>
*/ */
#include "upb_encoder.h" #include "upb/pb/encoder.h"
#include <stdlib.h> #include <stdlib.h>
#include "descriptor.h" #include "upb/descriptor.h"
/* Functions for calculating sizes of wire values. ****************************/ /* Functions for calculating sizes of wire values. ****************************/

@ -15,8 +15,8 @@
#ifndef UPB_ENCODER_H_ #ifndef UPB_ENCODER_H_
#define UPB_ENCODER_H_ #define UPB_ENCODER_H_
#include "upb.h" #include "upb/upb.h"
#include "upb_stream.h" #include "upb/bytestream.h"
#ifdef __cplusplus #ifdef __cplusplus
extern "C" { extern "C" {

Loading…
Cancel
Save