Remove temporary opt-in for extension support of weak descriptor messages.

PiperOrigin-RevId: 640168936
pull/16998/head
Protobuf Team Bot 11 months ago committed by Copybara-Service
parent 6a70bcf575
commit d3a0f59af1
  1. 30
      src/google/protobuf/compiler/cpp/extension.cc

@ -209,7 +209,6 @@ void ExtensionGenerator::GenerateRegistration(io::Printer* p,
if (using_implicit_weak_descriptors) { if (using_implicit_weak_descriptors) {
p->Emit({{"enum_name", ClassName(descriptor_->enum_type(), true)}}, p->Emit({{"enum_name", ClassName(descriptor_->enum_type(), true)}},
R"cc( R"cc(
#if defined(PROTOBUF_INTERNAL_TEMPORARY_WEAK_EXTENSION_OPT_IN)
(::_pbi::ExtensionSet::ShouldRegisterAtThisTime( (::_pbi::ExtensionSet::ShouldRegisterAtThisTime(
{{&$extendee_table$, $extendee_index$}}, $preregister$) {{&$extendee_table$, $extendee_index$}}, $preregister$)
? ::_pbi::ExtensionSet::RegisterEnumExtension( ? ::_pbi::ExtensionSet::RegisterEnumExtension(
@ -218,10 +217,8 @@ void ExtensionGenerator::GenerateRegistration(io::Printer* p,
$number$, $field_type$, $repeated$, $packed$, $number$, $field_type$, $repeated$, $packed$,
$enum_name$_IsValid) $enum_name$_IsValid)
: (void)0), : (void)0),
#else
)cc"); )cc");
} } else if (priority == kInitPriority102) {
if (priority == kInitPriority102) {
p->Emit({{"enum_name", ClassName(descriptor_->enum_type(), true)}}, p->Emit({{"enum_name", ClassName(descriptor_->enum_type(), true)}},
R"cc( R"cc(
::_pbi::ExtensionSet::RegisterEnumExtension( ::_pbi::ExtensionSet::RegisterEnumExtension(
@ -229,11 +226,6 @@ void ExtensionGenerator::GenerateRegistration(io::Printer* p,
$repeated$, $packed$, $enum_name$_IsValid), $repeated$, $packed$, $enum_name$_IsValid),
)cc"); )cc");
} }
if (using_implicit_weak_descriptors) {
p->Emit(R"cc(
#endif
)cc");
}
break; break;
case FieldDescriptor::CPPTYPE_MESSAGE: { case FieldDescriptor::CPPTYPE_MESSAGE: {
@ -261,7 +253,6 @@ void ExtensionGenerator::GenerateRegistration(io::Printer* p,
{"extension_index", find_index(descriptor_->message_type())}, {"extension_index", find_index(descriptor_->message_type())},
}, },
R"cc( R"cc(
#if defined(PROTOBUF_INTERNAL_TEMPORARY_WEAK_EXTENSION_OPT_IN)
(::_pbi::ExtensionSet::ShouldRegisterAtThisTime( (::_pbi::ExtensionSet::ShouldRegisterAtThisTime(
{{&$extendee_table$, $extendee_index$}, {{&$extendee_table$, $extendee_index$},
{&$extension_table$, $extension_index$}}, {&$extension_table$, $extension_index$}},
@ -274,10 +265,8 @@ void ExtensionGenerator::GenerateRegistration(io::Printer* p,
&$extension_table$, $extension_index$, true), &$extension_table$, $extension_index$, true),
$verify$, ::_pbi::LazyAnnotation::$lazy$) $verify$, ::_pbi::LazyAnnotation::$lazy$)
: (void)0), : (void)0),
#else
)cc"); )cc");
} } else if (priority == kInitPriority102) {
if (priority == kInitPriority102) {
p->Emit(R"cc( p->Emit(R"cc(
::_pbi::ExtensionSet::RegisterMessageExtension( ::_pbi::ExtensionSet::RegisterMessageExtension(
&$extendee$::default_instance(), $number$, $field_type$, &$extendee$::default_instance(), $number$, $field_type$,
@ -285,18 +274,12 @@ void ExtensionGenerator::GenerateRegistration(io::Printer* p,
$verify$, ::_pbi::LazyAnnotation::$lazy$), $verify$, ::_pbi::LazyAnnotation::$lazy$),
)cc"); )cc");
} }
if (using_implicit_weak_descriptors) {
p->Emit(R"cc(
#endif
)cc");
}
break; break;
} }
default: default:
if (using_implicit_weak_descriptors) { if (using_implicit_weak_descriptors) {
p->Emit(R"cc( p->Emit(R"cc(
#if defined(PROTOBUF_INTERNAL_TEMPORARY_WEAK_EXTENSION_OPT_IN)
(::_pbi::ExtensionSet::ShouldRegisterAtThisTime( (::_pbi::ExtensionSet::ShouldRegisterAtThisTime(
{{&$extendee_table$, $extendee_index$}}, $preregister$) {{&$extendee_table$, $extendee_index$}}, $preregister$)
? ::_pbi::ExtensionSet::RegisterExtension( ? ::_pbi::ExtensionSet::RegisterExtension(
@ -305,10 +288,8 @@ void ExtensionGenerator::GenerateRegistration(io::Printer* p,
true), true),
$number$, $field_type$, $repeated$, $packed$) $number$, $field_type$, $repeated$, $packed$)
: (void)0), : (void)0),
#else
)cc"); )cc");
} } else if (priority == kInitPriority102) {
if (priority == kInitPriority102) {
p->Emit( p->Emit(
R"cc( R"cc(
::_pbi::ExtensionSet::RegisterExtension( ::_pbi::ExtensionSet::RegisterExtension(
@ -316,11 +297,6 @@ void ExtensionGenerator::GenerateRegistration(io::Printer* p,
$repeated$, $packed$), $repeated$, $packed$),
)cc"); )cc");
} }
if (using_implicit_weak_descriptors) {
p->Emit(R"cc(
#endif
)cc");
}
break; break;
} }

Loading…
Cancel
Save