Break out idx in upb_MiniTableSub computation for clarity

PiperOrigin-RevId: 632314763
pull/16813/head
Hong Shin 7 months ago committed by Copybara-Service
parent fefec68753
commit d071c60878
  1. 6
      upb/mini_descriptor/link.c

@ -50,12 +50,12 @@ bool upb_MiniTable_SetSubMessage(upb_MiniTable* table,
return false; return false;
} }
upb_MiniTableSub* table_sub = int idx = field->UPB_PRIVATE(submsg_index);
(void*)&table->UPB_PRIVATE(subs)[field->UPB_PRIVATE(submsg_index)]; upb_MiniTableSub* table_subs = (void*)table->UPB_PRIVATE(subs);
// TODO: Add this assert back once YouTube is updated to not call // TODO: Add this assert back once YouTube is updated to not call
// this function repeatedly. // this function repeatedly.
// UPB_ASSERT(UPB_PRIVATE(_upb_MiniTable_IsEmpty)(table_sub->submsg)); // UPB_ASSERT(UPB_PRIVATE(_upb_MiniTable_IsEmpty)(table_sub->submsg));
*table_sub = upb_MiniTableSub_FromMessage(sub); table_subs[idx] = upb_MiniTableSub_FromMessage(sub);
return true; return true;
} }

Loading…
Cancel
Save