From d071c608780d3fa890b191aafb8aa2d4f8634973 Mon Sep 17 00:00:00 2001 From: Hong Shin Date: Thu, 9 May 2024 17:16:10 -0700 Subject: [PATCH] Break out idx in upb_MiniTableSub computation for clarity PiperOrigin-RevId: 632314763 --- upb/mini_descriptor/link.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/upb/mini_descriptor/link.c b/upb/mini_descriptor/link.c index bc5fa2f65b..093150b623 100644 --- a/upb/mini_descriptor/link.c +++ b/upb/mini_descriptor/link.c @@ -50,12 +50,12 @@ bool upb_MiniTable_SetSubMessage(upb_MiniTable* table, return false; } - upb_MiniTableSub* table_sub = - (void*)&table->UPB_PRIVATE(subs)[field->UPB_PRIVATE(submsg_index)]; + int idx = field->UPB_PRIVATE(submsg_index); + upb_MiniTableSub* table_subs = (void*)table->UPB_PRIVATE(subs); // TODO: Add this assert back once YouTube is updated to not call // this function repeatedly. // UPB_ASSERT(UPB_PRIVATE(_upb_MiniTable_IsEmpty)(table_sub->submsg)); - *table_sub = upb_MiniTableSub_FromMessage(sub); + table_subs[idx] = upb_MiniTableSub_FromMessage(sub); return true; }