Chiebot-Mirror
/
protobuf
mirror of https://github.com/protocolbuffers/protobuf.git
8
0
Fork 0
Code Issues Projects Releases Wiki Activity

Move over some more of FileGenerator to Emit.

Browse Source 
PiperOrigin-RevId: 544714210
pull/13187/head
Thomas Van Lenten 2 years ago committed by Copybara-Service
parent 70b0769073
commit cea4551466
2 changed files with 96 additions and 94 deletions
Whitespace
Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL
Split View
Diff Options
Show Stats Download Patch File Download Diff File
  1. 184
      src/google/protobuf/compiler/objectivec/file.cc
  2. 6
      src/google/protobuf/compiler/objectivec/file.h

184
src/google/protobuf/compiler/objectivec/file.cc
Unescape View File

@ -368,8 +368,8 @@ void FileGenerator::GenerateSource(io::Printer* p) const {
GenerateFile(p, GeneratedFileType::kSource, file_options, [&] {
EmitSourceFwdDecls(fwd_decls, p);
PrintRootImplementation(p, deps_with_extensions);
PrintFileDescription(p);
EmitRootImplementation(p, deps_with_extensions);
EmitFileDescription(p);
for (const auto& generator : enum_generators_) {
generator->GenerateSource(p);
@ -406,7 +406,7 @@ void FileGenerator::GenerateGlobalSource(io::Printer* p) const {
GenerateFile(p, GeneratedFileType::kSource, file_options, [&] {
EmitSourceFwdDecls(fwd_decls, p);
PrintRootImplementation(p, deps_with_extensions);
EmitRootImplementation(p, deps_with_extensions);
});
}
@ -438,7 +438,7 @@ void FileGenerator::GenerateSourceForMessage(int idx, io::Printer* p) const {
GenerateFile(p, GeneratedFileType::kSource, file_options, [&] {
EmitSourceFwdDecls(fwd_decls, p);
PrintFileDescription(p);
EmitFileDescription(p);
generator->GenerateSource(p);
});
}
@ -580,109 +580,111 @@ void FileGenerator::GenerateFile(io::Printer* p, GeneratedFileType file_type,
)objc");
}
void FileGenerator::PrintRootImplementation(
void FileGenerator::EmitRootImplementation(
io::Printer* p,
const std::vector<const FileDescriptor*>& deps_with_extensions) const {
p->Print(
// clang-format off
"#pragma mark - $root_class_name$\n"
"\n"
"@implementation $root_class_name$\n"
"\n",
// clang-format on
"root_class_name", root_class_name_);
p->Emit(
R"objc(
#pragma mark - $root_class_name$
// If there were any extensions or this file has any dependencies, output a
// registry to override to create the file specific registry.
@implementation $root_class_name$
)objc");
p->Emit("\n");
// If there were any extensions or this file has any dependencies,
// output a registry to override to create the file specific
// registry.
if (extension_generators_.empty() && deps_with_extensions.empty()) {
if (file_->dependency_count() == 0) {
// clang-format off
p->Print(
"// No extensions in the file and no imports, so no need to generate\n"
"// +extensionRegistry.\n");
// clang-format on
p->Emit(R"objc(
// No extensions in the file and no imports, so no need to generate
// +extensionRegistry.
)objc");
} else {
// clang-format off
p->Print(
"// No extensions in the file and none of the imports (direct or indirect)\n"
"// defined extensions, so no need to generate +extensionRegistry.\n");
// clang-format on
p->Emit(R"objc(
// No extensions in the file and none of the imports (direct or indirect)
// defined extensions, so no need to generate +extensionRegistry.
)objc");
}
} else {
PrintRootExtensionRegistryImplementation(p, deps_with_extensions);
EmitRootExtensionRegistryImplementation(p, deps_with_extensions);
}
p->Print("\n@end\n\n");
p->Emit("\n");
p->Emit("@end\n\n");
}
void FileGenerator::PrintRootExtensionRegistryImplementation(
void FileGenerator::EmitRootExtensionRegistryImplementation(
io::Printer* p,
const std::vector<const FileDescriptor*>& deps_with_extensions) const {
// clang-format off
p->Print(
"+ (GPBExtensionRegistry*)extensionRegistry {\n"
" // This is called by +initialize so there is no need to worry\n"
" // about thread safety and initialization of registry.\n"
" static GPBExtensionRegistry* registry = nil;\n"
" if (!registry) {\n"
" GPB_DEBUG_CHECK_RUNTIME_VERSIONS();\n"
" registry = [[GPBExtensionRegistry alloc] init];\n");
// clang-format on
p->Indent();
p->Indent();
if (!extension_generators_.empty()) {
p->Print("static GPBExtensionDescription descriptions[] = {\n");
p->Indent();
for (const auto& generator : extension_generators_) {
generator->GenerateStaticVariablesInitialization(p);
}
p->Outdent();
// clang-format off
p->Print(
"};\n"
"for (size_t i = 0; i < sizeof(descriptions) / sizeof(descriptions[0]); ++i) {\n"
" GPBExtensionDescriptor *extension =\n"
" [[GPBExtensionDescriptor alloc] initWithExtensionDescription:&descriptions[i]\n"
" usesClassRefs:YES];\n"
" [registry addExtension:extension];\n"
" [self globallyRegisterExtension:extension];\n"
" [extension release];\n"
"}\n");
// clang-format on
}
if (deps_with_extensions.empty()) {
// clang-format off
p->Print(
"// None of the imports (direct or indirect) defined extensions, so no need to add\n"
"// them to this registry.\n");
// clang-format on
} else {
// clang-format off
p->Print(
"// Merge in the imports (direct or indirect) that defined extensions.\n");
// clang-format on
for (const auto& dep : deps_with_extensions) {
const std::string root_class_name(FileClassName((dep)));
p->Print("[registry addExtensions:[$dependency$ extensionRegistry]];\n",
"dependency", root_class_name);
}
}
p->Outdent();
p->Outdent();
// clang-format off
p->Print(
" }\n"
" return registry;\n"
"}\n");
// clang-format on
p->Emit(
{
{"register_local_extensions",
[&] {
if (extension_generators_.empty()) {
return;
}
p->Emit(
{
{"register_local_extensions_variable_blocks",
[&] {
for (const auto& generator : extension_generators_) {
generator->GenerateStaticVariablesInitialization(p);
}
}},
},
R"objc(
static GPBExtensionDescription descriptions[] = {
$register_local_extensions_variable_blocks$
};
for (size_t i = 0; i < sizeof(descriptions) / sizeof(descriptions[0]); ++i) {
GPBExtensionDescriptor *extension =
[[GPBExtensionDescriptor alloc] initWithExtensionDescription:&descriptions[i]
usesClassRefs:YES];
[registry addExtension:extension];
[self globallyRegisterExtension:extension];
[extension release];
}
)objc");
}},
{"register_imports",
[&] {
if (deps_with_extensions.empty()) {
p->Emit(R"objc(
// None of the imports (direct or indirect) defined extensions, so no need to add
// them to this registry.
)objc");
} else {
p->Emit(R"objc(
// Merge in the imports (direct or indirect) that defined extensions.
)objc");
for (const auto& dep : deps_with_extensions) {
p->Emit({{"dependency", FileClassName(dep)}},
R"objc(
[registry addExtensions:[$dependency$ extensionRegistry]];
)objc");
}
}
}},
},
R"objc(
+ (GPBExtensionRegistry*)extensionRegistry {
// This is called by +initialize so there is no need to worry
// about thread safety and initialization of registry.
static GPBExtensionRegistry* registry = nil;
if (!registry) {
GPB_DEBUG_CHECK_RUNTIME_VERSIONS();
registry = [[GPBExtensionRegistry alloc] init];
$register_local_extensions$;
$register_imports$
}
return registry;
}
)objc");
}
void FileGenerator::PrintFileDescription(io::Printer* p) const {
void FileGenerator::EmitFileDescription(io::Printer* p) const {
// File descriptor only needed if there are messages to use it.
if (message_generators_.empty()) {
return;

6
src/google/protobuf/compiler/objectivec/file.h
Unescape View File

@ -108,13 +108,13 @@ class FileGenerator {
GenerateFile(p, file_type, file_options, body);
}
void PrintRootImplementation(
void EmitRootImplementation(
io::Printer* p,
const std::vector<const FileDescriptor*>& deps_with_extensions) const;
void PrintRootExtensionRegistryImplementation(
void EmitRootExtensionRegistryImplementation(
io::Printer* p,
const std::vector<const FileDescriptor*>& deps_with_extensions) const;
void PrintFileDescription(io::Printer* p) const;
void EmitFileDescription(io::Printer* p) const;
bool HeadersUseForwardDeclarations() const {
// The bundled protos (WKTs) don't make use of forward declarations.

Write Preview
Loading…
Cancel
Save