Use merge/partial variants to give proto2 benchmark the fairest hearing.

pull/13171/head
Joshua Haberman 4 years ago
parent 30f01afa83
commit bc301e7da4
  1. 12
      tests/benchmark.cc

@ -69,8 +69,8 @@ static void BM_ParseDescriptor_Proto2_NoArena(benchmark::State& state) {
size_t bytes = 0; size_t bytes = 0;
for (auto _ : state) { for (auto _ : state) {
protobuf::FileDescriptorProto proto; protobuf::FileDescriptorProto proto;
bool ok = proto.ParseFromArray(descriptor.data, descriptor.size); protobuf::StringPiece input(descriptor.data,descriptor.size);
bool ok = proto.ParseFrom<protobuf::MessageLite::kMergePartial>(input);
if (!ok) { if (!ok) {
printf("Failed to parse.\n"); printf("Failed to parse.\n");
exit(1); exit(1);
@ -85,9 +85,10 @@ static void BM_ParseDescriptor_Proto2_Arena(benchmark::State& state) {
size_t bytes = 0; size_t bytes = 0;
for (auto _ : state) { for (auto _ : state) {
protobuf::Arena arena; protobuf::Arena arena;
protobuf::StringPiece input(descriptor.data,descriptor.size);
auto proto = protobuf::Arena::CreateMessage<protobuf::FileDescriptorProto>( auto proto = protobuf::Arena::CreateMessage<protobuf::FileDescriptorProto>(
&arena); &arena);
bool ok = proto->ParseFromArray(descriptor.data, descriptor.size); bool ok = proto->ParseFrom<protobuf::MessageLite::kMergePartial>(input);
if (!ok) { if (!ok) {
printf("Failed to parse.\n"); printf("Failed to parse.\n");
@ -106,9 +107,10 @@ static void BM_ParseDescriptor_Proto2_Arena_LargeInitialBlock(benchmark::State&
opts.initial_block_size = sizeof(buf); opts.initial_block_size = sizeof(buf);
for (auto _ : state) { for (auto _ : state) {
protobuf::Arena arena(opts); protobuf::Arena arena(opts);
protobuf::StringPiece input(descriptor.data,descriptor.size);
auto proto = protobuf::Arena::CreateMessage<protobuf::FileDescriptorProto>( auto proto = protobuf::Arena::CreateMessage<protobuf::FileDescriptorProto>(
&arena); &arena);
bool ok = proto->ParsePartialFromArray(descriptor.data, descriptor.size); bool ok = proto->ParseFrom<protobuf::MessageLite::kMergePartial>(input);
if (!ok) { if (!ok) {
printf("Failed to parse.\n"); printf("Failed to parse.\n");
@ -125,7 +127,7 @@ static void BM_SerializeDescriptor_Proto2(benchmark::State& state) {
protobuf::FileDescriptorProto proto; protobuf::FileDescriptorProto proto;
proto.ParseFromArray(descriptor.data, descriptor.size); proto.ParseFromArray(descriptor.data, descriptor.size);
for (auto _ : state) { for (auto _ : state) {
proto.SerializeToArray(buf, sizeof(buf)); proto.SerializePartialToArray(buf, sizeof(buf));
bytes += descriptor.size; bytes += descriptor.size;
} }
state.SetBytesProcessed(state.iterations() * descriptor.size); state.SetBytesProcessed(state.iterations() * descriptor.size);

Loading…
Cancel
Save