[ObjC] Remove the "google/protobuf" path from generated test protos.

objectivec/DevTools/compile_testing_protos.sh

@@ -60,14 +60,14 @@ OBJC_EXTENSIONS=( .pbobjc.h .pbobjc.m )
 
 # -----------------------------------------------------------------------------
 # Ensure the output dir exists
-mkdir -p "${OUTPUT_DIR}/google/protobuf"
+mkdir -p "${OUTPUT_DIR}"
 
 # -----------------------------------------------------------------------------
 # Move to the top of the protobuf directories and ensure there is a protoc
 # binary to use.
 cd "${SRCROOT}/.."
 readonly PROTOC="bazel-bin/protoc"
-[[ -x $PROTOC ]] || \
+[[ -x "${PROTOC}" ]] || \
   die "Could not find the protoc binary; make sure you have built it (objectivec/DevTools/full_mac_build.sh -h)."
 
 # -----------------------------------------------------------------------------
@@ -83,7 +83,7 @@ for PROTO_FILE in "${OBJC_TEST_PROTO_FILES[@]}"; do
   OBJC_NAME=$(echo "${BASE_NAME}" | awk -F _ '{for(i=1; i<=NF; i++) printf "%s", toupper(substr($i,1,1)) substr($i,2);}')
 
   for EXT in "${OBJC_EXTENSIONS[@]}"; do
-    if [[ ! -f "${OUTPUT_DIR}/google/protobuf/${OBJC_NAME}${EXT}" ]]; then
+    if [[ ! -f "${OUTPUT_DIR}/${OBJC_NAME}${EXT}" ]]; then
       RUN_PROTOC=yes
     fi
   done
@@ -96,7 +96,7 @@ if [[ "${RUN_PROTOC}" != "yes" ]] ; then
   # (these patterns catch some extra stuff, but better to over sample than
   # under)
   readonly NewestInput=$(find \
-     objectivec/Tests/*.proto $PROTOC \
+     objectivec/Tests/*.proto "${PROTOC}" \
      objectivec/DevTools/compile_testing_protos.sh \
         -type f -print0 \
         | xargs -0 stat -f "%m %N" \
@@ -125,16 +125,6 @@ find "${OUTPUT_DIR}" \
     -type f -name "*.pbobjc.[hm]" -print0 \
     | xargs -0 rm -rf
 
-# -----------------------------------------------------------------------------
-# Helper to invoke protoc
-compile_protos() {
-  $PROTOC                                      \
-    --objc_out="${OUTPUT_DIR}/google/protobuf" \
-    --proto_path=src                           \
-    --experimental_allow_proto3_optional       \
-    "$@"
-}
-
 # -----------------------------------------------------------------------------
 # Generate the Objective C specific testing protos.
 
@@ -142,5 +132,9 @@ compile_protos() {
 # files, so they can't be generated all at once. This works because the overlap
 # isn't linked into a single binary.
 for a_proto in "${OBJC_TEST_PROTO_FILES[@]}" ; do
-  compile_protos --proto_path="objectivec/Tests" "${a_proto}"
+  "${PROTOC}"                                  \
+    --objc_out="${OUTPUT_DIR}"                 \
+    --proto_path=src                           \
+    --proto_path="objectivec/Tests"            \
+    "${a_proto}"
 done

objectivec/Tests/GPBARCUnittestProtos.m

@@ -34,17 +34,17 @@
 
 // Makes sure all the generated headers compile with ARC on.
 
-#import "google/protobuf/Unittest.pbobjc.h"
-#import "google/protobuf/UnittestCycle.pbobjc.h"
-#import "google/protobuf/UnittestDeprecated.pbobjc.h"
-#import "google/protobuf/UnittestDeprecatedFile.pbobjc.h"
-#import "google/protobuf/UnittestImport.pbobjc.h"
-#import "google/protobuf/UnittestImportPublic.pbobjc.h"
-#import "google/protobuf/UnittestImportPublicLite.pbobjc.h"
-#import "google/protobuf/UnittestMset.pbobjc.h"
-#import "google/protobuf/UnittestObjc.pbobjc.h"
-#import "google/protobuf/UnittestObjcOptions.pbobjc.h"
-#import "google/protobuf/UnittestObjcStartup.pbobjc.h"
-#import "google/protobuf/UnittestPreserveUnknownEnum.pbobjc.h"
-#import "google/protobuf/UnittestRuntimeProto2.pbobjc.h"
-#import "google/protobuf/UnittestRuntimeProto3.pbobjc.h"
+#import "Unittest.pbobjc.h"
+#import "UnittestCycle.pbobjc.h"
+#import "UnittestDeprecated.pbobjc.h"
+#import "UnittestDeprecatedFile.pbobjc.h"
+#import "UnittestImport.pbobjc.h"
+#import "UnittestImportPublic.pbobjc.h"
+#import "UnittestImportPublicLite.pbobjc.h"
+#import "UnittestMset.pbobjc.h"
+#import "UnittestObjc.pbobjc.h"
+#import "UnittestObjcOptions.pbobjc.h"
+#import "UnittestObjcStartup.pbobjc.h"
+#import "UnittestPreserveUnknownEnum.pbobjc.h"
+#import "UnittestRuntimeProto2.pbobjc.h"
+#import "UnittestRuntimeProto3.pbobjc.h"

objectivec/Tests/GPBCodedInputStreamTests.m

@@ -34,7 +34,7 @@
 #import "GPBCodedOutputStream.h"
 #import "GPBUnknownFieldSet_PackagePrivate.h"
 #import "GPBUtilities_PackagePrivate.h"
-#import "google/protobuf/Unittest.pbobjc.h"
+#import "Unittest.pbobjc.h"
 
 @interface CodedInputStreamTests : GPBTestCase
 @end

objectivec/Tests/GPBCodedOuputStreamTests.m

@@ -33,7 +33,7 @@
 #import "GPBCodedOutputStream_PackagePrivate.h"
 #import "GPBCodedInputStream.h"
 #import "GPBUtilities_PackagePrivate.h"
-#import "google/protobuf/Unittest.pbobjc.h"
+#import "Unittest.pbobjc.h"
 
 @interface GPBCodedOutputStream (InternalMethods)
 // Declared in the .m file, expose for testing.

objectivec/Tests/GPBConcurrencyTests.m

@@ -30,8 +30,8 @@
 
 #import "GPBTestUtilities.h"
 
-#import "google/protobuf/Unittest.pbobjc.h"
-#import "google/protobuf/UnittestObjc.pbobjc.h"
+#import "Unittest.pbobjc.h"
+#import "UnittestObjc.pbobjc.h"
 
 static const int kNumThreads = 100;
 static const int kNumMessages = 100;

objectivec/Tests/GPBDescriptorTests.m

@@ -33,9 +33,9 @@
 #import <objc/runtime.h>
 
 #import "GPBDescriptor_PackagePrivate.h"
-#import "google/protobuf/Unittest.pbobjc.h"
-#import "google/protobuf/UnittestObjc.pbobjc.h"
-#import "google/protobuf/UnittestObjcOptions.pbobjc.h"
+#import "Unittest.pbobjc.h"
+#import "UnittestObjc.pbobjc.h"
+#import "UnittestObjcOptions.pbobjc.h"
 
 @interface DescriptorTests : GPBTestCase
 @end

objectivec/Tests/GPBDictionaryTests+Bool.m

@@ -34,7 +34,7 @@
 #import "GPBDictionary.h"
 
 #import "GPBTestUtilities.h"
-#import "google/protobuf/UnittestRuntimeProto2.pbobjc.h"
+#import "UnittestRuntimeProto2.pbobjc.h"
 
 // Pull in the macros (using an external file because expanding all tests
 // in a single file makes a file that is failing to work with within Xcode.

objectivec/Tests/GPBDictionaryTests+Int32.m

@@ -34,7 +34,7 @@
 #import "GPBDictionary.h"
 
 #import "GPBTestUtilities.h"
-#import "google/protobuf/UnittestRuntimeProto2.pbobjc.h"
+#import "UnittestRuntimeProto2.pbobjc.h"
 
 // Pull in the macros (using an external file because expanding all tests
 // in a single file makes a file that is failing to work with within Xcode.

objectivec/Tests/GPBDictionaryTests+Int64.m

@@ -34,7 +34,7 @@
 #import "GPBDictionary.h"
 
 #import "GPBTestUtilities.h"
-#import "google/protobuf/UnittestRuntimeProto2.pbobjc.h"
+#import "UnittestRuntimeProto2.pbobjc.h"
 
 // Pull in the macros (using an external file because expanding all tests
 // in a single file makes a file that is failing to work with within Xcode.

objectivec/Tests/GPBDictionaryTests+String.m

@@ -34,7 +34,7 @@
 #import "GPBDictionary.h"
 
 #import "GPBTestUtilities.h"
-#import "google/protobuf/UnittestRuntimeProto2.pbobjc.h"
+#import "UnittestRuntimeProto2.pbobjc.h"
 
 // Pull in the macros (using an external file because expanding all tests
 // in a single file makes a file that is failing to work with within Xcode.

objectivec/Tests/GPBDictionaryTests+UInt32.m

@@ -34,7 +34,7 @@
 #import "GPBDictionary.h"
 
 #import "GPBTestUtilities.h"
-#import "google/protobuf/UnittestRuntimeProto2.pbobjc.h"
+#import "UnittestRuntimeProto2.pbobjc.h"
 
 // Pull in the macros (using an external file because expanding all tests
 // in a single file makes a file that is failing to work with within Xcode.

objectivec/Tests/GPBDictionaryTests+UInt64.m

@@ -34,7 +34,7 @@
 #import "GPBDictionary.h"
 
 #import "GPBTestUtilities.h"
-#import "google/protobuf/UnittestRuntimeProto2.pbobjc.h"
+#import "UnittestRuntimeProto2.pbobjc.h"
 
 // Pull in the macros (using an external file because expanding all tests
 // in a single file makes a file that is failing to work with within Xcode.

objectivec/Tests/GPBExtensionRegistryTest.m

@@ -31,7 +31,7 @@
 #import "GPBTestUtilities.h"
 
 #import "GPBExtensionRegistry.h"
-#import "google/protobuf/Unittest.pbobjc.h"
+#import "Unittest.pbobjc.h"
 
 @interface GPBExtensionRegistryTest : GPBTestCase
 @end

objectivec/Tests/GPBMessageTests+Merge.m

@@ -34,11 +34,11 @@
 
 #import "GPBMessage.h"
 
-#import "google/protobuf/MapUnittest.pbobjc.h"
-#import "google/protobuf/Unittest.pbobjc.h"
-#import "google/protobuf/UnittestPreserveUnknownEnum.pbobjc.h"
-#import "google/protobuf/UnittestRuntimeProto2.pbobjc.h"
-#import "google/protobuf/UnittestRuntimeProto3.pbobjc.h"
+#import "MapUnittest.pbobjc.h"
+#import "Unittest.pbobjc.h"
+#import "UnittestPreserveUnknownEnum.pbobjc.h"
+#import "UnittestRuntimeProto2.pbobjc.h"
+#import "UnittestRuntimeProto3.pbobjc.h"
 
 @interface MessageMergeTests : GPBTestCase
 @end

objectivec/Tests/GPBMessageTests+Runtime.m

@@ -34,12 +34,12 @@
 
 #import "GPBMessage.h"
 
-#import "google/protobuf/MapUnittest.pbobjc.h"
-#import "google/protobuf/Unittest.pbobjc.h"
-#import "google/protobuf/UnittestCycle.pbobjc.h"
-#import "google/protobuf/UnittestObjcStartup.pbobjc.h"
-#import "google/protobuf/UnittestRuntimeProto2.pbobjc.h"
-#import "google/protobuf/UnittestRuntimeProto3.pbobjc.h"
+#import "MapUnittest.pbobjc.h"
+#import "Unittest.pbobjc.h"
+#import "UnittestCycle.pbobjc.h"
+#import "UnittestObjcStartup.pbobjc.h"
+#import "UnittestRuntimeProto2.pbobjc.h"
+#import "UnittestRuntimeProto3.pbobjc.h"
 
 @interface MessageRuntimeTests : GPBTestCase
 @end

objectivec/Tests/GPBMessageTests+Serialization.m

@@ -34,12 +34,12 @@
 
 #import "GPBMessage.h"
 
-#import "google/protobuf/MapProto2Unittest.pbobjc.h"
-#import "google/protobuf/MapUnittest.pbobjc.h"
-#import "google/protobuf/Unittest.pbobjc.h"
-#import "google/protobuf/UnittestPreserveUnknownEnum.pbobjc.h"
-#import "google/protobuf/UnittestRuntimeProto2.pbobjc.h"
-#import "google/protobuf/UnittestRuntimeProto3.pbobjc.h"
+#import "MapProto2Unittest.pbobjc.h"
+#import "MapUnittest.pbobjc.h"
+#import "Unittest.pbobjc.h"
+#import "UnittestPreserveUnknownEnum.pbobjc.h"
+#import "UnittestRuntimeProto2.pbobjc.h"
+#import "UnittestRuntimeProto3.pbobjc.h"
 
 @interface MessageSerializationTests : GPBTestCase
 @end

objectivec/Tests/GPBMessageTests.m

@@ -38,10 +38,10 @@
 #import "GPBMessage_PackagePrivate.h"
 #import "GPBUnknownField_PackagePrivate.h"
 #import "GPBUnknownFieldSet_PackagePrivate.h"
-#import "google/protobuf/Unittest.pbobjc.h"
-#import "google/protobuf/UnittestObjc.pbobjc.h"
-#import "google/protobuf/UnittestObjcOptions.pbobjc.h"
-#import "google/protobuf/UnittestImport.pbobjc.h"
+#import "Unittest.pbobjc.h"
+#import "UnittestObjc.pbobjc.h"
+#import "UnittestObjcOptions.pbobjc.h"
+#import "UnittestImport.pbobjc.h"
 
 // Helper class to test KVO.
 @interface GPBKVOTestObserver : NSObject {

objectivec/Tests/GPBObjectiveCPlusPlusTest.mm

@@ -43,8 +43,8 @@
 // The "well know types" should have cross file enums needing imports.
 #import "GPBProtocolBuffers.h"
 // Some of the tests explicitly use cross file enums also.
-#import "google/protobuf/Unittest.pbobjc.h"
-#import "google/protobuf/UnittestImport.pbobjc.h"
+#import "Unittest.pbobjc.h"
+#import "UnittestImport.pbobjc.h"
 
 // Sanity check the conditions of the test within the Xcode project.
 #if !__cplusplus

objectivec/Tests/GPBPerfTests.m

@@ -29,9 +29,9 @@
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 #import "GPBTestUtilities.h"
-#import "google/protobuf/Unittest.pbobjc.h"
-#import "google/protobuf/UnittestImport.pbobjc.h"
-#import "google/protobuf/UnittestObjc.pbobjc.h"
+#import "Unittest.pbobjc.h"
+#import "UnittestImport.pbobjc.h"
+#import "UnittestObjc.pbobjc.h"
 
 //
 // This file really just uses the unittests framework as a testbed to

objectivec/Tests/GPBTestUtilities.m

@@ -30,9 +30,9 @@
 
 #import "GPBTestUtilities.h"
 
-#import "google/protobuf/MapUnittest.pbobjc.h"
-#import "google/protobuf/Unittest.pbobjc.h"
-#import "google/protobuf/UnittestImport.pbobjc.h"
+#import "MapUnittest.pbobjc.h"
+#import "Unittest.pbobjc.h"
+#import "UnittestImport.pbobjc.h"
 
 const uint32_t kGPBDefaultRepeatCount = 2;
 

objectivec/Tests/GPBUnittestProtos.m

@@ -31,29 +31,29 @@
 // Collects all the compiled protos into one file and compiles them to make sure
 // the compiler is generating valid code.
 
-#import "google/protobuf/AnyTest.pbobjc.m"
-#import "google/protobuf/MapProto2Unittest.pbobjc.m"
-#import "google/protobuf/MapUnittest.pbobjc.m"
-#import "google/protobuf/Unittest.pbobjc.m"
-#import "google/protobuf/UnittestCycle.pbobjc.m"
-#import "google/protobuf/UnittestDeprecated.pbobjc.m"
-#import "google/protobuf/UnittestDeprecatedFile.pbobjc.m"
-#import "google/protobuf/UnittestImport.pbobjc.m"
-#import "google/protobuf/UnittestImportPublic.pbobjc.m"
-#import "google/protobuf/UnittestImportPublicLite.pbobjc.m"
-#import "google/protobuf/UnittestMset.pbobjc.m"
-#import "google/protobuf/UnittestMsetWireFormat.pbobjc.m"
-#import "google/protobuf/UnittestObjc.pbobjc.m"
-#import "google/protobuf/UnittestObjcOptions.pbobjc.m"
-#import "google/protobuf/UnittestObjcStartup.pbobjc.m"
-#import "google/protobuf/UnittestPreserveUnknownEnum.pbobjc.m"
-#import "google/protobuf/UnittestRuntimeProto2.pbobjc.m"
-#import "google/protobuf/UnittestRuntimeProto3.pbobjc.m"
+#import "AnyTest.pbobjc.m"
+#import "MapProto2Unittest.pbobjc.m"
+#import "MapUnittest.pbobjc.m"
+#import "Unittest.pbobjc.m"
+#import "UnittestCycle.pbobjc.m"
+#import "UnittestDeprecated.pbobjc.m"
+#import "UnittestDeprecatedFile.pbobjc.m"
+#import "UnittestImport.pbobjc.m"
+#import "UnittestImportPublic.pbobjc.m"
+#import "UnittestImportPublicLite.pbobjc.m"
+#import "UnittestMset.pbobjc.m"
+#import "UnittestMsetWireFormat.pbobjc.m"
+#import "UnittestObjc.pbobjc.m"
+#import "UnittestObjcOptions.pbobjc.m"
+#import "UnittestObjcStartup.pbobjc.m"
+#import "UnittestPreserveUnknownEnum.pbobjc.m"
+#import "UnittestRuntimeProto2.pbobjc.m"
+#import "UnittestRuntimeProto3.pbobjc.m"
 
-#import "google/protobuf/UnittestExtensionChainA.pbobjc.m"
-#import "google/protobuf/UnittestExtensionChainB.pbobjc.m"
-#import "google/protobuf/UnittestExtensionChainC.pbobjc.m"
-#import "google/protobuf/UnittestExtensionChainD.pbobjc.m"
-#import "google/protobuf/UnittestExtensionChainE.pbobjc.m"
+#import "UnittestExtensionChainA.pbobjc.m"
+#import "UnittestExtensionChainB.pbobjc.m"
+#import "UnittestExtensionChainC.pbobjc.m"
+#import "UnittestExtensionChainD.pbobjc.m"
+#import "UnittestExtensionChainE.pbobjc.m"
 // See GPBUnittestProtos2.m for for "UnittestExtensionChainF.pbobjc.m"
-#import "google/protobuf/UnittestExtensionChainG.pbobjc.m"
+#import "UnittestExtensionChainG.pbobjc.m"

objectivec/Tests/GPBUnittestProtos2.m

@@ -31,4 +31,4 @@
 // This one file in the chain tests is compiled by itself to ensure if was
 // generated with the extra #imports needed to pull in the indirect Root class
 // used in its Root registry.
-#import "google/protobuf/UnittestExtensionChainF.pbobjc.m"
+#import "UnittestExtensionChainF.pbobjc.m"

objectivec/Tests/GPBUnknownFieldSetTest.m

@@ -32,7 +32,7 @@
 
 #import "GPBUnknownField_PackagePrivate.h"
 #import "GPBUnknownFieldSet_PackagePrivate.h"
-#import "google/protobuf/Unittest.pbobjc.h"
+#import "Unittest.pbobjc.h"
 
 @interface GPBUnknownFieldSet (GPBUnknownFieldSetTest)
 - (void)getTags:(int32_t*)tags;

objectivec/Tests/GPBUtilitiesTests.m

@@ -41,9 +41,9 @@
 #import "GPBMessage.h"
 #import "GPBUnknownField_PackagePrivate.h"
 
-#import "google/protobuf/MapUnittest.pbobjc.h"
-#import "google/protobuf/Unittest.pbobjc.h"
-#import "google/protobuf/UnittestObjc.pbobjc.h"
+#import "MapUnittest.pbobjc.h"
+#import "Unittest.pbobjc.h"
+#import "UnittestObjc.pbobjc.h"
 
 @interface UtilitiesTests : GPBTestCase
 @end

objectivec/Tests/GPBWellKnownTypesTest.m

@@ -33,7 +33,7 @@
 #import <XCTest/XCTest.h>
 
 #import "GPBTestUtilities.h"
-#import "google/protobuf/AnyTest.pbobjc.h"
+#import "AnyTest.pbobjc.h"
 
 // Nanosecond time accuracy
 static const NSTimeInterval kTimeAccuracy = 1e-9;

objectivec/Tests/GPBWireFormatTests.m

@@ -33,9 +33,9 @@
 #import "GPBCodedInputStream.h"
 #import "GPBMessage_PackagePrivate.h"
 #import "GPBUnknownField_PackagePrivate.h"
-#import "google/protobuf/Unittest.pbobjc.h"
-#import "google/protobuf/UnittestMset.pbobjc.h"
-#import "google/protobuf/UnittestMsetWireFormat.pbobjc.h"
+#import "Unittest.pbobjc.h"
+#import "UnittestMset.pbobjc.h"
+#import "UnittestMsetWireFormat.pbobjc.h"
 
 @interface WireFormatTests : GPBTestCase
 @end

objectivec/Tests/UnitTests-Bridging-Header.h

@@ -2,5 +2,5 @@
 //  Use this file to import your target's public headers that you would like to expose to Swift.
 //
 
-#import "google/protobuf/UnittestRuntimeProto2.pbobjc.h"
-#import "google/protobuf/UnittestRuntimeProto3.pbobjc.h"
+#import "UnittestRuntimeProto2.pbobjc.h"
+#import "UnittestRuntimeProto3.pbobjc.h"