diff --git a/upb/bazel/upb_proto_library.bzl b/upb/bazel/upb_proto_library.bzl index 941249d17e..9c4f85be36 100644 --- a/upb/bazel/upb_proto_library.bzl +++ b/upb/bazel/upb_proto_library.bzl @@ -153,7 +153,7 @@ def _cc_library_func(ctx, name, hdrs, srcs, copts, includes, dep_ccinfos): cc_toolchain = toolchain, compilation_outputs = compilation_outputs, linking_contexts = linking_contexts, - disallow_dynamic_library = cc_common.is_enabled(feature_configuration = feature_configuration, feature_name = "targets_windows"), + disallow_dynamic_library = cc_common.is_enabled(feature_configuration = feature_configuration, feature_name = "targets_windows") or not cc_common.is_enabled(feature_configuration = feature_configuration, feature_name = "supports_dynamic_linker"), ) return CcInfo( diff --git a/upb/python/dist/dist.bzl b/upb/python/dist/dist.bzl index 7ce38e35a6..75c21c31c3 100644 --- a/upb/python/dist/dist.bzl +++ b/upb/python/dist/dist.bzl @@ -22,6 +22,7 @@ def _get_suffix(limited_api, python_version, cpu): python_version += "m" abis = { "darwin_arm64": "darwin", + "darwin_x86_64": "darwin", "darwin": "darwin", "osx-x86_64": "darwin", "osx-aarch_64": "darwin", diff --git a/upb/python/message.c b/upb/python/message.c index 7c8ddebce1..5a96980578 100644 --- a/upb/python/message.c +++ b/upb/python/message.c @@ -1216,7 +1216,7 @@ static PyObject* PyUpb_Message_MergeInternal(PyObject* self, PyObject* arg, if (!serialized) return NULL; PyObject* ret = PyUpb_Message_MergeFromString(self, serialized); Py_DECREF(serialized); - Py_DECREF(ret); + Py_XDECREF(ret); Py_RETURN_NONE; } diff --git a/upb/upb/mini_descriptor/internal/encode.hpp b/upb/upb/mini_descriptor/internal/encode.hpp index d778a7253b..d8b3113d0a 100644 --- a/upb/upb/mini_descriptor/internal/encode.hpp +++ b/upb/upb/mini_descriptor/internal/encode.hpp @@ -43,49 +43,51 @@ class MtDataEncoder { MtDataEncoder() : appender_(&encoder_) {} bool StartMessage(uint64_t msg_mod) { - return appender_([=](char* buf) { + return appender_([this, msg_mod](char* buf) { return upb_MtDataEncoder_StartMessage(&encoder_, buf, msg_mod); }); } bool PutField(upb_FieldType type, uint32_t field_num, uint64_t field_mod) { - return appender_([=](char* buf) { + return appender_([this, type, field_num, field_mod](char* buf) { return upb_MtDataEncoder_PutField(&encoder_, buf, type, field_num, field_mod); }); } bool StartOneof() { - return appender_([=](char* buf) { + return appender_([this](char* buf) { return upb_MtDataEncoder_StartOneof(&encoder_, buf); }); } bool PutOneofField(uint32_t field_num) { - return appender_([=](char* buf) { + return appender_([this, field_num](char* buf) { return upb_MtDataEncoder_PutOneofField(&encoder_, buf, field_num); }); } bool StartEnum() { - return appender_( - [=](char* buf) { return upb_MtDataEncoder_StartEnum(&encoder_, buf); }); + return appender_([this](char* buf) { + return upb_MtDataEncoder_StartEnum(&encoder_, buf); + }); } bool PutEnumValue(uint32_t enum_value) { - return appender_([=](char* buf) { + return appender_([this, enum_value](char* buf) { return upb_MtDataEncoder_PutEnumValue(&encoder_, buf, enum_value); }); } bool EndEnum() { - return appender_( - [=](char* buf) { return upb_MtDataEncoder_EndEnum(&encoder_, buf); }); + return appender_([this](char* buf) { + return upb_MtDataEncoder_EndEnum(&encoder_, buf); + }); } bool EncodeExtension(upb_FieldType type, uint32_t field_num, uint64_t field_mod) { - return appender_([=](char* buf) { + return appender_([this, type, field_num, field_mod](char* buf) { return upb_MtDataEncoder_EncodeExtension(&encoder_, buf, type, field_num, field_mod); }); @@ -93,14 +95,14 @@ class MtDataEncoder { bool EncodeMap(upb_FieldType key_type, upb_FieldType val_type, uint64_t key_mod, uint64_t val_mod) { - return appender_([=](char* buf) { + return appender_([this, key_type, val_type, key_mod, val_mod](char* buf) { return upb_MtDataEncoder_EncodeMap(&encoder_, buf, key_type, val_type, key_mod, val_mod); }); } bool EncodeMessageSet() { - return appender_([=](char* buf) { + return appender_([this](char* buf) { return upb_MtDataEncoder_EncodeMessageSet(&encoder_, buf); }); }