Disable the warning for adding duplicated symbol (#8720)

When we need to aggregate metadata, duplication does happen.
Disable the warning for now to mitigate the noise for users of aggregate
metadata.
pull/8723/head
Paul Yang 4 years ago committed by GitHub
parent 9223147983
commit b24d0c2b7a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 10
      php/ext/google/protobuf/def.c

@ -918,10 +918,12 @@ static void add_descriptor(DescriptorPool *pool,
if (upb_symtab_lookupfile2(pool->symtab, name.data, name.size)) { if (upb_symtab_lookupfile2(pool->symtab, name.data, name.size)) {
// Already added. // Already added.
zend_error(E_USER_WARNING, // TODO(teboring): Re-enable this warning when aggregate metadata is
"proto descriptor was previously loaded (included in multiple " // deprecated.
"metadata bundles?): " UPB_STRVIEW_FORMAT, // zend_error(E_USER_WARNING,
UPB_STRVIEW_ARGS(name)); // "proto descriptor was previously loaded (included in multiple "
// "metadata bundles?): " UPB_STRVIEW_FORMAT,
// UPB_STRVIEW_ARGS(name));
return; return;
} }

Loading…
Cancel
Save