make changes to pass Cygwin

pull/1/head
jieluo@google.com 11 years ago
parent 91e32ac64d
commit abe61de6e6
  1. 3
      configure.ac
  2. 14
      src/google/protobuf/compiler/command_line_interface_unittest.cc

@ -29,7 +29,7 @@ AS_IF([test "x${ac_cv_env_CXXFLAGS_set}" = "x"],
AC_CANONICAL_TARGET AC_CANONICAL_TARGET
AM_INIT_AUTOMAKE AM_INIT_AUTOMAKE([subdir-objects])
AC_ARG_WITH([zlib], AC_ARG_WITH([zlib],
[AS_HELP_STRING([--with-zlib], [AS_HELP_STRING([--with-zlib],
@ -46,6 +46,7 @@ AC_PROG_CC
AC_PROG_CXX AC_PROG_CXX
AC_LANG([C++]) AC_LANG([C++])
ACX_USE_SYSTEM_EXTENSIONS ACX_USE_SYSTEM_EXTENSIONS
AM_PROG_AR
AM_CONDITIONAL(GCC, test "$GCC" = yes) # let the Makefile know if we're gcc AM_CONDITIONAL(GCC, test "$GCC" = yes) # let the Makefile know if we're gcc
# test_util.cc takes forever to compile with GCC and optimization turned on. # test_util.cc takes forever to compile with GCC and optimization turned on.

@ -85,7 +85,7 @@ class CommandLineInterfaceTest : public testing::Test {
// Runs the CommandLineInterface with the given command line. The // Runs the CommandLineInterface with the given command line. The
// command is automatically split on spaces, and the string "$tmpdir" // command is automatically split on spaces, and the string "$tmpdir"
// is replaced with TestTempDir(). // is replaced with TestTempDir().
void Run(const string& command); void Run(const string& command, bool capture_stdout = false);
// ----------------------------------------------------------------- // -----------------------------------------------------------------
// Methods to set up the test (called before Run()). // Methods to set up the test (called before Run()).
@ -261,7 +261,7 @@ void CommandLineInterfaceTest::TearDown() {
mock_generators_to_delete_.clear(); mock_generators_to_delete_.clear();
} }
void CommandLineInterfaceTest::Run(const string& command) { void CommandLineInterfaceTest::Run(const string& command, bool capture_stdout) {
vector<string> args = Split(command, " ", true); vector<string> args = Split(command, " ", true);
if (!disallow_plugins_) { if (!disallow_plugins_) {
@ -308,13 +308,17 @@ void CommandLineInterfaceTest::Run(const string& command) {
argv[i] = args[i].c_str(); argv[i] = args[i].c_str();
} }
CaptureTestStdout(); if (capture_stdout) {
CaptureTestStdout();
}
CaptureTestStderr(); CaptureTestStderr();
return_code_ = cli_.Run(args.size(), argv.get()); return_code_ = cli_.Run(args.size(), argv.get());
error_text_ = GetCapturedTestStderr(); error_text_ = GetCapturedTestStderr();
captured_stdout_ = GetCapturedTestStdout(); if (capture_stdout) {
captured_stdout_ = GetCapturedTestStdout();
}
} }
// ------------------------------------------------------------------- // -------------------------------------------------------------------
@ -1461,7 +1465,7 @@ TEST_F(CommandLineInterfaceTest, PrintFreeFieldNumbers) {
"}\n"); "}\n");
Run("protocol_compiler --print_free_field_numbers --proto_path=$tmpdir " Run("protocol_compiler --print_free_field_numbers --proto_path=$tmpdir "
"foo.proto bar.proto baz.proto quz.proto"); "foo.proto bar.proto baz.proto quz.proto", true);
ExpectNoErrors(); ExpectNoErrors();
ExpectCapturedStdout( ExpectCapturedStdout(

Loading…
Cancel
Save