Don't call GetReflection(), unless the result will be used.

PiperOrigin-RevId: 496782593
2 years ago · a7473b65b8
parent 91c7e91a1a
commit a7473b65b8
1 changed files with 2 additions and 2 deletions
--- a/src/google/protobuf/util/message_differencer.cc
+++ b/src/google/protobuf/util/message_differencer.cc
@ -638,12 +638,12 @@ bool MessageDifferencer::Compare(const Message& message1,
      return Compare(*data1, *data2, unpacked_any + 1, parent_fields);
    }
  }
-  const Reflection* reflection1 = message1.GetReflection();
-  const Reflection* reflection2 = message2.GetReflection();

  bool unknown_compare_result = true;
  // Ignore unknown fields in EQUIVALENT mode
  if (message_field_comparison_ != EQUIVALENT) {
+    const Reflection* reflection1 = message1.GetReflection();
+    const Reflection* reflection2 = message2.GetReflection();
    const UnknownFieldSet& unknown_field_set1 =
        reflection1->GetUnknownFields(message1);
    const UnknownFieldSet& unknown_field_set2 =