simplify mergeable UI messages (#9445)

No "Please"

see https://docs.google.com/document/d/1mIHBZQXI3F5VEPPmR54PySixl8wSsdwVciSENJ0Unxg/edit#heading=h.vvb6vlxagbv8 for justification

also make the and clause a little simpler. That is, this is now "Include release notes: yes AND at least a language label" instead of "Please include release notes: yes AND Please include at least a language label"
pull/9426/merge
Elliotte Rusty Harold 3 years ago committed by GitHub
parent 82372d8fe6
commit a30167f016
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 6
      .github/mergeable.yml

@ -9,10 +9,10 @@ mergeable:
- and: - and:
- must_include: - must_include:
regex: 'release notes: yes' regex: 'release notes: yes'
message: 'Please include release notes: yes' message: 'Include release notes: yes'
- must_include: - must_include:
regex: '^(autotools|bazel|c#|c\+\+|cleanup|cmake|conformance tests|integration|go|java|javascript|objective-c|php|protoc|python|ruby|kotlin)' regex: '^(autotools|bazel|c#|c\+\+|cleanup|cmake|conformance tests|integration|go|java|javascript|objective-c|php|protoc|python|ruby|kotlin)'
message: 'Please include at least a language label (e.g., c++, java, python). Or apply one of the following labels: autotools, bazel, cmake, cleanup, conformance tests, integration, protoc.' message: 'at least a language label (e.g., c++, java, python). Or apply one of the following labels: autotools, bazel, cmake, cleanup, conformance tests, integration, protoc.'
- must_include: - must_include:
regex: 'release notes: no' regex: 'release notes: no'
message: 'Please include release notes: no' message: 'Include release notes: no'

Loading…
Cancel
Save