Add UPB_FORCEINLINE for varint32 decoding.

This speeds up the decoder by >20% and also reduces code size slightly!

name                       old time/op  new time/op  delta
ArenaOneAlloc              20.4ns ± 0%  20.2ns ± 0%   -1.10%  (p=0.000 n=12+11)
ArenaInitialBlockOneAlloc  5.25ns ± 0%  5.25ns ± 0%     ~     (p=0.786 n=11+12)
ParseDescriptorNoHeap      17.1µs ± 0%  13.1µs ± 0%  -23.29%  (p=0.000 n=11+12)
ParseDescriptor            17.4µs ± 1%  13.5µs ± 1%  -22.51%  (p=0.000 n=12+12)
SerializeDescriptor        10.7µs ± 0%  10.9µs ± 0%   +1.95%  (p=0.000 n=12+12)

    FILE SIZE        VM SIZE
 --------------  --------------
  +2.7%     +16   +2.7%     +16    [LOAD #2 [RX]]
  +0.5%     +16   [ = ]       0    [Unmapped]
  -1.4%     -72   -0.7%     -32    upb/decode.c
      +3.1%     +98   +3.1%     +98    decode_msg
      [DEL]    -170   [DEL]    -130    decode_varint32
  -0.0%     -40   -0.0%     -16    TOTAL
pull/13171/head
Joshua Haberman 4 years ago
parent d0f2c4c8a2
commit a202ce9629
  1. 2
      benchmark.py
  2. 1
      upb/decode.c

@ -15,7 +15,7 @@ import tempfile
@contextlib.contextmanager @contextlib.contextmanager
def GitWorktree(commit): def GitWorktree(commit):
tmpdir = tempfile.mkdtemp() tmpdir = tempfile.mkdtemp()
subprocess.run(['git', 'worktree', 'add', '-q', tmpdir, commit], check=True) subprocess.run(['git', 'worktree', 'add', '-q', '-d', tmpdir, commit], check=True)
cwd = os.getcwd() cwd = os.getcwd()
os.chdir(tmpdir) os.chdir(tmpdir)
try: try:

@ -227,6 +227,7 @@ static const char *decode_varint64(upb_decstate *d, const char *ptr,
} }
} }
UPB_FORCEINLINE
static const char *decode_varint32(upb_decstate *d, const char *ptr, static const char *decode_varint32(upb_decstate *d, const char *ptr,
const char *limit, uint32_t *val) { const char *limit, uint32_t *val) {
uint64_t u64; uint64_t u64;

Loading…
Cancel
Save