Remove SmallSortedMap.lazyDescendingEntrySet field caching

I've noted the rationale for this in the comment, and in the attached bug.

This should save about 4-8 bytes of memory (on the 64bit server JVM depending on if compressed object pointers are on) per object with extensions. And 4 bytes on Android.

PiperOrigin-RevId: 661900014

java/core/src/main/java/com/google/protobuf/SmallSortedMap.java

@@ -108,7 +108,6 @@ class SmallSortedMap<K extends Comparable<K>, V> extends AbstractMap<K, V> {
   // time it is requested and reused henceforth.
   private volatile EntrySet lazyEntrySet;
   private Map<K, V> overflowEntriesDescending;
-  private volatile DescendingEntrySet lazyDescendingEntrySet;
 
   private SmallSortedMap() {
     this.overflowEntries = Collections.emptyMap();
@@ -338,10 +337,12 @@ class SmallSortedMap<K extends Comparable<K>, V> extends AbstractMap<K, V> {
   }
 
   Set<Map.Entry<K, V>> descendingEntrySet() {
-    if (lazyDescendingEntrySet == null) {
+    // Optimisation note: Many java.util.Map implementations would, here, cache the return value in
-      lazyDescendingEntrySet = new DescendingEntrySet();
+    // a field, to avoid allocations for future calls to this method. But for us, descending
-    }
+    // iteration is rare, SmallSortedMaps are very common, and the entry set is only useful for
-    return lazyDescendingEntrySet;
+    // iteration, which allocates anyway. The extra memory cost of the field (4-8 bytes) isn't worth
+    // it. See b/357002010.
+    return new DescendingEntrySet();
   }
 
   /** @throws UnsupportedOperationException if {@link #makeImmutable()} has has been called. */