PROTOBUF_SYNC_PIPER
pull/8604/head
Joshua Haberman 4 years ago
parent 094d18944e
commit 9521803d40
  1. 23
      CHANGES.txt
  2. 24
      README.md
  3. 2
      cmake/libprotobuf.cmake
  4. 4
      conformance/failure_list_java.txt
  5. 2
      conformance/failure_list_php_c.txt
  6. 2
      conformance/failure_list_ruby.txt
  7. 9
      csharp/src/Google.Protobuf.Test/CodedInputStreamTest.cs
  8. 58
      csharp/src/Google.Protobuf.Test/MessageParsingHelpers.cs
  9. 3
      csharp/src/Google.Protobuf/CodedInputStream.cs
  10. 19
      csharp/src/Google.Protobuf/MessageExtensions.cs
  11. 26
      csharp/src/Google.Protobuf/MessageParser.cs
  12. 21
      csharp/src/Google.Protobuf/ParseContext.cs
  13. 24
      java/core/src/main/java/com/google/protobuf/CodedInputStream.java
  14. 40
      java/kotlin/pom.xml
  15. 3
      js/README.md
  16. 18
      kokoro/linux/aarch64/php_build_and_run_tests_with_qemu_aarch64.sh
  17. 31
      kokoro/linux/aarch64/test_php_aarch64.sh
  18. 3
      kokoro/linux/aarch64/testimage_protobuf_php_arm64v8/Dockerfile
  19. 16
      kokoro/linux/php_aarch64/build.sh
  20. 11
      kokoro/linux/php_aarch64/continuous.cfg
  21. 11
      kokoro/linux/php_aarch64/presubmit.cfg
  22. 2
      objectivec/README.md
  23. 4
      objectivec/Tests/GPBDescriptorTests.m
  24. 21
      php/ext/google/protobuf/message.c
  25. 1571
      php/ext/google/protobuf/php-upb.c
  26. 620
      php/ext/google/protobuf/php-upb.h
  27. 12
      php/src/Google/Protobuf/Internal/Message.php
  28. 3
      php/src/Google/Protobuf/Internal/RepeatedField.php
  29. 11
      php/tests/ArrayTest.php
  30. 8
      php/tests/EncodeDecodeTest.php
  31. 9
      php/tests/GeneratedClassTest.php
  32. 6
      protobuf.bzl
  33. 17
      python/google/protobuf/pyext/message.cc
  34. 77
      ruby/Rakefile
  35. 8
      ruby/ext/google/protobuf_c/message.c
  36. 1568
      ruby/ext/google/protobuf_c/ruby-upb.c
  37. 617
      ruby/ext/google/protobuf_c/ruby-upb.h
  38. 2
      src/Makefile.am
  39. 2
      src/README.md
  40. 12
      src/google/protobuf/any.pb.cc
  41. 72
      src/google/protobuf/api.pb.cc
  42. 6
      src/google/protobuf/api.pb.h
  43. 18
      src/google/protobuf/arenastring.cc
  44. 186
      src/google/protobuf/compiler/cpp/cpp_field.cc
  45. 2
      src/google/protobuf/compiler/cpp/cpp_file.cc
  46. 8
      src/google/protobuf/compiler/cpp/cpp_generator.cc
  47. 35
      src/google/protobuf/compiler/cpp/cpp_helpers.cc
  48. 26
      src/google/protobuf/compiler/cpp/cpp_helpers.h
  49. 80
      src/google/protobuf/compiler/cpp/cpp_message.cc
  50. 6
      src/google/protobuf/compiler/cpp/cpp_message_field.cc
  51. 5
      src/google/protobuf/compiler/cpp/cpp_message_layout_helper.h
  52. 2
      src/google/protobuf/compiler/cpp/cpp_options.h
  53. 5
      src/google/protobuf/compiler/cpp/cpp_padding_optimizer.cc
  54. 3
      src/google/protobuf/compiler/cpp/cpp_padding_optimizer.h
  55. 103
      src/google/protobuf/compiler/cpp/cpp_parse_function_generator.cc
  56. 3
      src/google/protobuf/compiler/cpp/cpp_parse_function_generator.h
  57. 14
      src/google/protobuf/compiler/cpp/cpp_test_bad_identifiers.proto
  58. 12
      src/google/protobuf/compiler/plugin.pb.h
  59. 20
      src/google/protobuf/descriptor.cc
  60. 60
      src/google/protobuf/descriptor.pb.h
  61. 12
      src/google/protobuf/duration.pb.cc
  62. 52
      src/google/protobuf/field_access_listener.cc
  63. 246
      src/google/protobuf/field_access_listener.h
  64. 52
      src/google/protobuf/generated_message_reflection.cc
  65. 32
      src/google/protobuf/generated_message_reflection_unittest.cc
  66. 17
      src/google/protobuf/generated_message_tctable_impl.h
  67. 164
      src/google/protobuf/generated_message_tctable_impl.inc
  68. 296
      src/google/protobuf/generated_message_tctable_lite.cc
  69. 4
      src/google/protobuf/parse_context.h
  70. 11
      src/google/protobuf/port_def.inc
  71. 2
      src/google/protobuf/port_undef.inc
  72. 86
      src/google/protobuf/repeated_field.h
  73. 6
      src/google/protobuf/source_context.pb.cc
  74. 6
      src/google/protobuf/stubs/substitute.cc
  75. 8
      src/google/protobuf/stubs/substitute.h
  76. 12
      src/google/protobuf/timestamp.pb.cc
  77. 114
      src/google/protobuf/type.pb.cc
  78. 18
      src/google/protobuf/type.pb.h
  79. 54
      src/google/protobuf/wrappers.pb.cc

@ -1,3 +1,26 @@
Unreleased Changes (C++/Java/Python/PHP/Objective-C/C#/Ruby/JavaScript)
Protocol Compiler
* Stop emitting boilerplate {Copy/Merge}From in each ProtoBuf class
* split the accessor annotations according to their operation
* introduce proto message injector
* let proto message injector decide whether to calculate address info based on field descriptor and access type.
* Disable LITE_RUNTIME injector annotations
* move callback and @protoc_insertion_point after internal set of enum fields
* Improve ExtractFieldInfo codegen for string fields with oneof or default value
* Rename MessageInjector to FieldAccessListener
* Change the API of FieldAccessListener to support callbacks for info extraction
* make field_access_injector private
2021-05-07 version 3.17.1 (C++/Java/Python/PHP/Objective-C/C#/Ruby/JavaScript)
PHP
* Fixed JSON parser to allow multiple values from the same oneof as long as
all but one are null.
Ruby
* Fixed JSON parser to allow multiple values from the same oneof as long as
all but one are null.
2021-05-07 version 3.17.0 (C++/Java/Python/PHP/Objective-C/C#/Ruby/JavaScript) 2021-05-07 version 3.17.0 (C++/Java/Python/PHP/Objective-C/C#/Ruby/JavaScript)
Protocol Compiler Protocol Compiler

@ -52,18 +52,18 @@ Protobuf supports several different programming languages. For each programming
language, you can find instructions in the corresponding source directory about language, you can find instructions in the corresponding source directory about
how to install protobuf runtime for that specific language: how to install protobuf runtime for that specific language:
| Language | Source | Ubuntu | MacOS | Windows | | Language | Source |
|--------------------------------------|-------------------------------------------------------------|--------|-------|---------| |--------------------------------------|-------------------------------------------------------------|
| C++ (include C++ runtime and protoc) | [src](src) | [![Build status](https://storage.googleapis.com/protobuf-kokoro-badges/status-badge/linux-cpp_distcheck.png)](https://fusion.corp.google.com/projectanalysis/current/KOKORO/prod:protobuf%2Fgithub%2Fmaster%2Fubuntu%2Fcpp_distcheck%2Fcontinuous)<br/>[![Build status](https://storage.googleapis.com/protobuf-kokoro-badges/status-badge/linux-bazel.png)](https://fusion.corp.google.com/projectanalysis/current/KOKORO/prod:protobuf%2Fgithub%2Fmaster%2Fubuntu%2Fbazel%2Fcontinuous)<br/>[![Build status](https://storage.googleapis.com/protobuf-kokoro-badges/status-badge/linux-dist_install.png)](https://fusion.corp.google.com/projectanalysis/current/KOKORO/prod:protobuf%2Fgithub%2Fmaster%2Fubuntu%2Fdist_install%2Fcontinuous) | [![Build status](https://storage.googleapis.com/protobuf-kokoro-badges/status-badge/macos-cpp.png)](https://fusion.corp.google.com/projectanalysis/current/KOKORO/prod:protobuf%2Fgithub%2Fmaster%2Fmacos%2Fcpp%2Fcontinuous)<br/>[![Build status](https://storage.googleapis.com/protobuf-kokoro-badges/status-badge/macos-cpp_distcheck.png)](https://fusion.corp.google.com/projectanalysis/current/KOKORO/prod:protobuf%2Fgithub%2Fmaster%2Fmacos%2Fcpp_distcheck%2Fcontinuous) | [![Build status](https://ci.appveyor.com/api/projects/status/73ctee6ua4w2ruin?svg=true)](https://ci.appveyor.com/project/protobuf/protobuf) | | C++ (include C++ runtime and protoc) | [src](src) |
| Java | [java](java) | [![Build status](https://storage.googleapis.com/protobuf-kokoro-badges/status-badge/linux-java_compatibility.png)](https://fusion.corp.google.com/projectanalysis/current/KOKORO/prod:protobuf%2Fgithub%2Fmaster%2Fubuntu%2Fjava_compatibility%2Fcontinuous)<br/>[![Build status](https://storage.googleapis.com/protobuf-kokoro-badges/status-badge/linux-java_jdk7.png)](https://fusion.corp.google.com/projectanalysis/current/KOKORO/prod:protobuf%2Fgithub%2Fmaster%2Fubuntu%2Fjava_jdk7%2Fcontinuous)<br/>[![Build status](https://storage.googleapis.com/protobuf-kokoro-badges/status-badge/linux-java_oracle7.png)](https://fusion.corp.google.com/projectanalysis/current/KOKORO/prod:protobuf%2Fgithub%2Fmaster%2Fubuntu%2Fjava_oracle7%2Fcontinuous)<br/>[![Build status](https://storage.googleapis.com/protobuf-kokoro-badges/status-badge/linux-java_linkage_monitor.png)](https://fusion.corp.google.com/projectanalysis/current/KOKORO/prod:protobuf%2Fgithub%2Fmaster%2Fubuntu%2Fjava_linkage_monitor%2Fcontinuous) | | | | Java | [java](java) |
| Python | [python](python) | [![Build status](https://storage.googleapis.com/protobuf-kokoro-badges/status-badge/linux-python27.png)](https://fusion.corp.google.com/projectanalysis/current/KOKORO/prod:protobuf%2Fgithub%2Fmaster%2Fubuntu%2Fpython27%2Fcontinuous)<br/>[![Build status](https://storage.googleapis.com/protobuf-kokoro-badges/status-badge/linux-python35.png)](https://fusion.corp.google.com/projectanalysis/current/KOKORO/prod:protobuf%2Fgithub%2Fmaster%2Fubuntu%2Fpython35%2Fcontinuous)<br/>[![Build status](https://storage.googleapis.com/protobuf-kokoro-badges/status-badge/linux-python36.png)](https://fusion.corp.google.com/projectanalysis/current/KOKORO/prod:protobuf%2Fgithub%2Fmaster%2Fubuntu%2Fpython36%2Fcontinuous)<br/>[![Build status](https://storage.googleapis.com/protobuf-kokoro-badges/status-badge/linux-python37.png)](https://fusion.corp.google.com/projectanalysis/current/KOKORO/prod:protobuf%2Fgithub%2Fmaster%2Fubuntu%2Fpython37%2Fcontinuous)<br/>[![Build status](https://storage.googleapis.com/protobuf-kokoro-badges/status-badge/linux-python_compatibility.png)](https://fusion.corp.google.com/projectanalysis/current/KOKORO/prod:protobuf%2Fgithub%2Fmaster%2Fubuntu%2Fpython_compatibility%2Fcontinuous)<br/>[![Build status](https://storage.googleapis.com/protobuf-kokoro-badges/status-badge/linux-python27_cpp.png)](https://fusion.corp.google.com/projectanalysis/current/KOKORO/prod:protobuf%2Fgithub%2Fmaster%2Fubuntu%2Fpython27_cpp%2Fcontinuous)<br/>[![Build status](https://storage.googleapis.com/protobuf-kokoro-badges/status-badge/linux-python35_cpp.png)](https://fusion.corp.google.com/projectanalysis/current/KOKORO/prod:protobuf%2Fgithub%2Fmaster%2Fubuntu%2Fpython35_cpp%2Fcontinuous)<br/>[![Build status](https://storage.googleapis.com/protobuf-kokoro-badges/status-badge/linux-python36_cpp.png)](https://fusion.corp.google.com/projectanalysis/current/KOKORO/prod:protobuf%2Fgithub%2Fmaster%2Fubuntu%2Fpython36_cpp%2Fcontinuous)<br/>[![Build status](https://storage.googleapis.com/protobuf-kokoro-badges/status-badge/linux-python37_cpp.png)](https://fusion.corp.google.com/projectanalysis/current/KOKORO/prod:protobuf%2Fgithub%2Fmaster%2Fubuntu%2Fpython37_cpp%2Fcontinuous)<br/>[![Build status](https://storage.googleapis.com/protobuf-kokoro-badges/status-badge/linux-python-release.png)](https://fusion.corp.google.com/projectanalysis/current/KOKORO/prod:protobuf%2Fgithub%2Fmaster%2Fubuntu%2Fpython_release%2Fcontinuous) | [![Build status](https://storage.googleapis.com/protobuf-kokoro-badges/status-badge/macos-python.png)](https://fusion.corp.google.com/projectanalysis/current/KOKORO/prod:protobuf%2Fgithub%2Fmaster%2Fmacos%2Fpython%2Fcontinuous)<br/>[![Build status](https://storage.googleapis.com/protobuf-kokoro-badges/status-badge/macos-python_cpp.png)](https://fusion.corp.google.com/projectanalysis/current/KOKORO/prod:protobuf%2Fgithub%2Fmaster%2Fmacos%2Fpython_cpp%2Fcontinuous)<br/>[![Build status](https://storage.googleapis.com/protobuf-kokoro-badges/status-badge/macos-python-release.png)](https://fusion.corp.google.com/projectanalysis/current/KOKORO/prod:protobuf%2Fgithub%2Fmaster%2Fmacos%2Fpython_release%2Fcontinuous) | [![Build status](https://storage.googleapis.com/protobuf-kokoro-badges/status-badge/windows-python-release.png)](https://fusion.corp.google.com/projectanalysis/current/KOKORO/prod:protobuf%2Fgithub%2Fmaster%2Fwindows%2Fpython_release%2Fcontinuous) | | Python | [python](python) |
| Objective-C | [objectivec](objectivec) | | [![Build status](https://storage.googleapis.com/protobuf-kokoro-badges/status-badge/macos-objectivec_cocoapods_integration.png)](https://fusion.corp.google.com/projectanalysis/current/KOKORO/prod:protobuf%2Fgithub%2Fmaster%2Fmacos%2Fobjectivec_cocoapods_integration%2Fcontinuous)<br/>[![Build status](https://storage.googleapis.com/protobuf-kokoro-badges/status-badge/macos-objectivec_ios_debug.png)](https://fusion.corp.google.com/projectanalysis/current/KOKORO/prod:protobuf%2Fgithub%2Fmaster%2Fmacos%2Fobjectivec_ios_debug%2Fcontinuous)<br/>[![Build status](https://storage.googleapis.com/protobuf-kokoro-badges/status-badge/macos-objectivec_ios_release.png)](https://fusion.corp.google.com/projectanalysis/current/KOKORO/prod:protobuf%2Fgithub%2Fmaster%2Fmacos%2Fobjectivec_ios_release%2Fcontinuous)<br/>[![Build status](https://storage.googleapis.com/protobuf-kokoro-badges/status-badge/macos-objectivec_osx.png)](https://fusion.corp.google.com/projectanalysis/current/KOKORO/prod:protobuf%2Fgithub%2Fmaster%2Fmacos%2Fobjectivec_osx%2Fcontinuous) | | | Objective-C | [objectivec](objectivec) |
| C# | [csharp](csharp) | [![Build status](https://storage.googleapis.com/protobuf-kokoro-badges/status-badge/linux-csharp.png)](https://fusion.corp.google.com/projectanalysis/current/KOKORO/prod:protobuf%2Fgithub%2Fmaster%2Fubuntu%2Fcsharp%2Fcontinuous) | | [![Build status](https://ci.appveyor.com/api/projects/status/73ctee6ua4w2ruin?svg=true)](https://ci.appveyor.com/project/protobuf/protobuf)<br/>[![Build status](https://storage.googleapis.com/protobuf-kokoro-badges/status-badge/windows-csharp-release.png)](https://fusion.corp.google.com/projectanalysis/current/KOKORO/prod:protobuf%2Fgithub%2Fmaster%2Fwindows%2Fcsharp_release%2Fcontinuous) | | C# | [csharp](csharp) |
| JavaScript | [js](js) | [![Build status](https://storage.googleapis.com/protobuf-kokoro-badges/status-badge/linux-javascript.png)](https://fusion.corp.google.com/projectanalysis/current/KOKORO/prod:protobuf%2Fgithub%2Fmaster%2Fubuntu%2Fjavascript%2Fcontinuous) | [![Build status](https://storage.googleapis.com/protobuf-kokoro-badges/status-badge/macos-javascript.png)](https://fusion.corp.google.com/projectanalysis/current/KOKORO/prod:protobuf%2Fgithub%2Fmaster%2Fmacos%2Fjavascript%2Fcontinuous) | | | JavaScript | [js](js) |
| Ruby | [ruby](ruby) | [![Build status](https://storage.googleapis.com/protobuf-kokoro-badges/status-badge/linux-ruby23.png)](https://fusion.corp.google.com/projectanalysis/current/KOKORO/prod:protobuf%2Fgithub%2Fmaster%2Fubuntu%2Fruby23%2Fcontinuous)<br/>[![Build status](https://storage.googleapis.com/protobuf-kokoro-badges/status-badge/linux-ruby24.png)](https://fusion.corp.google.com/projectanalysis/current/KOKORO/prod:protobuf%2Fgithub%2Fmaster%2Fubuntu%2Fruby24%2Fcontinuous)<br/>[![Build status](https://storage.googleapis.com/protobuf-kokoro-badges/status-badge/linux-ruby25.png)](https://fusion.corp.google.com/projectanalysis/current/KOKORO/prod:protobuf%2Fgithub%2Fmaster%2Fubuntu%2Fruby25%2Fcontinuous)<br/>[![Build status](https://storage.googleapis.com/protobuf-kokoro-badges/status-badge/linux-ruby26.png)](https://fusion.corp.google.com/projectanalysis/current/KOKORO/prod:protobuf%2Fgithub%2Fmaster%2Fubuntu%2Fruby26%2Fcontinuous)<br/>[![Build status](https://storage.googleapis.com/protobuf-kokoro-badges/status-badge/linux-ruby-release.png)](https://fusion.corp.google.com/projectanalysis/current/KOKORO/prod:protobuf%2Fgithub%2Fmaster%2Fubuntu%2Fruby_release%2Fcontinuous) | [![Build status](https://storage.googleapis.com/protobuf-kokoro-badges/status-badge/macos-ruby23.png)](https://fusion.corp.google.com/projectanalysis/current/KOKORO/prod:protobuf%2Fgithub%2Fmaster%2Fmacos%2Fruby23%2Fcontinuous)<br/>[![Build status](https://storage.googleapis.com/protobuf-kokoro-badges/status-badge/macos-ruby24.png)](https://fusion.corp.google.com/projectanalysis/current/KOKORO/prod:protobuf%2Fgithub%2Fmaster%2Fmacos%2Fruby24%2Fcontinuous)<br/>[![Build status](https://storage.googleapis.com/protobuf-kokoro-badges/status-badge/macos-ruby25.png)](https://fusion.corp.google.com/projectanalysis/current/KOKORO/prod:protobuf%2Fgithub%2Fmaster%2Fmacos%2Fruby25%2Fcontinuous)<br/>[![Build status](https://storage.googleapis.com/protobuf-kokoro-badges/status-badge/macos-ruby26.png)](https://fusion.corp.google.com/projectanalysis/current/KOKORO/prod:protobuf%2Fgithub%2Fmaster%2Fmacos%2Fruby26%2Fcontinuous)<br/>[![Build status](https://storage.googleapis.com/protobuf-kokoro-badges/status-badge/macos-ruby-release.png)](https://fusion.corp.google.com/projectanalysis/current/KOKORO/prod:protobuf%2Fgithub%2Fmaster%2Fmacos%2Fruby_release%2Fcontinuous) | | | Ruby | [ruby](ruby) |
| Go | [protocolbuffers/protobuf-go](https://github.com/protocolbuffers/protobuf-go) | | | | | Go | [protocolbuffers/protobuf-go](https://github.com/protocolbuffers/protobuf-go)|
| PHP | [php](php) | [![Build status](https://storage.googleapis.com/protobuf-kokoro-badges/status-badge/linux-php_all.png)](https://fusion.corp.google.com/projectanalysis/current/KOKORO/prod:protobuf%2Fgithub%2Fmaster%2Fubuntu%2Fphp_all%2Fcontinuous)<br/>[![Build status](https://storage.googleapis.com/protobuf-kokoro-badges/status-badge/linux-32-bit.png)](https://fusion.corp.google.com/projectanalysis/current/KOKORO/prod:protobuf%2Fgithub%2Fmaster%2Fubuntu%2F32-bit%2Fcontinuous)<br/>[![Build status](https://storage.googleapis.com/protobuf-kokoro-badges/status-badge/linux-php80.png)](https://fusion.corp.google.com/projectanalysis/current/KOKORO/prod:protobuf%2Fgithub%2Fmaster%2Fubuntu%2Fphp80%2Fcontinuous) | [![Build status](https://storage.googleapis.com/protobuf-kokoro-badges/status-badge/macos-php5.6_mac.png)](https://fusion.corp.google.com/projectanalysis/current/KOKORO/prod:protobuf%2Fgithub%2Fmaster%2Fmacos%2Fphp5.6_mac%2Fcontinuous)<br/>[![Build status](https://storage.googleapis.com/protobuf-kokoro-badges/status-badge/macos-php7.0_mac.png)](https://fusion.corp.google.com/projectanalysis/current/KOKORO/prod:protobuf%2Fgithub%2Fmaster%2Fmacos%2Fphp7.0_mac%2Fcontinuous) | | | PHP | [php](php) |
| Dart | [dart-lang/protobuf](https://github.com/dart-lang/protobuf) | [![Build Status](https://travis-ci.org/dart-lang/protobuf.svg?branch=master)](https://travis-ci.org/dart-lang/protobuf) | | | | Dart | [dart-lang/protobuf](https://github.com/dart-lang/protobuf) |
Quick Start Quick Start
----------- -----------

@ -11,6 +11,7 @@ set(libprotobuf_files
${protobuf_source_dir}/src/google/protobuf/dynamic_message.cc ${protobuf_source_dir}/src/google/protobuf/dynamic_message.cc
${protobuf_source_dir}/src/google/protobuf/empty.pb.cc ${protobuf_source_dir}/src/google/protobuf/empty.pb.cc
${protobuf_source_dir}/src/google/protobuf/extension_set_heavy.cc ${protobuf_source_dir}/src/google/protobuf/extension_set_heavy.cc
${protobuf_source_dir}/src/google/protobuf/field_access_listener.cc
${protobuf_source_dir}/src/google/protobuf/field_mask.pb.cc ${protobuf_source_dir}/src/google/protobuf/field_mask.pb.cc
${protobuf_source_dir}/src/google/protobuf/generated_message_reflection.cc ${protobuf_source_dir}/src/google/protobuf/generated_message_reflection.cc
${protobuf_source_dir}/src/google/protobuf/generated_message_table_driven.cc ${protobuf_source_dir}/src/google/protobuf/generated_message_table_driven.cc
@ -65,6 +66,7 @@ set(libprotobuf_includes
${protobuf_source_dir}/src/google/protobuf/duration.pb.h ${protobuf_source_dir}/src/google/protobuf/duration.pb.h
${protobuf_source_dir}/src/google/protobuf/dynamic_message.h ${protobuf_source_dir}/src/google/protobuf/dynamic_message.h
${protobuf_source_dir}/src/google/protobuf/empty.pb.h ${protobuf_source_dir}/src/google/protobuf/empty.pb.h
${protobuf_source_dir}/src/google/protobuf/field_access_listener.h
${protobuf_source_dir}/src/google/protobuf/field_mask.pb.h ${protobuf_source_dir}/src/google/protobuf/field_mask.pb.h
${protobuf_source_dir}/src/google/protobuf/generated_message_reflection.h ${protobuf_source_dir}/src/google/protobuf/generated_message_reflection.h
${protobuf_source_dir}/src/google/protobuf/io/gzip_stream.h ${protobuf_source_dir}/src/google/protobuf/io/gzip_stream.h

@ -42,7 +42,3 @@ Required.Proto3.JsonInput.Int32FieldPlusSign
Required.Proto3.JsonInput.RepeatedFieldWrongElementTypeExpectingStringsGotBool Required.Proto3.JsonInput.RepeatedFieldWrongElementTypeExpectingStringsGotBool
Required.Proto3.JsonInput.RepeatedFieldWrongElementTypeExpectingStringsGotInt Required.Proto3.JsonInput.RepeatedFieldWrongElementTypeExpectingStringsGotInt
Required.Proto3.JsonInput.StringFieldNotAString Required.Proto3.JsonInput.StringFieldNotAString
Required.Proto3.ProtobufInput.PrematureEofInDelimitedDataForKnownNonRepeatedValue.MESSAGE
Required.Proto3.ProtobufInput.PrematureEofInDelimitedDataForKnownRepeatedValue.MESSAGE
Required.Proto2.ProtobufInput.PrematureEofInDelimitedDataForKnownNonRepeatedValue.MESSAGE
Required.Proto2.ProtobufInput.PrematureEofInDelimitedDataForKnownRepeatedValue.MESSAGE

@ -1,4 +1,2 @@
Recommended.Proto2.JsonInput.FieldNameExtension.Validator Recommended.Proto2.JsonInput.FieldNameExtension.Validator
Required.Proto2.JsonInput.StoresDefaultPrimitive.Validator Required.Proto2.JsonInput.StoresDefaultPrimitive.Validator
Required.Proto3.JsonInput.OneofFieldNullSecond.JsonOutput
Required.Proto3.JsonInput.OneofFieldNullSecond.ProtobufOutput

@ -56,5 +56,3 @@ Recommended.Proto3.ProtobufInput.ValidDataRepeated.UINT32.PackedInput.UnpackedOu
Recommended.Proto3.ProtobufInput.ValidDataRepeated.UINT32.UnpackedInput.UnpackedOutput.ProtobufOutput Recommended.Proto3.ProtobufInput.ValidDataRepeated.UINT32.UnpackedInput.UnpackedOutput.ProtobufOutput
Recommended.Proto3.ProtobufInput.ValidDataRepeated.UINT64.PackedInput.UnpackedOutput.ProtobufOutput Recommended.Proto3.ProtobufInput.ValidDataRepeated.UINT64.PackedInput.UnpackedOutput.ProtobufOutput
Recommended.Proto3.ProtobufInput.ValidDataRepeated.UINT64.UnpackedInput.UnpackedOutput.ProtobufOutput Recommended.Proto3.ProtobufInput.ValidDataRepeated.UINT64.UnpackedInput.UnpackedOutput.ProtobufOutput
Required.Proto3.JsonInput.OneofFieldNullSecond.JsonOutput
Required.Proto3.JsonInput.OneofFieldNullSecond.ProtobufOutput

@ -161,12 +161,21 @@ namespace Google.Protobuf
private static void AssertReadFromParseContext(ReadOnlySequence<byte> input, ParseContextAssertAction assertAction, bool assertIsAtEnd) private static void AssertReadFromParseContext(ReadOnlySequence<byte> input, ParseContextAssertAction assertAction, bool assertIsAtEnd)
{ {
// Check as ReadOnlySequence<byte>
ParseContext.Initialize(input, out ParseContext parseCtx); ParseContext.Initialize(input, out ParseContext parseCtx);
assertAction(ref parseCtx); assertAction(ref parseCtx);
if (assertIsAtEnd) if (assertIsAtEnd)
{ {
Assert.IsTrue(SegmentedBufferHelper.IsAtEnd(ref parseCtx.buffer, ref parseCtx.state)); Assert.IsTrue(SegmentedBufferHelper.IsAtEnd(ref parseCtx.buffer, ref parseCtx.state));
} }
// Check as ReadOnlySpan<byte>
ParseContext.Initialize(input.ToArray().AsSpan(), out ParseContext spanParseContext);
assertAction(ref spanParseContext);
if (assertIsAtEnd)
{
Assert.IsTrue(SegmentedBufferHelper.IsAtEnd(ref spanParseContext.buffer, ref spanParseContext.state));
}
} }
[Test] [Test]

@ -41,32 +41,38 @@ namespace Google.Protobuf
{ {
public static void AssertReadingMessage<T>(MessageParser<T> parser, byte[] bytes, Action<T> assert) where T : IMessage<T> public static void AssertReadingMessage<T>(MessageParser<T> parser, byte[] bytes, Action<T> assert) where T : IMessage<T>
{ {
var parsedStream = parser.ParseFrom(bytes); var parsedMsg = parser.ParseFrom(bytes);
assert(parsedMsg);
// Load content as single segment // Load content as single segment
var parsedBuffer = parser.ParseFrom(new ReadOnlySequence<byte>(bytes)); parsedMsg = parser.ParseFrom(new ReadOnlySequence<byte>(bytes));
assert(parsedBuffer); assert(parsedMsg);
// Load content as multiple segments // Load content as multiple segments
parsedBuffer = parser.ParseFrom(ReadOnlySequenceFactory.CreateWithContent(bytes)); parsedMsg = parser.ParseFrom(ReadOnlySequenceFactory.CreateWithContent(bytes));
assert(parsedBuffer); assert(parsedMsg);
assert(parsedStream); // Load content as ReadOnlySpan
parsedMsg = parser.ParseFrom(new ReadOnlySpan<byte>(bytes));
assert(parsedMsg);
} }
public static void AssertReadingMessage(MessageParser parser, byte[] bytes, Action<IMessage> assert) public static void AssertReadingMessage(MessageParser parser, byte[] bytes, Action<IMessage> assert)
{ {
var parsedStream = parser.ParseFrom(bytes); var parsedMsg = parser.ParseFrom(bytes);
assert(parsedMsg);
// Load content as single segment // Load content as single segment
var parsedBuffer = parser.ParseFrom(new ReadOnlySequence<byte>(bytes)); parsedMsg = parser.ParseFrom(new ReadOnlySequence<byte>(bytes));
assert(parsedBuffer); assert(parsedMsg);
// Load content as multiple segments // Load content as multiple segments
parsedBuffer = parser.ParseFrom(ReadOnlySequenceFactory.CreateWithContent(bytes)); parsedMsg = parser.ParseFrom(ReadOnlySequenceFactory.CreateWithContent(bytes));
assert(parsedBuffer); assert(parsedMsg);
assert(parsedStream); // Load content as ReadOnlySpan
parsedMsg = parser.ParseFrom(new ReadOnlySpan<byte>(bytes));
assert(parsedMsg);
} }
public static void AssertReadingMessageThrows<TMessage, TException>(MessageParser<TMessage> parser, byte[] bytes) public static void AssertReadingMessageThrows<TMessage, TException>(MessageParser<TMessage> parser, byte[] bytes)
@ -76,6 +82,8 @@ namespace Google.Protobuf
Assert.Throws<TException>(() => parser.ParseFrom(bytes)); Assert.Throws<TException>(() => parser.ParseFrom(bytes));
Assert.Throws<TException>(() => parser.ParseFrom(new ReadOnlySequence<byte>(bytes))); Assert.Throws<TException>(() => parser.ParseFrom(new ReadOnlySequence<byte>(bytes)));
Assert.Throws<TException>(() => parser.ParseFrom(new ReadOnlySpan<byte>(bytes)));
} }
public static void AssertRoundtrip<T>(MessageParser<T> parser, T message, Action<T> additionalAssert = null) where T : IMessage<T> public static void AssertRoundtrip<T>(MessageParser<T> parser, T message, Action<T> additionalAssert = null) where T : IMessage<T>
@ -87,20 +95,24 @@ namespace Google.Protobuf
message.WriteTo(bufferWriter); message.WriteTo(bufferWriter);
Assert.AreEqual(bytes, bufferWriter.WrittenSpan.ToArray(), "Both serialization approaches need to result in the same data."); Assert.AreEqual(bytes, bufferWriter.WrittenSpan.ToArray(), "Both serialization approaches need to result in the same data.");
var parsedMsg = parser.ParseFrom(bytes);
Assert.AreEqual(message, parsedMsg);
additionalAssert?.Invoke(parsedMsg);
// Load content as single segment // Load content as single segment
var parsedBuffer = parser.ParseFrom(new ReadOnlySequence<byte>(bytes)); parsedMsg = parser.ParseFrom(new ReadOnlySequence<byte>(bytes));
Assert.AreEqual(message, parsedBuffer); Assert.AreEqual(message, parsedMsg);
additionalAssert?.Invoke(parsedBuffer); additionalAssert?.Invoke(parsedMsg);
// Load content as multiple segments // Load content as multiple segments
parsedBuffer = parser.ParseFrom(ReadOnlySequenceFactory.CreateWithContent(bytes)); parsedMsg = parser.ParseFrom(ReadOnlySequenceFactory.CreateWithContent(bytes));
Assert.AreEqual(message, parsedBuffer); Assert.AreEqual(message, parsedMsg);
additionalAssert?.Invoke(parsedBuffer); additionalAssert?.Invoke(parsedMsg);
var parsedStream = parser.ParseFrom(bytes); // Load content as ReadOnlySpan
parsedMsg = parser.ParseFrom(new ReadOnlySpan<byte>(bytes));
Assert.AreEqual(message, parsedStream); Assert.AreEqual(message, parsedMsg);
additionalAssert?.Invoke(parsedStream); additionalAssert?.Invoke(parsedMsg);
} }
public static void AssertWritingMessage(IMessage message) public static void AssertWritingMessage(IMessage message)

@ -435,8 +435,7 @@ namespace Google.Protobuf
// we will need to switch back again to CodedInputStream-based parsing (which involves copying and storing the state) to be able to // we will need to switch back again to CodedInputStream-based parsing (which involves copying and storing the state) to be able to
// invoke the legacy MergeFrom(CodedInputStream) method. // invoke the legacy MergeFrom(CodedInputStream) method.
// For now, this inefficiency is fine, considering this is only a backward-compatibility scenario (and regenerating the code fixes it). // For now, this inefficiency is fine, considering this is only a backward-compatibility scenario (and regenerating the code fixes it).
var span = new ReadOnlySpan<byte>(buffer); ParseContext.Initialize(buffer.AsSpan(), ref state, out ParseContext ctx);
ParseContext.Initialize(ref span, ref state, out ParseContext ctx);
try try
{ {
ParsingPrimitivesMessages.ReadMessage(ref ctx, builder); ParsingPrimitivesMessages.ReadMessage(ref ctx, builder);

@ -79,6 +79,15 @@ namespace Google.Protobuf
public static void MergeFrom(this IMessage message, Stream input) => public static void MergeFrom(this IMessage message, Stream input) =>
MergeFrom(message, input, false, null); MergeFrom(message, input, false, null);
/// <summary>
/// Merges data from the given span into an existing message.
/// </summary>
/// <param name="message">The message to merge the data into.</param>
/// <param name="span">Span containing the data to merge, which must be protobuf-encoded binary data.</param>
[SecuritySafeCritical]
public static void MergeFrom(this IMessage message, ReadOnlySpan<byte> span) =>
MergeFrom(message, span, false, null);
/// <summary> /// <summary>
/// Merges length-delimited data from the given stream into an existing message. /// Merges length-delimited data from the given stream into an existing message.
/// </summary> /// </summary>
@ -294,6 +303,16 @@ namespace Google.Protobuf
ParsingPrimitivesMessages.CheckReadEndOfStreamTag(ref ctx.state); ParsingPrimitivesMessages.CheckReadEndOfStreamTag(ref ctx.state);
} }
[SecuritySafeCritical]
internal static void MergeFrom(this IMessage message, ReadOnlySpan<byte> data, bool discardUnknownFields, ExtensionRegistry registry)
{
ParseContext.Initialize(data, out ParseContext ctx);
ctx.DiscardUnknownFields = discardUnknownFields;
ctx.ExtensionRegistry = registry;
ParsingPrimitivesMessages.ReadRawMessage(ref ctx, message);
ParsingPrimitivesMessages.CheckReadEndOfStreamTag(ref ctx.state);
}
internal static void MergeDelimitedFrom(this IMessage message, Stream input, bool discardUnknownFields, ExtensionRegistry registry) internal static void MergeDelimitedFrom(this IMessage message, Stream input, bool discardUnknownFields, ExtensionRegistry registry)
{ {
ProtoPreconditions.CheckNotNull(message, "message"); ProtoPreconditions.CheckNotNull(message, "message");

@ -128,6 +128,19 @@ namespace Google.Protobuf
return message; return message;
} }
/// <summary>
/// Parses a message from the given span.
/// </summary>
/// <param name="data">The data to parse.</param>
/// <returns>The parsed message.</returns>
[SecuritySafeCritical]
public IMessage ParseFrom(ReadOnlySpan<byte> data)
{
IMessage message = factory();
message.MergeFrom(data, DiscardUnknownFields, Extensions);
return message;
}
/// <summary> /// <summary>
/// Parses a length-delimited message from the given stream. /// Parses a length-delimited message from the given stream.
/// </summary> /// </summary>
@ -315,6 +328,19 @@ namespace Google.Protobuf
return message; return message;
} }
/// <summary>
/// Parses a message from the given span.
/// </summary>
/// <param name="data">The data to parse.</param>
/// <returns>The parsed message.</returns>
[SecuritySafeCritical]
public new T ParseFrom(ReadOnlySpan<byte> data)
{
T message = factory();
message.MergeFrom(data, DiscardUnknownFields, Extensions);
return message;
}
/// <summary> /// <summary>
/// Parses a length-delimited message from the given stream. /// Parses a length-delimited message from the given stream.
/// </summary> /// </summary>

@ -58,8 +58,27 @@ namespace Google.Protobuf
internal ReadOnlySpan<byte> buffer; internal ReadOnlySpan<byte> buffer;
internal ParserInternalState state; internal ParserInternalState state;
/// <summary>
/// Initialize a <see cref="ParseContext"/>, building all <see cref="ParserInternalState"/> from defaults and
/// the given <paramref name="buffer"/>.
/// </summary>
[MethodImpl(MethodImplOptions.AggressiveInlining)]
internal static void Initialize(ReadOnlySpan<byte> buffer, out ParseContext ctx)
{
ParserInternalState state = default;
state.sizeLimit = DefaultSizeLimit;
state.recursionLimit = DefaultRecursionLimit;
state.currentLimit = int.MaxValue;
state.bufferSize = buffer.Length;
Initialize(buffer, ref state, out ctx);
}
/// <summary>
/// Initialize a <see cref="ParseContext"/> using existing <see cref="ParserInternalState"/>, e.g. from <see cref="CodedInputStream"/>.
/// </summary>
[MethodImpl(MethodImplOptions.AggressiveInlining)] [MethodImpl(MethodImplOptions.AggressiveInlining)]
internal static void Initialize(ref ReadOnlySpan<byte> buffer, ref ParserInternalState state, out ParseContext ctx) internal static void Initialize(ReadOnlySpan<byte> buffer, ref ParserInternalState state, out ParseContext ctx)
{ {
ctx.buffer = buffer; ctx.buffer = buffer;
ctx.state = state; ctx.state = state;

@ -873,6 +873,9 @@ public abstract class CodedInputStream {
builder.mergeFrom(this, extensionRegistry); builder.mergeFrom(this, extensionRegistry);
checkLastTagWas(0); checkLastTagWas(0);
--recursionDepth; --recursionDepth;
if (getBytesUntilLimit() != 0) {
throw InvalidProtocolBufferException.truncatedMessage();
}
popLimit(oldLimit); popLimit(oldLimit);
} }
@ -889,6 +892,9 @@ public abstract class CodedInputStream {
T result = parser.parsePartialFrom(this, extensionRegistry); T result = parser.parsePartialFrom(this, extensionRegistry);
checkLastTagWas(0); checkLastTagWas(0);
--recursionDepth; --recursionDepth;
if (getBytesUntilLimit() != 0) {
throw InvalidProtocolBufferException.truncatedMessage();
}
popLimit(oldLimit); popLimit(oldLimit);
return result; return result;
} }
@ -1595,6 +1601,9 @@ public abstract class CodedInputStream {
builder.mergeFrom(this, extensionRegistry); builder.mergeFrom(this, extensionRegistry);
checkLastTagWas(0); checkLastTagWas(0);
--recursionDepth; --recursionDepth;
if (getBytesUntilLimit() != 0) {
throw InvalidProtocolBufferException.truncatedMessage();
}
popLimit(oldLimit); popLimit(oldLimit);
} }
@ -1611,6 +1620,9 @@ public abstract class CodedInputStream {
T result = parser.parsePartialFrom(this, extensionRegistry); T result = parser.parsePartialFrom(this, extensionRegistry);
checkLastTagWas(0); checkLastTagWas(0);
--recursionDepth; --recursionDepth;
if (getBytesUntilLimit() != 0) {
throw InvalidProtocolBufferException.truncatedMessage();
}
popLimit(oldLimit); popLimit(oldLimit);
return result; return result;
} }
@ -2392,6 +2404,9 @@ public abstract class CodedInputStream {
builder.mergeFrom(this, extensionRegistry); builder.mergeFrom(this, extensionRegistry);
checkLastTagWas(0); checkLastTagWas(0);
--recursionDepth; --recursionDepth;
if (getBytesUntilLimit() != 0) {
throw InvalidProtocolBufferException.truncatedMessage();
}
popLimit(oldLimit); popLimit(oldLimit);
} }
@ -2408,6 +2423,9 @@ public abstract class CodedInputStream {
T result = parser.parsePartialFrom(this, extensionRegistry); T result = parser.parsePartialFrom(this, extensionRegistry);
checkLastTagWas(0); checkLastTagWas(0);
--recursionDepth; --recursionDepth;
if (getBytesUntilLimit() != 0) {
throw InvalidProtocolBufferException.truncatedMessage();
}
popLimit(oldLimit); popLimit(oldLimit);
return result; return result;
} }
@ -3489,6 +3507,9 @@ public abstract class CodedInputStream {
builder.mergeFrom(this, extensionRegistry); builder.mergeFrom(this, extensionRegistry);
checkLastTagWas(0); checkLastTagWas(0);
--recursionDepth; --recursionDepth;
if (getBytesUntilLimit() != 0) {
throw InvalidProtocolBufferException.truncatedMessage();
}
popLimit(oldLimit); popLimit(oldLimit);
} }
@ -3505,6 +3526,9 @@ public abstract class CodedInputStream {
T result = parser.parsePartialFrom(this, extensionRegistry); T result = parser.parsePartialFrom(this, extensionRegistry);
checkLastTagWas(0); checkLastTagWas(0);
--recursionDepth; --recursionDepth;
if (getBytesUntilLimit() != 0) {
throw InvalidProtocolBufferException.truncatedMessage();
}
popLimit(oldLimit); popLimit(oldLimit);
return result; return result;
} }

@ -18,6 +18,7 @@
<properties> <properties>
<kotlin.version>1.5.0</kotlin.version> <kotlin.version>1.5.0</kotlin.version>
<dokka.version>1.4.32</dokka.version>
</properties> </properties>
<dependencies> <dependencies>
@ -234,7 +235,46 @@
</instructions> </instructions>
</configuration> </configuration>
</plugin> </plugin>
<plugin>
<groupId>org.jetbrains.dokka</groupId>
<artifactId>dokka-maven-plugin</artifactId>
<version>${dokka.version}</version>
<executions>
<execution>
<phase>pre-site</phase>
<goals>
<goal>dokka</goal>
</goals>
</execution>
</executions>
<configuration>
<outputDir>gcode/kotlin</outputDir>
<sourceDirectories><dir>${project.basedir}/src/main/kotlin/com/google/protobuf</dir></sourceDirectories>
<externalDocumentationLinks>
<link>
<url>https://developers.google.com/protocol-buffers/docs/reference/java/</url>
</link>
</externalDocumentationLinks>
<dokkaPlugins>
<plugin>
<groupId>org.jetbrains.dokka</groupId>
<artifactId>gfm-plugin</artifactId>
<version>${dokka.version}</version>
</plugin>
</dokkaPlugins>
</configuration>
</plugin>
</plugins> </plugins>
</build> </build>
<pluginRepositories>
<pluginRepository>
<id>jcenter</id>
<name>JCenter</name>
<url>https://jcenter.bintray.com/</url>
</pluginRepository>
</pluginRepositories>
</project> </project>

@ -39,9 +39,8 @@ If you want, you can compile `protoc` from source instead. To do this
follow the instructions in [the top-level follow the instructions in [the top-level
README](https://github.com/protocolbuffers/protobuf/blob/master/src/README.md). README](https://github.com/protocolbuffers/protobuf/blob/master/src/README.md).
Once you have `protoc` compiled, you can run the tests by typing: Once you have `protoc` compiled, you can run the tests provided along with our project to examine whether it can run successfully. In order to do this, you should download the Protocol Buffer source code from the release page with the link above. Then extract the source code and navigate to the folder named `js` containing a `package.json` file and a series of test files. In this folder, you can run the commands below to run the tests automatically.
$ cd js
$ npm install $ npm install
$ npm test $ npm test

@ -0,0 +1,18 @@
#!/bin/bash
set -ex
# Install composer
curl -sS https://getcomposer.org/installer | php
mkdir -p "$HOME/bin"
mv composer.phar "$HOME/bin/composer"
PATH="$HOME/bin:$PATH"
# go to the repo root
cd $(dirname $0)/../../..
cd php
composer install
composer test
composer test_c

@ -0,0 +1,31 @@
#!/bin/bash
set -ex
# go to the repo root
cd $(dirname $0)/../../..
# there is no php testing docker image readily available, so we build
# our own. It's a aarch64 image, but that's fine since qemu will
# automatically be used to run the commands in the dockerfile.
docker build -t testimage_protobuf_php_arm64v8 kokoro/linux/aarch64/testimage_protobuf_php_arm64v8
if [[ -t 0 ]]; then
DOCKER_TTY_ARGS="-it"
else
# The input device on kokoro is not a TTY, so -it does not work.
DOCKER_TTY_ARGS=
fi
# crosscompile protoc as we will later need it for the php build.
# we build it under the dockcross/manylinux2014-aarch64 image so that the resulting protoc binary is compatible
# with a wide range of linux distros (including any docker images we will use later to build and test php)
kokoro/linux/aarch64/dockcross_helpers/run_dockcross_manylinux2014_aarch64.sh kokoro/linux/aarch64/protoc_crosscompile_aarch64.sh
# use an actual aarch64 docker image (with a real aarch64 php) to run build & test protobuf php under an emulator
# * mount the protobuf root as /work to be able to access the crosscompiled files
# * to avoid running the process inside docker as root (which can pollute the workspace with files owned by root), we force
# running under current user's UID and GID. To be able to do that, we need to provide a home directory for the user
# otherwise the UID would be homeless under the docker container and pip install wouldn't work. For simplicity,
# we just run map the user's home to a throwaway temporary directory
docker run $DOCKER_TTY_ARGS --rm --user "$(id -u):$(id -g)" -e "HOME=/home/fake-user" -v "$(mktemp -d):/home/fake-user" -v "$(pwd)":/work -w /work testimage_protobuf_php_arm64v8 kokoro/linux/aarch64/php_build_and_run_tests_with_qemu_aarch64.sh

@ -0,0 +1,3 @@
FROM arm64v8/debian:buster
RUN apt-get update && apt-get install -y php7.3-cli php7.3-dev php7.3-bcmath composer phpunit curl git valgrind && apt-get clean

@ -0,0 +1,16 @@
#!/bin/bash
#
# This is the top-level script we give to Kokoro as the entry point for
# running the "continuous" and "presubmit" jobs.
set -ex
# Change to repo root
cd $(dirname $0)/../../..
# Initialize any submodules.
git submodule update --init --recursive
kokoro/linux/aarch64/qemu_helpers/prepare_qemu.sh
kokoro/linux/aarch64/test_php_aarch64.sh

@ -0,0 +1,11 @@
# Config file for running tests in Kokoro
# Location of the build script in repository
build_file: "protobuf/kokoro/linux/php_aarch64/build.sh"
timeout_mins: 120
action {
define_artifacts {
regex: "**/sponge_log.xml"
}
}

@ -0,0 +1,11 @@
# Config file for running tests in Kokoro
# Location of the build script in repository
build_file: "protobuf/kokoro/linux/php_aarch64/build.sh"
timeout_mins: 120
action {
define_artifacts {
regex: "**/sponge_log.xml"
}
}

@ -194,4 +194,4 @@ Documentation
The complete documentation for Protocol Buffers is available via the The complete documentation for Protocol Buffers is available via the
web at: web at:
https://developers.google.com/protocol-buffers/ https://developers.google.com/protocol-buffers/

@ -305,7 +305,7 @@
GPBDescriptor *descriptor = [TestOneof2 descriptor]; GPBDescriptor *descriptor = [TestOneof2 descriptor];
// All fields should be listed. // All fields should be listed.
XCTAssertEqual(descriptor.fields.count, 17U); XCTAssertEqual(descriptor.fields.count, 21U);
// There are two oneofs in there. // There are two oneofs in there.
XCTAssertEqual(descriptor.oneofs.count, 2U); XCTAssertEqual(descriptor.oneofs.count, 2U);
@ -330,7 +330,7 @@
GPBOneofDescriptor *oneofBar = [descriptor oneofWithName:@"bar"]; GPBOneofDescriptor *oneofBar = [descriptor oneofWithName:@"bar"];
XCTAssertNotNil(oneofBar); XCTAssertNotNil(oneofBar);
XCTAssertEqual(oneofBar.fields.count, 6U); XCTAssertEqual(oneofBar.fields.count, 10U);
// Pointer comparisons. // Pointer comparisons.
XCTAssertEqual([oneofBar fieldWithNumber:TestOneof2_FieldNumber_BarString], XCTAssertEqual([oneofBar fieldWithNumber:TestOneof2_FieldNumber_BarString],

@ -149,6 +149,9 @@ static bool Message_set(Message *intern, const upb_fielddef *f, zval *val) {
} else if (upb_fielddef_isseq(f)) { } else if (upb_fielddef_isseq(f)) {
msgval.array_val = RepeatedField_GetUpbArray(val, TypeInfo_Get(f), arena); msgval.array_val = RepeatedField_GetUpbArray(val, TypeInfo_Get(f), arena);
if (!msgval.array_val) return false; if (!msgval.array_val) return false;
} else if (upb_fielddef_issubmsg(f) && Z_TYPE_P(val) == IS_NULL) {
upb_msg_clearfield(intern->msg, f);
return true;
} else { } else {
if (!Convert_PhpToUpb(val, &msgval, TypeInfo_Get(f), arena)) return false; if (!Convert_PhpToUpb(val, &msgval, TypeInfo_Get(f), arena)) return false;
} }
@ -198,8 +201,6 @@ static bool MessageEq(const upb_msg *m1, const upb_msg *m2, const upb_msgdef *m)
!upb_msg_field_done(&i); !upb_msg_field_done(&i);
upb_msg_field_next(&i)) { upb_msg_field_next(&i)) {
const upb_fielddef *f = upb_msg_iter_field(&i); const upb_fielddef *f = upb_msg_iter_field(&i);
upb_msgval val1 = upb_msg_get(m1, f);
upb_msgval val2 = upb_msg_get(m2, f);
if (upb_fielddef_haspresence(f)) { if (upb_fielddef_haspresence(f)) {
if (upb_msg_has(m1, f) != upb_msg_has(m2, f)) { if (upb_msg_has(m1, f) != upb_msg_has(m2, f)) {
@ -208,6 +209,9 @@ static bool MessageEq(const upb_msg *m1, const upb_msg *m2, const upb_msgdef *m)
if (!upb_msg_has(m1, f)) continue; if (!upb_msg_has(m1, f)) continue;
} }
upb_msgval val1 = upb_msg_get(m1, f);
upb_msgval val2 = upb_msg_get(m2, f);
if (upb_fielddef_ismap(f)) { if (upb_fielddef_ismap(f)) {
if (!MapEq(val1.map_val, val2.map_val, MapType_Get(f))) return false; if (!MapEq(val1.map_val, val2.map_val, MapType_Get(f))) return false;
} else if (upb_fielddef_isseq(f)) { } else if (upb_fielddef_isseq(f)) {
@ -454,11 +458,6 @@ bool Message_GetUpbMessage(zval *val, const Descriptor *desc, upb_arena *arena,
ZVAL_DEREF(val); ZVAL_DEREF(val);
} }
if (Z_TYPE_P(val) == IS_NULL) {
*msg = NULL;
return true;
}
if (Z_TYPE_P(val) == IS_OBJECT && if (Z_TYPE_P(val) == IS_OBJECT &&
instanceof_function(Z_OBJCE_P(val), desc->class_entry)) { instanceof_function(Z_OBJCE_P(val), desc->class_entry)) {
Message *intern = (Message*)Z_OBJ_P(val); Message *intern = (Message*)Z_OBJ_P(val);
@ -466,7 +465,8 @@ bool Message_GetUpbMessage(zval *val, const Descriptor *desc, upb_arena *arena,
*msg = intern->msg; *msg = intern->msg;
return true; return true;
} else { } else {
zend_throw_exception_ex(NULL, 0, "Given value is not an instance of %s.", zend_throw_exception_ex(zend_ce_type_error, 0,
"Given value is not an instance of %s.",
ZSTR_VAL(desc->class_entry->name)); ZSTR_VAL(desc->class_entry->name));
return false; return false;
} }
@ -1051,7 +1051,10 @@ PHP_METHOD(Message, writeOneof) {
f = upb_msgdef_itof(intern->desc->msgdef, field_num); f = upb_msgdef_itof(intern->desc->msgdef, field_num);
if (!Convert_PhpToUpb(val, &msgval, TypeInfo_Get(f), arena)) { if (upb_fielddef_issubmsg(f) && Z_TYPE_P(val) == IS_NULL) {
upb_msg_clearfield(intern->msg, f);
return;
} else if (!Convert_PhpToUpb(val, &msgval, TypeInfo_Get(f), arena)) {
return; return;
} }

File diff suppressed because it is too large Load Diff

@ -1,26 +1,53 @@
/* Amalgamated source file */ /* Amalgamated source file */
#include <stdint.h>/* /*
* This is where we define macros used across upb. * Copyright (c) 2009-2021, Google LLC
* * All rights reserved.
* All of these macros are undef'd in port_undef.inc to avoid leaking them to *
* users. * Redistribution and use in source and binary forms, with or without
* * modification, are permitted provided that the following conditions are met:
* The correct usage is: * * Redistributions of source code must retain the above copyright
* * notice, this list of conditions and the following disclaimer.
* #include "upb/foobar.h" * * Redistributions in binary form must reproduce the above copyright
* #include "upb/baz.h" * notice, this list of conditions and the following disclaimer in the
* * documentation and/or other materials provided with the distribution.
* // MUST be last included header. * * Neither the name of Google LLC nor the
* #include "upb/port_def.inc" * names of its contributors may be used to endorse or promote products
* * derived from this software without specific prior written permission.
* // Code for this file. *
* // <...> * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND
* * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
* // Can be omitted for .c files, required for .h. * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
* #include "upb/port_undef.inc" * DISCLAIMED. IN NO EVENT SHALL Google LLC BE LIABLE FOR ANY
* * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
* This file is private and must not be included by users! * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
*/ * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
* ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
* SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
/*
* This is where we define macros used across upb.
*
* All of these macros are undef'd in port_undef.inc to avoid leaking them to
* users.
*
* The correct usage is:
*
* #include "upb/foobar.h"
* #include "upb/baz.h"
*
* // MUST be last included header.
* #include "upb/port_def.inc"
*
* // Code for this file.
* // <...>
*
* // Can be omitted for .c files, required for .h.
* #include "upb/port_undef.inc"
*
* This file is private and must not be included by users!
*/
#if !((defined(__STDC_VERSION__) && __STDC_VERSION__ >= 199901L) || \ #if !((defined(__STDC_VERSION__) && __STDC_VERSION__ >= 199901L) || \
(defined(__cplusplus) && __cplusplus >= 201103L) || \ (defined(__cplusplus) && __cplusplus >= 201103L) || \
@ -136,9 +163,40 @@
#define UPB_LONGJMP(buf, val) longjmp(buf, val) #define UPB_LONGJMP(buf, val) longjmp(buf, val)
#endif #endif
/* UPB_PTRADD(ptr, ofs): add pointer while avoiding "NULL + 0" UB */
#define UPB_PTRADD(ptr, ofs) ((ofs) ? (ptr) + (ofs) : (ptr))
/* Configure whether fasttable is switched on or not. *************************/ /* Configure whether fasttable is switched on or not. *************************/
#if defined(__x86_64__) && defined(__GNUC__) #if defined(__has_attribute)
#define UPB_HAS_ATTRIBUTE(x) __has_attribute(x)
#else
#define UPB_HAS_ATTRIBUTE(x) 0
#endif
#if UPB_HAS_ATTRIBUTE(musttail)
#define UPB_MUSTTAIL __attribute__((musttail))
#else
#define UPB_MUSTTAIL
#endif
#undef UPB_HAS_ATTRIBUTE
/* This check is not fully robust: it does not require that we have "musttail"
* support available. We need tail calls to avoid consuming arbitrary amounts
* of stack space.
*
* GCC/Clang can mostly be trusted to generate tail calls as long as
* optimization is enabled, but, debug builds will not generate tail calls
* unless "musttail" is available.
*
* We should probably either:
* 1. require that the compiler supports musttail.
* 2. add some fallback code for when musttail isn't available (ie. return
* instead of tail calling). This is safe and portable, but this comes at
* a CPU cost.
*/
#if (defined(__x86_64__) || defined(__aarch64__)) && defined(__GNUC__)
#define UPB_FASTTABLE_SUPPORTED 1 #define UPB_FASTTABLE_SUPPORTED 1
#else #else
#define UPB_FASTTABLE_SUPPORTED 0 #define UPB_FASTTABLE_SUPPORTED 0
@ -149,7 +207,7 @@
* for example for testing or benchmarking. */ * for example for testing or benchmarking. */
#if defined(UPB_ENABLE_FASTTABLE) #if defined(UPB_ENABLE_FASTTABLE)
#if !UPB_FASTTABLE_SUPPORTED #if !UPB_FASTTABLE_SUPPORTED
#error fasttable is x86-64 + Clang/GCC only #error fasttable is x86-64/ARM64 only and requires GCC or Clang.
#endif #endif
#define UPB_FASTTABLE 1 #define UPB_FASTTABLE 1
/* Define UPB_TRY_ENABLE_FASTTABLE to use fasttable if possible. /* Define UPB_TRY_ENABLE_FASTTABLE to use fasttable if possible.
@ -193,55 +251,36 @@ void __asan_unpoison_memory_region(void const volatile *addr, size_t size);
((void)(addr), (void)(size)) ((void)(addr), (void)(size))
#define UPB_UNPOISON_MEMORY_REGION(addr, size) \ #define UPB_UNPOISON_MEMORY_REGION(addr, size) \
((void)(addr), (void)(size)) ((void)(addr), (void)(size))
#endif #endif
/** upb/decode.h ************************************************************/
/* /*
** upb_decode: parsing into a upb_msg using a upb_msglayout. * upb_decode: parsing into a upb_msg using a upb_msglayout.
*/ */
#ifndef UPB_DECODE_H_ #ifndef UPB_DECODE_H_
#define UPB_DECODE_H_ #define UPB_DECODE_H_
/** upb/msg.h ************************************************************/
/* /*
** Our memory representation for parsing tables and messages themselves. * Public APIs for message operations that do not require descriptors.
** Functions in this file are used by generated code and possibly reflection. * These functions can be used even in build that does not want to depend on
** * reflection or descriptors.
** The definitions in this file are internal to upb. *
**/ * Descriptor-based reflection functionality lives in reflection.h.
*/
#ifndef UPB_MSG_H_ #ifndef UPB_MSG_H_
#define UPB_MSG_H_ #define UPB_MSG_H_
#include <stdint.h> #include <stddef.h>
#include <stdlib.h>
#include <string.h>
/*
** upb_table
**
** This header is INTERNAL-ONLY! Its interfaces are not public or stable!
** This file defines very fast int->upb_value (inttable) and string->upb_value
** (strtable) hash tables.
**
** The table uses chained scatter with Brent's variation (inspired by the Lua
** implementation of hash tables). The hash function for strings is Austin
** Appleby's "MurmurHash."
**
** The inttable uses uintptr_t as its key, which guarantees it can be used to
** store pointers or integers of at least 32 bits (upb isn't really useful on
** systems where sizeof(void*) < 4).
**
** The table must be homogeneous (all values of the same type). In debug
** mode, we check this on insert and lookup.
*/
#ifndef UPB_TABLE_H_
#define UPB_TABLE_H_
#include <stdint.h> /** upb/upb.h ************************************************************/
#include <string.h>
/* /*
** This file contains shared definitions that are widely used across upb. * This file contains shared definitions that are widely used across upb.
*/ */
#ifndef UPB_H_ #ifndef UPB_H_
#define UPB_H_ #define UPB_H_
@ -399,7 +438,7 @@ typedef struct {
upb_arena *upb_arena_init(void *mem, size_t n, upb_alloc *alloc); upb_arena *upb_arena_init(void *mem, size_t n, upb_alloc *alloc);
void upb_arena_free(upb_arena *a); void upb_arena_free(upb_arena *a);
bool upb_arena_addcleanup(upb_arena *a, void *ud, upb_cleanup_func *func); bool upb_arena_addcleanup(upb_arena *a, void *ud, upb_cleanup_func *func);
void upb_arena_fuse(upb_arena *a, upb_arena *b); bool upb_arena_fuse(upb_arena *a, upb_arena *b);
void *_upb_arena_slowmalloc(upb_arena *a, size_t size); void *_upb_arena_slowmalloc(upb_arena *a, size_t size);
UPB_INLINE upb_alloc *upb_arena_alloc(upb_arena *a) { return (upb_alloc*)a; } UPB_INLINE upb_alloc *upb_arena_alloc(upb_arena *a) { return (upb_alloc*)a; }
@ -578,55 +617,134 @@ UPB_INLINE int _upb_lg2ceilsize(int x) {
#endif /* UPB_H_ */ #endif /* UPB_H_ */
#ifdef __cplusplus
extern "C" {
#endif
typedef void upb_msg;
/* For users these are opaque. They can be obtained from upb_msgdef_layout()
* but users cannot access any of the members. */
struct upb_msglayout;
typedef struct upb_msglayout upb_msglayout;
/* Adds unknown data (serialized protobuf data) to the given message. The data
* is copied into the message instance. */
void upb_msg_addunknown(upb_msg *msg, const char *data, size_t len,
upb_arena *arena);
/* Returns a reference to the message's unknown data. */
const char *upb_msg_getunknown(const upb_msg *msg, size_t *len);
#ifdef __cplusplus
} /* extern "C" */
#endif
#endif /* UPB_MSG_INT_H_ */
/* Must be last. */
#ifdef __cplusplus #ifdef __cplusplus
extern "C" { extern "C" {
#endif #endif
enum {
/* If set, strings will alias the input buffer instead of copying into the
* arena. */
UPB_DECODE_ALIAS = 1,
};
/* upb_value ******************************************************************/ #define UPB_DECODE_MAXDEPTH(depth) ((depth) << 16)
/* A tagged union (stored untagged inside the table) so that we can check that bool _upb_decode(const char *buf, size_t size, upb_msg *msg,
* clients calling table accessors are correctly typed without having to have const upb_msglayout *l, upb_arena *arena, int options);
* an explosion of accessors. */
typedef enum { UPB_INLINE
UPB_CTYPE_INT32 = 1, bool upb_decode(const char *buf, size_t size, upb_msg *msg,
UPB_CTYPE_INT64 = 2, const upb_msglayout *l, upb_arena *arena) {
UPB_CTYPE_UINT32 = 3, return _upb_decode(buf, size, msg, l, arena, 0);
UPB_CTYPE_UINT64 = 4, }
UPB_CTYPE_BOOL = 5,
UPB_CTYPE_CSTR = 6, #ifdef __cplusplus
UPB_CTYPE_PTR = 7, } /* extern "C" */
UPB_CTYPE_CONSTPTR = 8, #endif
UPB_CTYPE_FPTR = 9,
UPB_CTYPE_FLOAT = 10,
UPB_CTYPE_DOUBLE = 11 #endif /* UPB_DECODE_H_ */
} upb_ctype_t;
/** upb/decode_internal.h ************************************************************/
/*
* Internal implementation details of the decoder that are shared between
* decode.c and decode_fast.c.
*/
#ifndef UPB_DECODE_INT_H_
#define UPB_DECODE_INT_H_
#include <setjmp.h>
/** upb/msg_internal.h ************************************************************//*
** Our memory representation for parsing tables and messages themselves.
** Functions in this file are used by generated code and possibly reflection.
**
** The definitions in this file are internal to upb.
**/
#ifndef UPB_MSG_INT_H_
#define UPB_MSG_INT_H_
#include <stdint.h>
#include <stdlib.h>
#include <string.h>
/** upb/table_internal.h ************************************************************/
/*
* upb_table
*
* This header is INTERNAL-ONLY! Its interfaces are not public or stable!
* This file defines very fast int->upb_value (inttable) and string->upb_value
* (strtable) hash tables.
*
* The table uses chained scatter with Brent's variation (inspired by the Lua
* implementation of hash tables). The hash function for strings is Austin
* Appleby's "MurmurHash."
*
* The inttable uses uintptr_t as its key, which guarantees it can be used to
* store pointers or integers of at least 32 bits (upb isn't really useful on
* systems where sizeof(void*) < 4).
*
* The table must be homogeneous (all values of the same type). In debug
* mode, we check this on insert and lookup.
*/
#ifndef UPB_TABLE_H_
#define UPB_TABLE_H_
#include <stdint.h>
#include <string.h>
#ifdef __cplusplus
extern "C" {
#endif
/* upb_value ******************************************************************/
typedef struct { typedef struct {
uint64_t val; uint64_t val;
} upb_value; } upb_value;
/* Like strdup(), which isn't always available since it's not ANSI C. */
char *upb_strdup(const char *s, upb_alloc *a);
/* Variant that works with a length-delimited rather than NULL-delimited string, /* Variant that works with a length-delimited rather than NULL-delimited string,
* as supported by strtable. */ * as supported by strtable. */
char *upb_strdup2(const char *s, size_t len, upb_alloc *a); char *upb_strdup2(const char *s, size_t len, upb_arena *a);
UPB_INLINE char *upb_gstrdup(const char *s) {
return upb_strdup(s, &upb_alloc_global);
}
UPB_INLINE void _upb_value_setval(upb_value *v, uint64_t val) { UPB_INLINE void _upb_value_setval(upb_value *v, uint64_t val) {
v->val = val; v->val = val;
} }
UPB_INLINE upb_value _upb_value_val(uint64_t val) {
upb_value ret;
_upb_value_setval(&ret, val);
return ret;
}
/* For each value ctype, define the following set of functions: /* For each value ctype, define the following set of functions:
* *
* // Get/set an int32 from a upb_value. * // Get/set an int32 from a upb_value.
@ -734,14 +852,7 @@ typedef struct {
uint32_t mask; /* Mask to turn hash value -> bucket. */ uint32_t mask; /* Mask to turn hash value -> bucket. */
uint32_t max_count; /* Max count before we hit our load limit. */ uint32_t max_count; /* Max count before we hit our load limit. */
uint8_t size_lg2; /* Size of the hashtable part is 2^size_lg2 entries. */ uint8_t size_lg2; /* Size of the hashtable part is 2^size_lg2 entries. */
upb_tabent *entries;
/* Hash table entries.
* Making this const isn't entirely accurate; what we really want is for it to
* have the same const-ness as the table it's inside. But there's no way to
* declare that in C. So we have to make it const so that we can statically
* initialize const hash tables. Then we cast away const when we have to.
*/
const upb_tabent *entries;
} upb_table; } upb_table;
typedef struct { typedef struct {
@ -755,8 +866,6 @@ typedef struct {
size_t array_count; /* Array part number of elements. */ size_t array_count; /* Array part number of elements. */
} upb_inttable; } upb_inttable;
#define UPB_ARRAY_EMPTYENT -1
UPB_INLINE size_t upb_table_size(const upb_table *t) { UPB_INLINE size_t upb_table_size(const upb_table *t) {
if (t->size_lg2 == 0) if (t->size_lg2 == 0)
return 0; return 0;
@ -769,48 +878,10 @@ UPB_INLINE bool upb_tabent_isempty(const upb_tabent *e) {
return e->key == 0; return e->key == 0;
} }
/* Used by some of the unit tests for generic hashing functionality. */
uint32_t upb_murmur_hash2(const void * key, size_t len, uint32_t seed);
UPB_INLINE uintptr_t upb_intkey(uintptr_t key) {
return key;
}
UPB_INLINE uint32_t upb_inthash(uintptr_t key) {
return (uint32_t)key;
}
static const upb_tabent *upb_getentry(const upb_table *t, uint32_t hash) {
return t->entries + (hash & t->mask);
}
UPB_INLINE bool upb_arrhas(upb_tabval key) {
return key.val != (uint64_t)-1;
}
/* Initialize and uninitialize a table, respectively. If memory allocation /* Initialize and uninitialize a table, respectively. If memory allocation
* failed, false is returned that the table is uninitialized. */ * failed, false is returned that the table is uninitialized. */
bool upb_inttable_init2(upb_inttable *table, upb_ctype_t ctype, upb_alloc *a); bool upb_inttable_init(upb_inttable *table, upb_arena *a);
bool upb_strtable_init2(upb_strtable *table, upb_ctype_t ctype, bool upb_strtable_init(upb_strtable *table, size_t expected_size, upb_arena *a);
size_t expected_size, upb_alloc *a);
void upb_inttable_uninit2(upb_inttable *table, upb_alloc *a);
void upb_strtable_uninit2(upb_strtable *table, upb_alloc *a);
UPB_INLINE bool upb_inttable_init(upb_inttable *table, upb_ctype_t ctype) {
return upb_inttable_init2(table, ctype, &upb_alloc_global);
}
UPB_INLINE bool upb_strtable_init(upb_strtable *table, upb_ctype_t ctype) {
return upb_strtable_init2(table, ctype, 4, &upb_alloc_global);
}
UPB_INLINE void upb_inttable_uninit(upb_inttable *table) {
upb_inttable_uninit2(table, &upb_alloc_global);
}
UPB_INLINE void upb_strtable_uninit(upb_strtable *table) {
upb_strtable_uninit2(table, &upb_alloc_global);
}
/* Returns the number of values in the table. */ /* Returns the number of values in the table. */
size_t upb_inttable_count(const upb_inttable *t); size_t upb_inttable_count(const upb_inttable *t);
@ -818,12 +889,6 @@ UPB_INLINE size_t upb_strtable_count(const upb_strtable *t) {
return t->t.count; return t->t.count;
} }
void upb_inttable_packedsize(const upb_inttable *t, size_t *size);
void upb_strtable_packedsize(const upb_strtable *t, size_t *size);
upb_inttable *upb_inttable_pack(const upb_inttable *t, void *p, size_t *ofs,
size_t size);
upb_strtable *upb_strtable_pack(const upb_strtable *t, void *p, size_t *ofs,
size_t size);
void upb_strtable_clear(upb_strtable *t); void upb_strtable_clear(upb_strtable *t);
/* Inserts the given key into the hashtable with the given value. The key must /* Inserts the given key into the hashtable with the given value. The key must
@ -833,26 +898,10 @@ void upb_strtable_clear(upb_strtable *t);
* *
* If a table resize was required but memory allocation failed, false is * If a table resize was required but memory allocation failed, false is
* returned and the table is unchanged. */ * returned and the table is unchanged. */
bool upb_inttable_insert2(upb_inttable *t, uintptr_t key, upb_value val, bool upb_inttable_insert(upb_inttable *t, uintptr_t key, upb_value val,
upb_alloc *a); upb_arena *a);
bool upb_strtable_insert3(upb_strtable *t, const char *key, size_t len, bool upb_strtable_insert(upb_strtable *t, const char *key, size_t len,
upb_value val, upb_alloc *a); upb_value val, upb_arena *a);
UPB_INLINE bool upb_inttable_insert(upb_inttable *t, uintptr_t key,
upb_value val) {
return upb_inttable_insert2(t, key, val, &upb_alloc_global);
}
UPB_INLINE bool upb_strtable_insert2(upb_strtable *t, const char *key,
size_t len, upb_value val) {
return upb_strtable_insert3(t, key, len, val, &upb_alloc_global);
}
/* For NULL-terminated strings. */
UPB_INLINE bool upb_strtable_insert(upb_strtable *t, const char *key,
upb_value val) {
return upb_strtable_insert2(t, key, strlen(key), val);
}
/* Looks up key in this table, returning "true" if the key was found. /* Looks up key in this table, returning "true" if the key was found.
* If v is non-NULL, copies the value for this key into *v. */ * If v is non-NULL, copies the value for this key into *v. */
@ -869,74 +918,21 @@ UPB_INLINE bool upb_strtable_lookup(const upb_strtable *t, const char *key,
/* Removes an item from the table. Returns true if the remove was successful, /* Removes an item from the table. Returns true if the remove was successful,
* and stores the removed item in *val if non-NULL. */ * and stores the removed item in *val if non-NULL. */
bool upb_inttable_remove(upb_inttable *t, uintptr_t key, upb_value *val); bool upb_inttable_remove(upb_inttable *t, uintptr_t key, upb_value *val);
bool upb_strtable_remove3(upb_strtable *t, const char *key, size_t len, bool upb_strtable_remove(upb_strtable *t, const char *key, size_t len,
upb_value *val, upb_alloc *alloc); upb_value *val);
UPB_INLINE bool upb_strtable_remove2(upb_strtable *t, const char *key,
size_t len, upb_value *val) {
return upb_strtable_remove3(t, key, len, val, &upb_alloc_global);
}
/* For NULL-terminated strings. */
UPB_INLINE bool upb_strtable_remove(upb_strtable *t, const char *key,
upb_value *v) {
return upb_strtable_remove2(t, key, strlen(key), v);
}
/* Updates an existing entry in an inttable. If the entry does not exist, /* Updates an existing entry in an inttable. If the entry does not exist,
* returns false and does nothing. Unlike insert/remove, this does not * returns false and does nothing. Unlike insert/remove, this does not
* invalidate iterators. */ * invalidate iterators. */
bool upb_inttable_replace(upb_inttable *t, uintptr_t key, upb_value val); bool upb_inttable_replace(upb_inttable *t, uintptr_t key, upb_value val);
/* Convenience routines for inttables with pointer keys. */
bool upb_inttable_insertptr2(upb_inttable *t, const void *key, upb_value val,
upb_alloc *a);
bool upb_inttable_removeptr(upb_inttable *t, const void *key, upb_value *val);
bool upb_inttable_lookupptr(
const upb_inttable *t, const void *key, upb_value *val);
UPB_INLINE bool upb_inttable_insertptr(upb_inttable *t, const void *key,
upb_value val) {
return upb_inttable_insertptr2(t, key, val, &upb_alloc_global);
}
/* Optimizes the table for the current set of entries, for both memory use and /* Optimizes the table for the current set of entries, for both memory use and
* lookup time. Client should call this after all entries have been inserted; * lookup time. Client should call this after all entries have been inserted;
* inserting more entries is legal, but will likely require a table resize. */ * inserting more entries is legal, but will likely require a table resize. */
void upb_inttable_compact2(upb_inttable *t, upb_alloc *a); void upb_inttable_compact(upb_inttable *t, upb_arena *a);
UPB_INLINE void upb_inttable_compact(upb_inttable *t) {
upb_inttable_compact2(t, &upb_alloc_global);
}
/* A special-case inlinable version of the lookup routine for 32-bit
* integers. */
UPB_INLINE bool upb_inttable_lookup32(const upb_inttable *t, uint32_t key,
upb_value *v) {
*v = upb_value_int32(0); /* Silence compiler warnings. */
if (key < t->array_size) {
upb_tabval arrval = t->array[key];
if (upb_arrhas(arrval)) {
_upb_value_setval(v, arrval.val);
return true;
} else {
return false;
}
} else {
const upb_tabent *e;
if (t->t.entries == NULL) return false;
for (e = upb_getentry(&t->t, upb_inthash(key)); true; e = e->next) {
if ((uint32_t)e->key == key) {
_upb_value_setval(v, e->val.val);
return true;
}
if (e->next == NULL) return false;
}
}
}
/* Exposed for testing only. */ /* Exposed for testing only. */
bool upb_strtable_resize(upb_strtable *t, size_t size_lg2, upb_alloc *a); bool upb_strtable_resize(upb_strtable *t, size_t size_lg2, upb_arena *a);
/* Iterators ******************************************************************/ /* Iterators ******************************************************************/
@ -1032,10 +1028,6 @@ bool upb_inttable_iter_isequal(const upb_inttable_iter *i1,
extern "C" { extern "C" {
#endif #endif
#define PTR_AT(msg, ofs, type) (type*)((const char*)msg + ofs)
typedef void upb_msg;
/** upb_msglayout *************************************************************/ /** upb_msglayout *************************************************************/
/* upb_msglayout represents the memory layout of a given upb_msgdef. The /* upb_msglayout represents the memory layout of a given upb_msgdef. The
@ -1070,7 +1062,7 @@ typedef struct {
_upb_field_parser *field_parser; _upb_field_parser *field_parser;
} _upb_fasttable_entry; } _upb_fasttable_entry;
typedef struct upb_msglayout { struct upb_msglayout {
const struct upb_msglayout *const* submsgs; const struct upb_msglayout *const* submsgs;
const upb_msglayout_field *fields; const upb_msglayout_field *fields;
/* Must be aligned to sizeof(void*). Doesn't include internal members like /* Must be aligned to sizeof(void*). Doesn't include internal members like
@ -1082,7 +1074,7 @@ typedef struct upb_msglayout {
/* To constant-initialize the tables of variable length, we need a flexible /* To constant-initialize the tables of variable length, we need a flexible
* array member, and we need to compile in C99 mode. */ * array member, and we need to compile in C99 mode. */
_upb_fasttable_entry fasttable[]; _upb_fasttable_entry fasttable[];
} upb_msglayout; };
/** upb_msg *******************************************************************/ /** upb_msg *******************************************************************/
@ -1137,21 +1129,18 @@ void _upb_msg_discardunknown_shallow(upb_msg *msg);
bool _upb_msg_addunknown(upb_msg *msg, const char *data, size_t len, bool _upb_msg_addunknown(upb_msg *msg, const char *data, size_t len,
upb_arena *arena); upb_arena *arena);
/* Returns a reference to the message's unknown data. */
const char *upb_msg_getunknown(const upb_msg *msg, size_t *len);
/** Hasbit access *************************************************************/ /** Hasbit access *************************************************************/
UPB_INLINE bool _upb_hasbit(const upb_msg *msg, size_t idx) { UPB_INLINE bool _upb_hasbit(const upb_msg *msg, size_t idx) {
return (*PTR_AT(msg, idx / 8, const char) & (1 << (idx % 8))) != 0; return (*UPB_PTR_AT(msg, idx / 8, const char) & (1 << (idx % 8))) != 0;
} }
UPB_INLINE void _upb_sethas(const upb_msg *msg, size_t idx) { UPB_INLINE void _upb_sethas(const upb_msg *msg, size_t idx) {
(*PTR_AT(msg, idx / 8, char)) |= (char)(1 << (idx % 8)); (*UPB_PTR_AT(msg, idx / 8, char)) |= (char)(1 << (idx % 8));
} }
UPB_INLINE void _upb_clearhas(const upb_msg *msg, size_t idx) { UPB_INLINE void _upb_clearhas(const upb_msg *msg, size_t idx) {
(*PTR_AT(msg, idx / 8, char)) &= (char)(~(1 << (idx % 8))); (*UPB_PTR_AT(msg, idx / 8, char)) &= (char)(~(1 << (idx % 8)));
} }
UPB_INLINE size_t _upb_msg_hasidx(const upb_msglayout_field *f) { UPB_INLINE size_t _upb_msg_hasidx(const upb_msglayout_field *f) {
@ -1177,11 +1166,11 @@ UPB_INLINE void _upb_clearhas_field(const upb_msg *msg,
/** Oneof case access *********************************************************/ /** Oneof case access *********************************************************/
UPB_INLINE uint32_t *_upb_oneofcase(upb_msg *msg, size_t case_ofs) { UPB_INLINE uint32_t *_upb_oneofcase(upb_msg *msg, size_t case_ofs) {
return PTR_AT(msg, case_ofs, uint32_t); return UPB_PTR_AT(msg, case_ofs, uint32_t);
} }
UPB_INLINE uint32_t _upb_getoneofcase(const void *msg, size_t case_ofs) { UPB_INLINE uint32_t _upb_getoneofcase(const void *msg, size_t case_ofs) {
return *PTR_AT(msg, case_ofs, uint32_t); return *UPB_PTR_AT(msg, case_ofs, uint32_t);
} }
UPB_INLINE size_t _upb_oneofcase_ofs(const upb_msglayout_field *f) { UPB_INLINE size_t _upb_oneofcase_ofs(const upb_msglayout_field *f) {
@ -1200,7 +1189,7 @@ UPB_INLINE uint32_t _upb_getoneofcase_field(const upb_msg *msg,
} }
UPB_INLINE bool _upb_has_submsg_nohasbit(const upb_msg *msg, size_t ofs) { UPB_INLINE bool _upb_has_submsg_nohasbit(const upb_msg *msg, size_t ofs) {
return *PTR_AT(msg, ofs, const upb_msg*) != NULL; return *UPB_PTR_AT(msg, ofs, const upb_msg*) != NULL;
} }
UPB_INLINE bool _upb_isrepeated(const upb_msglayout_field *field) { UPB_INLINE bool _upb_isrepeated(const upb_msglayout_field *field) {
@ -1277,7 +1266,7 @@ UPB_INLINE bool _upb_array_resize(upb_array *arr, size_t size,
UPB_INLINE const void *_upb_array_accessor(const void *msg, size_t ofs, UPB_INLINE const void *_upb_array_accessor(const void *msg, size_t ofs,
size_t *size) { size_t *size) {
const upb_array *arr = *PTR_AT(msg, ofs, const upb_array*); const upb_array *arr = *UPB_PTR_AT(msg, ofs, const upb_array*);
if (arr) { if (arr) {
if (size) *size = arr->len; if (size) *size = arr->len;
return _upb_array_constptr(arr); return _upb_array_constptr(arr);
@ -1289,7 +1278,7 @@ UPB_INLINE const void *_upb_array_accessor(const void *msg, size_t ofs,
UPB_INLINE void *_upb_array_mutable_accessor(void *msg, size_t ofs, UPB_INLINE void *_upb_array_mutable_accessor(void *msg, size_t ofs,
size_t *size) { size_t *size) {
upb_array *arr = *PTR_AT(msg, ofs, upb_array*); upb_array *arr = *UPB_PTR_AT(msg, ofs, upb_array*);
if (arr) { if (arr) {
if (size) *size = arr->len; if (size) *size = arr->len;
return _upb_array_ptr(arr); return _upb_array_ptr(arr);
@ -1302,7 +1291,7 @@ UPB_INLINE void *_upb_array_mutable_accessor(void *msg, size_t ofs,
UPB_INLINE void *_upb_array_resize_accessor2(void *msg, size_t ofs, size_t size, UPB_INLINE void *_upb_array_resize_accessor2(void *msg, size_t ofs, size_t size,
int elem_size_lg2, int elem_size_lg2,
upb_arena *arena) { upb_arena *arena) {
upb_array **arr_ptr = PTR_AT(msg, ofs, upb_array *); upb_array **arr_ptr = UPB_PTR_AT(msg, ofs, upb_array *);
upb_array *arr = *arr_ptr; upb_array *arr = *arr_ptr;
if (!arr || arr->size < size) { if (!arr || arr->size < size) {
return _upb_array_resize_fallback(arr_ptr, size, elem_size_lg2, arena); return _upb_array_resize_fallback(arr_ptr, size, elem_size_lg2, arena);
@ -1315,7 +1304,7 @@ UPB_INLINE bool _upb_array_append_accessor2(void *msg, size_t ofs,
int elem_size_lg2, int elem_size_lg2,
const void *value, const void *value,
upb_arena *arena) { upb_arena *arena) {
upb_array **arr_ptr = PTR_AT(msg, ofs, upb_array *); upb_array **arr_ptr = UPB_PTR_AT(msg, ofs, upb_array *);
size_t elem_size = 1 << elem_size_lg2; size_t elem_size = 1 << elem_size_lg2;
upb_array *arr = *arr_ptr; upb_array *arr = *arr_ptr;
void *ptr; void *ptr;
@ -1323,7 +1312,7 @@ UPB_INLINE bool _upb_array_append_accessor2(void *msg, size_t ofs,
return _upb_array_append_fallback(arr_ptr, value, elem_size_lg2, arena); return _upb_array_append_fallback(arr_ptr, value, elem_size_lg2, arena);
} }
ptr = _upb_array_ptr(arr); ptr = _upb_array_ptr(arr);
memcpy(PTR_AT(ptr, arr->len * elem_size, char), value, elem_size); memcpy(UPB_PTR_AT(ptr, arr->len * elem_size, char), value, elem_size);
arr->len++; arr->len++;
return true; return true;
} }
@ -1470,20 +1459,19 @@ UPB_INLINE void* _upb_map_next(const upb_map *map, size_t *iter) {
} }
UPB_INLINE bool _upb_map_set(upb_map *map, const void *key, size_t key_size, UPB_INLINE bool _upb_map_set(upb_map *map, const void *key, size_t key_size,
void *val, size_t val_size, upb_arena *arena) { void *val, size_t val_size, upb_arena *a) {
upb_strview strkey = _upb_map_tokey(key, key_size); upb_strview strkey = _upb_map_tokey(key, key_size);
upb_value tabval = {0}; upb_value tabval = {0};
if (!_upb_map_tovalue(val, val_size, &tabval, arena)) return false; if (!_upb_map_tovalue(val, val_size, &tabval, a)) return false;
upb_alloc *a = upb_arena_alloc(arena);
/* TODO(haberman): add overwrite operation to minimize number of lookups. */ /* TODO(haberman): add overwrite operation to minimize number of lookups. */
upb_strtable_remove3(&map->table, strkey.data, strkey.size, NULL, a); upb_strtable_remove(&map->table, strkey.data, strkey.size, NULL);
return upb_strtable_insert3(&map->table, strkey.data, strkey.size, tabval, a); return upb_strtable_insert(&map->table, strkey.data, strkey.size, tabval, a);
} }
UPB_INLINE bool _upb_map_delete(upb_map *map, const void *key, size_t key_size) { UPB_INLINE bool _upb_map_delete(upb_map *map, const void *key, size_t key_size) {
upb_strview k = _upb_map_tokey(key, key_size); upb_strview k = _upb_map_tokey(key, key_size);
return upb_strtable_remove3(&map->table, k.data, k.size, NULL, NULL); return upb_strtable_remove(&map->table, k.data, k.size, NULL);
} }
UPB_INLINE void _upb_map_clear(upb_map *map) { UPB_INLINE void _upb_map_clear(upb_map *map) {
@ -1515,7 +1503,7 @@ UPB_INLINE void *_upb_msg_map_next(const upb_msg *msg, size_t ofs,
UPB_INLINE bool _upb_msg_map_set(upb_msg *msg, size_t ofs, const void *key, UPB_INLINE bool _upb_msg_map_set(upb_msg *msg, size_t ofs, const void *key,
size_t key_size, void *val, size_t val_size, size_t key_size, void *val, size_t val_size,
upb_arena *arena) { upb_arena *arena) {
upb_map **map = PTR_AT(msg, ofs, upb_map *); upb_map **map = UPB_PTR_AT(msg, ofs, upb_map *);
if (!*map) { if (!*map) {
*map = _upb_map_new(arena, key_size, val_size); *map = _upb_map_new(arena, key_size, val_size);
} }
@ -1548,8 +1536,7 @@ UPB_INLINE void _upb_msg_map_key(const void* msg, void* key, size_t size) {
UPB_INLINE void _upb_msg_map_value(const void* msg, void* val, size_t size) { UPB_INLINE void _upb_msg_map_value(const void* msg, void* val, size_t size) {
const upb_tabent *ent = (const upb_tabent*)msg; const upb_tabent *ent = (const upb_tabent*)msg;
upb_value v; upb_value v = {ent->val.val};
_upb_value_setval(&v, ent->val.val);
_upb_map_fromvalue(v, val, size); _upb_map_fromvalue(v, val, size);
} }
@ -1612,55 +1599,14 @@ UPB_INLINE bool _upb_sortedmap_next(_upb_mapsorter *s, const upb_map *map,
return true; return true;
} }
#undef PTR_AT
#ifdef __cplusplus
} /* extern "C" */
#endif
#endif /* UPB_MSG_H_ */
/* Must be last. */
#ifdef __cplusplus
extern "C" {
#endif
enum {
/* If set, strings will alias the input buffer instead of copying into the
* arena. */
UPB_DECODE_ALIAS = 1,
};
#define UPB_DECODE_MAXDEPTH(depth) ((depth) << 16)
bool _upb_decode(const char *buf, size_t size, upb_msg *msg,
const upb_msglayout *l, upb_arena *arena, int options);
UPB_INLINE
bool upb_decode(const char *buf, size_t size, upb_msg *msg,
const upb_msglayout *l, upb_arena *arena) {
return _upb_decode(buf, size, msg, l, arena, 0);
}
#ifdef __cplusplus #ifdef __cplusplus
} /* extern "C" */ } /* extern "C" */
#endif #endif
#endif /* UPB_DECODE_H_ */ #endif /* UPB_MSG_INT_H_ */
/*
** Internal implementation details of the decoder that are shared between
** decode.c and decode_fast.c.
*/
#ifndef UPB_DECODE_INT_H_
#define UPB_DECODE_INT_H_
#include <setjmp.h>
/** upb/upb_internal.h ************************************************************/
#ifndef UPB_INT_H_ #ifndef UPB_INT_H_
#define UPB_INT_H_ #define UPB_INT_H_
@ -1670,7 +1616,10 @@ typedef struct mem_block mem_block;
struct upb_arena { struct upb_arena {
_upb_arena_head head; _upb_arena_head head;
uint32_t *cleanups; /* Stores cleanup metadata for this arena.
* - a pointer to the current cleanup counter.
* - a boolean indicating if there is an unowned initial block. */
uintptr_t cleanup_metadata;
/* Allocator to allocate arena blocks. We are responsible for freeing these /* Allocator to allocate arena blocks. We are responsible for freeing these
* when we are destroyed. */ * when we are destroyed. */
@ -1792,10 +1741,11 @@ bool decode_isdone(upb_decstate *d, const char **ptr) {
} }
} }
#if UPB_FASTTABLE
UPB_INLINE UPB_INLINE
const char *fastdecode_tagdispatch(upb_decstate *d, const char *ptr, const char *fastdecode_tagdispatch(upb_decstate *d, const char *ptr,
upb_msg *msg, intptr_t table, upb_msg *msg, intptr_t table,
uint64_t hasbits, uint32_t tag) { uint64_t hasbits, uint64_t tag) {
const upb_msglayout *table_p = decode_totablep(table); const upb_msglayout *table_p = decode_totablep(table);
uint8_t mask = table; uint8_t mask = table;
uint64_t data; uint64_t data;
@ -1803,8 +1753,10 @@ const char *fastdecode_tagdispatch(upb_decstate *d, const char *ptr,
UPB_ASSUME((idx & 7) == 0); UPB_ASSUME((idx & 7) == 0);
idx >>= 3; idx >>= 3;
data = table_p->fasttable[idx].field_data ^ tag; data = table_p->fasttable[idx].field_data ^ tag;
return table_p->fasttable[idx].field_parser(d, ptr, msg, table, hasbits, data); UPB_MUSTTAIL return table_p->fasttable[idx].field_parser(d, ptr, msg, table,
hasbits, data);
} }
#endif
UPB_INLINE uint32_t fastdecode_loadtag(const char* ptr) { UPB_INLINE uint32_t fastdecode_loadtag(const char* ptr) {
uint16_t tag; uint16_t tag;
@ -1837,9 +1789,11 @@ UPB_INLINE void decode_poplimit(upb_decstate *d, const char *ptr,
#endif /* UPB_DECODE_INT_H_ */ #endif /* UPB_DECODE_INT_H_ */
/** upb/encode.h ************************************************************/
/* /*
** upb_encode: parsing into a upb_msg using a upb_msglayout. * upb_encode: parsing into a upb_msg using a upb_msglayout.
*/ */
#ifndef UPB_ENCODE_H_ #ifndef UPB_ENCODE_H_
#define UPB_ENCODE_H_ #define UPB_ENCODE_H_
@ -1880,6 +1834,8 @@ UPB_INLINE char *upb_encode(const void *msg, const upb_msglayout *l,
#endif #endif
#endif /* UPB_ENCODE_H_ */ #endif /* UPB_ENCODE_H_ */
/** upb/decode_fast.h ************************************************************/
// These are the specialized field parser functions for the fast parser. // These are the specialized field parser functions for the fast parser.
// Generated tables will refer to these by name. // Generated tables will refer to these by name.
// //
@ -2005,7 +1961,8 @@ TAGBYTES(r)
#undef UPB_PARSE_PARAMS #undef UPB_PARSE_PARAMS
#endif /* UPB_DECODE_FAST_H_ */ #endif /* UPB_DECODE_FAST_H_ */
/* This file was generated by upbc (the upb compiler) from the input
/** google/protobuf/descriptor.upb.h ************************************************************//* This file was generated by upbc (the upb compiler) from the input
* file: * file:
* *
* google/protobuf/descriptor.proto * google/protobuf/descriptor.proto
@ -3884,18 +3841,20 @@ UPB_INLINE void google_protobuf_GeneratedCodeInfo_Annotation_set_end(google_prot
#endif /* GOOGLE_PROTOBUF_DESCRIPTOR_PROTO_UPB_H_ */ #endif /* GOOGLE_PROTOBUF_DESCRIPTOR_PROTO_UPB_H_ */
/** upb/def.h ************************************************************/
/* /*
** Defs are upb's internal representation of the constructs that can appear * Defs are upb's internal representation of the constructs that can appear
** in a .proto file: * in a .proto file:
** *
** - upb_msgdef: describes a "message" construct. * - upb_msgdef: describes a "message" construct.
** - upb_fielddef: describes a message field. * - upb_fielddef: describes a message field.
** - upb_filedef: describes a .proto file and its defs. * - upb_filedef: describes a .proto file and its defs.
** - upb_enumdef: describes an enum. * - upb_enumdef: describes an enum.
** - upb_oneofdef: describes a oneof. * - upb_oneofdef: describes a oneof.
** *
** TODO: definitions of services. * TODO: definitions of services.
*/ */
#ifndef UPB_DEF_H_ #ifndef UPB_DEF_H_
#define UPB_DEF_H_ #define UPB_DEF_H_
@ -3991,9 +3950,6 @@ const upb_msgdef *upb_fielddef_msgsubdef(const upb_fielddef *f);
const upb_enumdef *upb_fielddef_enumsubdef(const upb_fielddef *f); const upb_enumdef *upb_fielddef_enumsubdef(const upb_fielddef *f);
const upb_msglayout_field *upb_fielddef_layout(const upb_fielddef *f); const upb_msglayout_field *upb_fielddef_layout(const upb_fielddef *f);
/* Internal only. */
uint32_t upb_fielddef_selectorbase(const upb_fielddef *f);
/* upb_oneofdef ***************************************************************/ /* upb_oneofdef ***************************************************************/
typedef upb_inttable_iter upb_oneof_iter; typedef upb_inttable_iter upb_oneof_iter;
@ -4078,10 +4034,6 @@ UPB_INLINE const upb_fielddef *upb_msgdef_ntofz(const upb_msgdef *m,
return upb_msgdef_ntof(m, name, strlen(name)); return upb_msgdef_ntof(m, name, strlen(name));
} }
/* Internal-only. */
size_t upb_msgdef_selectorcount(const upb_msgdef *m);
uint32_t upb_msgdef_submsgfieldcount(const upb_msgdef *m);
/* Lookup of either field or oneof by name. Returns whether either was found. /* Lookup of either field or oneof by name. Returns whether either was found.
* If the return is true, then the found def will be set, and the non-found * If the return is true, then the found def will be set, and the non-found
* one set to NULL. */ * one set to NULL. */
@ -4196,7 +4148,8 @@ bool _upb_symtab_loaddefinit(upb_symtab *s, const upb_def_init *init);
#endif /* __cplusplus */ #endif /* __cplusplus */
#endif /* UPB_DEF_H_ */ #endif /* UPB_DEF_H_ */
/* This file was generated by upbc (the upb compiler) from the input
/** google/protobuf/descriptor.upbdefs.h ************************************************************//* This file was generated by upbc (the upb compiler) from the input
* file: * file:
* *
* google/protobuf/descriptor.proto * google/protobuf/descriptor.proto
@ -4357,6 +4310,7 @@ UPB_INLINE const upb_msgdef *google_protobuf_GeneratedCodeInfo_Annotation_getmsg
#endif /* GOOGLE_PROTOBUF_DESCRIPTOR_PROTO_UPBDEFS_H_ */ #endif /* GOOGLE_PROTOBUF_DESCRIPTOR_PROTO_UPBDEFS_H_ */
/** upb/reflection.h ************************************************************/
#ifndef UPB_REFLECTION_H_ #ifndef UPB_REFLECTION_H_
#define UPB_REFLECTION_H_ #define UPB_REFLECTION_H_
@ -4438,17 +4392,9 @@ bool upb_msg_next(const upb_msg *msg, const upb_msgdef *m,
const upb_symtab *ext_pool, const upb_fielddef **f, const upb_symtab *ext_pool, const upb_fielddef **f,
upb_msgval *val, size_t *iter); upb_msgval *val, size_t *iter);
/* Adds unknown data (serialized protobuf data) to the given message. The data
* is copied into the message instance. */
void upb_msg_addunknown(upb_msg *msg, const char *data, size_t len,
upb_arena *arena);
/* Clears all unknown field data from this message and all submessages. */ /* Clears all unknown field data from this message and all submessages. */
bool upb_msg_discardunknown(upb_msg *msg, const upb_msgdef *m, int maxdepth); bool upb_msg_discardunknown(upb_msg *msg, const upb_msgdef *m, int maxdepth);
/* Returns a reference to the message's unknown data. */
const char *upb_msg_getunknown(const upb_msg *msg, size_t *len);
/** upb_array *****************************************************************/ /** upb_array *****************************************************************/
/* Creates a new array on the given arena that holds elements of this type. */ /* Creates a new array on the given arena that holds elements of this type. */
@ -4530,6 +4476,7 @@ void upb_mapiter_setvalue(upb_map *map, size_t iter, upb_msgval value);
#endif /* UPB_REFLECTION_H_ */ #endif /* UPB_REFLECTION_H_ */
/** upb/json_decode.h ************************************************************/
#ifndef UPB_JSONDECODE_H_ #ifndef UPB_JSONDECODE_H_
#define UPB_JSONDECODE_H_ #define UPB_JSONDECODE_H_
@ -4552,6 +4499,7 @@ bool upb_json_decode(const char *buf, size_t size, upb_msg *msg,
#endif /* UPB_JSONDECODE_H_ */ #endif /* UPB_JSONDECODE_H_ */
/** upb/json_encode.h ************************************************************/
#ifndef UPB_JSONENCODE_H_ #ifndef UPB_JSONENCODE_H_
#define UPB_JSONENCODE_H_ #define UPB_JSONENCODE_H_
@ -4586,27 +4534,39 @@ size_t upb_json_encode(const upb_msg *msg, const upb_msgdef *m,
#endif #endif
#endif /* UPB_JSONENCODE_H_ */ #endif /* UPB_JSONENCODE_H_ */
/** upb/port_undef.inc ************************************************************/
/* See port_def.inc. This should #undef all macros #defined there. */ /* See port_def.inc. This should #undef all macros #defined there. */
#undef UPB_MAPTYPE_STRING
#undef UPB_SIZE #undef UPB_SIZE
#undef UPB_PTR_AT #undef UPB_PTR_AT
#undef UPB_READ_ONEOF #undef UPB_READ_ONEOF
#undef UPB_WRITE_ONEOF #undef UPB_WRITE_ONEOF
#undef UPB_MAPTYPE_STRING
#undef UPB_INLINE #undef UPB_INLINE
#undef UPB_ALIGN_UP #undef UPB_ALIGN_UP
#undef UPB_ALIGN_DOWN #undef UPB_ALIGN_DOWN
#undef UPB_ALIGN_MALLOC #undef UPB_ALIGN_MALLOC
#undef UPB_ALIGN_OF #undef UPB_ALIGN_OF
#undef UPB_LIKELY
#undef UPB_UNLIKELY
#undef UPB_FORCEINLINE #undef UPB_FORCEINLINE
#undef UPB_NOINLINE #undef UPB_NOINLINE
#undef UPB_NORETURN #undef UPB_NORETURN
#undef UPB_PRINTF
#undef UPB_MAX #undef UPB_MAX
#undef UPB_MIN #undef UPB_MIN
#undef UPB_UNUSED #undef UPB_UNUSED
#undef UPB_ASSUME #undef UPB_ASSUME
#undef UPB_ASSERT #undef UPB_ASSERT
#undef UPB_UNREACHABLE #undef UPB_UNREACHABLE
#undef UPB_SETJMP
#undef UPB_LONGJMP
#undef UPB_PTRADD
#undef UPB_MUSTTAIL
#undef UPB_FASTTABLE_SUPPORTED
#undef UPB_FASTTABLE
#undef UPB_FASTTABLE_INIT
#undef UPB_POISON_MEMORY_REGION #undef UPB_POISON_MEMORY_REGION
#undef UPB_UNPOISON_MEMORY_REGION #undef UPB_UNPOISON_MEMORY_REGION
#undef UPB_ASAN #undef UPB_ASAN

@ -240,10 +240,14 @@ class Message
$field = $this->desc->getFieldByNumber($number); $field = $this->desc->getFieldByNumber($number);
$oneof = $this->desc->getOneofDecl()[$field->getOneofIndex()]; $oneof = $this->desc->getOneofDecl()[$field->getOneofIndex()];
$oneof_name = $oneof->getName(); $oneof_name = $oneof->getName();
$oneof_field = $this->$oneof_name; if ($value === null) {
$oneof_field->setValue($value); $this->$oneof_name = new OneofField($oneof);
$oneof_field->setFieldName($field->getName()); } else {
$oneof_field->setNumber($number); $oneof_field = $this->$oneof_name;
$oneof_field->setValue($value);
$oneof_field->setFieldName($field->getName());
$oneof_field->setNumber($number);
}
} }
protected function whichOneof($oneof_name) protected function whichOneof($oneof_name)

@ -177,8 +177,7 @@ class RepeatedField implements \ArrayAccess, \IteratorAggregate, \Countable
break; break;
case GPBType::MESSAGE: case GPBType::MESSAGE:
if (is_null($value)) { if (is_null($value)) {
trigger_error("RepeatedField element cannot be null.", throw new \TypeError("RepeatedField element cannot be null.");
E_USER_ERROR);
} }
GPBUtil::checkMessage($value, $this->klass); GPBUtil::checkMessage($value, $this->klass);
break; break;

@ -602,6 +602,17 @@ class ArrayTest extends TestBase
$this->assertLessThan($start, $end); $this->assertLessThan($start, $end);
} }
#########################################################
# Test incorrect types
#########################################################
public function testAppendNull()
{
$this->expectException(TypeError::class);
$arr = new RepeatedField(GPBType::MESSAGE, TestMessage::class);
$arr[] = null;
}
######################################################### #########################################################
# Test equality # Test equality
######################################################### #########################################################

@ -940,6 +940,14 @@ class EncodeDecodeTest extends TestBase
$this->expectFields($to); $this->expectFields($to);
} }
public function testJsonEncodeNullSubMessage()
{
$from = new TestMessage();
$from->setOptionalMessage(null);
$data = $from->serializeToJsonString();
$this->assertEquals("{}", $data);
}
public function testDecodeDuration() public function testDecodeDuration()
{ {
$m = new Google\Protobuf\Duration(); $m = new Google\Protobuf\Duration();

@ -476,10 +476,12 @@ class GeneratedClassTest extends TestBase
$sub_m->setA(1); $sub_m->setA(1);
$m->setOptionalMessage($sub_m); $m->setOptionalMessage($sub_m);
$this->assertSame(1, $m->getOptionalMessage()->getA()); $this->assertSame(1, $m->getOptionalMessage()->getA());
$this->assertTrue($m->hasOptionalMessage());
$null = null; $null = null;
$m->setOptionalMessage($null); $m->setOptionalMessage($null);
$this->assertNull($m->getOptionalMessage()); $this->assertNull($m->getOptionalMessage());
$this->assertFalse($m->hasOptionalMessage());
} }
public function testLegacyMessageField() public function testLegacyMessageField()
@ -1748,6 +1750,13 @@ class GeneratedClassTest extends TestBase
$m->clear(); $m->clear();
$this->assertFalse($m->hasOneofInt32()); $this->assertFalse($m->hasOneofInt32());
$this->assertFalse($m->hasOneofString()); $this->assertFalse($m->hasOneofString());
$sub_m = new Sub();
$sub_m->setA(1);
$m->setOneofMessage($sub_m);
$this->assertTrue($m->hasOneofMessage());
$m->setOneofMessage(null);
$this->assertFalse($m->hasOneofMessage());
} }
######################################################### #########################################################

@ -190,13 +190,13 @@ proto_gen = rule(
"deps": attr.label_list(providers = ["proto"]), "deps": attr.label_list(providers = ["proto"]),
"includes": attr.string_list(), "includes": attr.string_list(),
"protoc": attr.label( "protoc": attr.label(
cfg = "host", cfg = "exec",
executable = True, executable = True,
allow_single_file = True, allow_single_file = True,
mandatory = True, mandatory = True,
), ),
"plugin": attr.label( "plugin": attr.label(
cfg = "host", cfg = "exec",
allow_files = True, allow_files = True,
executable = True, executable = True,
), ),
@ -378,7 +378,7 @@ internal_gen_well_known_protos_java = rule(
), ),
"_protoc": attr.label( "_protoc": attr.label(
executable = True, executable = True,
cfg = "host", cfg = "exec",
default = "@com_google_protobuf//:protoc", default = "@com_google_protobuf//:protoc",
), ),
}, },

@ -1564,12 +1564,17 @@ static int InternalReparentFields(
to_release); to_release);
} }
GOOGLE_CHECK_EQ(self->message->GetArena(), new_message->message->GetArena()); if (self->message->GetArena() == new_message->message->GetArena()) {
MessageReflectionFriend::UnsafeShallowSwapFields(
MessageReflectionFriend::UnsafeShallowSwapFields( self->message, new_message->message,
self->message, new_message->message, std::vector<const FieldDescriptor*>(fields_to_swap.begin(),
std::vector<const FieldDescriptor*>(fields_to_swap.begin(), fields_to_swap.end()));
fields_to_swap.end())); } else {
self->message->GetReflection()->SwapFields(
self->message, new_message->message,
std::vector<const FieldDescriptor*>(fields_to_swap.begin(),
fields_to_swap.end()));
}
// This might delete the Python message completely if all children were moved. // This might delete the Python message completely if all children were moved.
Py_DECREF(self); Py_DECREF(self);

@ -18,6 +18,18 @@ well_known_protos = %w[
google/protobuf/wrappers.proto google/protobuf/wrappers.proto
] ]
test_protos = %w[
tests/basic_test.proto
tests/basic_test_proto2.proto
tests/generated_code.proto
tests/generated_code_proto2.proto
tests/multi_level_nesting_test.proto
tests/test_import.proto
tests/test_import_proto2.proto
tests/test_ruby_package.proto
tests/test_ruby_package_proto2.proto
]
# These are omitted for now because we don't support proto2. # These are omitted for now because we don't support proto2.
proto2_protos = %w[ proto2_protos = %w[
google/protobuf/descriptor.proto google/protobuf/descriptor.proto
@ -43,6 +55,14 @@ unless ENV['IN_DOCKER'] == 'true'
sh "#{protoc_command} -I../src --ruby_out=lib #{input_file}" sh "#{protoc_command} -I../src --ruby_out=lib #{input_file}"
end end
end end
test_protos.each do |proto_file|
output_file = proto_file.sub(/\.proto$/, "_pb.rb")
genproto_output << output_file
file output_file => proto_file do |file_task|
sh "#{protoc_command} -I../src -I. --ruby_out=. #{proto_file}"
end
end
end end
if RUBY_PLATFORM == "java" if RUBY_PLATFORM == "java"
@ -100,59 +120,6 @@ else
end end
end end
# Proto for tests.
genproto_output << "tests/generated_code.rb"
genproto_output << "tests/generated_code_proto2.rb"
genproto_output << "tests/test_import.rb"
genproto_output << "tests/test_import_proto2.rb"
genproto_output << "tests/test_ruby_package.rb"
genproto_output << "tests/test_ruby_package_proto2.rb"
genproto_output << "tests/basic_test.rb"
genproto_output << "tests/basic_test_proto2.rb"
genproto_output << "tests/multi_level_nesting_test.rb"
genproto_output << "tests/wrappers.rb"
file "tests/generated_code.rb" => "tests/generated_code.proto" do |file_task|
sh "#{protoc_command} --ruby_out=. tests/generated_code.proto"
end
file "tests/generated_code_proto2.rb" => "tests/generated_code_proto2.proto" do |file_task|
sh "#{protoc_command} --ruby_out=. tests/generated_code_proto2.proto"
end
file "tests/test_import.rb" => "tests/test_import.proto" do |file_task|
sh "#{protoc_command} --ruby_out=. tests/test_import.proto"
end
file "tests/test_import_proto2.rb" => "tests/test_import_proto2.proto" do |file_task|
sh "#{protoc_command} --ruby_out=. tests/test_import_proto2.proto"
end
file "tests/test_ruby_package.rb" => "tests/test_ruby_package.proto" do |file_task|
sh "#{protoc_command} --ruby_out=. tests/test_ruby_package.proto"
end
file "tests/test_ruby_package_proto2.rb" => "tests/test_ruby_package_proto2.proto" do |file_task|
sh "#{protoc_command} --ruby_out=. tests/test_ruby_package_proto2.proto"
end
file "tests/basic_test.rb" => "tests/basic_test.proto" do |file_task|
sh "#{protoc_command} --experimental_allow_proto3_optional -I../src -I. --ruby_out=. tests/basic_test.proto"
end
file "tests/basic_test_proto2.rb" => "tests/basic_test_proto2.proto" do |file_task|
sh "#{protoc_command} -I../src -I. --ruby_out=. tests/basic_test_proto2.proto"
end
file "tests/multi_level_nesting_test.rb" => "tests/multi_level_nesting_test.proto" do |file_task|
sh "#{protoc_command} -I../src -I. --ruby_out=. tests/multi_level_nesting_test.proto"
end
file "tests/wrappers.rb" => "../src/google/protobuf/wrappers.proto" do |file_task|
sh "#{protoc_command} -I../src -I. --ruby_out=tests ../src/google/protobuf/wrappers.proto"
end
task :genproto => genproto_output task :genproto => genproto_output
task :clean do task :clean do
@ -162,7 +129,7 @@ end
Gem::PackageTask.new(spec) do |pkg| Gem::PackageTask.new(spec) do |pkg|
end end
Rake::TestTask.new(:test => :build) do |t| Rake::TestTask.new(:test => [:build, :genproto]) do |t|
t.test_files = FileList["tests/*.rb"].exclude("tests/gc_test.rb", "tests/common_tests.rb") t.test_files = FileList["tests/*.rb"].exclude("tests/gc_test.rb", "tests/common_tests.rb")
end end
@ -172,7 +139,7 @@ Rake::TestTask.new(:gc_test => :build) do |t|
t.test_files = FileList["tests/gc_test.rb"] t.test_files = FileList["tests/gc_test.rb"]
end end
task :build => [:clean, :compile, :genproto] task :build => [:clean, :genproto, :compile]
task :default => [:build] task :default => [:build]
# vim:sw=2:et # vim:sw=2:et

@ -794,6 +794,14 @@ static VALUE Message_CreateHash(const upb_msg *msg, const upb_msgdef *m) {
VALUE msg_value; VALUE msg_value;
VALUE msg_key; VALUE msg_key;
if (!is_proto2 && upb_fielddef_issubmsg(field) &&
!upb_fielddef_isseq(field) && !upb_msg_has(msg, field)) {
// TODO: Legacy behavior, remove when we fix the is_proto2 differences.
msg_key = ID2SYM(rb_intern(upb_fielddef_name(field)));
rb_hash_aset(hash, msg_key, Qnil);
continue;
}
// Do not include fields that are not present (oneof or optional fields). // Do not include fields that are not present (oneof or optional fields).
if (is_proto2 && upb_fielddef_haspresence(field) && if (is_proto2 && upb_fielddef_haspresence(field) &&
!upb_msg_has(msg, field)) { !upb_msg_has(msg, field)) {

File diff suppressed because it is too large Load Diff

@ -1,26 +1,53 @@
/* Amalgamated source file */ /* Amalgamated source file */
#include <stdint.h>/* /*
* This is where we define macros used across upb. * Copyright (c) 2009-2021, Google LLC
* * All rights reserved.
* All of these macros are undef'd in port_undef.inc to avoid leaking them to *
* users. * Redistribution and use in source and binary forms, with or without
* * modification, are permitted provided that the following conditions are met:
* The correct usage is: * * Redistributions of source code must retain the above copyright
* * notice, this list of conditions and the following disclaimer.
* #include "upb/foobar.h" * * Redistributions in binary form must reproduce the above copyright
* #include "upb/baz.h" * notice, this list of conditions and the following disclaimer in the
* * documentation and/or other materials provided with the distribution.
* // MUST be last included header. * * Neither the name of Google LLC nor the
* #include "upb/port_def.inc" * names of its contributors may be used to endorse or promote products
* * derived from this software without specific prior written permission.
* // Code for this file. *
* // <...> * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND
* * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
* // Can be omitted for .c files, required for .h. * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
* #include "upb/port_undef.inc" * DISCLAIMED. IN NO EVENT SHALL Google LLC BE LIABLE FOR ANY
* * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
* This file is private and must not be included by users! * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
*/ * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
* ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
* SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
/*
* This is where we define macros used across upb.
*
* All of these macros are undef'd in port_undef.inc to avoid leaking them to
* users.
*
* The correct usage is:
*
* #include "upb/foobar.h"
* #include "upb/baz.h"
*
* // MUST be last included header.
* #include "upb/port_def.inc"
*
* // Code for this file.
* // <...>
*
* // Can be omitted for .c files, required for .h.
* #include "upb/port_undef.inc"
*
* This file is private and must not be included by users!
*/
#if !((defined(__STDC_VERSION__) && __STDC_VERSION__ >= 199901L) || \ #if !((defined(__STDC_VERSION__) && __STDC_VERSION__ >= 199901L) || \
(defined(__cplusplus) && __cplusplus >= 201103L) || \ (defined(__cplusplus) && __cplusplus >= 201103L) || \
@ -136,9 +163,40 @@
#define UPB_LONGJMP(buf, val) longjmp(buf, val) #define UPB_LONGJMP(buf, val) longjmp(buf, val)
#endif #endif
/* UPB_PTRADD(ptr, ofs): add pointer while avoiding "NULL + 0" UB */
#define UPB_PTRADD(ptr, ofs) ((ofs) ? (ptr) + (ofs) : (ptr))
/* Configure whether fasttable is switched on or not. *************************/ /* Configure whether fasttable is switched on or not. *************************/
#if defined(__x86_64__) && defined(__GNUC__) #ifdef __has_attribute
#define UPB_HAS_ATTRIBUTE(x) __has_attribute(x)
#else
#define UPB_HAS_ATTRIBUTE(x) 0
#endif
#if UPB_HAS_ATTRIBUTE(musttail)
#define UPB_MUSTTAIL __attribute__((musttail))
#else
#define UPB_MUSTTAIL
#endif
#undef UPB_HAS_ATTRIBUTE
/* This check is not fully robust: it does not require that we have "musttail"
* support available. We need tail calls to avoid consuming arbitrary amounts
* of stack space.
*
* GCC/Clang can mostly be trusted to generate tail calls as long as
* optimization is enabled, but, debug builds will not generate tail calls
* unless "musttail" is available.
*
* We should probably either:
* 1. require that the compiler supports musttail.
* 2. add some fallback code for when musttail isn't available (ie. return
* instead of tail calling). This is safe and portable, but this comes at
* a CPU cost.
*/
#if (defined(__x86_64__) || defined(__aarch64__)) && defined(__GNUC__)
#define UPB_FASTTABLE_SUPPORTED 1 #define UPB_FASTTABLE_SUPPORTED 1
#else #else
#define UPB_FASTTABLE_SUPPORTED 0 #define UPB_FASTTABLE_SUPPORTED 0
@ -149,7 +207,7 @@
* for example for testing or benchmarking. */ * for example for testing or benchmarking. */
#if defined(UPB_ENABLE_FASTTABLE) #if defined(UPB_ENABLE_FASTTABLE)
#if !UPB_FASTTABLE_SUPPORTED #if !UPB_FASTTABLE_SUPPORTED
#error fasttable is x86-64 + Clang/GCC only #error fasttable is x86-64/ARM64 only and requires GCC or Clang.
#endif #endif
#define UPB_FASTTABLE 1 #define UPB_FASTTABLE 1
/* Define UPB_TRY_ENABLE_FASTTABLE to use fasttable if possible. /* Define UPB_TRY_ENABLE_FASTTABLE to use fasttable if possible.
@ -193,55 +251,36 @@ void __asan_unpoison_memory_region(void const volatile *addr, size_t size);
((void)(addr), (void)(size)) ((void)(addr), (void)(size))
#define UPB_UNPOISON_MEMORY_REGION(addr, size) \ #define UPB_UNPOISON_MEMORY_REGION(addr, size) \
((void)(addr), (void)(size)) ((void)(addr), (void)(size))
#endif #endif
/** upb/decode.h ************************************************************/
/* /*
** upb_decode: parsing into a upb_msg using a upb_msglayout. * upb_decode: parsing into a upb_msg using a upb_msglayout.
*/ */
#ifndef UPB_DECODE_H_ #ifndef UPB_DECODE_H_
#define UPB_DECODE_H_ #define UPB_DECODE_H_
/** upb/msg.h ************************************************************/
/* /*
** Our memory representation for parsing tables and messages themselves. * Public APIs for message operations that do not require descriptors.
** Functions in this file are used by generated code and possibly reflection. * These functions can be used even in build that does not want to depend on
** * reflection or descriptors.
** The definitions in this file are internal to upb. *
**/ * Descriptor-based reflection functionality lives in reflection.h.
*/
#ifndef UPB_MSG_H_ #ifndef UPB_MSG_H_
#define UPB_MSG_H_ #define UPB_MSG_H_
#include <stdint.h> #include <stddef.h>
#include <stdlib.h>
#include <string.h>
/*
** upb_table
**
** This header is INTERNAL-ONLY! Its interfaces are not public or stable!
** This file defines very fast int->upb_value (inttable) and string->upb_value
** (strtable) hash tables.
**
** The table uses chained scatter with Brent's variation (inspired by the Lua
** implementation of hash tables). The hash function for strings is Austin
** Appleby's "MurmurHash."
**
** The inttable uses uintptr_t as its key, which guarantees it can be used to
** store pointers or integers of at least 32 bits (upb isn't really useful on
** systems where sizeof(void*) < 4).
**
** The table must be homogeneous (all values of the same type). In debug
** mode, we check this on insert and lookup.
*/
#ifndef UPB_TABLE_H_
#define UPB_TABLE_H_
#include <stdint.h> /** upb/upb.h ************************************************************/
#include <string.h>
/* /*
** This file contains shared definitions that are widely used across upb. * This file contains shared definitions that are widely used across upb.
*/ */
#ifndef UPB_H_ #ifndef UPB_H_
#define UPB_H_ #define UPB_H_
@ -399,7 +438,7 @@ typedef struct {
upb_arena *upb_arena_init(void *mem, size_t n, upb_alloc *alloc); upb_arena *upb_arena_init(void *mem, size_t n, upb_alloc *alloc);
void upb_arena_free(upb_arena *a); void upb_arena_free(upb_arena *a);
bool upb_arena_addcleanup(upb_arena *a, void *ud, upb_cleanup_func *func); bool upb_arena_addcleanup(upb_arena *a, void *ud, upb_cleanup_func *func);
void upb_arena_fuse(upb_arena *a, upb_arena *b); bool upb_arena_fuse(upb_arena *a, upb_arena *b);
void *_upb_arena_slowmalloc(upb_arena *a, size_t size); void *_upb_arena_slowmalloc(upb_arena *a, size_t size);
UPB_INLINE upb_alloc *upb_arena_alloc(upb_arena *a) { return (upb_alloc*)a; } UPB_INLINE upb_alloc *upb_arena_alloc(upb_arena *a) { return (upb_alloc*)a; }
@ -578,55 +617,134 @@ UPB_INLINE int _upb_lg2ceilsize(int x) {
#endif /* UPB_H_ */ #endif /* UPB_H_ */
#ifdef __cplusplus
extern "C" {
#endif
typedef void upb_msg;
/* For users these are opaque. They can be obtained from upb_msgdef_layout()
* but users cannot access any of the members. */
struct upb_msglayout;
typedef struct upb_msglayout upb_msglayout;
/* Adds unknown data (serialized protobuf data) to the given message. The data
* is copied into the message instance. */
void upb_msg_addunknown(upb_msg *msg, const char *data, size_t len,
upb_arena *arena);
/* Returns a reference to the message's unknown data. */
const char *upb_msg_getunknown(const upb_msg *msg, size_t *len);
#ifdef __cplusplus
} /* extern "C" */
#endif
#endif /* UPB_MSG_INT_H_ */
/* Must be last. */
#ifdef __cplusplus #ifdef __cplusplus
extern "C" { extern "C" {
#endif #endif
enum {
/* If set, strings will alias the input buffer instead of copying into the
* arena. */
UPB_DECODE_ALIAS = 1,
};
/* upb_value ******************************************************************/ #define UPB_DECODE_MAXDEPTH(depth) ((depth) << 16)
/* A tagged union (stored untagged inside the table) so that we can check that bool _upb_decode(const char *buf, size_t size, upb_msg *msg,
* clients calling table accessors are correctly typed without having to have const upb_msglayout *l, upb_arena *arena, int options);
* an explosion of accessors. */
typedef enum { UPB_INLINE
UPB_CTYPE_INT32 = 1, bool upb_decode(const char *buf, size_t size, upb_msg *msg,
UPB_CTYPE_INT64 = 2, const upb_msglayout *l, upb_arena *arena) {
UPB_CTYPE_UINT32 = 3, return _upb_decode(buf, size, msg, l, arena, 0);
UPB_CTYPE_UINT64 = 4, }
UPB_CTYPE_BOOL = 5,
UPB_CTYPE_CSTR = 6, #ifdef __cplusplus
UPB_CTYPE_PTR = 7, } /* extern "C" */
UPB_CTYPE_CONSTPTR = 8, #endif
UPB_CTYPE_FPTR = 9,
UPB_CTYPE_FLOAT = 10,
UPB_CTYPE_DOUBLE = 11 #endif /* UPB_DECODE_H_ */
} upb_ctype_t;
/** upb/decode_internal.h ************************************************************/
/*
* Internal implementation details of the decoder that are shared between
* decode.c and decode_fast.c.
*/
#ifndef UPB_DECODE_INT_H_
#define UPB_DECODE_INT_H_
#include <setjmp.h>
/** upb/msg_internal.h ************************************************************//*
** Our memory representation for parsing tables and messages themselves.
** Functions in this file are used by generated code and possibly reflection.
**
** The definitions in this file are internal to upb.
**/
#ifndef UPB_MSG_INT_H_
#define UPB_MSG_INT_H_
#include <stdint.h>
#include <stdlib.h>
#include <string.h>
/** upb/table_internal.h ************************************************************/
/*
* upb_table
*
* This header is INTERNAL-ONLY! Its interfaces are not public or stable!
* This file defines very fast int->upb_value (inttable) and string->upb_value
* (strtable) hash tables.
*
* The table uses chained scatter with Brent's variation (inspired by the Lua
* implementation of hash tables). The hash function for strings is Austin
* Appleby's "MurmurHash."
*
* The inttable uses uintptr_t as its key, which guarantees it can be used to
* store pointers or integers of at least 32 bits (upb isn't really useful on
* systems where sizeof(void*) < 4).
*
* The table must be homogeneous (all values of the same type). In debug
* mode, we check this on insert and lookup.
*/
#ifndef UPB_TABLE_H_
#define UPB_TABLE_H_
#include <stdint.h>
#include <string.h>
#ifdef __cplusplus
extern "C" {
#endif
/* upb_value ******************************************************************/
typedef struct { typedef struct {
uint64_t val; uint64_t val;
} upb_value; } upb_value;
/* Like strdup(), which isn't always available since it's not ANSI C. */
char *upb_strdup(const char *s, upb_alloc *a);
/* Variant that works with a length-delimited rather than NULL-delimited string, /* Variant that works with a length-delimited rather than NULL-delimited string,
* as supported by strtable. */ * as supported by strtable. */
char *upb_strdup2(const char *s, size_t len, upb_alloc *a); char *upb_strdup2(const char *s, size_t len, upb_arena *a);
UPB_INLINE char *upb_gstrdup(const char *s) {
return upb_strdup(s, &upb_alloc_global);
}
UPB_INLINE void _upb_value_setval(upb_value *v, uint64_t val) { UPB_INLINE void _upb_value_setval(upb_value *v, uint64_t val) {
v->val = val; v->val = val;
} }
UPB_INLINE upb_value _upb_value_val(uint64_t val) {
upb_value ret;
_upb_value_setval(&ret, val);
return ret;
}
/* For each value ctype, define the following set of functions: /* For each value ctype, define the following set of functions:
* *
* // Get/set an int32 from a upb_value. * // Get/set an int32 from a upb_value.
@ -734,14 +852,7 @@ typedef struct {
uint32_t mask; /* Mask to turn hash value -> bucket. */ uint32_t mask; /* Mask to turn hash value -> bucket. */
uint32_t max_count; /* Max count before we hit our load limit. */ uint32_t max_count; /* Max count before we hit our load limit. */
uint8_t size_lg2; /* Size of the hashtable part is 2^size_lg2 entries. */ uint8_t size_lg2; /* Size of the hashtable part is 2^size_lg2 entries. */
upb_tabent *entries;
/* Hash table entries.
* Making this const isn't entirely accurate; what we really want is for it to
* have the same const-ness as the table it's inside. But there's no way to
* declare that in C. So we have to make it const so that we can statically
* initialize const hash tables. Then we cast away const when we have to.
*/
const upb_tabent *entries;
} upb_table; } upb_table;
typedef struct { typedef struct {
@ -755,8 +866,6 @@ typedef struct {
size_t array_count; /* Array part number of elements. */ size_t array_count; /* Array part number of elements. */
} upb_inttable; } upb_inttable;
#define UPB_ARRAY_EMPTYENT -1
UPB_INLINE size_t upb_table_size(const upb_table *t) { UPB_INLINE size_t upb_table_size(const upb_table *t) {
if (t->size_lg2 == 0) if (t->size_lg2 == 0)
return 0; return 0;
@ -769,48 +878,10 @@ UPB_INLINE bool upb_tabent_isempty(const upb_tabent *e) {
return e->key == 0; return e->key == 0;
} }
/* Used by some of the unit tests for generic hashing functionality. */
uint32_t upb_murmur_hash2(const void * key, size_t len, uint32_t seed);
UPB_INLINE uintptr_t upb_intkey(uintptr_t key) {
return key;
}
UPB_INLINE uint32_t upb_inthash(uintptr_t key) {
return (uint32_t)key;
}
static const upb_tabent *upb_getentry(const upb_table *t, uint32_t hash) {
return t->entries + (hash & t->mask);
}
UPB_INLINE bool upb_arrhas(upb_tabval key) {
return key.val != (uint64_t)-1;
}
/* Initialize and uninitialize a table, respectively. If memory allocation /* Initialize and uninitialize a table, respectively. If memory allocation
* failed, false is returned that the table is uninitialized. */ * failed, false is returned that the table is uninitialized. */
bool upb_inttable_init2(upb_inttable *table, upb_ctype_t ctype, upb_alloc *a); bool upb_inttable_init(upb_inttable *table, upb_arena *a);
bool upb_strtable_init2(upb_strtable *table, upb_ctype_t ctype, bool upb_strtable_init(upb_strtable *table, size_t expected_size, upb_arena *a);
size_t expected_size, upb_alloc *a);
void upb_inttable_uninit2(upb_inttable *table, upb_alloc *a);
void upb_strtable_uninit2(upb_strtable *table, upb_alloc *a);
UPB_INLINE bool upb_inttable_init(upb_inttable *table, upb_ctype_t ctype) {
return upb_inttable_init2(table, ctype, &upb_alloc_global);
}
UPB_INLINE bool upb_strtable_init(upb_strtable *table, upb_ctype_t ctype) {
return upb_strtable_init2(table, ctype, 4, &upb_alloc_global);
}
UPB_INLINE void upb_inttable_uninit(upb_inttable *table) {
upb_inttable_uninit2(table, &upb_alloc_global);
}
UPB_INLINE void upb_strtable_uninit(upb_strtable *table) {
upb_strtable_uninit2(table, &upb_alloc_global);
}
/* Returns the number of values in the table. */ /* Returns the number of values in the table. */
size_t upb_inttable_count(const upb_inttable *t); size_t upb_inttable_count(const upb_inttable *t);
@ -818,12 +889,6 @@ UPB_INLINE size_t upb_strtable_count(const upb_strtable *t) {
return t->t.count; return t->t.count;
} }
void upb_inttable_packedsize(const upb_inttable *t, size_t *size);
void upb_strtable_packedsize(const upb_strtable *t, size_t *size);
upb_inttable *upb_inttable_pack(const upb_inttable *t, void *p, size_t *ofs,
size_t size);
upb_strtable *upb_strtable_pack(const upb_strtable *t, void *p, size_t *ofs,
size_t size);
void upb_strtable_clear(upb_strtable *t); void upb_strtable_clear(upb_strtable *t);
/* Inserts the given key into the hashtable with the given value. The key must /* Inserts the given key into the hashtable with the given value. The key must
@ -833,26 +898,10 @@ void upb_strtable_clear(upb_strtable *t);
* *
* If a table resize was required but memory allocation failed, false is * If a table resize was required but memory allocation failed, false is
* returned and the table is unchanged. */ * returned and the table is unchanged. */
bool upb_inttable_insert2(upb_inttable *t, uintptr_t key, upb_value val, bool upb_inttable_insert(upb_inttable *t, uintptr_t key, upb_value val,
upb_alloc *a); upb_arena *a);
bool upb_strtable_insert3(upb_strtable *t, const char *key, size_t len, bool upb_strtable_insert(upb_strtable *t, const char *key, size_t len,
upb_value val, upb_alloc *a); upb_value val, upb_arena *a);
UPB_INLINE bool upb_inttable_insert(upb_inttable *t, uintptr_t key,
upb_value val) {
return upb_inttable_insert2(t, key, val, &upb_alloc_global);
}
UPB_INLINE bool upb_strtable_insert2(upb_strtable *t, const char *key,
size_t len, upb_value val) {
return upb_strtable_insert3(t, key, len, val, &upb_alloc_global);
}
/* For NULL-terminated strings. */
UPB_INLINE bool upb_strtable_insert(upb_strtable *t, const char *key,
upb_value val) {
return upb_strtable_insert2(t, key, strlen(key), val);
}
/* Looks up key in this table, returning "true" if the key was found. /* Looks up key in this table, returning "true" if the key was found.
* If v is non-NULL, copies the value for this key into *v. */ * If v is non-NULL, copies the value for this key into *v. */
@ -869,74 +918,21 @@ UPB_INLINE bool upb_strtable_lookup(const upb_strtable *t, const char *key,
/* Removes an item from the table. Returns true if the remove was successful, /* Removes an item from the table. Returns true if the remove was successful,
* and stores the removed item in *val if non-NULL. */ * and stores the removed item in *val if non-NULL. */
bool upb_inttable_remove(upb_inttable *t, uintptr_t key, upb_value *val); bool upb_inttable_remove(upb_inttable *t, uintptr_t key, upb_value *val);
bool upb_strtable_remove3(upb_strtable *t, const char *key, size_t len, bool upb_strtable_remove(upb_strtable *t, const char *key, size_t len,
upb_value *val, upb_alloc *alloc); upb_value *val);
UPB_INLINE bool upb_strtable_remove2(upb_strtable *t, const char *key,
size_t len, upb_value *val) {
return upb_strtable_remove3(t, key, len, val, &upb_alloc_global);
}
/* For NULL-terminated strings. */
UPB_INLINE bool upb_strtable_remove(upb_strtable *t, const char *key,
upb_value *v) {
return upb_strtable_remove2(t, key, strlen(key), v);
}
/* Updates an existing entry in an inttable. If the entry does not exist, /* Updates an existing entry in an inttable. If the entry does not exist,
* returns false and does nothing. Unlike insert/remove, this does not * returns false and does nothing. Unlike insert/remove, this does not
* invalidate iterators. */ * invalidate iterators. */
bool upb_inttable_replace(upb_inttable *t, uintptr_t key, upb_value val); bool upb_inttable_replace(upb_inttable *t, uintptr_t key, upb_value val);
/* Convenience routines for inttables with pointer keys. */
bool upb_inttable_insertptr2(upb_inttable *t, const void *key, upb_value val,
upb_alloc *a);
bool upb_inttable_removeptr(upb_inttable *t, const void *key, upb_value *val);
bool upb_inttable_lookupptr(
const upb_inttable *t, const void *key, upb_value *val);
UPB_INLINE bool upb_inttable_insertptr(upb_inttable *t, const void *key,
upb_value val) {
return upb_inttable_insertptr2(t, key, val, &upb_alloc_global);
}
/* Optimizes the table for the current set of entries, for both memory use and /* Optimizes the table for the current set of entries, for both memory use and
* lookup time. Client should call this after all entries have been inserted; * lookup time. Client should call this after all entries have been inserted;
* inserting more entries is legal, but will likely require a table resize. */ * inserting more entries is legal, but will likely require a table resize. */
void upb_inttable_compact2(upb_inttable *t, upb_alloc *a); void upb_inttable_compact(upb_inttable *t, upb_arena *a);
UPB_INLINE void upb_inttable_compact(upb_inttable *t) {
upb_inttable_compact2(t, &upb_alloc_global);
}
/* A special-case inlinable version of the lookup routine for 32-bit
* integers. */
UPB_INLINE bool upb_inttable_lookup32(const upb_inttable *t, uint32_t key,
upb_value *v) {
*v = upb_value_int32(0); /* Silence compiler warnings. */
if (key < t->array_size) {
upb_tabval arrval = t->array[key];
if (upb_arrhas(arrval)) {
_upb_value_setval(v, arrval.val);
return true;
} else {
return false;
}
} else {
const upb_tabent *e;
if (t->t.entries == NULL) return false;
for (e = upb_getentry(&t->t, upb_inthash(key)); true; e = e->next) {
if ((uint32_t)e->key == key) {
_upb_value_setval(v, e->val.val);
return true;
}
if (e->next == NULL) return false;
}
}
}
/* Exposed for testing only. */ /* Exposed for testing only. */
bool upb_strtable_resize(upb_strtable *t, size_t size_lg2, upb_alloc *a); bool upb_strtable_resize(upb_strtable *t, size_t size_lg2, upb_arena *a);
/* Iterators ******************************************************************/ /* Iterators ******************************************************************/
@ -1032,10 +1028,6 @@ bool upb_inttable_iter_isequal(const upb_inttable_iter *i1,
extern "C" { extern "C" {
#endif #endif
#define PTR_AT(msg, ofs, type) (type*)((const char*)msg + ofs)
typedef void upb_msg;
/** upb_msglayout *************************************************************/ /** upb_msglayout *************************************************************/
/* upb_msglayout represents the memory layout of a given upb_msgdef. The /* upb_msglayout represents the memory layout of a given upb_msgdef. The
@ -1070,7 +1062,7 @@ typedef struct {
_upb_field_parser *field_parser; _upb_field_parser *field_parser;
} _upb_fasttable_entry; } _upb_fasttable_entry;
typedef struct upb_msglayout { struct upb_msglayout {
const struct upb_msglayout *const* submsgs; const struct upb_msglayout *const* submsgs;
const upb_msglayout_field *fields; const upb_msglayout_field *fields;
/* Must be aligned to sizeof(void*). Doesn't include internal members like /* Must be aligned to sizeof(void*). Doesn't include internal members like
@ -1082,7 +1074,7 @@ typedef struct upb_msglayout {
/* To constant-initialize the tables of variable length, we need a flexible /* To constant-initialize the tables of variable length, we need a flexible
* array member, and we need to compile in C99 mode. */ * array member, and we need to compile in C99 mode. */
_upb_fasttable_entry fasttable[]; _upb_fasttable_entry fasttable[];
} upb_msglayout; };
/** upb_msg *******************************************************************/ /** upb_msg *******************************************************************/
@ -1137,21 +1129,18 @@ void _upb_msg_discardunknown_shallow(upb_msg *msg);
bool _upb_msg_addunknown(upb_msg *msg, const char *data, size_t len, bool _upb_msg_addunknown(upb_msg *msg, const char *data, size_t len,
upb_arena *arena); upb_arena *arena);
/* Returns a reference to the message's unknown data. */
const char *upb_msg_getunknown(const upb_msg *msg, size_t *len);
/** Hasbit access *************************************************************/ /** Hasbit access *************************************************************/
UPB_INLINE bool _upb_hasbit(const upb_msg *msg, size_t idx) { UPB_INLINE bool _upb_hasbit(const upb_msg *msg, size_t idx) {
return (*PTR_AT(msg, idx / 8, const char) & (1 << (idx % 8))) != 0; return (*UPB_PTR_AT(msg, idx / 8, const char) & (1 << (idx % 8))) != 0;
} }
UPB_INLINE void _upb_sethas(const upb_msg *msg, size_t idx) { UPB_INLINE void _upb_sethas(const upb_msg *msg, size_t idx) {
(*PTR_AT(msg, idx / 8, char)) |= (char)(1 << (idx % 8)); (*UPB_PTR_AT(msg, idx / 8, char)) |= (char)(1 << (idx % 8));
} }
UPB_INLINE void _upb_clearhas(const upb_msg *msg, size_t idx) { UPB_INLINE void _upb_clearhas(const upb_msg *msg, size_t idx) {
(*PTR_AT(msg, idx / 8, char)) &= (char)(~(1 << (idx % 8))); (*UPB_PTR_AT(msg, idx / 8, char)) &= (char)(~(1 << (idx % 8)));
} }
UPB_INLINE size_t _upb_msg_hasidx(const upb_msglayout_field *f) { UPB_INLINE size_t _upb_msg_hasidx(const upb_msglayout_field *f) {
@ -1177,11 +1166,11 @@ UPB_INLINE void _upb_clearhas_field(const upb_msg *msg,
/** Oneof case access *********************************************************/ /** Oneof case access *********************************************************/
UPB_INLINE uint32_t *_upb_oneofcase(upb_msg *msg, size_t case_ofs) { UPB_INLINE uint32_t *_upb_oneofcase(upb_msg *msg, size_t case_ofs) {
return PTR_AT(msg, case_ofs, uint32_t); return UPB_PTR_AT(msg, case_ofs, uint32_t);
} }
UPB_INLINE uint32_t _upb_getoneofcase(const void *msg, size_t case_ofs) { UPB_INLINE uint32_t _upb_getoneofcase(const void *msg, size_t case_ofs) {
return *PTR_AT(msg, case_ofs, uint32_t); return *UPB_PTR_AT(msg, case_ofs, uint32_t);
} }
UPB_INLINE size_t _upb_oneofcase_ofs(const upb_msglayout_field *f) { UPB_INLINE size_t _upb_oneofcase_ofs(const upb_msglayout_field *f) {
@ -1200,7 +1189,7 @@ UPB_INLINE uint32_t _upb_getoneofcase_field(const upb_msg *msg,
} }
UPB_INLINE bool _upb_has_submsg_nohasbit(const upb_msg *msg, size_t ofs) { UPB_INLINE bool _upb_has_submsg_nohasbit(const upb_msg *msg, size_t ofs) {
return *PTR_AT(msg, ofs, const upb_msg*) != NULL; return *UPB_PTR_AT(msg, ofs, const upb_msg*) != NULL;
} }
UPB_INLINE bool _upb_isrepeated(const upb_msglayout_field *field) { UPB_INLINE bool _upb_isrepeated(const upb_msglayout_field *field) {
@ -1277,7 +1266,7 @@ UPB_INLINE bool _upb_array_resize(upb_array *arr, size_t size,
UPB_INLINE const void *_upb_array_accessor(const void *msg, size_t ofs, UPB_INLINE const void *_upb_array_accessor(const void *msg, size_t ofs,
size_t *size) { size_t *size) {
const upb_array *arr = *PTR_AT(msg, ofs, const upb_array*); const upb_array *arr = *UPB_PTR_AT(msg, ofs, const upb_array*);
if (arr) { if (arr) {
if (size) *size = arr->len; if (size) *size = arr->len;
return _upb_array_constptr(arr); return _upb_array_constptr(arr);
@ -1289,7 +1278,7 @@ UPB_INLINE const void *_upb_array_accessor(const void *msg, size_t ofs,
UPB_INLINE void *_upb_array_mutable_accessor(void *msg, size_t ofs, UPB_INLINE void *_upb_array_mutable_accessor(void *msg, size_t ofs,
size_t *size) { size_t *size) {
upb_array *arr = *PTR_AT(msg, ofs, upb_array*); upb_array *arr = *UPB_PTR_AT(msg, ofs, upb_array*);
if (arr) { if (arr) {
if (size) *size = arr->len; if (size) *size = arr->len;
return _upb_array_ptr(arr); return _upb_array_ptr(arr);
@ -1302,7 +1291,7 @@ UPB_INLINE void *_upb_array_mutable_accessor(void *msg, size_t ofs,
UPB_INLINE void *_upb_array_resize_accessor2(void *msg, size_t ofs, size_t size, UPB_INLINE void *_upb_array_resize_accessor2(void *msg, size_t ofs, size_t size,
int elem_size_lg2, int elem_size_lg2,
upb_arena *arena) { upb_arena *arena) {
upb_array **arr_ptr = PTR_AT(msg, ofs, upb_array *); upb_array **arr_ptr = UPB_PTR_AT(msg, ofs, upb_array *);
upb_array *arr = *arr_ptr; upb_array *arr = *arr_ptr;
if (!arr || arr->size < size) { if (!arr || arr->size < size) {
return _upb_array_resize_fallback(arr_ptr, size, elem_size_lg2, arena); return _upb_array_resize_fallback(arr_ptr, size, elem_size_lg2, arena);
@ -1315,7 +1304,7 @@ UPB_INLINE bool _upb_array_append_accessor2(void *msg, size_t ofs,
int elem_size_lg2, int elem_size_lg2,
const void *value, const void *value,
upb_arena *arena) { upb_arena *arena) {
upb_array **arr_ptr = PTR_AT(msg, ofs, upb_array *); upb_array **arr_ptr = UPB_PTR_AT(msg, ofs, upb_array *);
size_t elem_size = 1 << elem_size_lg2; size_t elem_size = 1 << elem_size_lg2;
upb_array *arr = *arr_ptr; upb_array *arr = *arr_ptr;
void *ptr; void *ptr;
@ -1323,7 +1312,7 @@ UPB_INLINE bool _upb_array_append_accessor2(void *msg, size_t ofs,
return _upb_array_append_fallback(arr_ptr, value, elem_size_lg2, arena); return _upb_array_append_fallback(arr_ptr, value, elem_size_lg2, arena);
} }
ptr = _upb_array_ptr(arr); ptr = _upb_array_ptr(arr);
memcpy(PTR_AT(ptr, arr->len * elem_size, char), value, elem_size); memcpy(UPB_PTR_AT(ptr, arr->len * elem_size, char), value, elem_size);
arr->len++; arr->len++;
return true; return true;
} }
@ -1470,20 +1459,19 @@ UPB_INLINE void* _upb_map_next(const upb_map *map, size_t *iter) {
} }
UPB_INLINE bool _upb_map_set(upb_map *map, const void *key, size_t key_size, UPB_INLINE bool _upb_map_set(upb_map *map, const void *key, size_t key_size,
void *val, size_t val_size, upb_arena *arena) { void *val, size_t val_size, upb_arena *a) {
upb_strview strkey = _upb_map_tokey(key, key_size); upb_strview strkey = _upb_map_tokey(key, key_size);
upb_value tabval = {0}; upb_value tabval = {0};
if (!_upb_map_tovalue(val, val_size, &tabval, arena)) return false; if (!_upb_map_tovalue(val, val_size, &tabval, a)) return false;
upb_alloc *a = upb_arena_alloc(arena);
/* TODO(haberman): add overwrite operation to minimize number of lookups. */ /* TODO(haberman): add overwrite operation to minimize number of lookups. */
upb_strtable_remove3(&map->table, strkey.data, strkey.size, NULL, a); upb_strtable_remove(&map->table, strkey.data, strkey.size, NULL);
return upb_strtable_insert3(&map->table, strkey.data, strkey.size, tabval, a); return upb_strtable_insert(&map->table, strkey.data, strkey.size, tabval, a);
} }
UPB_INLINE bool _upb_map_delete(upb_map *map, const void *key, size_t key_size) { UPB_INLINE bool _upb_map_delete(upb_map *map, const void *key, size_t key_size) {
upb_strview k = _upb_map_tokey(key, key_size); upb_strview k = _upb_map_tokey(key, key_size);
return upb_strtable_remove3(&map->table, k.data, k.size, NULL, NULL); return upb_strtable_remove(&map->table, k.data, k.size, NULL);
} }
UPB_INLINE void _upb_map_clear(upb_map *map) { UPB_INLINE void _upb_map_clear(upb_map *map) {
@ -1515,7 +1503,7 @@ UPB_INLINE void *_upb_msg_map_next(const upb_msg *msg, size_t ofs,
UPB_INLINE bool _upb_msg_map_set(upb_msg *msg, size_t ofs, const void *key, UPB_INLINE bool _upb_msg_map_set(upb_msg *msg, size_t ofs, const void *key,
size_t key_size, void *val, size_t val_size, size_t key_size, void *val, size_t val_size,
upb_arena *arena) { upb_arena *arena) {
upb_map **map = PTR_AT(msg, ofs, upb_map *); upb_map **map = UPB_PTR_AT(msg, ofs, upb_map *);
if (!*map) { if (!*map) {
*map = _upb_map_new(arena, key_size, val_size); *map = _upb_map_new(arena, key_size, val_size);
} }
@ -1548,8 +1536,7 @@ UPB_INLINE void _upb_msg_map_key(const void* msg, void* key, size_t size) {
UPB_INLINE void _upb_msg_map_value(const void* msg, void* val, size_t size) { UPB_INLINE void _upb_msg_map_value(const void* msg, void* val, size_t size) {
const upb_tabent *ent = (const upb_tabent*)msg; const upb_tabent *ent = (const upb_tabent*)msg;
upb_value v; upb_value v = {ent->val.val};
_upb_value_setval(&v, ent->val.val);
_upb_map_fromvalue(v, val, size); _upb_map_fromvalue(v, val, size);
} }
@ -1612,55 +1599,14 @@ UPB_INLINE bool _upb_sortedmap_next(_upb_mapsorter *s, const upb_map *map,
return true; return true;
} }
#undef PTR_AT
#ifdef __cplusplus
} /* extern "C" */
#endif
#endif /* UPB_MSG_H_ */
/* Must be last. */
#ifdef __cplusplus
extern "C" {
#endif
enum {
/* If set, strings will alias the input buffer instead of copying into the
* arena. */
UPB_DECODE_ALIAS = 1,
};
#define UPB_DECODE_MAXDEPTH(depth) ((depth) << 16)
bool _upb_decode(const char *buf, size_t size, upb_msg *msg,
const upb_msglayout *l, upb_arena *arena, int options);
UPB_INLINE
bool upb_decode(const char *buf, size_t size, upb_msg *msg,
const upb_msglayout *l, upb_arena *arena) {
return _upb_decode(buf, size, msg, l, arena, 0);
}
#ifdef __cplusplus #ifdef __cplusplus
} /* extern "C" */ } /* extern "C" */
#endif #endif
#endif /* UPB_DECODE_H_ */ #endif /* UPB_MSG_INT_H_ */
/*
** Internal implementation details of the decoder that are shared between
** decode.c and decode_fast.c.
*/
#ifndef UPB_DECODE_INT_H_
#define UPB_DECODE_INT_H_
#include <setjmp.h>
/** upb/upb_internal.h ************************************************************/
#ifndef UPB_INT_H_ #ifndef UPB_INT_H_
#define UPB_INT_H_ #define UPB_INT_H_
@ -1670,7 +1616,10 @@ typedef struct mem_block mem_block;
struct upb_arena { struct upb_arena {
_upb_arena_head head; _upb_arena_head head;
uint32_t *cleanups; /* Stores cleanup metadata for this arena.
* - a pointer to the current cleanup counter.
* - a boolean indicating if there is an unowned initial block. */
uintptr_t cleanup_metadata;
/* Allocator to allocate arena blocks. We are responsible for freeing these /* Allocator to allocate arena blocks. We are responsible for freeing these
* when we are destroyed. */ * when we are destroyed. */
@ -1792,10 +1741,11 @@ bool decode_isdone(upb_decstate *d, const char **ptr) {
} }
} }
#if UPB_FASTTABLE
UPB_INLINE UPB_INLINE
const char *fastdecode_tagdispatch(upb_decstate *d, const char *ptr, const char *fastdecode_tagdispatch(upb_decstate *d, const char *ptr,
upb_msg *msg, intptr_t table, upb_msg *msg, intptr_t table,
uint64_t hasbits, uint32_t tag) { uint64_t hasbits, uint64_t tag) {
const upb_msglayout *table_p = decode_totablep(table); const upb_msglayout *table_p = decode_totablep(table);
uint8_t mask = table; uint8_t mask = table;
uint64_t data; uint64_t data;
@ -1803,8 +1753,10 @@ const char *fastdecode_tagdispatch(upb_decstate *d, const char *ptr,
UPB_ASSUME((idx & 7) == 0); UPB_ASSUME((idx & 7) == 0);
idx >>= 3; idx >>= 3;
data = table_p->fasttable[idx].field_data ^ tag; data = table_p->fasttable[idx].field_data ^ tag;
return table_p->fasttable[idx].field_parser(d, ptr, msg, table, hasbits, data); UPB_MUSTTAIL return table_p->fasttable[idx].field_parser(d, ptr, msg, table,
hasbits, data);
} }
#endif
UPB_INLINE uint32_t fastdecode_loadtag(const char* ptr) { UPB_INLINE uint32_t fastdecode_loadtag(const char* ptr) {
uint16_t tag; uint16_t tag;
@ -1837,9 +1789,11 @@ UPB_INLINE void decode_poplimit(upb_decstate *d, const char *ptr,
#endif /* UPB_DECODE_INT_H_ */ #endif /* UPB_DECODE_INT_H_ */
/** upb/encode.h ************************************************************/
/* /*
** upb_encode: parsing into a upb_msg using a upb_msglayout. * upb_encode: parsing into a upb_msg using a upb_msglayout.
*/ */
#ifndef UPB_ENCODE_H_ #ifndef UPB_ENCODE_H_
#define UPB_ENCODE_H_ #define UPB_ENCODE_H_
@ -1880,6 +1834,8 @@ UPB_INLINE char *upb_encode(const void *msg, const upb_msglayout *l,
#endif #endif
#endif /* UPB_ENCODE_H_ */ #endif /* UPB_ENCODE_H_ */
/** upb/decode_fast.h ************************************************************/
// These are the specialized field parser functions for the fast parser. // These are the specialized field parser functions for the fast parser.
// Generated tables will refer to these by name. // Generated tables will refer to these by name.
// //
@ -2005,7 +1961,8 @@ TAGBYTES(r)
#undef UPB_PARSE_PARAMS #undef UPB_PARSE_PARAMS
#endif /* UPB_DECODE_FAST_H_ */ #endif /* UPB_DECODE_FAST_H_ */
/* This file was generated by upbc (the upb compiler) from the input
/** google/protobuf/descriptor.upb.h ************************************************************//* This file was generated by upbc (the upb compiler) from the input
* file: * file:
* *
* google/protobuf/descriptor.proto * google/protobuf/descriptor.proto
@ -3884,18 +3841,20 @@ UPB_INLINE void google_protobuf_GeneratedCodeInfo_Annotation_set_end(google_prot
#endif /* GOOGLE_PROTOBUF_DESCRIPTOR_PROTO_UPB_H_ */ #endif /* GOOGLE_PROTOBUF_DESCRIPTOR_PROTO_UPB_H_ */
/** upb/def.h ************************************************************/
/* /*
** Defs are upb's internal representation of the constructs that can appear * Defs are upb's internal representation of the constructs that can appear
** in a .proto file: * in a .proto file:
** *
** - upb_msgdef: describes a "message" construct. * - upb_msgdef: describes a "message" construct.
** - upb_fielddef: describes a message field. * - upb_fielddef: describes a message field.
** - upb_filedef: describes a .proto file and its defs. * - upb_filedef: describes a .proto file and its defs.
** - upb_enumdef: describes an enum. * - upb_enumdef: describes an enum.
** - upb_oneofdef: describes a oneof. * - upb_oneofdef: describes a oneof.
** *
** TODO: definitions of services. * TODO: definitions of services.
*/ */
#ifndef UPB_DEF_H_ #ifndef UPB_DEF_H_
#define UPB_DEF_H_ #define UPB_DEF_H_
@ -3991,9 +3950,6 @@ const upb_msgdef *upb_fielddef_msgsubdef(const upb_fielddef *f);
const upb_enumdef *upb_fielddef_enumsubdef(const upb_fielddef *f); const upb_enumdef *upb_fielddef_enumsubdef(const upb_fielddef *f);
const upb_msglayout_field *upb_fielddef_layout(const upb_fielddef *f); const upb_msglayout_field *upb_fielddef_layout(const upb_fielddef *f);
/* Internal only. */
uint32_t upb_fielddef_selectorbase(const upb_fielddef *f);
/* upb_oneofdef ***************************************************************/ /* upb_oneofdef ***************************************************************/
typedef upb_inttable_iter upb_oneof_iter; typedef upb_inttable_iter upb_oneof_iter;
@ -4078,10 +4034,6 @@ UPB_INLINE const upb_fielddef *upb_msgdef_ntofz(const upb_msgdef *m,
return upb_msgdef_ntof(m, name, strlen(name)); return upb_msgdef_ntof(m, name, strlen(name));
} }
/* Internal-only. */
size_t upb_msgdef_selectorcount(const upb_msgdef *m);
uint32_t upb_msgdef_submsgfieldcount(const upb_msgdef *m);
/* Lookup of either field or oneof by name. Returns whether either was found. /* Lookup of either field or oneof by name. Returns whether either was found.
* If the return is true, then the found def will be set, and the non-found * If the return is true, then the found def will be set, and the non-found
* one set to NULL. */ * one set to NULL. */
@ -4197,6 +4149,7 @@ bool _upb_symtab_loaddefinit(upb_symtab *s, const upb_def_init *init);
#endif /* UPB_DEF_H_ */ #endif /* UPB_DEF_H_ */
/** upb/reflection.h ************************************************************/
#ifndef UPB_REFLECTION_H_ #ifndef UPB_REFLECTION_H_
#define UPB_REFLECTION_H_ #define UPB_REFLECTION_H_
@ -4278,17 +4231,9 @@ bool upb_msg_next(const upb_msg *msg, const upb_msgdef *m,
const upb_symtab *ext_pool, const upb_fielddef **f, const upb_symtab *ext_pool, const upb_fielddef **f,
upb_msgval *val, size_t *iter); upb_msgval *val, size_t *iter);
/* Adds unknown data (serialized protobuf data) to the given message. The data
* is copied into the message instance. */
void upb_msg_addunknown(upb_msg *msg, const char *data, size_t len,
upb_arena *arena);
/* Clears all unknown field data from this message and all submessages. */ /* Clears all unknown field data from this message and all submessages. */
bool upb_msg_discardunknown(upb_msg *msg, const upb_msgdef *m, int maxdepth); bool upb_msg_discardunknown(upb_msg *msg, const upb_msgdef *m, int maxdepth);
/* Returns a reference to the message's unknown data. */
const char *upb_msg_getunknown(const upb_msg *msg, size_t *len);
/** upb_array *****************************************************************/ /** upb_array *****************************************************************/
/* Creates a new array on the given arena that holds elements of this type. */ /* Creates a new array on the given arena that holds elements of this type. */
@ -4370,6 +4315,7 @@ void upb_mapiter_setvalue(upb_map *map, size_t iter, upb_msgval value);
#endif /* UPB_REFLECTION_H_ */ #endif /* UPB_REFLECTION_H_ */
/** upb/json_decode.h ************************************************************/
#ifndef UPB_JSONDECODE_H_ #ifndef UPB_JSONDECODE_H_
#define UPB_JSONDECODE_H_ #define UPB_JSONDECODE_H_
@ -4392,6 +4338,7 @@ bool upb_json_decode(const char *buf, size_t size, upb_msg *msg,
#endif /* UPB_JSONDECODE_H_ */ #endif /* UPB_JSONDECODE_H_ */
/** upb/json_encode.h ************************************************************/
#ifndef UPB_JSONENCODE_H_ #ifndef UPB_JSONENCODE_H_
#define UPB_JSONENCODE_H_ #define UPB_JSONENCODE_H_
@ -4426,27 +4373,39 @@ size_t upb_json_encode(const upb_msg *msg, const upb_msgdef *m,
#endif #endif
#endif /* UPB_JSONENCODE_H_ */ #endif /* UPB_JSONENCODE_H_ */
/** upb/port_undef.inc ************************************************************/
/* See port_def.inc. This should #undef all macros #defined there. */ /* See port_def.inc. This should #undef all macros #defined there. */
#undef UPB_MAPTYPE_STRING
#undef UPB_SIZE #undef UPB_SIZE
#undef UPB_PTR_AT #undef UPB_PTR_AT
#undef UPB_READ_ONEOF #undef UPB_READ_ONEOF
#undef UPB_WRITE_ONEOF #undef UPB_WRITE_ONEOF
#undef UPB_MAPTYPE_STRING
#undef UPB_INLINE #undef UPB_INLINE
#undef UPB_ALIGN_UP #undef UPB_ALIGN_UP
#undef UPB_ALIGN_DOWN #undef UPB_ALIGN_DOWN
#undef UPB_ALIGN_MALLOC #undef UPB_ALIGN_MALLOC
#undef UPB_ALIGN_OF #undef UPB_ALIGN_OF
#undef UPB_LIKELY
#undef UPB_UNLIKELY
#undef UPB_FORCEINLINE #undef UPB_FORCEINLINE
#undef UPB_NOINLINE #undef UPB_NOINLINE
#undef UPB_NORETURN #undef UPB_NORETURN
#undef UPB_PRINTF
#undef UPB_MAX #undef UPB_MAX
#undef UPB_MIN #undef UPB_MIN
#undef UPB_UNUSED #undef UPB_UNUSED
#undef UPB_ASSUME #undef UPB_ASSUME
#undef UPB_ASSERT #undef UPB_ASSERT
#undef UPB_UNREACHABLE #undef UPB_UNREACHABLE
#undef UPB_SETJMP
#undef UPB_LONGJMP
#undef UPB_PTRADD
#undef UPB_MUSTTAIL
#undef UPB_FASTTABLE_SUPPORTED
#undef UPB_FASTTABLE
#undef UPB_FASTTABLE_INIT
#undef UPB_POISON_MEMORY_REGION #undef UPB_POISON_MEMORY_REGION
#undef UPB_UNPOISON_MEMORY_REGION #undef UPB_UNPOISON_MEMORY_REGION
#undef UPB_ASAN #undef UPB_ASAN

@ -95,6 +95,7 @@ nobase_include_HEADERS = \
google/protobuf/empty.pb.h \ google/protobuf/empty.pb.h \
google/protobuf/extension_set.h \ google/protobuf/extension_set.h \
google/protobuf/extension_set_inl.h \ google/protobuf/extension_set_inl.h \
google/protobuf/field_access_listener.h \
google/protobuf/field_mask.pb.h \ google/protobuf/field_mask.pb.h \
google/protobuf/generated_enum_reflection.h \ google/protobuf/generated_enum_reflection.h \
google/protobuf/generated_enum_util.h \ google/protobuf/generated_enum_util.h \
@ -203,6 +204,7 @@ libprotobuf_lite_la_SOURCES = \
google/protobuf/arena.cc \ google/protobuf/arena.cc \
google/protobuf/arenastring.cc \ google/protobuf/arenastring.cc \
google/protobuf/extension_set.cc \ google/protobuf/extension_set.cc \
google/protobuf/field_access_listener.cc \
google/protobuf/generated_enum_util.cc \ google/protobuf/generated_enum_util.cc \
google/protobuf/generated_message_util.cc \ google/protobuf/generated_message_util.cc \
google/protobuf/generated_message_table_driven_lite.h \ google/protobuf/generated_message_table_driven_lite.h \

@ -229,4 +229,4 @@ Usage
The complete documentation for Protocol Buffers is available via the The complete documentation for Protocol Buffers is available via the
web at: web at:
https://developers.google.com/protocol-buffers/ https://developers.google.com/protocol-buffers/

@ -215,7 +215,7 @@ failure:
(void) cached_has_bits; (void) cached_has_bits;
// string type_url = 1; // string type_url = 1;
if (!this->type_url().empty()) { if (!this->_internal_type_url().empty()) {
::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::VerifyUtf8String( ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::VerifyUtf8String(
this->_internal_type_url().data(), static_cast<int>(this->_internal_type_url().length()), this->_internal_type_url().data(), static_cast<int>(this->_internal_type_url().length()),
::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::SERIALIZE, ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::SERIALIZE,
@ -225,7 +225,7 @@ failure:
} }
// bytes value = 2; // bytes value = 2;
if (!this->value().empty()) { if (!this->_internal_value().empty()) {
target = stream->WriteBytesMaybeAliased( target = stream->WriteBytesMaybeAliased(
2, this->_internal_value(), target); 2, this->_internal_value(), target);
} }
@ -247,14 +247,14 @@ size_t Any::ByteSizeLong() const {
(void) cached_has_bits; (void) cached_has_bits;
// string type_url = 1; // string type_url = 1;
if (!this->type_url().empty()) { if (!this->_internal_type_url().empty()) {
total_size += 1 + total_size += 1 +
::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::StringSize( ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::StringSize(
this->_internal_type_url()); this->_internal_type_url());
} }
// bytes value = 2; // bytes value = 2;
if (!this->value().empty()) { if (!this->_internal_value().empty()) {
total_size += 1 + total_size += 1 +
::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::BytesSize( ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::BytesSize(
this->_internal_value()); this->_internal_value());
@ -288,10 +288,10 @@ void Any::MergeFrom(const Any& from) {
::PROTOBUF_NAMESPACE_ID::uint32 cached_has_bits = 0; ::PROTOBUF_NAMESPACE_ID::uint32 cached_has_bits = 0;
(void) cached_has_bits; (void) cached_has_bits;
if (!from.type_url().empty()) { if (!from._internal_type_url().empty()) {
_internal_set_type_url(from._internal_type_url()); _internal_set_type_url(from._internal_type_url());
} }
if (!from.value().empty()) { if (!from._internal_value().empty()) {
_internal_set_value(from._internal_value()); _internal_set_value(from._internal_value());
} }
_internal_metadata_.MergeFrom<::PROTOBUF_NAMESPACE_ID::UnknownFieldSet>(from._internal_metadata_); _internal_metadata_.MergeFrom<::PROTOBUF_NAMESPACE_ID::UnknownFieldSet>(from._internal_metadata_);

@ -372,7 +372,7 @@ failure:
(void) cached_has_bits; (void) cached_has_bits;
// string name = 1; // string name = 1;
if (!this->name().empty()) { if (!this->_internal_name().empty()) {
::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::VerifyUtf8String( ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::VerifyUtf8String(
this->_internal_name().data(), static_cast<int>(this->_internal_name().length()), this->_internal_name().data(), static_cast<int>(this->_internal_name().length()),
::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::SERIALIZE, ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::SERIALIZE,
@ -398,7 +398,7 @@ failure:
} }
// string version = 4; // string version = 4;
if (!this->version().empty()) { if (!this->_internal_version().empty()) {
::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::VerifyUtf8String( ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::VerifyUtf8String(
this->_internal_version().data(), static_cast<int>(this->_internal_version().length()), this->_internal_version().data(), static_cast<int>(this->_internal_version().length()),
::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::SERIALIZE, ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::SERIALIZE,
@ -408,7 +408,7 @@ failure:
} }
// .google.protobuf.SourceContext source_context = 5; // .google.protobuf.SourceContext source_context = 5;
if (this->has_source_context()) { if (this->_internal_has_source_context()) {
target = stream->EnsureSpace(target); target = stream->EnsureSpace(target);
target = ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite:: target = ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::
InternalWriteMessage( InternalWriteMessage(
@ -424,7 +424,7 @@ failure:
} }
// .google.protobuf.Syntax syntax = 7; // .google.protobuf.Syntax syntax = 7;
if (this->syntax() != 0) { if (this->_internal_syntax() != 0) {
target = stream->EnsureSpace(target); target = stream->EnsureSpace(target);
target = ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::WriteEnumToArray( target = ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::WriteEnumToArray(
7, this->_internal_syntax(), target); 7, this->_internal_syntax(), target);
@ -468,28 +468,28 @@ size_t Api::ByteSizeLong() const {
} }
// string name = 1; // string name = 1;
if (!this->name().empty()) { if (!this->_internal_name().empty()) {
total_size += 1 + total_size += 1 +
::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::StringSize( ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::StringSize(
this->_internal_name()); this->_internal_name());
} }
// string version = 4; // string version = 4;
if (!this->version().empty()) { if (!this->_internal_version().empty()) {
total_size += 1 + total_size += 1 +
::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::StringSize( ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::StringSize(
this->_internal_version()); this->_internal_version());
} }
// .google.protobuf.SourceContext source_context = 5; // .google.protobuf.SourceContext source_context = 5;
if (this->has_source_context()) { if (this->_internal_has_source_context()) {
total_size += 1 + total_size += 1 +
::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::MessageSize( ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::MessageSize(
*source_context_); *source_context_);
} }
// .google.protobuf.Syntax syntax = 7; // .google.protobuf.Syntax syntax = 7;
if (this->syntax() != 0) { if (this->_internal_syntax() != 0) {
total_size += 1 + total_size += 1 +
::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::EnumSize(this->_internal_syntax()); ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::EnumSize(this->_internal_syntax());
} }
@ -525,16 +525,16 @@ void Api::MergeFrom(const Api& from) {
methods_.MergeFrom(from.methods_); methods_.MergeFrom(from.methods_);
options_.MergeFrom(from.options_); options_.MergeFrom(from.options_);
mixins_.MergeFrom(from.mixins_); mixins_.MergeFrom(from.mixins_);
if (!from.name().empty()) { if (!from._internal_name().empty()) {
_internal_set_name(from._internal_name()); _internal_set_name(from._internal_name());
} }
if (!from.version().empty()) { if (!from._internal_version().empty()) {
_internal_set_version(from._internal_version()); _internal_set_version(from._internal_version());
} }
if (from.has_source_context()) { if (from._internal_has_source_context()) {
_internal_mutable_source_context()->PROTOBUF_NAMESPACE_ID::SourceContext::MergeFrom(from._internal_source_context()); _internal_mutable_source_context()->PROTOBUF_NAMESPACE_ID::SourceContext::MergeFrom(from._internal_source_context());
} }
if (from.syntax() != 0) { if (from._internal_syntax() != 0) {
_internal_set_syntax(from._internal_syntax()); _internal_set_syntax(from._internal_syntax());
} }
_internal_metadata_.MergeFrom<::PROTOBUF_NAMESPACE_ID::UnknownFieldSet>(from._internal_metadata_); _internal_metadata_.MergeFrom<::PROTOBUF_NAMESPACE_ID::UnknownFieldSet>(from._internal_metadata_);
@ -772,7 +772,7 @@ failure:
(void) cached_has_bits; (void) cached_has_bits;
// string name = 1; // string name = 1;
if (!this->name().empty()) { if (!this->_internal_name().empty()) {
::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::VerifyUtf8String( ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::VerifyUtf8String(
this->_internal_name().data(), static_cast<int>(this->_internal_name().length()), this->_internal_name().data(), static_cast<int>(this->_internal_name().length()),
::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::SERIALIZE, ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::SERIALIZE,
@ -782,7 +782,7 @@ failure:
} }
// string request_type_url = 2; // string request_type_url = 2;
if (!this->request_type_url().empty()) { if (!this->_internal_request_type_url().empty()) {
::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::VerifyUtf8String( ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::VerifyUtf8String(
this->_internal_request_type_url().data(), static_cast<int>(this->_internal_request_type_url().length()), this->_internal_request_type_url().data(), static_cast<int>(this->_internal_request_type_url().length()),
::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::SERIALIZE, ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::SERIALIZE,
@ -792,13 +792,13 @@ failure:
} }
// bool request_streaming = 3; // bool request_streaming = 3;
if (this->request_streaming() != 0) { if (this->_internal_request_streaming() != 0) {
target = stream->EnsureSpace(target); target = stream->EnsureSpace(target);
target = ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::WriteBoolToArray(3, this->_internal_request_streaming(), target); target = ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::WriteBoolToArray(3, this->_internal_request_streaming(), target);
} }
// string response_type_url = 4; // string response_type_url = 4;
if (!this->response_type_url().empty()) { if (!this->_internal_response_type_url().empty()) {
::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::VerifyUtf8String( ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::VerifyUtf8String(
this->_internal_response_type_url().data(), static_cast<int>(this->_internal_response_type_url().length()), this->_internal_response_type_url().data(), static_cast<int>(this->_internal_response_type_url().length()),
::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::SERIALIZE, ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::SERIALIZE,
@ -808,7 +808,7 @@ failure:
} }
// bool response_streaming = 5; // bool response_streaming = 5;
if (this->response_streaming() != 0) { if (this->_internal_response_streaming() != 0) {
target = stream->EnsureSpace(target); target = stream->EnsureSpace(target);
target = ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::WriteBoolToArray(5, this->_internal_response_streaming(), target); target = ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::WriteBoolToArray(5, this->_internal_response_streaming(), target);
} }
@ -822,7 +822,7 @@ failure:
} }
// .google.protobuf.Syntax syntax = 7; // .google.protobuf.Syntax syntax = 7;
if (this->syntax() != 0) { if (this->_internal_syntax() != 0) {
target = stream->EnsureSpace(target); target = stream->EnsureSpace(target);
target = ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::WriteEnumToArray( target = ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::WriteEnumToArray(
7, this->_internal_syntax(), target); 7, this->_internal_syntax(), target);
@ -852,38 +852,38 @@ size_t Method::ByteSizeLong() const {
} }
// string name = 1; // string name = 1;
if (!this->name().empty()) { if (!this->_internal_name().empty()) {
total_size += 1 + total_size += 1 +
::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::StringSize( ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::StringSize(
this->_internal_name()); this->_internal_name());
} }
// string request_type_url = 2; // string request_type_url = 2;
if (!this->request_type_url().empty()) { if (!this->_internal_request_type_url().empty()) {
total_size += 1 + total_size += 1 +
::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::StringSize( ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::StringSize(
this->_internal_request_type_url()); this->_internal_request_type_url());
} }
// string response_type_url = 4; // string response_type_url = 4;
if (!this->response_type_url().empty()) { if (!this->_internal_response_type_url().empty()) {
total_size += 1 + total_size += 1 +
::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::StringSize( ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::StringSize(
this->_internal_response_type_url()); this->_internal_response_type_url());
} }
// bool request_streaming = 3; // bool request_streaming = 3;
if (this->request_streaming() != 0) { if (this->_internal_request_streaming() != 0) {
total_size += 1 + 1; total_size += 1 + 1;
} }
// bool response_streaming = 5; // bool response_streaming = 5;
if (this->response_streaming() != 0) { if (this->_internal_response_streaming() != 0) {
total_size += 1 + 1; total_size += 1 + 1;
} }
// .google.protobuf.Syntax syntax = 7; // .google.protobuf.Syntax syntax = 7;
if (this->syntax() != 0) { if (this->_internal_syntax() != 0) {
total_size += 1 + total_size += 1 +
::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::EnumSize(this->_internal_syntax()); ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::EnumSize(this->_internal_syntax());
} }
@ -917,22 +917,22 @@ void Method::MergeFrom(const Method& from) {
(void) cached_has_bits; (void) cached_has_bits;
options_.MergeFrom(from.options_); options_.MergeFrom(from.options_);
if (!from.name().empty()) { if (!from._internal_name().empty()) {
_internal_set_name(from._internal_name()); _internal_set_name(from._internal_name());
} }
if (!from.request_type_url().empty()) { if (!from._internal_request_type_url().empty()) {
_internal_set_request_type_url(from._internal_request_type_url()); _internal_set_request_type_url(from._internal_request_type_url());
} }
if (!from.response_type_url().empty()) { if (!from._internal_response_type_url().empty()) {
_internal_set_response_type_url(from._internal_response_type_url()); _internal_set_response_type_url(from._internal_response_type_url());
} }
if (from.request_streaming() != 0) { if (from._internal_request_streaming() != 0) {
_internal_set_request_streaming(from._internal_request_streaming()); _internal_set_request_streaming(from._internal_request_streaming());
} }
if (from.response_streaming() != 0) { if (from._internal_response_streaming() != 0) {
_internal_set_response_streaming(from._internal_response_streaming()); _internal_set_response_streaming(from._internal_response_streaming());
} }
if (from.syntax() != 0) { if (from._internal_syntax() != 0) {
_internal_set_syntax(from._internal_syntax()); _internal_set_syntax(from._internal_syntax());
} }
_internal_metadata_.MergeFrom<::PROTOBUF_NAMESPACE_ID::UnknownFieldSet>(from._internal_metadata_); _internal_metadata_.MergeFrom<::PROTOBUF_NAMESPACE_ID::UnknownFieldSet>(from._internal_metadata_);
@ -1106,7 +1106,7 @@ failure:
(void) cached_has_bits; (void) cached_has_bits;
// string name = 1; // string name = 1;
if (!this->name().empty()) { if (!this->_internal_name().empty()) {
::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::VerifyUtf8String( ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::VerifyUtf8String(
this->_internal_name().data(), static_cast<int>(this->_internal_name().length()), this->_internal_name().data(), static_cast<int>(this->_internal_name().length()),
::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::SERIALIZE, ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::SERIALIZE,
@ -1116,7 +1116,7 @@ failure:
} }
// string root = 2; // string root = 2;
if (!this->root().empty()) { if (!this->_internal_root().empty()) {
::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::VerifyUtf8String( ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::VerifyUtf8String(
this->_internal_root().data(), static_cast<int>(this->_internal_root().length()), this->_internal_root().data(), static_cast<int>(this->_internal_root().length()),
::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::SERIALIZE, ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::SERIALIZE,
@ -1142,14 +1142,14 @@ size_t Mixin::ByteSizeLong() const {
(void) cached_has_bits; (void) cached_has_bits;
// string name = 1; // string name = 1;
if (!this->name().empty()) { if (!this->_internal_name().empty()) {
total_size += 1 + total_size += 1 +
::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::StringSize( ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::StringSize(
this->_internal_name()); this->_internal_name());
} }
// string root = 2; // string root = 2;
if (!this->root().empty()) { if (!this->_internal_root().empty()) {
total_size += 1 + total_size += 1 +
::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::StringSize( ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::StringSize(
this->_internal_root()); this->_internal_root());
@ -1183,10 +1183,10 @@ void Mixin::MergeFrom(const Mixin& from) {
::PROTOBUF_NAMESPACE_ID::uint32 cached_has_bits = 0; ::PROTOBUF_NAMESPACE_ID::uint32 cached_has_bits = 0;
(void) cached_has_bits; (void) cached_has_bits;
if (!from.name().empty()) { if (!from._internal_name().empty()) {
_internal_set_name(from._internal_name()); _internal_set_name(from._internal_name());
} }
if (!from.root().empty()) { if (!from._internal_root().empty()) {
_internal_set_root(from._internal_root()); _internal_set_root(from._internal_root());
} }
_internal_metadata_.MergeFrom<::PROTOBUF_NAMESPACE_ID::UnknownFieldSet>(from._internal_metadata_); _internal_metadata_.MergeFrom<::PROTOBUF_NAMESPACE_ID::UnknownFieldSet>(from._internal_metadata_);

@ -926,9 +926,15 @@ inline PROTOBUF_NAMESPACE_ID::SourceContext* Api::release_source_context() {
PROTOBUF_NAMESPACE_ID::SourceContext* temp = source_context_; PROTOBUF_NAMESPACE_ID::SourceContext* temp = source_context_;
source_context_ = nullptr; source_context_ = nullptr;
#ifdef PROTOBUF_FORCE_COPY_IN_RELEASE
auto* old = reinterpret_cast<::PROTOBUF_NAMESPACE_ID::MessageLite*>(temp);
temp = ::PROTOBUF_NAMESPACE_ID::internal::DuplicateIfNonNull(temp);
if (GetArenaForAllocation() == nullptr) { delete old; }
#else // PROTOBUF_FORCE_COPY_IN_RELEASE
if (GetArenaForAllocation() != nullptr) { if (GetArenaForAllocation() != nullptr) {
temp = ::PROTOBUF_NAMESPACE_ID::internal::DuplicateIfNonNull(temp); temp = ::PROTOBUF_NAMESPACE_ID::internal::DuplicateIfNonNull(temp);
} }
#endif // !PROTOBUF_FORCE_COPY_IN_RELEASE
return temp; return temp;
} }
inline PROTOBUF_NAMESPACE_ID::SourceContext* Api::unsafe_arena_release_source_context() { inline PROTOBUF_NAMESPACE_ID::SourceContext* Api::unsafe_arena_release_source_context() {

@ -256,6 +256,24 @@ void ArenaStringPtr::ClearToDefault(const LazyString& default_value,
} }
} }
const char* EpsCopyInputStream::ReadArenaString(const char* ptr,
ArenaStringPtr* s,
Arena* arena) {
GOOGLE_DCHECK(arena != nullptr);
int size = ReadSize(&ptr);
if (!ptr) return nullptr;
auto str = Arena::Create<std::string>(arena);
ptr = ReadString(ptr, size, str);
GOOGLE_PROTOBUF_PARSER_ASSERT(ptr);
TaggedPtr<std::string> res;
res.Set(str);
s->UnsafeSetTaggedPointer(res);
return ptr;
}
} // namespace internal } // namespace internal
} // namespace protobuf } // namespace protobuf

@ -59,6 +59,69 @@ namespace cpp {
using internal::WireFormat; using internal::WireFormat;
namespace {
std::string GenerateAnnotation(StringPiece substitute_template_prefix,
StringPiece prepared_template,
StringPiece substitute_template_suffix,
int field_index, StringPiece lambda_args,
StringPiece access_type) {
return strings::Substitute(
StrCat(substitute_template_prefix, prepared_template,
substitute_template_suffix),
field_index, access_type, lambda_args);
}
std::string GenerateTemplateForOneofString(const FieldDescriptor* descriptor,
StringPiece proto_ns,
StringPiece field_member) {
std::string field_pointer =
descriptor->options().ctype() == google::protobuf::FieldOptions::STRING
? "$0.GetPointer()"
: "$0";
if (descriptor->default_value_string().empty()) {
return strings::Substitute(
StrCat("_internal_has_",
google::protobuf::compiler::cpp::FieldName(descriptor),
"()? _listener_->ExtractFieldInfo(", field_pointer,
"): ::", proto_ns, "::FieldAccessListener::AddressInfo()"),
field_member);
}
if (descriptor->options().ctype() == google::protobuf::FieldOptions::STRING_PIECE) {
return StrCat("_listener_->ExtractFieldInfo(_internal_",
google::protobuf::compiler::cpp::FieldName(descriptor), "())");
}
std::string default_value_pointer =
descriptor->options().ctype() == google::protobuf::FieldOptions::STRING
? "&$1.get()"
: "&$1";
return strings::Substitute(
StrCat("_listener_->ExtractFieldInfo(_internal_has_",
google::protobuf::compiler::cpp::FieldName(descriptor), "()? ",
field_pointer, " : ", default_value_pointer, ")"),
field_member, MakeDefaultName(descriptor));
}
std::string GenerateTemplateForSingleString(const FieldDescriptor* descriptor,
StringPiece field_member) {
if (descriptor->default_value_string().empty()) {
return strings::Substitute("_listener_->ExtractFieldInfo(&$0)", field_member);
}
if (descriptor->options().ctype() == google::protobuf::FieldOptions::STRING) {
return strings::Substitute(
"_listener_->ExtractFieldInfo($0.IsDefault("
"nullptr) ? &$1.get() : $0.GetPointer())",
field_member, MakeDefaultName(descriptor));
}
return strings::Substitute("_listener_->ExtractFieldInfo(&$0)", field_member);
}
} // namespace
void AddAccessorAnnotations(const FieldDescriptor* descriptor, void AddAccessorAnnotations(const FieldDescriptor* descriptor,
const Options& options, const Options& options,
@ -74,6 +137,129 @@ void AddAccessorAnnotations(const FieldDescriptor* descriptor,
for (size_t i = 0; i < GOOGLE_ARRAYSIZE(kAccessorsAnnotations); ++i) { for (size_t i = 0; i < GOOGLE_ARRAYSIZE(kAccessorsAnnotations); ++i) {
(*variables)[kAccessorsAnnotations[i]] = ""; (*variables)[kAccessorsAnnotations[i]] = "";
} }
if (options.annotate_accessor) {
for (size_t i = 0; i < GOOGLE_ARRAYSIZE(kAccessorsAnnotations); ++i) {
(*variables)[kAccessorsAnnotations[i]] = StrCat(
" ", FieldName(descriptor), "_AccessedNoStrip = true;\n");
}
}
if (!options.inject_field_listener_events) {
return;
}
if (descriptor->file()->options().optimize_for() ==
google::protobuf::FileOptions::LITE_RUNTIME) {
return;
}
std::string field_member = (*variables)["field_member"];
const google::protobuf::OneofDescriptor* oneof_member =
descriptor->real_containing_oneof();
if (oneof_member) {
field_member = StrCat(oneof_member->name(), "_.", field_member);
}
const std::string proto_ns = (*variables)["proto_ns"];
std::string lambda_args = "_listener_, this";
std::string lambda_flat_args = "_listener_, this";
const std::string substitute_template_prefix = StrCat(
" {\n"
" auto _listener_ = ::",
proto_ns,
"::FieldAccessListener::GetListener();\n"
" if (_listener_) _listener_->OnFieldAccess([$2] { return ");
const std::string substitute_template_suffix = StrCat(
"; }, "
"GetDescriptor()->field($0), "
"::",
proto_ns,
"::FieldAccessListener::FieldAccessType::$1);\n"
" }\n");
std::string prepared_template;
// Flat template is needed if the prepared one is introspecting the values
// inside the returned values, for example, for repeated fields and maps.
std::string prepared_flat_template;
std::string prepared_add_template;
// TODO(jianzhouzh): Fix all forward declared messages and deal with the
// weak fields.
if (descriptor->is_repeated() && !descriptor->is_map()) {
if (descriptor->type() != FieldDescriptor::TYPE_MESSAGE &&
descriptor->type() != FieldDescriptor::TYPE_GROUP) {
lambda_args = "_listener_, this, index";
prepared_template = strings::Substitute(
"_listener_->ExtractFieldInfo(&$0.Get(index))", field_member);
prepared_add_template = strings::Substitute(
"_listener_->ExtractFieldInfo(&$0.Get($0.size() - 1))", field_member);
} else {
prepared_template =
StrCat("::", proto_ns, "::FieldAccessListener::AddressInfo()");
prepared_add_template =
StrCat("::", proto_ns, "::FieldAccessListener::AddressInfo()");
}
} else if (descriptor->is_map()) {
prepared_template =
StrCat("::", proto_ns, "::FieldAccessListener::AddressInfo()");
} else if (descriptor->type() == FieldDescriptor::TYPE_MESSAGE &&
!descriptor->options().lazy()) {
prepared_template =
StrCat("::", proto_ns, "::FieldAccessListener::AddressInfo()");
} else if (descriptor->cpp_type() == FieldDescriptor::CPPTYPE_STRING) {
if (oneof_member) {
prepared_template = GenerateTemplateForOneofString(
descriptor, (*variables)["proto_ns"], field_member);
} else {
prepared_template =
GenerateTemplateForSingleString(descriptor, field_member);
}
} else {
prepared_template =
strings::Substitute("_listener_->ExtractFieldInfo(&$0)", field_member);
}
if (descriptor->is_repeated() && !descriptor->is_map() &&
descriptor->type() != FieldDescriptor::TYPE_MESSAGE &&
descriptor->type() != FieldDescriptor::TYPE_GROUP) {
prepared_flat_template =
strings::Substitute("_listener_->ExtractFieldInfo(&$0)", field_member);
} else {
prepared_flat_template = prepared_template;
}
(*variables)["annotate_get"] = GenerateAnnotation(
substitute_template_prefix, prepared_template, substitute_template_suffix,
descriptor->index(), lambda_args, "kGet");
(*variables)["annotate_set"] = GenerateAnnotation(
substitute_template_prefix, prepared_template, substitute_template_suffix,
descriptor->index(), lambda_args, "kSet");
(*variables)["annotate_has"] = GenerateAnnotation(
substitute_template_prefix, prepared_template, substitute_template_suffix,
descriptor->index(), lambda_args, "kHas");
(*variables)["annotate_mutable"] = GenerateAnnotation(
substitute_template_prefix, prepared_template, substitute_template_suffix,
descriptor->index(), lambda_args, "kMutable");
(*variables)["annotate_release"] = GenerateAnnotation(
substitute_template_prefix, prepared_template, substitute_template_suffix,
descriptor->index(), lambda_args, "kRelease");
(*variables)["annotate_clear"] =
GenerateAnnotation(substitute_template_prefix, prepared_flat_template,
substitute_template_suffix, descriptor->index(),
lambda_flat_args, "kClear");
(*variables)["annotate_size"] =
GenerateAnnotation(substitute_template_prefix, prepared_flat_template,
substitute_template_suffix, descriptor->index(),
lambda_flat_args, "kSize");
(*variables)["annotate_list"] =
GenerateAnnotation(substitute_template_prefix, prepared_flat_template,
substitute_template_suffix, descriptor->index(),
lambda_flat_args, "kList");
(*variables)["annotate_mutable_list"] =
GenerateAnnotation(substitute_template_prefix, prepared_flat_template,
substitute_template_suffix, descriptor->index(),
lambda_flat_args, "kMutableList");
(*variables)["annotate_add"] =
GenerateAnnotation(substitute_template_prefix, prepared_add_template,
substitute_template_suffix, descriptor->index(),
lambda_flat_args, "kAdd");
(*variables)["annotate_add_mutable"] =
GenerateAnnotation(substitute_template_prefix, prepared_add_template,
substitute_template_suffix, descriptor->index(),
lambda_flat_args, "kAddMutable");
} }
void SetCommonFieldVariables(const FieldDescriptor* descriptor, void SetCommonFieldVariables(const FieldDescriptor* descriptor,

@ -1139,7 +1139,7 @@ void FileGenerator::GenerateLibraryIncludes(io::Printer* printer) {
GOOGLE_CHECK(!options_.opensource_runtime); GOOGLE_CHECK(!options_.opensource_runtime);
IncludeFile("net/proto2/public/weak_field_map.h", printer); IncludeFile("net/proto2/public/weak_field_map.h", printer);
} }
if (HasLazyFields(file_, options_)) { if (HasLazyFields(file_, options_, &scc_analyzer_)) {
GOOGLE_CHECK(!options_.opensource_runtime); GOOGLE_CHECK(!options_.opensource_runtime);
IncludeFile("net/proto2/public/lazy_field.h", printer); IncludeFile("net/proto2/public/lazy_field.h", printer);
} }

@ -104,6 +104,14 @@ bool CppGenerator::Generate(const FileDescriptor* file,
file_options.num_cc_files = file_options.num_cc_files =
strto32(options[i].second.c_str(), NULL, 10); strto32(options[i].second.c_str(), NULL, 10);
} }
} else if (options[i].first == "annotate_accessor") {
file_options.annotate_accessor = true;
} else if (options[i].first == "inject_field_listener_events") {
file_options.inject_field_listener_events = true;
} else if (options[i].first == "eagerly_verified_lazy") {
file_options.eagerly_verified_lazy = true;
} else if (options[i].first == "force_eagerly_verified_lazy") {
file_options.force_eagerly_verified_lazy = true;
} else if (options[i].first == "table_driven_parsing") { } else if (options[i].first == "table_driven_parsing") {
file_options.table_driven_parsing = true; file_options.table_driven_parsing = true;
} else if (options[i].first == "table_driven_serialization") { } else if (options[i].first == "table_driven_serialization") {

@ -205,9 +205,20 @@ void SetIntVar(const Options& options, const std::string& type,
std::map<std::string, std::string>* variables) { std::map<std::string, std::string>* variables) {
(*variables)[type] = IntTypeName(options, type); (*variables)[type] = IntTypeName(options, type);
} }
bool IsEagerlyVerifiedLazyImpl(const FieldDescriptor* field,
const Options& options,
MessageSCCAnalyzer* scc_analyzer) {
return false;
}
} // namespace } // namespace
bool IsLazy(const FieldDescriptor* field, const Options& options,
MessageSCCAnalyzer* scc_analyzer) {
return IsLazilyVerifiedLazy(field, options) ||
IsEagerlyVerifiedLazyImpl(field, options, scc_analyzer);
}
void SetCommonVars(const Options& options, void SetCommonVars(const Options& options,
std::map<std::string, std::string>* variables) { std::map<std::string, std::string>* variables) {
(*variables)["proto_ns"] = ProtobufNamespace(options); (*variables)["proto_ns"] = ProtobufNamespace(options);
@ -785,20 +796,20 @@ std::string SafeFunctionName(const Descriptor* descriptor,
return function_name; return function_name;
} }
static bool HasLazyFields(const Descriptor* descriptor, static bool HasLazyFields(const Descriptor* descriptor, const Options& options,
const Options& options) { MessageSCCAnalyzer* scc_analyzer) {
for (int field_idx = 0; field_idx < descriptor->field_count(); field_idx++) { for (int field_idx = 0; field_idx < descriptor->field_count(); field_idx++) {
if (IsLazy(descriptor->field(field_idx), options)) { if (IsLazy(descriptor->field(field_idx), options, scc_analyzer)) {
return true; return true;
} }
} }
for (int idx = 0; idx < descriptor->extension_count(); idx++) { for (int idx = 0; idx < descriptor->extension_count(); idx++) {
if (IsLazy(descriptor->extension(idx), options)) { if (IsLazy(descriptor->extension(idx), options, scc_analyzer)) {
return true; return true;
} }
} }
for (int idx = 0; idx < descriptor->nested_type_count(); idx++) { for (int idx = 0; idx < descriptor->nested_type_count(); idx++) {
if (HasLazyFields(descriptor->nested_type(idx), options)) { if (HasLazyFields(descriptor->nested_type(idx), options, scc_analyzer)) {
return true; return true;
} }
} }
@ -806,15 +817,16 @@ static bool HasLazyFields(const Descriptor* descriptor,
} }
// Does the given FileDescriptor use lazy fields? // Does the given FileDescriptor use lazy fields?
bool HasLazyFields(const FileDescriptor* file, const Options& options) { bool HasLazyFields(const FileDescriptor* file, const Options& options,
MessageSCCAnalyzer* scc_analyzer) {
for (int i = 0; i < file->message_type_count(); i++) { for (int i = 0; i < file->message_type_count(); i++) {
const Descriptor* descriptor(file->message_type(i)); const Descriptor* descriptor(file->message_type(i));
if (HasLazyFields(descriptor, options)) { if (HasLazyFields(descriptor, options, scc_analyzer)) {
return true; return true;
} }
} }
for (int field_idx = 0; field_idx < file->extension_count(); field_idx++) { for (int field_idx = 0; field_idx < file->extension_count(); field_idx++) {
if (IsLazy(file->extension(field_idx), options)) { if (IsLazy(file->extension(field_idx), options, scc_analyzer)) {
return true; return true;
} }
} }
@ -1143,6 +1155,9 @@ bool IsImplicitWeakField(const FieldDescriptor* field, const Options& options,
MessageAnalysis MessageSCCAnalyzer::GetSCCAnalysis(const SCC* scc) { MessageAnalysis MessageSCCAnalyzer::GetSCCAnalysis(const SCC* scc) {
if (analysis_cache_.count(scc)) return analysis_cache_[scc]; if (analysis_cache_.count(scc)) return analysis_cache_[scc];
MessageAnalysis result{}; MessageAnalysis result{};
if (UsingImplicitWeakFields(scc->GetFile(), options_)) {
result.contains_weak = true;
}
for (int i = 0; i < scc->descriptors.size(); i++) { for (int i = 0; i < scc->descriptors.size(); i++) {
const Descriptor* descriptor = scc->descriptors[i]; const Descriptor* descriptor = scc->descriptors[i];
if (descriptor->extension_range_count() > 0) { if (descriptor->extension_range_count() > 0) {
@ -1153,6 +1168,9 @@ MessageAnalysis MessageSCCAnalyzer::GetSCCAnalysis(const SCC* scc) {
if (field->is_required()) { if (field->is_required()) {
result.contains_required = true; result.contains_required = true;
} }
if (field->options().weak()) {
result.contains_weak = true;
}
switch (field->type()) { switch (field->type()) {
case FieldDescriptor::TYPE_STRING: case FieldDescriptor::TYPE_STRING:
case FieldDescriptor::TYPE_BYTES: { case FieldDescriptor::TYPE_BYTES: {
@ -1171,6 +1189,7 @@ MessageAnalysis MessageSCCAnalyzer::GetSCCAnalysis(const SCC* scc) {
if (!ShouldIgnoreRequiredFieldCheck(field, options_)) { if (!ShouldIgnoreRequiredFieldCheck(field, options_)) {
result.contains_required |= analysis.contains_required; result.contains_required |= analysis.contains_required;
} }
result.contains_weak |= analysis.contains_weak;
} else { } else {
// This field points back into the same SCC hence the messages // This field points back into the same SCC hence the messages
// in the SCC are recursive. Note if SCC contains more than two // in the SCC are recursive. Note if SCC contains more than two

@ -331,17 +331,30 @@ inline bool IsStringPiece(const FieldDescriptor* field,
EffectiveStringCType(field, options) == FieldOptions::STRING_PIECE; EffectiveStringCType(field, options) == FieldOptions::STRING_PIECE;
} }
class MessageSCCAnalyzer;
// Does the given FileDescriptor use lazy fields? // Does the given FileDescriptor use lazy fields?
bool HasLazyFields(const FileDescriptor* file, const Options& options); bool HasLazyFields(const FileDescriptor* file, const Options& options,
MessageSCCAnalyzer* scc_analyzer);
// Is the given field a supported lazy field? // Is the given field a supported lazy field?
inline bool IsLazy(const FieldDescriptor* field, const Options& options) { bool IsLazy(const FieldDescriptor* field, const Options& options,
MessageSCCAnalyzer* scc_analyzer);
inline bool IsLazilyVerifiedLazy(const FieldDescriptor* field,
const Options& options) {
return field->options().lazy() && !field->is_repeated() && return field->options().lazy() && !field->is_repeated() &&
field->type() == FieldDescriptor::TYPE_MESSAGE && field->type() == FieldDescriptor::TYPE_MESSAGE &&
GetOptimizeFor(field->file(), options) != FileOptions::LITE_RUNTIME && GetOptimizeFor(field->file(), options) != FileOptions::LITE_RUNTIME &&
!options.opensource_runtime; !options.opensource_runtime;
} }
inline bool IsEagerlyVerifiedLazy(const FieldDescriptor* field,
const Options& options,
MessageSCCAnalyzer* scc_analyzer) {
return IsLazy(field, options, scc_analyzer) && !field->options().lazy();
}
inline bool IsFieldUsed(const FieldDescriptor* /* field */, inline bool IsFieldUsed(const FieldDescriptor* /* field */,
const Options& options) { const Options& options) {
return true; return true;
@ -527,8 +540,8 @@ bool HasWeakFields(const FileDescriptor* desc, const Options& options);
// given field. // given field.
inline static bool ShouldIgnoreRequiredFieldCheck(const FieldDescriptor* field, inline static bool ShouldIgnoreRequiredFieldCheck(const FieldDescriptor* field,
const Options& options) { const Options& options) {
// Do not check "required" for lazy fields. // Do not check "required" for lazily verified lazy fields.
return IsLazy(field, options); return IsLazilyVerifiedLazy(field, options);
} }
struct MessageAnalysis { struct MessageAnalysis {
@ -536,6 +549,7 @@ struct MessageAnalysis {
bool contains_cord; bool contains_cord;
bool contains_extension; bool contains_extension;
bool contains_required; bool contains_required;
bool contains_weak; // Implicit weak as well.
}; };
// This class is used in FileGenerator, to ensure linear instead of // This class is used in FileGenerator, to ensure linear instead of
@ -552,6 +566,10 @@ class PROTOC_EXPORT MessageSCCAnalyzer {
MessageAnalysis result = GetSCCAnalysis(GetSCC(descriptor)); MessageAnalysis result = GetSCCAnalysis(GetSCC(descriptor));
return result.contains_required || result.contains_extension; return result.contains_required || result.contains_extension;
} }
bool HasWeakField(const Descriptor* descriptor) {
MessageAnalysis result = GetSCCAnalysis(GetSCC(descriptor));
return result.contains_weak;
}
const SCC* GetSCC(const Descriptor* descriptor) { const SCC* GetSCC(const Descriptor* descriptor) {
return analyzer_.GetSCC(descriptor); return analyzer_.GetSCC(descriptor);
} }

@ -168,14 +168,16 @@ bool IsPOD(const FieldDescriptor* field) {
// Anything that is a POD or a "normal" message (represented by a pointer) can // Anything that is a POD or a "normal" message (represented by a pointer) can
// be manipulated as raw bytes. // be manipulated as raw bytes.
bool CanBeManipulatedAsRawBytes(const FieldDescriptor* field, bool CanBeManipulatedAsRawBytes(const FieldDescriptor* field,
const Options& options) { const Options& options,
MessageSCCAnalyzer* scc_analyzer) {
bool ret = CanInitializeByZeroing(field); bool ret = CanInitializeByZeroing(field);
// Non-repeated, non-lazy message fields are simply raw pointers, so we can // Non-repeated, non-lazy message fields are simply raw pointers, so we can
// swap them or use memset to initialize these in SharedCtor. We cannot use // swap them or use memset to initialize these in SharedCtor. We cannot use
// this in Clear, as we need to potentially delete the existing value. // this in Clear, as we need to potentially delete the existing value.
ret = ret || (!field->is_repeated() && !IsLazy(field, options) && ret =
field->cpp_type() == FieldDescriptor::CPPTYPE_MESSAGE); ret || (!field->is_repeated() && !IsLazy(field, options, scc_analyzer) &&
field->cpp_type() == FieldDescriptor::CPPTYPE_MESSAGE);
return ret; return ret;
} }
@ -218,16 +220,18 @@ bool EmitFieldNonDefaultCondition(io::Printer* printer,
// if non-zero (numeric) or non-empty (string). // if non-zero (numeric) or non-empty (string).
if (!field->is_repeated() && !field->containing_oneof()) { if (!field->is_repeated() && !field->containing_oneof()) {
if (field->cpp_type() == FieldDescriptor::CPPTYPE_STRING) { if (field->cpp_type() == FieldDescriptor::CPPTYPE_STRING) {
format("if (!$prefix$$name$().empty()) {\n"); format("if (!$prefix$_internal_$name$().empty()) {\n");
} else if (field->cpp_type() == FieldDescriptor::CPPTYPE_MESSAGE) { } else if (field->cpp_type() == FieldDescriptor::CPPTYPE_MESSAGE) {
// Message fields still have has_$name$() methods. // Message fields still have has_$name$() methods.
format("if ($prefix$has_$name$()) {\n"); format("if ($prefix$_internal_has_$name$()) {\n");
} else if (field->cpp_type() == FieldDescriptor::CPPTYPE_DOUBLE || } else if (field->cpp_type() == FieldDescriptor::CPPTYPE_DOUBLE ||
field->cpp_type() == FieldDescriptor::CPPTYPE_FLOAT) { field->cpp_type() == FieldDescriptor::CPPTYPE_FLOAT) {
// Handle float comparison to prevent -Wfloat-equal warnings // Handle float comparison to prevent -Wfloat-equal warnings
format("if (!($prefix$$name$() <= 0 && $prefix$$name$() >= 0)) {\n"); format(
"if (!($prefix$_internal_$name$() <= 0 && $prefix$_internal_$name$() "
">= 0)) {\n");
} else { } else {
format("if ($prefix$$name$() != 0) {\n"); format("if ($prefix$_internal_$name$() != 0) {\n");
} }
format.Indent(); format.Indent();
return true; return true;
@ -313,7 +317,8 @@ bool ShouldSerializeInOrder(const Descriptor* descriptor,
} }
bool TableDrivenParsingEnabled(const Descriptor* descriptor, bool TableDrivenParsingEnabled(const Descriptor* descriptor,
const Options& options) { const Options& options,
MessageSCCAnalyzer* scc_analyzer) {
if (!options.table_driven_parsing) { if (!options.table_driven_parsing) {
return false; return false;
} }
@ -344,7 +349,7 @@ bool TableDrivenParsingEnabled(const Descriptor* descriptor,
} }
// - There are no lazy fields (they require the non-lite library). // - There are no lazy fields (they require the non-lite library).
if (IsLazy(field, options)) { if (IsLazy(field, options, scc_analyzer)) {
return false; return false;
} }
} }
@ -579,6 +584,35 @@ MessageGenerator::MessageGenerator(
variables_["annotate_reflection"] = ""; variables_["annotate_reflection"] = "";
variables_["annotate_bytesize"] = ""; variables_["annotate_bytesize"] = "";
if (options.inject_field_listener_events &&
descriptor->file()->options().optimize_for() !=
google::protobuf::FileOptions::LITE_RUNTIME) {
const std::string injector_template = StrCat(
" {\n"
" auto _listener_ = ::",
variables_["proto_ns"],
"::FieldAccessListener::GetListener();\n"
" if (_listener_) ");
StrAppend(&variables_["annotate_serialize"], injector_template,
"_listener_->OnSerializationAccess(this);\n"
" }\n");
StrAppend(&variables_["annotate_deserialize"], injector_template,
" _listener_->OnDeserializationAccess(this);\n"
" }\n");
// TODO(danilak): Ideally annotate_reflection should not exist and we need
// to annotate all reflective calls on our own, however, as this is a cause
// for side effects, i.e. reading values dynamically, we want the users know
// that dynamic access can happen.
StrAppend(&variables_["annotate_reflection"], injector_template,
"_listener_->OnReflectionAccess(default_instance()"
".GetMetadata().descriptor);\n"
" }\n");
StrAppend(&variables_["annotate_bytesize"], injector_template,
"_listener_->OnByteSizeAccess(this);\n"
" }\n");
}
SetUnknownFieldsVariable(descriptor_, options_, &variables_); SetUnknownFieldsVariable(descriptor_, options_, &variables_);
// Compute optimized field order to be used for layout and initialization // Compute optimized field order to be used for layout and initialization
@ -595,7 +629,8 @@ MessageGenerator::MessageGenerator(
} }
} }
message_layout_helper_->OptimizeLayout(&optimized_order_, options_); message_layout_helper_->OptimizeLayout(&optimized_order_, options_,
scc_analyzer_);
// This message has hasbits iff one or more fields need one. // This message has hasbits iff one or more fields need one.
for (auto field : optimized_order_) { for (auto field : optimized_order_) {
@ -618,7 +653,8 @@ MessageGenerator::MessageGenerator(
} }
} }
table_driven_ = TableDrivenParsingEnabled(descriptor_, options_); table_driven_ =
TableDrivenParsingEnabled(descriptor_, options_, scc_analyzer_);
parse_function_generator_.reset(new ParseFunctionGenerator( parse_function_generator_.reset(new ParseFunctionGenerator(
descriptor_, max_has_bit_index_, has_bit_indices_, options_, descriptor_, max_has_bit_index_, has_bit_indices_, options_,
scc_analyzer_, variables_)); scc_analyzer_, variables_));
@ -794,7 +830,7 @@ void MessageGenerator::GenerateSingularFieldHasBits(
"(_has_bits_[$has_array_index$] & 0x$has_mask$u) != 0;\n"); "(_has_bits_[$has_array_index$] & 0x$has_mask$u) != 0;\n");
if (field->cpp_type() == FieldDescriptor::CPPTYPE_MESSAGE && if (field->cpp_type() == FieldDescriptor::CPPTYPE_MESSAGE &&
!IsLazy(field, options_)) { !IsLazy(field, options_, scc_analyzer_)) {
// We maintain the invariant that for a submessage x, has_x() returning // We maintain the invariant that for a submessage x, has_x() returning
// true implies that x_ is not null. By giving this information to the // true implies that x_ is not null. By giving this information to the
// compiler, we allow it to eliminate unnecessary null checks later on. // compiler, we allow it to eliminate unnecessary null checks later on.
@ -810,7 +846,7 @@ void MessageGenerator::GenerateSingularFieldHasBits(
"}\n"); "}\n");
} else if (field->cpp_type() == FieldDescriptor::CPPTYPE_MESSAGE) { } else if (field->cpp_type() == FieldDescriptor::CPPTYPE_MESSAGE) {
// Message fields have a has_$name$() method. // Message fields have a has_$name$() method.
if (IsLazy(field, options_)) { if (IsLazy(field, options_, scc_analyzer_)) {
format( format(
"inline bool $classname$::_internal_has_$name$() const {\n" "inline bool $classname$::_internal_has_$name$() const {\n"
" return !$name$_.IsCleared();\n" " return !$name$_.IsCleared();\n"
@ -1853,7 +1889,7 @@ int MessageGenerator::GenerateFieldMetadata(io::Printer* printer) {
const FieldGenerator& generator = field_generators_.get(field); const FieldGenerator& generator = field_generators_.get(field);
int type = CalcFieldNum(generator, field, options_); int type = CalcFieldNum(generator, field, options_);
if (IsLazy(field, options_)) { if (IsLazy(field, options_, scc_analyzer_)) {
type = internal::FieldMetadata::kSpecial; type = internal::FieldMetadata::kSpecial;
ptr = "reinterpret_cast<const void*>(::" + variables_["proto_ns"] + ptr = "reinterpret_cast<const void*>(::" + variables_["proto_ns"] +
"::internal::LazyFieldSerializer"; "::internal::LazyFieldSerializer";
@ -2311,6 +2347,8 @@ std::pair<size_t, size_t> MessageGenerator::GenerateOffsets(
if (!IsFieldUsed(field, options_)) { if (!IsFieldUsed(field, options_)) {
format(" | 0x80000000u, // unused\n"); format(" | 0x80000000u, // unused\n");
} else if (IsEagerlyVerifiedLazy(field, options_, scc_analyzer_)) {
format(" | 0x1u, // eagerly verified lazy\n");
} else { } else {
format(",\n"); format(",\n");
} }
@ -2486,7 +2524,7 @@ void MessageGenerator::GenerateConstructorBody(io::Printer* printer,
optimized_order_, [copy_constructor, this](const FieldDescriptor* field) { optimized_order_, [copy_constructor, this](const FieldDescriptor* field) {
return (copy_constructor && IsPOD(field)) || return (copy_constructor && IsPOD(field)) ||
(!copy_constructor && (!copy_constructor &&
CanBeManipulatedAsRawBytes(field, options_)); CanBeManipulatedAsRawBytes(field, options_, scc_analyzer_));
}); });
std::string pod_template; std::string pod_template;
@ -2554,7 +2592,8 @@ void MessageGenerator::GenerateStructors(io::Printer* printer) {
GOOGLE_DCHECK(!IsFieldStripped(field, options_)); GOOGLE_DCHECK(!IsFieldStripped(field, options_));
bool has_arena_constructor = field->is_repeated(); bool has_arena_constructor = field->is_repeated();
if (!field->real_containing_oneof() && if (!field->real_containing_oneof() &&
(IsLazy(field, options_) || IsStringPiece(field, options_))) { (IsLazy(field, options_, scc_analyzer_) ||
IsStringPiece(field, options_))) {
has_arena_constructor = true; has_arena_constructor = true;
} }
if (has_arena_constructor) { if (has_arena_constructor) {
@ -2961,7 +3000,7 @@ void MessageGenerator::GenerateSwap(io::Printer* printer) {
// If possible, we swap several fields at once, including padding. // If possible, we swap several fields at once, including padding.
const RunMap runs = const RunMap runs =
FindRuns(optimized_order_, [this](const FieldDescriptor* field) { FindRuns(optimized_order_, [this](const FieldDescriptor* field) {
return CanBeManipulatedAsRawBytes(field, options_); return CanBeManipulatedAsRawBytes(field, options_, scc_analyzer_);
}); });
for (int i = 0; i < optimized_order_.size(); ++i) { for (int i = 0; i < optimized_order_.size(); ++i) {
@ -4018,6 +4057,13 @@ void MessageGenerator::GenerateIsInitialized(io::Printer* printer) {
} }
} else if (field->options().weak()) { } else if (field->options().weak()) {
continue; continue;
} else if (IsEagerlyVerifiedLazy(field, options_, scc_analyzer_)) {
GOOGLE_CHECK(!field->real_containing_oneof());
format(
"if (_internal_has_$1$()) {\n"
" if (!$1$().IsInitialized()) return false;\n"
"}\n",
FieldName(field));
} else { } else {
GOOGLE_CHECK(!field->real_containing_oneof()); GOOGLE_CHECK(!field->real_containing_oneof());
format( format(

@ -200,9 +200,15 @@ void MessageFieldGenerator::GenerateInlineAccessorDefinitions(
" $clear_hasbit$\n" " $clear_hasbit$\n"
" $type$* temp = $casted_member$;\n" " $type$* temp = $casted_member$;\n"
" $name$_ = nullptr;\n" " $name$_ = nullptr;\n"
"#ifdef PROTOBUF_FORCE_COPY_IN_RELEASE\n"
" auto* old = reinterpret_cast<::$proto_ns$::MessageLite*>(temp);\n"
" temp = ::$proto_ns$::internal::DuplicateIfNonNull(temp);\n"
" if (GetArenaForAllocation() == nullptr) { delete old; }\n"
"#else // PROTOBUF_FORCE_COPY_IN_RELEASE\n"
" if (GetArenaForAllocation() != nullptr) {\n" " if (GetArenaForAllocation() != nullptr) {\n"
" temp = ::$proto_ns$::internal::DuplicateIfNonNull(temp);\n" " temp = ::$proto_ns$::internal::DuplicateIfNonNull(temp);\n"
" }\n" " }\n"
"#endif // !PROTOBUF_FORCE_COPY_IN_RELEASE\n"
" return temp;\n" " return temp;\n"
"}\n" "}\n"
"inline $type$* $classname$::unsafe_arena_release_$name$() {\n" "inline $type$* $classname$::unsafe_arena_release_$name$() {\n"

@ -43,6 +43,8 @@ namespace protobuf {
namespace compiler { namespace compiler {
namespace cpp { namespace cpp {
class MessageSCCAnalyzer;
// Provides an abstract interface to optimize message layout // Provides an abstract interface to optimize message layout
// by rearranging the fields of a message. // by rearranging the fields of a message.
class MessageLayoutHelper { class MessageLayoutHelper {
@ -50,7 +52,8 @@ class MessageLayoutHelper {
virtual ~MessageLayoutHelper() {} virtual ~MessageLayoutHelper() {}
virtual void OptimizeLayout(std::vector<const FieldDescriptor*>* fields, virtual void OptimizeLayout(std::vector<const FieldDescriptor*>* fields,
const Options& options) = 0; const Options& options,
MessageSCCAnalyzer* scc_analyzer) = 0;
}; };
} // namespace cpp } // namespace cpp

@ -75,6 +75,8 @@ struct Options {
kTCTableAlways kTCTableAlways
} tctable_mode = kTCTableNever; } tctable_mode = kTCTableNever;
bool inject_field_listener_events = false; bool inject_field_listener_events = false;
bool eagerly_verified_lazy = false;
bool force_eagerly_verified_lazy = false;
}; };
} // namespace cpp } // namespace cpp

@ -118,7 +118,8 @@ class FieldGroup {
// //
// OTHER these fields are initialized one-by-one. // OTHER these fields are initialized one-by-one.
void PaddingOptimizer::OptimizeLayout( void PaddingOptimizer::OptimizeLayout(
std::vector<const FieldDescriptor*>* fields, const Options& options) { std::vector<const FieldDescriptor*>* fields, const Options& options,
MessageSCCAnalyzer* scc_analyzer) {
// The sorted numeric order of Family determines the declaration order in the // The sorted numeric order of Family determines the declaration order in the
// memory layout. // memory layout.
enum Family { enum Family {
@ -147,7 +148,7 @@ void PaddingOptimizer::OptimizeLayout(
f = STRING; f = STRING;
} else if (field->cpp_type() == FieldDescriptor::CPPTYPE_MESSAGE) { } else if (field->cpp_type() == FieldDescriptor::CPPTYPE_MESSAGE) {
f = MESSAGE; f = MESSAGE;
if (IsLazy(field, options)) { if (IsLazy(field, options, scc_analyzer)) {
f = LAZY_MESSAGE; f = LAZY_MESSAGE;
} }
} else if (CanInitializeByZeroing(field)) { } else if (CanInitializeByZeroing(field)) {

@ -53,7 +53,8 @@ class PaddingOptimizer : public MessageLayoutHelper {
~PaddingOptimizer() override {} ~PaddingOptimizer() override {}
void OptimizeLayout(std::vector<const FieldDescriptor*>* fields, void OptimizeLayout(std::vector<const FieldDescriptor*>* fields,
const Options& options) override; const Options& options,
MessageSCCAnalyzer* scc_analyzer) override;
}; };
} // namespace cpp } // namespace cpp

@ -94,8 +94,8 @@ std::string MessageParseFunctionName(const FieldDescriptor* field,
} else { } else {
name.append("Singular"); name.append("Singular");
} }
name.append("ParseMessage<" + ClassName(field->message_type()) + ", " + name.append("ParseMessage<" + QualifiedClassName(field->message_type()) +
TagType(field) + ">"); ", " + TagType(field) + ">");
return name; return name;
} }
@ -198,9 +198,23 @@ TailCallTableInfo::TailCallTableInfo(const Descriptor* descriptor,
case FieldDescriptor::TYPE_SFIXED32: case FieldDescriptor::TYPE_SFIXED32:
case FieldDescriptor::TYPE_DOUBLE: case FieldDescriptor::TYPE_DOUBLE:
case FieldDescriptor::TYPE_FLOAT: case FieldDescriptor::TYPE_FLOAT:
case FieldDescriptor::TYPE_INT64:
case FieldDescriptor::TYPE_INT32:
case FieldDescriptor::TYPE_UINT64:
case FieldDescriptor::TYPE_UINT32:
case FieldDescriptor::TYPE_SINT64:
case FieldDescriptor::TYPE_SINT32:
case FieldDescriptor::TYPE_BOOL:
name = FieldParseFunctionName(field, options, table_size_log2); name = FieldParseFunctionName(field, options, table_size_log2);
break; break;
case FieldDescriptor::TYPE_BYTES:
if (field->options().ctype() == FieldOptions::STRING &&
field->default_value_string().empty()) {
name = FieldParseFunctionName(field, options, table_size_log2);
}
break;
default: default:
break; break;
} }
@ -263,10 +277,10 @@ void ParseFunctionGenerator::GenerateMethodDecls(io::Printer* printer) {
if (tc_table_info_->use_generated_fallback) { if (tc_table_info_->use_generated_fallback) {
format( format(
"static const char* Tct_ParseFallback(\n" "static const char* Tct_ParseFallback(\n"
" ::google::protobuf::MessageLite *msg, const char *ptr,\n" " ::$proto_ns$::MessageLite *msg, const char *ptr,\n"
" ::google::protobuf::internal::ParseContext *ctx,\n" " ::$proto_ns$::internal::ParseContext *ctx,\n"
" const ::google::protobuf::internal::TailCallParseTableBase *table,\n" " const ::$proto_ns$::internal::TailCallParseTableBase *table,\n"
" uint64_t hasbits, ::google::protobuf::internal::TcFieldData data);\n" " uint64_t hasbits, ::$proto_ns$::internal::TcFieldData data);\n"
"inline const char* Tct_FallbackImpl(\n" "inline const char* Tct_FallbackImpl(\n"
" const char* ptr, ::$proto_ns$::internal::ParseContext* ctx,\n" " const char* ptr, ::$proto_ns$::internal::ParseContext* ctx,\n"
" const void*, $uint64$ hasbits);\n"); " const void*, $uint64$ hasbits);\n");
@ -646,7 +660,7 @@ void ParseFunctionGenerator::GenerateLengthDelim(Formatter& format,
} else { } else {
format("ptr = ctx->ParseMessage(&$1$_, ptr);\n", FieldName(field)); format("ptr = ctx->ParseMessage(&$1$_, ptr);\n", FieldName(field));
} }
} else if (IsLazy(field, options_)) { } else if (IsLazy(field, options_, scc_analyzer_)) {
if (field->real_containing_oneof()) { if (field->real_containing_oneof()) {
format( format(
"if (!_internal_has_$1$()) {\n" "if (!_internal_has_$1$()) {\n"
@ -988,19 +1002,27 @@ std::string FieldParseFunctionName(const FieldDescriptor* field,
break; break;
case FieldDescriptor::TYPE_STRING: case FieldDescriptor::TYPE_STRING:
type_format = TypeFormat::kString; switch (GetUtf8CheckMode(field, options)) {
case Utf8CheckMode::kNone:
type_format = TypeFormat::kBytes;
break;
case Utf8CheckMode::kStrict:
type_format = TypeFormat::kString;
break;
case Utf8CheckMode::kVerify:
type_format = TypeFormat::kStringValidateOnly;
break;
}
break; break;
case FieldDescriptor::TYPE_GROUP: default:
case FieldDescriptor::TYPE_MESSAGE:
case FieldDescriptor::TYPE_ENUM:
GOOGLE_LOG(DFATAL) << "Type not handled: " << field->DebugString(); GOOGLE_LOG(DFATAL) << "Type not handled: " << field->DebugString();
return ""; return "";
} }
return "::" + ProtobufNamespace(options) + "::internal::" + return "::" + ProtobufNamespace(options) + "::internal::" +
GetTailCallFieldHandlerName(card, type_format, table_size_log2, GetTailCallFieldHandlerName(card, type_format, table_size_log2,
TagSize(field->number())); TagSize(field->number()), options);
} }
} // namespace } // namespace
@ -1008,7 +1030,8 @@ std::string FieldParseFunctionName(const FieldDescriptor* field,
std::string GetTailCallFieldHandlerName(ParseCardinality card, std::string GetTailCallFieldHandlerName(ParseCardinality card,
TypeFormat type_format, TypeFormat type_format,
int table_size_log2, int table_size_log2,
int tag_length_bytes) { int tag_length_bytes,
const Options& options) {
std::string name; std::string name;
switch (card) { switch (card) {
@ -1058,6 +1081,20 @@ std::string GetTailCallFieldHandlerName(ParseCardinality card,
name.append("Fixed"); name.append("Fixed");
break; break;
case TypeFormat::kVar64:
case TypeFormat::kVar32:
case TypeFormat::kSInt64:
case TypeFormat::kSInt32:
case TypeFormat::kBool:
name.append("Varint");
break;
case TypeFormat::kBytes:
case TypeFormat::kString:
case TypeFormat::kStringValidateOnly:
name.append("String");
break;
default: default:
break; break;
} }
@ -1069,35 +1106,59 @@ std::string GetTailCallFieldHandlerName(ParseCardinality card,
switch (type_format) { switch (type_format) {
case TypeFormat::kVar64: case TypeFormat::kVar64:
case TypeFormat::kFixed64: case TypeFormat::kFixed64:
name.append("uint64_t"); name.append("uint64_t, ");
break; break;
case TypeFormat::kSInt64: case TypeFormat::kSInt64:
name.append("int64_t"); name.append("int64_t, ");
break; break;
case TypeFormat::kVar32: case TypeFormat::kVar32:
case TypeFormat::kFixed32: case TypeFormat::kFixed32:
name.append("uint32_t"); name.append("uint32_t, ");
break; break;
case TypeFormat::kSInt32: case TypeFormat::kSInt32:
name.append("int32_t"); name.append("int32_t, ");
break; break;
case TypeFormat::kBool: case TypeFormat::kBool:
name.append("bool"); name.append("bool, ");
break; break;
default: default:
GOOGLE_LOG(FATAL) << static_cast<int>(type_format); break;
return "";
} }
name.append(", ");
name.append(CodedTagType(tag_length_bytes)); name.append(CodedTagType(tag_length_bytes));
std::string tcpb =
StrCat(ProtobufNamespace(options), "::internal::TcParserBase");
switch (type_format) { switch (type_format) {
case TypeFormat::kVar64:
case TypeFormat::kVar32:
case TypeFormat::kBool:
name.append(StrCat(", ::", tcpb, "::kNoConversion"));
break;
case TypeFormat::kSInt64:
case TypeFormat::kSInt32:
name.append(StrCat(", ::", tcpb, "::kZigZag"));
break;
case TypeFormat::kBytes:
name.append(StrCat(", ::", tcpb, "::kNoUtf8"));
break;
case TypeFormat::kString:
name.append(StrCat(", ::", tcpb, "::kUtf8"));
break;
case TypeFormat::kStringValidateOnly:
name.append(StrCat(", ::", tcpb, "::kUtf8ValidateOnly"));
break;
default: default:
break; break;
} }

@ -169,7 +169,8 @@ enum class TypeFormat {
std::string GetTailCallFieldHandlerName(ParseCardinality card, std::string GetTailCallFieldHandlerName(ParseCardinality card,
TypeFormat type_format, TypeFormat type_format,
int table_size_log2, int table_size_log2,
int tag_length_bytes); int tag_length_bytes,
const Options& options);
} // namespace cpp } // namespace cpp
} // namespace compiler } // namespace compiler

@ -41,7 +41,7 @@ syntax = "proto2";
// Some generic_services option(s) added automatically. // Some generic_services option(s) added automatically.
// See: http://go/proto2-generic-services-default // See: http://go/proto2-generic-services-default
option cc_generic_services = true; // auto-added option cc_generic_services = true; // auto-added
// We don't put this in a package within proto2 because we need to make sure // We don't put this in a package within proto2 because we need to make sure
// that the generated code doesn't depend on being in the proto2 namespace. // that the generated code doesn't depend on being in the proto2 namespace.
@ -158,11 +158,11 @@ message TestConflictingEnumNames { // NO_PROTO3
optional while conflicting_enum = 1; // NO_PROTO3 optional while conflicting_enum = 1; // NO_PROTO3
} // NO_PROTO3 } // NO_PROTO3
enum bool { // NO_PROTO3 enum bool { // NO_PROTO3
default = 0; // NO_PROTO3 default = 0; // NO_PROTO3
NOT_EQ = 1; // NO_PROTO3 NOT_EQ = 1; // NO_PROTO3
volatile = 2; // NO_PROTO3 volatile = 2; // NO_PROTO3
return = 3; // NO_PROTO3 return = 3; // NO_PROTO3
} // NO_PROTO3 } // NO_PROTO3
message DummyMessage {} message DummyMessage {}
@ -173,7 +173,7 @@ message NULL {
extend TestConflictingSymbolNames { // NO_PROTO3 extend TestConflictingSymbolNames { // NO_PROTO3
optional int32 void = 314253; // NO_PROTO3 optional int32 void = 314253; // NO_PROTO3
} // NO_PROTO3 } // NO_PROTO3
// Message names that could conflict. // Message names that could conflict.
message Shutdown {} message Shutdown {}

@ -1337,9 +1337,15 @@ inline PROTOBUF_NAMESPACE_ID::compiler::Version* CodeGeneratorRequest::release_c
_has_bits_[0] &= ~0x00000002u; _has_bits_[0] &= ~0x00000002u;
PROTOBUF_NAMESPACE_ID::compiler::Version* temp = compiler_version_; PROTOBUF_NAMESPACE_ID::compiler::Version* temp = compiler_version_;
compiler_version_ = nullptr; compiler_version_ = nullptr;
#ifdef PROTOBUF_FORCE_COPY_IN_RELEASE
auto* old = reinterpret_cast<::PROTOBUF_NAMESPACE_ID::MessageLite*>(temp);
temp = ::PROTOBUF_NAMESPACE_ID::internal::DuplicateIfNonNull(temp);
if (GetArenaForAllocation() == nullptr) { delete old; }
#else // PROTOBUF_FORCE_COPY_IN_RELEASE
if (GetArenaForAllocation() != nullptr) { if (GetArenaForAllocation() != nullptr) {
temp = ::PROTOBUF_NAMESPACE_ID::internal::DuplicateIfNonNull(temp); temp = ::PROTOBUF_NAMESPACE_ID::internal::DuplicateIfNonNull(temp);
} }
#endif // !PROTOBUF_FORCE_COPY_IN_RELEASE
return temp; return temp;
} }
inline PROTOBUF_NAMESPACE_ID::compiler::Version* CodeGeneratorRequest::unsafe_arena_release_compiler_version() { inline PROTOBUF_NAMESPACE_ID::compiler::Version* CodeGeneratorRequest::unsafe_arena_release_compiler_version() {
@ -1595,9 +1601,15 @@ inline PROTOBUF_NAMESPACE_ID::GeneratedCodeInfo* CodeGeneratorResponse_File::rel
_has_bits_[0] &= ~0x00000008u; _has_bits_[0] &= ~0x00000008u;
PROTOBUF_NAMESPACE_ID::GeneratedCodeInfo* temp = generated_code_info_; PROTOBUF_NAMESPACE_ID::GeneratedCodeInfo* temp = generated_code_info_;
generated_code_info_ = nullptr; generated_code_info_ = nullptr;
#ifdef PROTOBUF_FORCE_COPY_IN_RELEASE
auto* old = reinterpret_cast<::PROTOBUF_NAMESPACE_ID::MessageLite*>(temp);
temp = ::PROTOBUF_NAMESPACE_ID::internal::DuplicateIfNonNull(temp);
if (GetArenaForAllocation() == nullptr) { delete old; }
#else // PROTOBUF_FORCE_COPY_IN_RELEASE
if (GetArenaForAllocation() != nullptr) { if (GetArenaForAllocation() != nullptr) {
temp = ::PROTOBUF_NAMESPACE_ID::internal::DuplicateIfNonNull(temp); temp = ::PROTOBUF_NAMESPACE_ID::internal::DuplicateIfNonNull(temp);
} }
#endif // !PROTOBUF_FORCE_COPY_IN_RELEASE
return temp; return temp;
} }
inline PROTOBUF_NAMESPACE_ID::GeneratedCodeInfo* CodeGeneratorResponse_File::unsafe_arena_release_generated_code_info() { inline PROTOBUF_NAMESPACE_ID::GeneratedCodeInfo* CodeGeneratorResponse_File::unsafe_arena_release_generated_code_info() {

@ -786,13 +786,7 @@ class FileDescriptorTables {
mutable internal::WrappedMutex unknown_enum_values_mu_; mutable internal::WrappedMutex unknown_enum_values_mu_;
}; };
DescriptorPool::Tables::Tables() DescriptorPool::Tables::Tables() {
// Start some hash-map and hash-set objects with a small # of buckets
: known_bad_files_(3),
known_bad_symbols_(3),
extensions_loaded_from_db_(3),
symbols_by_name_(3),
files_by_name_(3) {
well_known_types_.insert({ well_known_types_.insert({
{"google.protobuf.DoubleValue", Descriptor::WELLKNOWNTYPE_DOUBLEVALUE}, {"google.protobuf.DoubleValue", Descriptor::WELLKNOWNTYPE_DOUBLEVALUE},
{"google.protobuf.FloatValue", Descriptor::WELLKNOWNTYPE_FLOATVALUE}, {"google.protobuf.FloatValue", Descriptor::WELLKNOWNTYPE_FLOATVALUE},
@ -816,16 +810,8 @@ DescriptorPool::Tables::Tables()
DescriptorPool::Tables::~Tables() { GOOGLE_DCHECK(checkpoints_.empty()); } DescriptorPool::Tables::~Tables() { GOOGLE_DCHECK(checkpoints_.empty()); }
FileDescriptorTables::FileDescriptorTables() FileDescriptorTables::FileDescriptorTables()
// Initialize all the hash tables to start out with a small # of buckets. : fields_by_lowercase_name_tmp_(new FieldsByNameMap()),
: symbols_by_parent_(3), fields_by_camelcase_name_tmp_(new FieldsByNameMap()) {}
fields_by_lowercase_name_(3),
fields_by_lowercase_name_tmp_(new FieldsByNameMap()),
fields_by_camelcase_name_(3),
fields_by_camelcase_name_tmp_(new FieldsByNameMap()),
fields_by_number_(3),
enum_values_by_number_(3),
unknown_enum_values_by_number_(3),
locations_by_path_(3) {}
FileDescriptorTables::~FileDescriptorTables() {} FileDescriptorTables::~FileDescriptorTables() {}

@ -7113,9 +7113,15 @@ inline PROTOBUF_NAMESPACE_ID::FileOptions* FileDescriptorProto::release_options(
_has_bits_[0] &= ~0x00000008u; _has_bits_[0] &= ~0x00000008u;
PROTOBUF_NAMESPACE_ID::FileOptions* temp = options_; PROTOBUF_NAMESPACE_ID::FileOptions* temp = options_;
options_ = nullptr; options_ = nullptr;
#ifdef PROTOBUF_FORCE_COPY_IN_RELEASE
auto* old = reinterpret_cast<::PROTOBUF_NAMESPACE_ID::MessageLite*>(temp);
temp = ::PROTOBUF_NAMESPACE_ID::internal::DuplicateIfNonNull(temp);
if (GetArenaForAllocation() == nullptr) { delete old; }
#else // PROTOBUF_FORCE_COPY_IN_RELEASE
if (GetArenaForAllocation() != nullptr) { if (GetArenaForAllocation() != nullptr) {
temp = ::PROTOBUF_NAMESPACE_ID::internal::DuplicateIfNonNull(temp); temp = ::PROTOBUF_NAMESPACE_ID::internal::DuplicateIfNonNull(temp);
} }
#endif // !PROTOBUF_FORCE_COPY_IN_RELEASE
return temp; return temp;
} }
inline PROTOBUF_NAMESPACE_ID::FileOptions* FileDescriptorProto::unsafe_arena_release_options() { inline PROTOBUF_NAMESPACE_ID::FileOptions* FileDescriptorProto::unsafe_arena_release_options() {
@ -7197,9 +7203,15 @@ inline PROTOBUF_NAMESPACE_ID::SourceCodeInfo* FileDescriptorProto::release_sourc
_has_bits_[0] &= ~0x00000010u; _has_bits_[0] &= ~0x00000010u;
PROTOBUF_NAMESPACE_ID::SourceCodeInfo* temp = source_code_info_; PROTOBUF_NAMESPACE_ID::SourceCodeInfo* temp = source_code_info_;
source_code_info_ = nullptr; source_code_info_ = nullptr;
#ifdef PROTOBUF_FORCE_COPY_IN_RELEASE
auto* old = reinterpret_cast<::PROTOBUF_NAMESPACE_ID::MessageLite*>(temp);
temp = ::PROTOBUF_NAMESPACE_ID::internal::DuplicateIfNonNull(temp);
if (GetArenaForAllocation() == nullptr) { delete old; }
#else // PROTOBUF_FORCE_COPY_IN_RELEASE
if (GetArenaForAllocation() != nullptr) { if (GetArenaForAllocation() != nullptr) {
temp = ::PROTOBUF_NAMESPACE_ID::internal::DuplicateIfNonNull(temp); temp = ::PROTOBUF_NAMESPACE_ID::internal::DuplicateIfNonNull(temp);
} }
#endif // !PROTOBUF_FORCE_COPY_IN_RELEASE
return temp; return temp;
} }
inline PROTOBUF_NAMESPACE_ID::SourceCodeInfo* FileDescriptorProto::unsafe_arena_release_source_code_info() { inline PROTOBUF_NAMESPACE_ID::SourceCodeInfo* FileDescriptorProto::unsafe_arena_release_source_code_info() {
@ -7399,9 +7411,15 @@ inline PROTOBUF_NAMESPACE_ID::ExtensionRangeOptions* DescriptorProto_ExtensionRa
_has_bits_[0] &= ~0x00000001u; _has_bits_[0] &= ~0x00000001u;
PROTOBUF_NAMESPACE_ID::ExtensionRangeOptions* temp = options_; PROTOBUF_NAMESPACE_ID::ExtensionRangeOptions* temp = options_;
options_ = nullptr; options_ = nullptr;
#ifdef PROTOBUF_FORCE_COPY_IN_RELEASE
auto* old = reinterpret_cast<::PROTOBUF_NAMESPACE_ID::MessageLite*>(temp);
temp = ::PROTOBUF_NAMESPACE_ID::internal::DuplicateIfNonNull(temp);
if (GetArenaForAllocation() == nullptr) { delete old; }
#else // PROTOBUF_FORCE_COPY_IN_RELEASE
if (GetArenaForAllocation() != nullptr) { if (GetArenaForAllocation() != nullptr) {
temp = ::PROTOBUF_NAMESPACE_ID::internal::DuplicateIfNonNull(temp); temp = ::PROTOBUF_NAMESPACE_ID::internal::DuplicateIfNonNull(temp);
} }
#endif // !PROTOBUF_FORCE_COPY_IN_RELEASE
return temp; return temp;
} }
inline PROTOBUF_NAMESPACE_ID::ExtensionRangeOptions* DescriptorProto_ExtensionRange::unsafe_arena_release_options() { inline PROTOBUF_NAMESPACE_ID::ExtensionRangeOptions* DescriptorProto_ExtensionRange::unsafe_arena_release_options() {
@ -7845,9 +7863,15 @@ inline PROTOBUF_NAMESPACE_ID::MessageOptions* DescriptorProto::release_options()
_has_bits_[0] &= ~0x00000002u; _has_bits_[0] &= ~0x00000002u;
PROTOBUF_NAMESPACE_ID::MessageOptions* temp = options_; PROTOBUF_NAMESPACE_ID::MessageOptions* temp = options_;
options_ = nullptr; options_ = nullptr;
#ifdef PROTOBUF_FORCE_COPY_IN_RELEASE
auto* old = reinterpret_cast<::PROTOBUF_NAMESPACE_ID::MessageLite*>(temp);
temp = ::PROTOBUF_NAMESPACE_ID::internal::DuplicateIfNonNull(temp);
if (GetArenaForAllocation() == nullptr) { delete old; }
#else // PROTOBUF_FORCE_COPY_IN_RELEASE
if (GetArenaForAllocation() != nullptr) { if (GetArenaForAllocation() != nullptr) {
temp = ::PROTOBUF_NAMESPACE_ID::internal::DuplicateIfNonNull(temp); temp = ::PROTOBUF_NAMESPACE_ID::internal::DuplicateIfNonNull(temp);
} }
#endif // !PROTOBUF_FORCE_COPY_IN_RELEASE
return temp; return temp;
} }
inline PROTOBUF_NAMESPACE_ID::MessageOptions* DescriptorProto::unsafe_arena_release_options() { inline PROTOBUF_NAMESPACE_ID::MessageOptions* DescriptorProto::unsafe_arena_release_options() {
@ -8496,9 +8520,15 @@ inline PROTOBUF_NAMESPACE_ID::FieldOptions* FieldDescriptorProto::release_option
_has_bits_[0] &= ~0x00000020u; _has_bits_[0] &= ~0x00000020u;
PROTOBUF_NAMESPACE_ID::FieldOptions* temp = options_; PROTOBUF_NAMESPACE_ID::FieldOptions* temp = options_;
options_ = nullptr; options_ = nullptr;
#ifdef PROTOBUF_FORCE_COPY_IN_RELEASE
auto* old = reinterpret_cast<::PROTOBUF_NAMESPACE_ID::MessageLite*>(temp);
temp = ::PROTOBUF_NAMESPACE_ID::internal::DuplicateIfNonNull(temp);
if (GetArenaForAllocation() == nullptr) { delete old; }
#else // PROTOBUF_FORCE_COPY_IN_RELEASE
if (GetArenaForAllocation() != nullptr) { if (GetArenaForAllocation() != nullptr) {
temp = ::PROTOBUF_NAMESPACE_ID::internal::DuplicateIfNonNull(temp); temp = ::PROTOBUF_NAMESPACE_ID::internal::DuplicateIfNonNull(temp);
} }
#endif // !PROTOBUF_FORCE_COPY_IN_RELEASE
return temp; return temp;
} }
inline PROTOBUF_NAMESPACE_ID::FieldOptions* FieldDescriptorProto::unsafe_arena_release_options() { inline PROTOBUF_NAMESPACE_ID::FieldOptions* FieldDescriptorProto::unsafe_arena_release_options() {
@ -8670,9 +8700,15 @@ inline PROTOBUF_NAMESPACE_ID::OneofOptions* OneofDescriptorProto::release_option
_has_bits_[0] &= ~0x00000002u; _has_bits_[0] &= ~0x00000002u;
PROTOBUF_NAMESPACE_ID::OneofOptions* temp = options_; PROTOBUF_NAMESPACE_ID::OneofOptions* temp = options_;
options_ = nullptr; options_ = nullptr;
#ifdef PROTOBUF_FORCE_COPY_IN_RELEASE
auto* old = reinterpret_cast<::PROTOBUF_NAMESPACE_ID::MessageLite*>(temp);
temp = ::PROTOBUF_NAMESPACE_ID::internal::DuplicateIfNonNull(temp);
if (GetArenaForAllocation() == nullptr) { delete old; }
#else // PROTOBUF_FORCE_COPY_IN_RELEASE
if (GetArenaForAllocation() != nullptr) { if (GetArenaForAllocation() != nullptr) {
temp = ::PROTOBUF_NAMESPACE_ID::internal::DuplicateIfNonNull(temp); temp = ::PROTOBUF_NAMESPACE_ID::internal::DuplicateIfNonNull(temp);
} }
#endif // !PROTOBUF_FORCE_COPY_IN_RELEASE
return temp; return temp;
} }
inline PROTOBUF_NAMESPACE_ID::OneofOptions* OneofDescriptorProto::unsafe_arena_release_options() { inline PROTOBUF_NAMESPACE_ID::OneofOptions* OneofDescriptorProto::unsafe_arena_release_options() {
@ -8916,9 +8952,15 @@ inline PROTOBUF_NAMESPACE_ID::EnumOptions* EnumDescriptorProto::release_options(
_has_bits_[0] &= ~0x00000002u; _has_bits_[0] &= ~0x00000002u;
PROTOBUF_NAMESPACE_ID::EnumOptions* temp = options_; PROTOBUF_NAMESPACE_ID::EnumOptions* temp = options_;
options_ = nullptr; options_ = nullptr;
#ifdef PROTOBUF_FORCE_COPY_IN_RELEASE
auto* old = reinterpret_cast<::PROTOBUF_NAMESPACE_ID::MessageLite*>(temp);
temp = ::PROTOBUF_NAMESPACE_ID::internal::DuplicateIfNonNull(temp);
if (GetArenaForAllocation() == nullptr) { delete old; }
#else // PROTOBUF_FORCE_COPY_IN_RELEASE
if (GetArenaForAllocation() != nullptr) { if (GetArenaForAllocation() != nullptr) {
temp = ::PROTOBUF_NAMESPACE_ID::internal::DuplicateIfNonNull(temp); temp = ::PROTOBUF_NAMESPACE_ID::internal::DuplicateIfNonNull(temp);
} }
#endif // !PROTOBUF_FORCE_COPY_IN_RELEASE
return temp; return temp;
} }
inline PROTOBUF_NAMESPACE_ID::EnumOptions* EnumDescriptorProto::unsafe_arena_release_options() { inline PROTOBUF_NAMESPACE_ID::EnumOptions* EnumDescriptorProto::unsafe_arena_release_options() {
@ -9205,9 +9247,15 @@ inline PROTOBUF_NAMESPACE_ID::EnumValueOptions* EnumValueDescriptorProto::releas
_has_bits_[0] &= ~0x00000002u; _has_bits_[0] &= ~0x00000002u;
PROTOBUF_NAMESPACE_ID::EnumValueOptions* temp = options_; PROTOBUF_NAMESPACE_ID::EnumValueOptions* temp = options_;
options_ = nullptr; options_ = nullptr;
#ifdef PROTOBUF_FORCE_COPY_IN_RELEASE
auto* old = reinterpret_cast<::PROTOBUF_NAMESPACE_ID::MessageLite*>(temp);
temp = ::PROTOBUF_NAMESPACE_ID::internal::DuplicateIfNonNull(temp);
if (GetArenaForAllocation() == nullptr) { delete old; }
#else // PROTOBUF_FORCE_COPY_IN_RELEASE
if (GetArenaForAllocation() != nullptr) { if (GetArenaForAllocation() != nullptr) {
temp = ::PROTOBUF_NAMESPACE_ID::internal::DuplicateIfNonNull(temp); temp = ::PROTOBUF_NAMESPACE_ID::internal::DuplicateIfNonNull(temp);
} }
#endif // !PROTOBUF_FORCE_COPY_IN_RELEASE
return temp; return temp;
} }
inline PROTOBUF_NAMESPACE_ID::EnumValueOptions* EnumValueDescriptorProto::unsafe_arena_release_options() { inline PROTOBUF_NAMESPACE_ID::EnumValueOptions* EnumValueDescriptorProto::unsafe_arena_release_options() {
@ -9391,9 +9439,15 @@ inline PROTOBUF_NAMESPACE_ID::ServiceOptions* ServiceDescriptorProto::release_op
_has_bits_[0] &= ~0x00000002u; _has_bits_[0] &= ~0x00000002u;
PROTOBUF_NAMESPACE_ID::ServiceOptions* temp = options_; PROTOBUF_NAMESPACE_ID::ServiceOptions* temp = options_;
options_ = nullptr; options_ = nullptr;
#ifdef PROTOBUF_FORCE_COPY_IN_RELEASE
auto* old = reinterpret_cast<::PROTOBUF_NAMESPACE_ID::MessageLite*>(temp);
temp = ::PROTOBUF_NAMESPACE_ID::internal::DuplicateIfNonNull(temp);
if (GetArenaForAllocation() == nullptr) { delete old; }
#else // PROTOBUF_FORCE_COPY_IN_RELEASE
if (GetArenaForAllocation() != nullptr) { if (GetArenaForAllocation() != nullptr) {
temp = ::PROTOBUF_NAMESPACE_ID::internal::DuplicateIfNonNull(temp); temp = ::PROTOBUF_NAMESPACE_ID::internal::DuplicateIfNonNull(temp);
} }
#endif // !PROTOBUF_FORCE_COPY_IN_RELEASE
return temp; return temp;
} }
inline PROTOBUF_NAMESPACE_ID::ServiceOptions* ServiceDescriptorProto::unsafe_arena_release_options() { inline PROTOBUF_NAMESPACE_ID::ServiceOptions* ServiceDescriptorProto::unsafe_arena_release_options() {
@ -9653,9 +9707,15 @@ inline PROTOBUF_NAMESPACE_ID::MethodOptions* MethodDescriptorProto::release_opti
_has_bits_[0] &= ~0x00000008u; _has_bits_[0] &= ~0x00000008u;
PROTOBUF_NAMESPACE_ID::MethodOptions* temp = options_; PROTOBUF_NAMESPACE_ID::MethodOptions* temp = options_;
options_ = nullptr; options_ = nullptr;
#ifdef PROTOBUF_FORCE_COPY_IN_RELEASE
auto* old = reinterpret_cast<::PROTOBUF_NAMESPACE_ID::MessageLite*>(temp);
temp = ::PROTOBUF_NAMESPACE_ID::internal::DuplicateIfNonNull(temp);
if (GetArenaForAllocation() == nullptr) { delete old; }
#else // PROTOBUF_FORCE_COPY_IN_RELEASE
if (GetArenaForAllocation() != nullptr) { if (GetArenaForAllocation() != nullptr) {
temp = ::PROTOBUF_NAMESPACE_ID::internal::DuplicateIfNonNull(temp); temp = ::PROTOBUF_NAMESPACE_ID::internal::DuplicateIfNonNull(temp);
} }
#endif // !PROTOBUF_FORCE_COPY_IN_RELEASE
return temp; return temp;
} }
inline PROTOBUF_NAMESPACE_ID::MethodOptions* MethodDescriptorProto::unsafe_arena_release_options() { inline PROTOBUF_NAMESPACE_ID::MethodOptions* MethodDescriptorProto::unsafe_arena_release_options() {

@ -189,13 +189,13 @@ failure:
(void) cached_has_bits; (void) cached_has_bits;
// int64 seconds = 1; // int64 seconds = 1;
if (this->seconds() != 0) { if (this->_internal_seconds() != 0) {
target = stream->EnsureSpace(target); target = stream->EnsureSpace(target);
target = ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::WriteInt64ToArray(1, this->_internal_seconds(), target); target = ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::WriteInt64ToArray(1, this->_internal_seconds(), target);
} }
// int32 nanos = 2; // int32 nanos = 2;
if (this->nanos() != 0) { if (this->_internal_nanos() != 0) {
target = stream->EnsureSpace(target); target = stream->EnsureSpace(target);
target = ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::WriteInt32ToArray(2, this->_internal_nanos(), target); target = ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::WriteInt32ToArray(2, this->_internal_nanos(), target);
} }
@ -217,14 +217,14 @@ size_t Duration::ByteSizeLong() const {
(void) cached_has_bits; (void) cached_has_bits;
// int64 seconds = 1; // int64 seconds = 1;
if (this->seconds() != 0) { if (this->_internal_seconds() != 0) {
total_size += 1 + total_size += 1 +
::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::Int64Size( ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::Int64Size(
this->_internal_seconds()); this->_internal_seconds());
} }
// int32 nanos = 2; // int32 nanos = 2;
if (this->nanos() != 0) { if (this->_internal_nanos() != 0) {
total_size += 1 + total_size += 1 +
::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::Int32Size( ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::Int32Size(
this->_internal_nanos()); this->_internal_nanos());
@ -258,10 +258,10 @@ void Duration::MergeFrom(const Duration& from) {
::PROTOBUF_NAMESPACE_ID::uint32 cached_has_bits = 0; ::PROTOBUF_NAMESPACE_ID::uint32 cached_has_bits = 0;
(void) cached_has_bits; (void) cached_has_bits;
if (from.seconds() != 0) { if (from._internal_seconds() != 0) {
_internal_set_seconds(from._internal_seconds()); _internal_set_seconds(from._internal_seconds());
} }
if (from.nanos() != 0) { if (from._internal_nanos() != 0) {
_internal_set_nanos(from._internal_nanos()); _internal_set_nanos(from._internal_nanos());
} }
_internal_metadata_.MergeFrom<::PROTOBUF_NAMESPACE_ID::UnknownFieldSet>(from._internal_metadata_); _internal_metadata_.MergeFrom<::PROTOBUF_NAMESPACE_ID::UnknownFieldSet>(from._internal_metadata_);

@ -0,0 +1,52 @@
// Protocol Buffers - Google's data interchange format
// Copyright 2008 Google Inc. All rights reserved.
// https://developers.google.com/protocol-buffers/
//
// Redistribution and use in source and binary forms, with or without
// modification, are permitted provided that the following conditions are
// met:
//
// * Redistributions of source code must retain the above copyright
// notice, this list of conditions and the following disclaimer.
// * Redistributions in binary form must reproduce the above
// copyright notice, this list of conditions and the following disclaimer
// in the documentation and/or other materials provided with the
// distribution.
// * Neither the name of Google Inc. nor the names of its
// contributors may be used to endorse or promote products derived from
// this software without specific prior written permission.
//
// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
#include <google/protobuf/field_access_listener.h>
#include <google/protobuf/stubs/once.h>
namespace google {
namespace protobuf {
internal::once_flag FieldAccessListener::register_once_ = {};
FieldAccessListener* FieldAccessListener::field_listener_ = nullptr;
FieldAccessListener* FieldAccessListener::GetListener() {
return field_listener_;
}
void FieldAccessListener::RegisterListener(FieldAccessListener* listener) {
// TODO(danilak): Add a GOOGLE_DCHECK for message_injector_ to be nullptr and update
// tests.
internal::call_once(register_once_, [&] { field_listener_ = listener; });
}
} // namespace protobuf
} // namespace google

@ -0,0 +1,246 @@
// Protocol Buffers - Google's data interchange format
// Copyright 2008 Google Inc. All rights reserved.
// https://developers.google.com/protocol-buffers/
//
// Redistribution and use in source and binary forms, with or without
// modification, are permitted provided that the following conditions are
// met:
//
// * Redistributions of source code must retain the above copyright
// notice, this list of conditions and the following disclaimer.
// * Redistributions in binary form must reproduce the above
// copyright notice, this list of conditions and the following disclaimer
// in the documentation and/or other materials provided with the
// distribution.
// * Neither the name of Google Inc. nor the names of its
// contributors may be used to endorse or promote products derived from
// this software without specific prior written permission.
//
// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
#ifndef GOOGLE_PROTOBUF_FIELD_ACCESS_LISTENER_H__
#define GOOGLE_PROTOBUF_FIELD_ACCESS_LISTENER_H__
#include <cstddef>
#include <functional>
#include <string>
#include <type_traits>
#include <utility>
#include <vector>
#include <google/protobuf/stubs/common.h>
#include <google/protobuf/arenastring.h>
#include <google/protobuf/descriptor.h>
#include <google/protobuf/map.h>
#include <google/protobuf/stubs/once.h>
#include <google/protobuf/repeated_field.h>
namespace google {
namespace protobuf {
namespace internal {
template <typename T>
struct ResolvedType {
using type = T;
};
} // namespace internal
// Tracks the events of field accesses for all protos
// that are built with --inject_field_listener_events. This is a global
// interface which you must implement yourself and register with
// RegisterListener() function. All events consist of Descriptors,
// FieldAccessTypes and the underlying storage for tracking the memory which is
// accessed where possible and makes sense. Users are responsible for the
// implementations to be thread safe.
class FieldAccessListener {
public:
FieldAccessListener() = default;
virtual ~FieldAccessListener() = default;
// The memory annotations of the proto fields that are touched by the
// accessors. They are returned as if the operation completes.
struct DataAnnotation {
DataAnnotation() = default;
DataAnnotation(const void* other_address, size_t other_size)
: address(other_address), size(other_size) {}
const void* address = nullptr;
size_t size = 0;
};
using AddressInfo = std::vector<DataAnnotation>;
using AddressInfoExtractor = std::function<AddressInfo()>;
enum class FieldAccessType {
kAdd, // add_<field>(f)
kAddMutable, // add_<field>()
kGet, // <field>() and <repeated_field>(i)
kClear, // clear_<field>()
kHas, // has_<field>()
kList, // <repeated_field>()
kMutable, // mutable_<field>()
kMutableList, // mutable_<repeated_field>()
kRelease, // release_<field>()
kSet, // set_<field>() and set_<repeated_field>(i)
kSize, // <repeated_field>_size()
};
static FieldAccessListener* GetListener();
// Registers the field listener, can be called only once, |listener| must
// outlive all proto accesses (in most cases, the lifetime of the program).
static void RegisterListener(FieldAccessListener* listener);
// All field accessors noted in FieldAccessType have this call.
// |extractor| extracts the address info from the field
virtual void OnFieldAccess(const AddressInfoExtractor& extractor,
const FieldDescriptor* descriptor,
FieldAccessType access_type) = 0;
// Side effect calls.
virtual void OnDeserializationAccess(const Message* message) = 0;
virtual void OnSerializationAccess(const Message* message) = 0;
virtual void OnReflectionAccess(const Descriptor* descriptor) = 0;
virtual void OnByteSizeAccess(const Message* message) = 0;
// We can probably add more if we need to, like {Merge,Copy}{From}Access.
// Extracts all the addresses from the underlying fields.
template <typename T>
AddressInfo ExtractFieldInfo(const T* field_value);
private:
template <typename T>
AddressInfo ExtractFieldInfoSpecific(const T* field_value,
internal::ResolvedType<T>);
AddressInfo ExtractFieldInfoSpecific(const Message* field_value,
internal::ResolvedType<Message>);
AddressInfo ExtractFieldInfoSpecific(const std::string* field_value,
internal::ResolvedType<std::string>);
AddressInfo ExtractFieldInfoSpecific(
const internal::ArenaStringPtr* field_value,
internal::ResolvedType<internal::ArenaStringPtr>);
template <typename T>
AddressInfo ExtractFieldInfoSpecific(
const RepeatedField<T>* field_value,
internal::ResolvedType<RepeatedField<T>>);
template <typename T>
AddressInfo ExtractFieldInfoSpecific(
const RepeatedPtrField<T>* field_value,
internal::ResolvedType<RepeatedPtrField<T>>);
template <typename K, typename V>
AddressInfo ExtractFieldInfoSpecific(const Map<K, V>* field_value,
internal::ResolvedType<Map<K, V>>);
static internal::once_flag register_once_;
static FieldAccessListener* field_listener_;
GOOGLE_DISALLOW_EVIL_CONSTRUCTORS(FieldAccessListener);
};
template <typename T>
inline FieldAccessListener::AddressInfo FieldAccessListener::ExtractFieldInfo(
const T* field_value) {
return ExtractFieldInfoSpecific(field_value, internal::ResolvedType<T>());
}
template <typename T>
inline FieldAccessListener::AddressInfo
FieldAccessListener::ExtractFieldInfoSpecific(const T* field_value,
internal::ResolvedType<T>) {
static_assert(std::is_trivial<T>::value,
"This overload should be chosen only for trivial types");
return FieldAccessListener::AddressInfo{FieldAccessListener::DataAnnotation(
static_cast<const void*>(field_value), sizeof(*field_value))};
}
inline FieldAccessListener::AddressInfo
FieldAccessListener::ExtractFieldInfoSpecific(
const std::string* field_value, internal::ResolvedType<std::string>) {
return FieldAccessListener::AddressInfo{FieldAccessListener::DataAnnotation(
static_cast<const void*>(field_value->c_str()), field_value->length())};
}
inline FieldAccessListener::AddressInfo
FieldAccessListener::ExtractFieldInfoSpecific(
const internal::ArenaStringPtr* field_value,
internal::ResolvedType<internal::ArenaStringPtr>) {
return FieldAccessListener::ExtractFieldInfoSpecific(
field_value->GetPointer(), internal::ResolvedType<std::string>());
}
template <typename T>
inline FieldAccessListener::AddressInfo
FieldAccessListener::ExtractFieldInfoSpecific(
const RepeatedField<T>* field_value,
internal::ResolvedType<RepeatedField<T>>) {
// TODO(jianzhouzh): This can cause data races. Synchronize this if needed.
FieldAccessListener::AddressInfo address_info;
address_info.reserve(field_value->size());
for (int i = 0, ie = field_value->size(); i < ie; ++i) {
auto sub = ExtractFieldInfoSpecific(&field_value->Get(i),
internal::ResolvedType<T>());
address_info.insert(address_info.end(), sub.begin(), sub.end());
}
return address_info;
}
template <typename T>
inline FieldAccessListener::AddressInfo
FieldAccessListener::ExtractFieldInfoSpecific(
const RepeatedPtrField<T>* field_value,
internal::ResolvedType<RepeatedPtrField<T>>) {
FieldAccessListener::AddressInfo address_info;
// TODO(jianzhouzh): This can cause data races. Synchronize this if needed.
address_info.reserve(field_value->size());
for (int i = 0, ie = field_value->size(); i < ie; ++i) {
auto sub = ExtractFieldInfoSpecific(&field_value->Get(i),
internal::ResolvedType<T>());
address_info.insert(address_info.end(), sub.begin(), sub.end());
}
return address_info;
}
template <typename K, typename V>
inline FieldAccessListener::AddressInfo
FieldAccessListener::ExtractFieldInfoSpecific(
const Map<K, V>* field_value, internal::ResolvedType<Map<K, V>>) {
// TODO(jianzhouzh): This can cause data races. Synchronize this if needed.
FieldAccessListener::AddressInfo address_info;
address_info.reserve(field_value->size());
for (auto it = field_value->begin(); it != field_value->end(); ++it) {
auto sub_first =
ExtractFieldInfoSpecific(&it->first, internal::ResolvedType<K>());
auto sub_second =
ExtractFieldInfoSpecific(&it->second, internal::ResolvedType<V>());
address_info.insert(address_info.end(), sub_first.begin(), sub_first.end());
address_info.insert(address_info.end(), sub_second.begin(),
sub_second.end());
}
return address_info;
}
inline FieldAccessListener::AddressInfo
FieldAccessListener::ExtractFieldInfoSpecific(const Message* field_value,
internal::ResolvedType<Message>) {
// TODO(jianzhouzh): implement and adjust all annotations in the compiler.
return {};
}
} // namespace protobuf
} // namespace google
#endif // GOOGLE_PROTOBUF_FIELD_ACCESS_LISTENER_H__

@ -76,6 +76,17 @@ namespace protobuf {
namespace { namespace {
bool IsMapFieldInApi(const FieldDescriptor* field) { return field->is_map(); } bool IsMapFieldInApi(const FieldDescriptor* field) { return field->is_map(); }
#ifdef PROTOBUF_FORCE_COPY_IN_RELEASE
Message* MaybeForceCopy(Arena* arena, Message* msg) {
if (arena != nullptr || msg == nullptr) return msg;
Message* copy = msg->New();
copy->MergeFrom(*msg);
delete msg;
return copy;
}
#endif // PROTOBUF_FORCE_COPY_IN_RELEASE
} // anonymous namespace } // anonymous namespace
namespace internal { namespace internal {
@ -512,13 +523,13 @@ void SwapFieldHelper::SwapMessage(const Reflection* r, Message* lhs,
if (*lhs_sub != nullptr && *rhs_sub != nullptr) { if (*lhs_sub != nullptr && *rhs_sub != nullptr) {
(*lhs_sub)->GetReflection()->Swap(*lhs_sub, *rhs_sub); (*lhs_sub)->GetReflection()->Swap(*lhs_sub, *rhs_sub);
} else if (*lhs_sub == nullptr) { } else if (*lhs_sub == nullptr && r->HasBit(*rhs, field)) {
*lhs_sub = (*rhs_sub)->New(lhs_arena); *lhs_sub = (*rhs_sub)->New(lhs_arena);
(*lhs_sub)->CopyFrom(**rhs_sub); (*lhs_sub)->CopyFrom(**rhs_sub);
r->ClearField(rhs, field); r->ClearField(rhs, field);
// Ensures has bit is unchanged after ClearField. // Ensures has bit is unchanged after ClearField.
r->SetBit(rhs, field); r->SetBit(rhs, field);
} else { } else if (*rhs_sub == nullptr && r->HasBit(*lhs, field)) {
*rhs_sub = (*lhs_sub)->New(rhs_arena); *rhs_sub = (*lhs_sub)->New(rhs_arena);
(*rhs_sub)->CopyFrom(**lhs_sub); (*rhs_sub)->CopyFrom(**lhs_sub);
r->ClearField(lhs, field); r->ClearField(lhs, field);
@ -649,14 +660,14 @@ void Reflection::SwapOneofField(Message* message1, Message* message2,
uint32 oneof_case1 = GetOneofCase(*message1, oneof_descriptor); uint32 oneof_case1 = GetOneofCase(*message1, oneof_descriptor);
uint32 oneof_case2 = GetOneofCase(*message2, oneof_descriptor); uint32 oneof_case2 = GetOneofCase(*message2, oneof_descriptor);
int32 temp_int32; int32 temp_int32 = 0;
int64 temp_int64; int64 temp_int64 = 0;
uint32 temp_uint32; uint32 temp_uint32 = 0;
uint64 temp_uint64; uint64 temp_uint64 = 0;
float temp_float; float temp_float = 0;
double temp_double; double temp_double = 0;
bool temp_bool; bool temp_bool = false;
int temp_int; int temp_int = 0;
Message* temp_message = nullptr; Message* temp_message = nullptr;
std::string temp_string; std::string temp_string;
@ -1196,19 +1207,25 @@ Message* Reflection::ReleaseLast(Message* message,
USAGE_CHECK_ALL(ReleaseLast, REPEATED, MESSAGE); USAGE_CHECK_ALL(ReleaseLast, REPEATED, MESSAGE);
CheckInvalidAccess(schema_, field); CheckInvalidAccess(schema_, field);
Message* released;
if (field->is_extension()) { if (field->is_extension()) {
return static_cast<Message*>( released = static_cast<Message*>(
MutableExtensionSet(message)->ReleaseLast(field->number())); MutableExtensionSet(message)->ReleaseLast(field->number()));
} else { } else {
if (IsMapFieldInApi(field)) { if (IsMapFieldInApi(field)) {
return MutableRaw<MapFieldBase>(message, field) released = MutableRaw<MapFieldBase>(message, field)
->MutableRepeatedField() ->MutableRepeatedField()
->ReleaseLast<GenericTypeHandler<Message> >(); ->ReleaseLast<GenericTypeHandler<Message>>();
} else { } else {
return MutableRaw<RepeatedPtrFieldBase>(message, field) released = MutableRaw<RepeatedPtrFieldBase>(message, field)
->ReleaseLast<GenericTypeHandler<Message> >(); ->ReleaseLast<GenericTypeHandler<Message>>();
} }
} }
#ifdef PROTOBUF_FORCE_COPY_IN_RELEASE
return MaybeForceCopy(message->GetArenaForAllocation(), released);
#else // PROTOBUF_FORCE_COPY_IN_RELEASE
return released;
#endif // !PROTOBUF_FORCE_COPY_IN_RELEASE
} }
void Reflection::SwapElements(Message* message, const FieldDescriptor* field, void Reflection::SwapElements(Message* message, const FieldDescriptor* field,
@ -1918,6 +1935,9 @@ Message* Reflection::ReleaseMessage(Message* message,
CheckInvalidAccess(schema_, field); CheckInvalidAccess(schema_, field);
Message* released = UnsafeArenaReleaseMessage(message, field, factory); Message* released = UnsafeArenaReleaseMessage(message, field, factory);
#ifdef PROTOBUF_FORCE_COPY_IN_RELEASE
released = MaybeForceCopy(message->GetArenaForAllocation(), released);
#endif // PROTOBUF_FORCE_COPY_IN_RELEASE
if (message->GetArenaForAllocation() != nullptr && released != nullptr) { if (message->GetArenaForAllocation() != nullptr && released != nullptr) {
Message* copy_from_arena = released->New(); Message* copy_from_arena = released->New();
copy_from_arena->CopyFrom(*released); copy_from_arena->CopyFrom(*released);

@ -200,6 +200,38 @@ TEST(GeneratedMessageReflectionTest, SwapWithBothSet) {
EXPECT_EQ(532819, message2.optional_int32()); EXPECT_EQ(532819, message2.optional_int32());
} }
TEST(GeneratedMessageReflectionTest, SwapWithLhsCleared) {
unittest::TestAllTypes message1;
unittest::TestAllTypes message2;
TestUtil::SetAllFields(&message1);
// For proto2 message, for message field, Clear only reset hasbits, but
// doesn't delete the underlying field.
message1.Clear();
const Reflection* reflection = message1.GetReflection();
reflection->Swap(&message1, &message2);
TestUtil::ExpectClear(message2);
}
TEST(GeneratedMessageReflectionTest, SwapWithRhsCleared) {
unittest::TestAllTypes message1;
unittest::TestAllTypes message2;
TestUtil::SetAllFields(&message2);
// For proto2 message, for message field, Clear only reset hasbits, but
// doesn't delete the underlying field.
message2.Clear();
const Reflection* reflection = message1.GetReflection();
reflection->Swap(&message1, &message2);
TestUtil::ExpectClear(message1);
}
TEST(GeneratedMessageReflectionTest, SwapExtensions) { TEST(GeneratedMessageReflectionTest, SwapExtensions) {
unittest::TestAllExtensions message1; unittest::TestAllExtensions message1;
unittest::TestAllExtensions message2; unittest::TestAllExtensions message2;

@ -79,7 +79,7 @@ class TcParserBase {
return table->fallback(PROTOBUF_TC_PARAM_PASS); return table->fallback(PROTOBUF_TC_PARAM_PASS);
} }
ptr += sizeof(TagType); ptr += sizeof(TagType);
hasbits |= (1 << data.hasbit_idx()); hasbits |= (uint64_t{1} << data.hasbit_idx());
auto& field = RefAt<FieldType*>(msg, data.offset()); auto& field = RefAt<FieldType*>(msg, data.offset());
if (field == nullptr) { if (field == nullptr) {
auto arena = ctx->data().arena; auto arena = ctx->data().arena;
@ -111,6 +111,18 @@ class TcParserBase {
template <typename LayoutType, typename TagType> template <typename LayoutType, typename TagType>
static const char* PackedFixed(PROTOBUF_TC_PARAM_DECL); static const char* PackedFixed(PROTOBUF_TC_PARAM_DECL);
enum VarintDecode { kNoConversion = 0, kZigZag = 1 };
template <typename FieldType, typename TagType, VarintDecode zigzag>
static const char* RepeatedVarint(PROTOBUF_TC_PARAM_DECL);
template <typename FieldType, typename TagType, VarintDecode zigzag>
static const char* PackedVarint(PROTOBUF_TC_PARAM_DECL);
enum Utf8Type { kNoUtf8 = 0, kUtf8 = 1, kUtf8ValidateOnly = 2 };
template <typename TagType, Utf8Type utf8>
static const char* SingularString(PROTOBUF_TC_PARAM_DECL);
template <typename TagType, Utf8Type utf8>
static const char* RepeatedString(PROTOBUF_TC_PARAM_DECL);
protected: protected:
template <typename T> template <typename T>
static T& RefAt(void* x, size_t offset) { static T& RefAt(void* x, size_t offset) {
@ -231,6 +243,9 @@ struct TcParser final : TcParserBase {
template <typename LayoutType, typename TagType> template <typename LayoutType, typename TagType>
static const char* SingularFixed(PROTOBUF_TC_PARAM_DECL); static const char* SingularFixed(PROTOBUF_TC_PARAM_DECL);
template <typename FieldType, typename TagType, VarintDecode zigzag>
static const char* SingularVarint(PROTOBUF_TC_PARAM_DECL);
}; };
// Declare helper functions: // Declare helper functions:

@ -44,6 +44,47 @@ template const char* TcParser<4>::SingularFixed<uint32_t, uint8_t>(PROTOBUF_TC_P
template const char* TcParser<5>::SingularFixed<uint32_t, uint8_t>(PROTOBUF_TC_PARAM_DECL); template const char* TcParser<5>::SingularFixed<uint32_t, uint8_t>(PROTOBUF_TC_PARAM_DECL);
template const char* TcParserBase::RepeatedFixed<uint32_t, uint8_t>(PROTOBUF_TC_PARAM_DECL); template const char* TcParserBase::RepeatedFixed<uint32_t, uint8_t>(PROTOBUF_TC_PARAM_DECL);
template const char* TcParserBase::PackedFixed<uint32_t, uint8_t>(PROTOBUF_TC_PARAM_DECL); template const char* TcParserBase::PackedFixed<uint32_t, uint8_t>(PROTOBUF_TC_PARAM_DECL);
template const char* TcParser<1>::SingularVarint<uint64_t, uint8_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kNoConversion>(PROTOBUF_TC_PARAM_DECL);
template const char* TcParser<2>::SingularVarint<uint64_t, uint8_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kNoConversion>(PROTOBUF_TC_PARAM_DECL);
template const char* TcParser<3>::SingularVarint<uint64_t, uint8_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kNoConversion>(PROTOBUF_TC_PARAM_DECL);
template const char* TcParser<4>::SingularVarint<uint64_t, uint8_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kNoConversion>(PROTOBUF_TC_PARAM_DECL);
template const char* TcParser<5>::SingularVarint<uint64_t, uint8_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kNoConversion>(PROTOBUF_TC_PARAM_DECL);
template const char* TcParserBase::RepeatedVarint<uint64_t, uint8_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kNoConversion>(PROTOBUF_TC_PARAM_DECL);
template const char* TcParserBase::PackedVarint<uint64_t, uint8_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kNoConversion>(PROTOBUF_TC_PARAM_DECL);
template const char* TcParser<1>::SingularVarint<uint32_t, uint8_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kNoConversion>(PROTOBUF_TC_PARAM_DECL);
template const char* TcParser<2>::SingularVarint<uint32_t, uint8_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kNoConversion>(PROTOBUF_TC_PARAM_DECL);
template const char* TcParser<3>::SingularVarint<uint32_t, uint8_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kNoConversion>(PROTOBUF_TC_PARAM_DECL);
template const char* TcParser<4>::SingularVarint<uint32_t, uint8_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kNoConversion>(PROTOBUF_TC_PARAM_DECL);
template const char* TcParser<5>::SingularVarint<uint32_t, uint8_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kNoConversion>(PROTOBUF_TC_PARAM_DECL);
template const char* TcParserBase::RepeatedVarint<uint32_t, uint8_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kNoConversion>(PROTOBUF_TC_PARAM_DECL);
template const char* TcParserBase::PackedVarint<uint32_t, uint8_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kNoConversion>(PROTOBUF_TC_PARAM_DECL);
template const char* TcParser<1>::SingularVarint<int64_t, uint8_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kZigZag>(PROTOBUF_TC_PARAM_DECL);
template const char* TcParser<2>::SingularVarint<int64_t, uint8_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kZigZag>(PROTOBUF_TC_PARAM_DECL);
template const char* TcParser<3>::SingularVarint<int64_t, uint8_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kZigZag>(PROTOBUF_TC_PARAM_DECL);
template const char* TcParser<4>::SingularVarint<int64_t, uint8_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kZigZag>(PROTOBUF_TC_PARAM_DECL);
template const char* TcParser<5>::SingularVarint<int64_t, uint8_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kZigZag>(PROTOBUF_TC_PARAM_DECL);
template const char* TcParserBase::RepeatedVarint<int64_t, uint8_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kZigZag>(PROTOBUF_TC_PARAM_DECL);
template const char* TcParserBase::PackedVarint<int64_t, uint8_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kZigZag>(PROTOBUF_TC_PARAM_DECL);
template const char* TcParser<1>::SingularVarint<int32_t, uint8_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kZigZag>(PROTOBUF_TC_PARAM_DECL);
template const char* TcParser<2>::SingularVarint<int32_t, uint8_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kZigZag>(PROTOBUF_TC_PARAM_DECL);
template const char* TcParser<3>::SingularVarint<int32_t, uint8_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kZigZag>(PROTOBUF_TC_PARAM_DECL);
template const char* TcParser<4>::SingularVarint<int32_t, uint8_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kZigZag>(PROTOBUF_TC_PARAM_DECL);
template const char* TcParser<5>::SingularVarint<int32_t, uint8_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kZigZag>(PROTOBUF_TC_PARAM_DECL);
template const char* TcParserBase::RepeatedVarint<int32_t, uint8_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kZigZag>(PROTOBUF_TC_PARAM_DECL);
template const char* TcParserBase::PackedVarint<int32_t, uint8_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kZigZag>(PROTOBUF_TC_PARAM_DECL);
template const char* TcParser<1>::SingularVarint<bool, uint8_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kNoConversion>(PROTOBUF_TC_PARAM_DECL);
template const char* TcParser<2>::SingularVarint<bool, uint8_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kNoConversion>(PROTOBUF_TC_PARAM_DECL);
template const char* TcParser<3>::SingularVarint<bool, uint8_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kNoConversion>(PROTOBUF_TC_PARAM_DECL);
template const char* TcParser<4>::SingularVarint<bool, uint8_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kNoConversion>(PROTOBUF_TC_PARAM_DECL);
template const char* TcParser<5>::SingularVarint<bool, uint8_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kNoConversion>(PROTOBUF_TC_PARAM_DECL);
template const char* TcParserBase::RepeatedVarint<bool, uint8_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kNoConversion>(PROTOBUF_TC_PARAM_DECL);
template const char* TcParserBase::PackedVarint<bool, uint8_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kNoConversion>(PROTOBUF_TC_PARAM_DECL);
template const char* TcParserBase::SingularString<uint8_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kNoUtf8>(PROTOBUF_TC_PARAM_DECL);
template const char* TcParserBase::RepeatedString<uint8_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kNoUtf8>(PROTOBUF_TC_PARAM_DECL);
template const char* TcParserBase::SingularString<uint8_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kUtf8>(PROTOBUF_TC_PARAM_DECL);
template const char* TcParserBase::RepeatedString<uint8_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kUtf8>(PROTOBUF_TC_PARAM_DECL);
template const char* TcParserBase::SingularString<uint8_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kUtf8ValidateOnly>(PROTOBUF_TC_PARAM_DECL);
template const char* TcParserBase::RepeatedString<uint8_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kUtf8ValidateOnly>(PROTOBUF_TC_PARAM_DECL);
template const char* TcParser<1>::SingularFixed<uint64_t, uint16_t>(PROTOBUF_TC_PARAM_DECL); template const char* TcParser<1>::SingularFixed<uint64_t, uint16_t>(PROTOBUF_TC_PARAM_DECL);
template const char* TcParser<2>::SingularFixed<uint64_t, uint16_t>(PROTOBUF_TC_PARAM_DECL); template const char* TcParser<2>::SingularFixed<uint64_t, uint16_t>(PROTOBUF_TC_PARAM_DECL);
template const char* TcParser<3>::SingularFixed<uint64_t, uint16_t>(PROTOBUF_TC_PARAM_DECL); template const char* TcParser<3>::SingularFixed<uint64_t, uint16_t>(PROTOBUF_TC_PARAM_DECL);
@ -58,6 +99,47 @@ template const char* TcParser<4>::SingularFixed<uint32_t, uint16_t>(PROTOBUF_TC_
template const char* TcParser<5>::SingularFixed<uint32_t, uint16_t>(PROTOBUF_TC_PARAM_DECL); template const char* TcParser<5>::SingularFixed<uint32_t, uint16_t>(PROTOBUF_TC_PARAM_DECL);
template const char* TcParserBase::RepeatedFixed<uint32_t, uint16_t>(PROTOBUF_TC_PARAM_DECL); template const char* TcParserBase::RepeatedFixed<uint32_t, uint16_t>(PROTOBUF_TC_PARAM_DECL);
template const char* TcParserBase::PackedFixed<uint32_t, uint16_t>(PROTOBUF_TC_PARAM_DECL); template const char* TcParserBase::PackedFixed<uint32_t, uint16_t>(PROTOBUF_TC_PARAM_DECL);
template const char* TcParser<1>::SingularVarint<uint64_t, uint16_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kNoConversion>(PROTOBUF_TC_PARAM_DECL);
template const char* TcParser<2>::SingularVarint<uint64_t, uint16_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kNoConversion>(PROTOBUF_TC_PARAM_DECL);
template const char* TcParser<3>::SingularVarint<uint64_t, uint16_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kNoConversion>(PROTOBUF_TC_PARAM_DECL);
template const char* TcParser<4>::SingularVarint<uint64_t, uint16_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kNoConversion>(PROTOBUF_TC_PARAM_DECL);
template const char* TcParser<5>::SingularVarint<uint64_t, uint16_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kNoConversion>(PROTOBUF_TC_PARAM_DECL);
template const char* TcParserBase::RepeatedVarint<uint64_t, uint16_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kNoConversion>(PROTOBUF_TC_PARAM_DECL);
template const char* TcParserBase::PackedVarint<uint64_t, uint16_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kNoConversion>(PROTOBUF_TC_PARAM_DECL);
template const char* TcParser<1>::SingularVarint<uint32_t, uint16_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kNoConversion>(PROTOBUF_TC_PARAM_DECL);
template const char* TcParser<2>::SingularVarint<uint32_t, uint16_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kNoConversion>(PROTOBUF_TC_PARAM_DECL);
template const char* TcParser<3>::SingularVarint<uint32_t, uint16_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kNoConversion>(PROTOBUF_TC_PARAM_DECL);
template const char* TcParser<4>::SingularVarint<uint32_t, uint16_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kNoConversion>(PROTOBUF_TC_PARAM_DECL);
template const char* TcParser<5>::SingularVarint<uint32_t, uint16_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kNoConversion>(PROTOBUF_TC_PARAM_DECL);
template const char* TcParserBase::RepeatedVarint<uint32_t, uint16_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kNoConversion>(PROTOBUF_TC_PARAM_DECL);
template const char* TcParserBase::PackedVarint<uint32_t, uint16_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kNoConversion>(PROTOBUF_TC_PARAM_DECL);
template const char* TcParser<1>::SingularVarint<int64_t, uint16_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kZigZag>(PROTOBUF_TC_PARAM_DECL);
template const char* TcParser<2>::SingularVarint<int64_t, uint16_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kZigZag>(PROTOBUF_TC_PARAM_DECL);
template const char* TcParser<3>::SingularVarint<int64_t, uint16_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kZigZag>(PROTOBUF_TC_PARAM_DECL);
template const char* TcParser<4>::SingularVarint<int64_t, uint16_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kZigZag>(PROTOBUF_TC_PARAM_DECL);
template const char* TcParser<5>::SingularVarint<int64_t, uint16_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kZigZag>(PROTOBUF_TC_PARAM_DECL);
template const char* TcParserBase::RepeatedVarint<int64_t, uint16_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kZigZag>(PROTOBUF_TC_PARAM_DECL);
template const char* TcParserBase::PackedVarint<int64_t, uint16_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kZigZag>(PROTOBUF_TC_PARAM_DECL);
template const char* TcParser<1>::SingularVarint<int32_t, uint16_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kZigZag>(PROTOBUF_TC_PARAM_DECL);
template const char* TcParser<2>::SingularVarint<int32_t, uint16_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kZigZag>(PROTOBUF_TC_PARAM_DECL);
template const char* TcParser<3>::SingularVarint<int32_t, uint16_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kZigZag>(PROTOBUF_TC_PARAM_DECL);
template const char* TcParser<4>::SingularVarint<int32_t, uint16_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kZigZag>(PROTOBUF_TC_PARAM_DECL);
template const char* TcParser<5>::SingularVarint<int32_t, uint16_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kZigZag>(PROTOBUF_TC_PARAM_DECL);
template const char* TcParserBase::RepeatedVarint<int32_t, uint16_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kZigZag>(PROTOBUF_TC_PARAM_DECL);
template const char* TcParserBase::PackedVarint<int32_t, uint16_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kZigZag>(PROTOBUF_TC_PARAM_DECL);
template const char* TcParser<1>::SingularVarint<bool, uint16_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kNoConversion>(PROTOBUF_TC_PARAM_DECL);
template const char* TcParser<2>::SingularVarint<bool, uint16_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kNoConversion>(PROTOBUF_TC_PARAM_DECL);
template const char* TcParser<3>::SingularVarint<bool, uint16_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kNoConversion>(PROTOBUF_TC_PARAM_DECL);
template const char* TcParser<4>::SingularVarint<bool, uint16_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kNoConversion>(PROTOBUF_TC_PARAM_DECL);
template const char* TcParser<5>::SingularVarint<bool, uint16_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kNoConversion>(PROTOBUF_TC_PARAM_DECL);
template const char* TcParserBase::RepeatedVarint<bool, uint16_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kNoConversion>(PROTOBUF_TC_PARAM_DECL);
template const char* TcParserBase::PackedVarint<bool, uint16_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kNoConversion>(PROTOBUF_TC_PARAM_DECL);
template const char* TcParserBase::SingularString<uint16_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kNoUtf8>(PROTOBUF_TC_PARAM_DECL);
template const char* TcParserBase::RepeatedString<uint16_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kNoUtf8>(PROTOBUF_TC_PARAM_DECL);
template const char* TcParserBase::SingularString<uint16_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kUtf8>(PROTOBUF_TC_PARAM_DECL);
template const char* TcParserBase::RepeatedString<uint16_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kUtf8>(PROTOBUF_TC_PARAM_DECL);
template const char* TcParserBase::SingularString<uint16_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kUtf8ValidateOnly>(PROTOBUF_TC_PARAM_DECL);
template const char* TcParserBase::RepeatedString<uint16_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kUtf8ValidateOnly>(PROTOBUF_TC_PARAM_DECL);
#else #else
extern template const char* TcParser<1>::SingularFixed<uint64_t, uint8_t>(PROTOBUF_TC_PARAM_DECL); extern template const char* TcParser<1>::SingularFixed<uint64_t, uint8_t>(PROTOBUF_TC_PARAM_DECL);
extern template const char* TcParser<2>::SingularFixed<uint64_t, uint8_t>(PROTOBUF_TC_PARAM_DECL); extern template const char* TcParser<2>::SingularFixed<uint64_t, uint8_t>(PROTOBUF_TC_PARAM_DECL);
@ -73,6 +155,47 @@ extern template const char* TcParser<4>::SingularFixed<uint32_t, uint8_t>(PROTOB
extern template const char* TcParser<5>::SingularFixed<uint32_t, uint8_t>(PROTOBUF_TC_PARAM_DECL); extern template const char* TcParser<5>::SingularFixed<uint32_t, uint8_t>(PROTOBUF_TC_PARAM_DECL);
extern template const char* TcParserBase::RepeatedFixed<uint32_t, uint8_t>(PROTOBUF_TC_PARAM_DECL); extern template const char* TcParserBase::RepeatedFixed<uint32_t, uint8_t>(PROTOBUF_TC_PARAM_DECL);
extern template const char* TcParserBase::PackedFixed<uint32_t, uint8_t>(PROTOBUF_TC_PARAM_DECL); extern template const char* TcParserBase::PackedFixed<uint32_t, uint8_t>(PROTOBUF_TC_PARAM_DECL);
extern template const char* TcParser<1>::SingularVarint<uint64_t, uint8_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kNoConversion>(PROTOBUF_TC_PARAM_DECL);
extern template const char* TcParser<2>::SingularVarint<uint64_t, uint8_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kNoConversion>(PROTOBUF_TC_PARAM_DECL);
extern template const char* TcParser<3>::SingularVarint<uint64_t, uint8_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kNoConversion>(PROTOBUF_TC_PARAM_DECL);
extern template const char* TcParser<4>::SingularVarint<uint64_t, uint8_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kNoConversion>(PROTOBUF_TC_PARAM_DECL);
extern template const char* TcParser<5>::SingularVarint<uint64_t, uint8_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kNoConversion>(PROTOBUF_TC_PARAM_DECL);
extern template const char* TcParserBase::RepeatedVarint<uint64_t, uint8_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kNoConversion>(PROTOBUF_TC_PARAM_DECL);
extern template const char* TcParserBase::PackedVarint<uint64_t, uint8_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kNoConversion>(PROTOBUF_TC_PARAM_DECL);
extern template const char* TcParser<1>::SingularVarint<uint32_t, uint8_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kNoConversion>(PROTOBUF_TC_PARAM_DECL);
extern template const char* TcParser<2>::SingularVarint<uint32_t, uint8_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kNoConversion>(PROTOBUF_TC_PARAM_DECL);
extern template const char* TcParser<3>::SingularVarint<uint32_t, uint8_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kNoConversion>(PROTOBUF_TC_PARAM_DECL);
extern template const char* TcParser<4>::SingularVarint<uint32_t, uint8_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kNoConversion>(PROTOBUF_TC_PARAM_DECL);
extern template const char* TcParser<5>::SingularVarint<uint32_t, uint8_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kNoConversion>(PROTOBUF_TC_PARAM_DECL);
extern template const char* TcParserBase::RepeatedVarint<uint32_t, uint8_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kNoConversion>(PROTOBUF_TC_PARAM_DECL);
extern template const char* TcParserBase::PackedVarint<uint32_t, uint8_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kNoConversion>(PROTOBUF_TC_PARAM_DECL);
extern template const char* TcParser<1>::SingularVarint<int64_t, uint8_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kZigZag>(PROTOBUF_TC_PARAM_DECL);
extern template const char* TcParser<2>::SingularVarint<int64_t, uint8_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kZigZag>(PROTOBUF_TC_PARAM_DECL);
extern template const char* TcParser<3>::SingularVarint<int64_t, uint8_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kZigZag>(PROTOBUF_TC_PARAM_DECL);
extern template const char* TcParser<4>::SingularVarint<int64_t, uint8_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kZigZag>(PROTOBUF_TC_PARAM_DECL);
extern template const char* TcParser<5>::SingularVarint<int64_t, uint8_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kZigZag>(PROTOBUF_TC_PARAM_DECL);
extern template const char* TcParserBase::RepeatedVarint<int64_t, uint8_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kZigZag>(PROTOBUF_TC_PARAM_DECL);
extern template const char* TcParserBase::PackedVarint<int64_t, uint8_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kZigZag>(PROTOBUF_TC_PARAM_DECL);
extern template const char* TcParser<1>::SingularVarint<int32_t, uint8_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kZigZag>(PROTOBUF_TC_PARAM_DECL);
extern template const char* TcParser<2>::SingularVarint<int32_t, uint8_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kZigZag>(PROTOBUF_TC_PARAM_DECL);
extern template const char* TcParser<3>::SingularVarint<int32_t, uint8_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kZigZag>(PROTOBUF_TC_PARAM_DECL);
extern template const char* TcParser<4>::SingularVarint<int32_t, uint8_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kZigZag>(PROTOBUF_TC_PARAM_DECL);
extern template const char* TcParser<5>::SingularVarint<int32_t, uint8_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kZigZag>(PROTOBUF_TC_PARAM_DECL);
extern template const char* TcParserBase::RepeatedVarint<int32_t, uint8_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kZigZag>(PROTOBUF_TC_PARAM_DECL);
extern template const char* TcParserBase::PackedVarint<int32_t, uint8_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kZigZag>(PROTOBUF_TC_PARAM_DECL);
extern template const char* TcParser<1>::SingularVarint<bool, uint8_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kNoConversion>(PROTOBUF_TC_PARAM_DECL);
extern template const char* TcParser<2>::SingularVarint<bool, uint8_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kNoConversion>(PROTOBUF_TC_PARAM_DECL);
extern template const char* TcParser<3>::SingularVarint<bool, uint8_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kNoConversion>(PROTOBUF_TC_PARAM_DECL);
extern template const char* TcParser<4>::SingularVarint<bool, uint8_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kNoConversion>(PROTOBUF_TC_PARAM_DECL);
extern template const char* TcParser<5>::SingularVarint<bool, uint8_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kNoConversion>(PROTOBUF_TC_PARAM_DECL);
extern template const char* TcParserBase::RepeatedVarint<bool, uint8_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kNoConversion>(PROTOBUF_TC_PARAM_DECL);
extern template const char* TcParserBase::PackedVarint<bool, uint8_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kNoConversion>(PROTOBUF_TC_PARAM_DECL);
extern template const char* TcParserBase::SingularString<uint8_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kNoUtf8>(PROTOBUF_TC_PARAM_DECL);
extern template const char* TcParserBase::RepeatedString<uint8_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kNoUtf8>(PROTOBUF_TC_PARAM_DECL);
extern template const char* TcParserBase::SingularString<uint8_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kUtf8>(PROTOBUF_TC_PARAM_DECL);
extern template const char* TcParserBase::RepeatedString<uint8_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kUtf8>(PROTOBUF_TC_PARAM_DECL);
extern template const char* TcParserBase::SingularString<uint8_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kUtf8ValidateOnly>(PROTOBUF_TC_PARAM_DECL);
extern template const char* TcParserBase::RepeatedString<uint8_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kUtf8ValidateOnly>(PROTOBUF_TC_PARAM_DECL);
extern template const char* TcParser<1>::SingularFixed<uint64_t, uint16_t>(PROTOBUF_TC_PARAM_DECL); extern template const char* TcParser<1>::SingularFixed<uint64_t, uint16_t>(PROTOBUF_TC_PARAM_DECL);
extern template const char* TcParser<2>::SingularFixed<uint64_t, uint16_t>(PROTOBUF_TC_PARAM_DECL); extern template const char* TcParser<2>::SingularFixed<uint64_t, uint16_t>(PROTOBUF_TC_PARAM_DECL);
extern template const char* TcParser<3>::SingularFixed<uint64_t, uint16_t>(PROTOBUF_TC_PARAM_DECL); extern template const char* TcParser<3>::SingularFixed<uint64_t, uint16_t>(PROTOBUF_TC_PARAM_DECL);
@ -87,5 +210,46 @@ extern template const char* TcParser<4>::SingularFixed<uint32_t, uint16_t>(PROTO
extern template const char* TcParser<5>::SingularFixed<uint32_t, uint16_t>(PROTOBUF_TC_PARAM_DECL); extern template const char* TcParser<5>::SingularFixed<uint32_t, uint16_t>(PROTOBUF_TC_PARAM_DECL);
extern template const char* TcParserBase::RepeatedFixed<uint32_t, uint16_t>(PROTOBUF_TC_PARAM_DECL); extern template const char* TcParserBase::RepeatedFixed<uint32_t, uint16_t>(PROTOBUF_TC_PARAM_DECL);
extern template const char* TcParserBase::PackedFixed<uint32_t, uint16_t>(PROTOBUF_TC_PARAM_DECL); extern template const char* TcParserBase::PackedFixed<uint32_t, uint16_t>(PROTOBUF_TC_PARAM_DECL);
extern template const char* TcParser<1>::SingularVarint<uint64_t, uint16_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kNoConversion>(PROTOBUF_TC_PARAM_DECL);
extern template const char* TcParser<2>::SingularVarint<uint64_t, uint16_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kNoConversion>(PROTOBUF_TC_PARAM_DECL);
extern template const char* TcParser<3>::SingularVarint<uint64_t, uint16_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kNoConversion>(PROTOBUF_TC_PARAM_DECL);
extern template const char* TcParser<4>::SingularVarint<uint64_t, uint16_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kNoConversion>(PROTOBUF_TC_PARAM_DECL);
extern template const char* TcParser<5>::SingularVarint<uint64_t, uint16_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kNoConversion>(PROTOBUF_TC_PARAM_DECL);
extern template const char* TcParserBase::RepeatedVarint<uint64_t, uint16_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kNoConversion>(PROTOBUF_TC_PARAM_DECL);
extern template const char* TcParserBase::PackedVarint<uint64_t, uint16_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kNoConversion>(PROTOBUF_TC_PARAM_DECL);
extern template const char* TcParser<1>::SingularVarint<uint32_t, uint16_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kNoConversion>(PROTOBUF_TC_PARAM_DECL);
extern template const char* TcParser<2>::SingularVarint<uint32_t, uint16_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kNoConversion>(PROTOBUF_TC_PARAM_DECL);
extern template const char* TcParser<3>::SingularVarint<uint32_t, uint16_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kNoConversion>(PROTOBUF_TC_PARAM_DECL);
extern template const char* TcParser<4>::SingularVarint<uint32_t, uint16_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kNoConversion>(PROTOBUF_TC_PARAM_DECL);
extern template const char* TcParser<5>::SingularVarint<uint32_t, uint16_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kNoConversion>(PROTOBUF_TC_PARAM_DECL);
extern template const char* TcParserBase::RepeatedVarint<uint32_t, uint16_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kNoConversion>(PROTOBUF_TC_PARAM_DECL);
extern template const char* TcParserBase::PackedVarint<uint32_t, uint16_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kNoConversion>(PROTOBUF_TC_PARAM_DECL);
extern template const char* TcParser<1>::SingularVarint<int64_t, uint16_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kZigZag>(PROTOBUF_TC_PARAM_DECL);
extern template const char* TcParser<2>::SingularVarint<int64_t, uint16_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kZigZag>(PROTOBUF_TC_PARAM_DECL);
extern template const char* TcParser<3>::SingularVarint<int64_t, uint16_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kZigZag>(PROTOBUF_TC_PARAM_DECL);
extern template const char* TcParser<4>::SingularVarint<int64_t, uint16_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kZigZag>(PROTOBUF_TC_PARAM_DECL);
extern template const char* TcParser<5>::SingularVarint<int64_t, uint16_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kZigZag>(PROTOBUF_TC_PARAM_DECL);
extern template const char* TcParserBase::RepeatedVarint<int64_t, uint16_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kZigZag>(PROTOBUF_TC_PARAM_DECL);
extern template const char* TcParserBase::PackedVarint<int64_t, uint16_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kZigZag>(PROTOBUF_TC_PARAM_DECL);
extern template const char* TcParser<1>::SingularVarint<int32_t, uint16_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kZigZag>(PROTOBUF_TC_PARAM_DECL);
extern template const char* TcParser<2>::SingularVarint<int32_t, uint16_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kZigZag>(PROTOBUF_TC_PARAM_DECL);
extern template const char* TcParser<3>::SingularVarint<int32_t, uint16_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kZigZag>(PROTOBUF_TC_PARAM_DECL);
extern template const char* TcParser<4>::SingularVarint<int32_t, uint16_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kZigZag>(PROTOBUF_TC_PARAM_DECL);
extern template const char* TcParser<5>::SingularVarint<int32_t, uint16_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kZigZag>(PROTOBUF_TC_PARAM_DECL);
extern template const char* TcParserBase::RepeatedVarint<int32_t, uint16_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kZigZag>(PROTOBUF_TC_PARAM_DECL);
extern template const char* TcParserBase::PackedVarint<int32_t, uint16_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kZigZag>(PROTOBUF_TC_PARAM_DECL);
extern template const char* TcParser<1>::SingularVarint<bool, uint16_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kNoConversion>(PROTOBUF_TC_PARAM_DECL);
extern template const char* TcParser<2>::SingularVarint<bool, uint16_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kNoConversion>(PROTOBUF_TC_PARAM_DECL);
extern template const char* TcParser<3>::SingularVarint<bool, uint16_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kNoConversion>(PROTOBUF_TC_PARAM_DECL);
extern template const char* TcParser<4>::SingularVarint<bool, uint16_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kNoConversion>(PROTOBUF_TC_PARAM_DECL);
extern template const char* TcParser<5>::SingularVarint<bool, uint16_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kNoConversion>(PROTOBUF_TC_PARAM_DECL);
extern template const char* TcParserBase::RepeatedVarint<bool, uint16_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kNoConversion>(PROTOBUF_TC_PARAM_DECL);
extern template const char* TcParserBase::PackedVarint<bool, uint16_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kNoConversion>(PROTOBUF_TC_PARAM_DECL);
extern template const char* TcParserBase::SingularString<uint16_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kNoUtf8>(PROTOBUF_TC_PARAM_DECL);
extern template const char* TcParserBase::RepeatedString<uint16_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kNoUtf8>(PROTOBUF_TC_PARAM_DECL);
extern template const char* TcParserBase::SingularString<uint16_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kUtf8>(PROTOBUF_TC_PARAM_DECL);
extern template const char* TcParserBase::RepeatedString<uint16_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kUtf8>(PROTOBUF_TC_PARAM_DECL);
extern template const char* TcParserBase::SingularString<uint16_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kUtf8ValidateOnly>(PROTOBUF_TC_PARAM_DECL);
extern template const char* TcParserBase::RepeatedString<uint16_t, ::PROTOBUF_NAMESPACE_ID::internal::TcParserBase::kUtf8ValidateOnly>(PROTOBUF_TC_PARAM_DECL);
#endif #endif
// clang-format on // clang-format on

@ -77,7 +77,7 @@ const char* TcParser<kPowerOf2>::SingularFixed(PROTOBUF_TC_PARAM_DECL) {
return table->fallback(PROTOBUF_TC_PARAM_PASS); return table->fallback(PROTOBUF_TC_PARAM_PASS);
} }
ptr += sizeof(TagType); // Consume tag ptr += sizeof(TagType); // Consume tag
hasbits |= (1 << data.hasbit_idx()); hasbits |= (uint64_t{1} << data.hasbit_idx());
std::memcpy(Offset(msg, data.offset()), ptr, sizeof(LayoutType)); std::memcpy(Offset(msg, data.offset()), ptr, sizeof(LayoutType));
ptr += sizeof(LayoutType); ptr += sizeof(LayoutType);
// TailCall syncs any pending hasbits: // TailCall syncs any pending hasbits:
@ -140,6 +140,300 @@ const char* TcParserBase::PackedFixed(PROTOBUF_TC_PARAM_DECL) {
static_cast<RepeatedField<LayoutType>*>(&field)); static_cast<RepeatedField<LayoutType>*>(&field));
} }
//////////////////////////////////////////////////////////////////////////////
// Varint fields
//////////////////////////////////////////////////////////////////////////////
namespace {
inline PROTOBUF_ALWAYS_INLINE std::pair<const char*, uint64_t>
Parse64FallbackPair(const char* p, int64_t res1) {
auto ptr = reinterpret_cast<const int8_t*>(p);
// The algorithm relies on sign extension for each byte to set all high bits
// when the varint continues. It also relies on asserting all of the lower
// bits for each successive byte read. This allows the result to be aggregated
// using a bitwise AND. For example:
//
// 8 1 64 57 ... 24 17 16 9 8 1
// ptr[0] = 1aaa aaaa ; res1 = 1111 1111 ... 1111 1111 1111 1111 1aaa aaaa
// ptr[1] = 1bbb bbbb ; res2 = 1111 1111 ... 1111 1111 11bb bbbb b111 1111
// ptr[2] = 1ccc cccc ; res3 = 0000 0000 ... 000c cccc cc11 1111 1111 1111
// ---------------------------------------------
// res1 & res2 & res3 = 0000 0000 ... 000c cccc ccbb bbbb baaa aaaa
//
// On x86-64, a shld from a single register filled with enough 1s in the high
// bits can accomplish all this in one instruction. It so happens that res1
// has 57 high bits of ones, which is enough for the largest shift done.
GOOGLE_DCHECK_EQ(res1 >> 7, -1);
uint64_t ones = res1; // save the high 1 bits from res1 (input to SHLD)
uint64_t byte; // the "next" 7-bit chunk, shifted (result from SHLD)
int64_t res2, res3; // accumulated result chunks
#define SHLD(n) byte = ((byte << (n * 7)) | (ones >> (64 - (n * 7))))
int sign_bit;
#if defined(__GCC_ASM_FLAG_OUTPUTS__) && defined(__x86_64__)
// For the first two rounds (ptr[1] and ptr[2]), micro benchmarks show a
// substantial improvement from capturing the sign from the condition code
// register on x86-64.
#define SHLD_SIGN(n) \
asm("shldq %3, %2, %1" \
: "=@ccs"(sign_bit), "+r"(byte) \
: "r"(ones), "i"(n * 7))
#else
// Generic fallback:
#define SHLD_SIGN(n) \
do { \
SHLD(n); \
sign_bit = static_cast<int64_t>(byte) < 0; \
} while (0)
#endif
byte = ptr[1];
SHLD_SIGN(1);
res2 = byte;
if (!sign_bit) goto done2;
byte = ptr[2];
SHLD_SIGN(2);
res3 = byte;
if (!sign_bit) goto done3;
#undef SHLD_SIGN
// For the remainder of the chunks, check the sign of the AND result.
byte = ptr[3];
SHLD(3);
res1 &= byte;
if (res1 >= 0) goto done4;
byte = ptr[4];
SHLD(4);
res2 &= byte;
if (res2 >= 0) goto done5;
byte = ptr[5];
SHLD(5);
res3 &= byte;
if (res3 >= 0) goto done6;
byte = ptr[6];
SHLD(6);
res1 &= byte;
if (res1 >= 0) goto done7;
byte = ptr[7];
SHLD(7);
res2 &= byte;
if (res2 >= 0) goto done8;
byte = ptr[8];
SHLD(8);
res3 &= byte;
if (res3 >= 0) goto done9;
#undef SHLD
// For valid 64bit varints, the 10th byte/ptr[9] should be exactly 1. In this
// case, the continuation bit of ptr[8] already set the top bit of res3
// correctly, so all we have to do is check that the expected case is true.
byte = ptr[9];
if (PROTOBUF_PREDICT_TRUE(byte == 1)) goto done10;
// A value of 0, however, represents an over-serialized varint. This case
// should not happen, but if does (say, due to a nonconforming serializer),
// deassert the continuation bit that came from ptr[8].
if (byte == 0) {
res3 ^= static_cast<uint64_t>(1) << 63;
goto done10;
}
// If the 10th byte/ptr[9] itself has any other value, then it is too big to
// fit in 64 bits. If the continue bit is set, it is an unterminated varint.
return {nullptr, 0};
#define DONE(n) done##n : return {p + n, res1 & res2 & res3};
done2:
return {p + 2, res1 & res2};
DONE(3)
DONE(4)
DONE(5)
DONE(6)
DONE(7)
DONE(8)
DONE(9)
DONE(10)
#undef DONE
}
inline PROTOBUF_ALWAYS_INLINE const char* ParseVarint(const char* p,
uint64_t* value) {
int64_t byte = static_cast<int8_t>(*p);
if (PROTOBUF_PREDICT_TRUE(byte >= 0)) {
*value = byte;
return p + 1;
} else {
auto tmp = Parse64FallbackPair(p, byte);
if (PROTOBUF_PREDICT_TRUE(tmp.first)) *value = tmp.second;
return tmp.first;
}
}
} // namespace
template <uint32_t kPowerOf2>
template <typename FieldType, typename TagType,
TcParserBase::VarintDecode zigzag>
const char* TcParser<kPowerOf2>::SingularVarint(PROTOBUF_TC_PARAM_DECL) {
if (PROTOBUF_PREDICT_FALSE(static_cast<TagType>(data.coded_tag()) != 0)) {
return table->fallback(PROTOBUF_TC_PARAM_PASS);
}
ptr += sizeof(TagType); // Consume tag
hasbits |= (uint64_t{1} << data.hasbit_idx());
uint64_t tmp;
ptr = ParseVarint(ptr, &tmp);
if (ptr == nullptr) {
return Error(PROTOBUF_TC_PARAM_PASS);
}
RefAt<FieldType>(msg, data.offset()) = static_cast<FieldType>(
zigzag ? google::protobuf::internal::WireFormatLite::ZigZagDecode64(tmp) : tmp);
PROTOBUF_MUSTTAIL return TailCall(PROTOBUF_TC_PARAM_PASS);
}
template <typename FieldType, typename TagType,
TcParserBase::VarintDecode zigzag>
PROTOBUF_NOINLINE const char* TcParserBase::RepeatedVarint(
PROTOBUF_TC_PARAM_DECL) {
if (PROTOBUF_PREDICT_FALSE(static_cast<TagType>(data.coded_tag()) != 0)) {
// Try parsing as non-packed repeated:
InvertPacked<WireFormatLite::WIRETYPE_VARINT>(data);
if (static_cast<TagType>(data.coded_tag()) == 0) {
return PackedVarint<FieldType, TagType, zigzag>(PROTOBUF_TC_PARAM_PASS);
} else {
return table->fallback(PROTOBUF_TC_PARAM_PASS);
}
}
auto& field = RefAt<RepeatedField<FieldType>>(msg, data.offset());
auto expected_tag = UnalignedLoad<TagType>(ptr);
do {
ptr += sizeof(TagType);
uint64_t tmp;
ptr = ParseVarint(ptr, &tmp);
if (ptr == nullptr) {
return Error(PROTOBUF_TC_PARAM_PASS);
}
field.Add(zigzag ? google::protobuf::internal::WireFormatLite::ZigZagDecode64(tmp)
: tmp);
if (!ctx->DataAvailable(ptr)) {
break;
}
} while (UnalignedLoad<TagType>(ptr) == expected_tag);
return Return(PROTOBUF_TC_PARAM_PASS);
}
template <typename FieldType, typename TagType,
TcParserBase::VarintDecode zigzag>
PROTOBUF_NOINLINE const char* TcParserBase::PackedVarint(
PROTOBUF_TC_PARAM_DECL) {
if (PROTOBUF_PREDICT_FALSE(static_cast<TagType>(data.coded_tag()) != 0)) {
InvertPacked<WireFormatLite::WIRETYPE_VARINT>(data);
if (static_cast<TagType>(data.coded_tag()) == 0) {
return RepeatedVarint<FieldType, TagType, zigzag>(PROTOBUF_TC_PARAM_PASS);
} else {
return table->fallback(PROTOBUF_TC_PARAM_PASS);
}
}
ptr += sizeof(TagType);
// Since ctx->ReadPackedVarint does not use TailCall or Return, sync any
// pending hasbits now:
SyncHasbits(msg, hasbits, table);
auto* field = &RefAt<RepeatedField<FieldType>>(msg, data.offset());
return ctx->ReadPackedVarint(ptr, [field](uint64_t varint) {
FieldType val;
if (zigzag) {
if (sizeof(FieldType) == 8) {
val = WireFormatLite::ZigZagDecode64(varint);
} else {
val = WireFormatLite::ZigZagDecode32(varint);
}
} else {
val = varint;
}
field->Add(val);
});
}
//////////////////////////////////////////////////////////////////////////////
// String/bytes fields
//////////////////////////////////////////////////////////////////////////////
// Defined in wire_format_lite.cc
void PrintUTF8ErrorLog(const char* field_name, const char* operation_str,
bool emit_stacktrace);
namespace {
PROTOBUF_NOINLINE
const char* SingularStringParserFallback(ArenaStringPtr* s, const char* ptr,
EpsCopyInputStream* stream) {
int size = ReadSize(&ptr);
if (!ptr) return nullptr;
return stream->ReadString(
ptr, size, s->MutableNoArenaNoDefault(&GetEmptyStringAlreadyInited()));
}
} // namespace
template <typename TagType, TcParserBase::Utf8Type utf8>
const char* TcParserBase::SingularString(PROTOBUF_TC_PARAM_DECL) {
if (PROTOBUF_PREDICT_FALSE(static_cast<TagType>(data.coded_tag()) != 0)) {
return table->fallback(PROTOBUF_TC_PARAM_PASS);
}
ptr += sizeof(TagType);
hasbits |= (uint64_t{1} << data.hasbit_idx());
auto& field = RefAt<ArenaStringPtr>(msg, data.offset());
auto arena = ctx->data().arena;
if (arena) {
ptr = ctx->ReadArenaString(ptr, &field, arena);
} else {
ptr = SingularStringParserFallback(&field, ptr, ctx);
}
if (ptr == nullptr) return Error(PROTOBUF_TC_PARAM_PASS);
switch (utf8) {
case kNoUtf8:
#ifdef NDEBUG
case kUtf8ValidateOnly:
#endif
return Return(PROTOBUF_TC_PARAM_PASS);
default:
if (PROTOBUF_PREDICT_TRUE(IsStructurallyValidUTF8(field.Get()))) {
return Return(PROTOBUF_TC_PARAM_PASS);
}
PrintUTF8ErrorLog("unknown", "parsing", false);
return utf8 == kUtf8 ? Error(PROTOBUF_TC_PARAM_PASS)
: Return(PROTOBUF_TC_PARAM_PASS);
}
}
template <typename TagType, TcParserBase::Utf8Type utf8>
const char* TcParserBase::RepeatedString(PROTOBUF_TC_PARAM_DECL) {
if (PROTOBUF_PREDICT_FALSE(static_cast<TagType>(data.coded_tag()) != 0)) {
return table->fallback(PROTOBUF_TC_PARAM_PASS);
}
auto expected_tag = UnalignedLoad<TagType>(ptr);
auto& field = RefAt<RepeatedPtrField<std::string>>(msg, data.offset());
do {
ptr += sizeof(TagType);
std::string* str = field.Add();
ptr = InlineGreedyStringParser(str, ptr, ctx);
if (ptr == nullptr) {
return Error(PROTOBUF_TC_PARAM_PASS);
}
if (utf8 != kNoUtf8) {
if (PROTOBUF_PREDICT_FALSE(!IsStructurallyValidUTF8(*str))) {
PrintUTF8ErrorLog("unknown", "parsing", false);
if (utf8 == kUtf8) return Error(PROTOBUF_TC_PARAM_PASS);
}
}
if (!ctx->DataAvailable(ptr)) break;
} while (UnalignedLoad<TagType>(ptr) == expected_tag);
return Return(PROTOBUF_TC_PARAM_PASS);
}
#define PROTOBUF_TCT_SOURCE #define PROTOBUF_TCT_SOURCE
#include <google/protobuf/generated_message_tctable_impl.inc> #include <google/protobuf/generated_message_tctable_impl.inc>

@ -166,6 +166,10 @@ class PROTOBUF_EXPORT EpsCopyInputStream {
} }
return AppendStringFallback(ptr, size, s); return AppendStringFallback(ptr, size, s);
} }
// Implemented in arenastring.cc
PROTOBUF_MUST_USE_RESULT const char* ReadArenaString(const char* ptr,
ArenaStringPtr* s,
Arena* arena);
template <typename Tag, typename T> template <typename Tag, typename T>
PROTOBUF_MUST_USE_RESULT const char* ReadRepeatedFixed(const char* ptr, PROTOBUF_MUST_USE_RESULT const char* ReadRepeatedFixed(const char* ptr,

@ -183,7 +183,8 @@
#ifdef PROTOBUF_TAILCALL #ifdef PROTOBUF_TAILCALL
#error PROTOBUF_TAILCALL was previously defined #error PROTOBUF_TAILCALL was previously defined
#endif #endif
#if __has_cpp_attribute(clang::musttail) && !defined(_ARCH_PPC) #if __has_cpp_attribute(clang::musttail) && \
!defined(_ARCH_PPC) && !defined(__wasm__)
# ifndef PROTO2_OPENSOURCE # ifndef PROTO2_OPENSOURCE
// Compilation fails on powerpc64le: b/187985113 // Compilation fails on powerpc64le: b/187985113
# endif # endif
@ -408,6 +409,14 @@
#endif #endif
# define PROTOBUF_MUST_USE_RESULT # define PROTOBUF_MUST_USE_RESULT
#ifdef PROTOBUF_MUST_USE_EXTRACT_RESULT
#error PROTOBUF_MUST_USE_EXTRACT_RESULT was previously defined
#endif
#ifdef PROTOBUF_FORCE_COPY_IN_RELEASE
#error PROTOBUF_FORCE_COPY_IN_RELEASE was previously defined
#endif
#ifdef PROTOBUF_FORCE_COPY_IN_SWAP #ifdef PROTOBUF_FORCE_COPY_IN_SWAP
#error PROTOBUF_FORCE_COPY_IN_SWAP was previously defined #error PROTOBUF_FORCE_COPY_IN_SWAP was previously defined
#endif #endif

@ -61,6 +61,8 @@
#undef PROTOBUF_EXPORT #undef PROTOBUF_EXPORT
#undef PROTOC_EXPORT #undef PROTOC_EXPORT
#undef PROTOBUF_MUST_USE_RESULT #undef PROTOBUF_MUST_USE_RESULT
#undef PROTOBUF_MUST_USE_EXTRACT_RESULT
#undef PROTOBUF_FORCE_COPY_IN_RELEASE
#undef PROTOBUF_FORCE_COPY_IN_SWAP #undef PROTOBUF_FORCE_COPY_IN_SWAP
#undef PROTOBUF_NAMESPACE_OPEN #undef PROTOBUF_NAMESPACE_OPEN
#undef PROTOBUF_NAMESPACE_CLOSE #undef PROTOBUF_NAMESPACE_CLOSE

@ -654,6 +654,14 @@ class PROTOBUF_EXPORT RepeatedPtrFieldBase {
int Capacity() const; int Capacity() const;
template <typename TypeHandler>
static inline typename TypeHandler::Type* copy(
typename TypeHandler::Type* value) {
auto* new_value = TypeHandler::NewFromPrototype(value, nullptr);
TypeHandler::Merge(*value, new_value);
return new_value;
}
// Used for constructing iterators. // Used for constructing iterators.
void* const* raw_data() const; void* const* raw_data() const;
void** raw_mutable_data() const; void** raw_mutable_data() const;
@ -2047,14 +2055,15 @@ inline typename TypeHandler::Type* RepeatedPtrFieldBase::ReleaseLastInternal(
typename TypeHandler::Type* result = UnsafeArenaReleaseLast<TypeHandler>(); typename TypeHandler::Type* result = UnsafeArenaReleaseLast<TypeHandler>();
// Now perform a copy if we're on an arena. // Now perform a copy if we're on an arena.
Arena* arena = GetArena(); Arena* arena = GetArena();
if (arena == NULL) {
return result; typename TypeHandler::Type* new_result;
} else { #ifdef PROTOBUF_FORCE_COPY_IN_RELEASE
typename TypeHandler::Type* new_result = new_result = copy<TypeHandler>(result);
TypeHandler::NewFromPrototype(result, NULL); if (arena == nullptr) delete result;
TypeHandler::Merge(*result, new_result); #else // PROTOBUF_FORCE_COPY_IN_RELEASE
return new_result; new_result = (arena == nullptr) ? result : copy<TypeHandler>(result);
} #endif // !PROTOBUF_FORCE_COPY_IN_RELEASE
return new_result;
} }
// ReleaseLast() for types that *do not* implement merge/copy behavior -- this // ReleaseLast() for types that *do not* implement merge/copy behavior -- this
@ -2064,7 +2073,7 @@ inline typename TypeHandler::Type* RepeatedPtrFieldBase::ReleaseLastInternal(
template <typename TypeHandler> template <typename TypeHandler>
inline typename TypeHandler::Type* RepeatedPtrFieldBase::ReleaseLastInternal( inline typename TypeHandler::Type* RepeatedPtrFieldBase::ReleaseLastInternal(
std::false_type) { std::false_type) {
GOOGLE_DCHECK(GetArena() == NULL) GOOGLE_DCHECK(GetArena() == nullptr)
<< "ReleaseLast() called on a RepeatedPtrField that is on an arena, " << "ReleaseLast() called on a RepeatedPtrField that is on an arena, "
<< "with a type that does not implement MergeFrom. This is unsafe; " << "with a type that does not implement MergeFrom. This is unsafe; "
<< "please implement MergeFrom for your type."; << "please implement MergeFrom for your type.";
@ -2254,7 +2263,7 @@ inline void RepeatedPtrField<Element>::DeleteSubrange(int start, int num) {
for (int i = 0; i < num; ++i) { for (int i = 0; i < num; ++i) {
RepeatedPtrFieldBase::Delete<TypeHandler>(start + i); RepeatedPtrFieldBase::Delete<TypeHandler>(start + i);
} }
ExtractSubrange(start, num, NULL); UnsafeArenaExtractSubrange(start, num, nullptr);
} }
template <typename Element> template <typename Element>
@ -2274,28 +2283,45 @@ inline void RepeatedPtrField<Element>::ExtractSubrangeInternal(
GOOGLE_DCHECK_GE(num, 0); GOOGLE_DCHECK_GE(num, 0);
GOOGLE_DCHECK_LE(start + num, size()); GOOGLE_DCHECK_LE(start + num, size());
if (num > 0) { if (num == 0) return;
// Save the values of the removed elements if requested.
if (elements != NULL) { #ifdef PROTOBUF_MUST_USE_EXTRACT_RESULT
if (GetArena() != NULL) { GOOGLE_DCHECK_NE(elements, nullptr)
// If we're on an arena, we perform a copy for each element so that the << "Releasing elements without transferring ownership is an unsafe "
// returned elements are heap-allocated. "operation. Use UnsafeArenaExtractSubrange.";
for (int i = 0; i < num; ++i) { #endif
Element* element = if (elements == nullptr) {
RepeatedPtrFieldBase::Mutable<TypeHandler>(i + start);
typename TypeHandler::Type* new_value =
TypeHandler::NewFromPrototype(element, NULL);
TypeHandler::Merge(*element, new_value);
elements[i] = new_value;
}
} else {
for (int i = 0; i < num; ++i) {
elements[i] = RepeatedPtrFieldBase::Mutable<TypeHandler>(i + start);
}
}
}
CloseGap(start, num); CloseGap(start, num);
return;
}
Arena* arena = GetArena();
#ifdef PROTOBUF_FORCE_COPY_IN_RELEASE
// Always copy.
for (int i = 0; i < num; ++i) {
elements[i] = copy<TypeHandler>(
RepeatedPtrFieldBase::Mutable<TypeHandler>(i + start));
}
if (arena == nullptr) {
for (int i = 0; i < num; ++i) {
delete RepeatedPtrFieldBase::Mutable<TypeHandler>(i + start);
}
}
#else // PROTOBUF_FORCE_COPY_IN_RELEASE
// If we're on an arena, we perform a copy for each element so that the
// returned elements are heap-allocated. Otherwise, just forward it.
if (arena != nullptr) {
for (int i = 0; i < num; ++i) {
elements[i] = copy<TypeHandler>(
RepeatedPtrFieldBase::Mutable<TypeHandler>(i + start));
}
} else {
for (int i = 0; i < num; ++i) {
elements[i] = RepeatedPtrFieldBase::Mutable<TypeHandler>(i + start);
}
} }
#endif // !PROTOBUF_FORCE_COPY_IN_RELEASE
CloseGap(start, num);
} }
// ExtractSubrange() implementation for types that do not implement merge/copy // ExtractSubrange() implementation for types that do not implement merge/copy

@ -180,7 +180,7 @@ failure:
(void) cached_has_bits; (void) cached_has_bits;
// string file_name = 1; // string file_name = 1;
if (!this->file_name().empty()) { if (!this->_internal_file_name().empty()) {
::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::VerifyUtf8String( ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::VerifyUtf8String(
this->_internal_file_name().data(), static_cast<int>(this->_internal_file_name().length()), this->_internal_file_name().data(), static_cast<int>(this->_internal_file_name().length()),
::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::SERIALIZE, ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::SERIALIZE,
@ -206,7 +206,7 @@ size_t SourceContext::ByteSizeLong() const {
(void) cached_has_bits; (void) cached_has_bits;
// string file_name = 1; // string file_name = 1;
if (!this->file_name().empty()) { if (!this->_internal_file_name().empty()) {
total_size += 1 + total_size += 1 +
::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::StringSize( ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::StringSize(
this->_internal_file_name()); this->_internal_file_name());
@ -240,7 +240,7 @@ void SourceContext::MergeFrom(const SourceContext& from) {
::PROTOBUF_NAMESPACE_ID::uint32 cached_has_bits = 0; ::PROTOBUF_NAMESPACE_ID::uint32 cached_has_bits = 0;
(void) cached_has_bits; (void) cached_has_bits;
if (!from.file_name().empty()) { if (!from._internal_file_name().empty()) {
_internal_set_file_name(from._internal_file_name()); _internal_set_file_name(from._internal_file_name());
} }
_internal_metadata_.MergeFrom<::PROTOBUF_NAMESPACE_ID::UnknownFieldSet>(from._internal_metadata_); _internal_metadata_.MergeFrom<::PROTOBUF_NAMESPACE_ID::UnknownFieldSet>(from._internal_metadata_);

@ -52,15 +52,15 @@ static int CountSubstituteArgs(const SubstituteArg* const* args_array) {
return count; return count;
} }
std::string Substitute(const char* format, const SubstituteArg& arg0, std::string Substitute(const std::string& format, const SubstituteArg& arg0,
const SubstituteArg& arg1, const SubstituteArg& arg2, const SubstituteArg& arg1, const SubstituteArg& arg2,
const SubstituteArg& arg3, const SubstituteArg& arg4, const SubstituteArg& arg3, const SubstituteArg& arg4,
const SubstituteArg& arg5, const SubstituteArg& arg6, const SubstituteArg& arg5, const SubstituteArg& arg6,
const SubstituteArg& arg7, const SubstituteArg& arg8, const SubstituteArg& arg7, const SubstituteArg& arg8,
const SubstituteArg& arg9) { const SubstituteArg& arg9) {
std::string result; std::string result;
SubstituteAndAppend(&result, format, arg0, arg1, arg2, arg3, arg4, SubstituteAndAppend(&result, format.c_str(), arg0, arg1, arg2, arg3, arg4,
arg5, arg6, arg7, arg8, arg9); arg5, arg6, arg7, arg8, arg9);
return result; return result;
} }

@ -31,10 +31,12 @@
// Author: kenton@google.com (Kenton Varda) // Author: kenton@google.com (Kenton Varda)
// from google3/strings/substitute.h // from google3/strings/substitute.h
#include <string>
#include <google/protobuf/stubs/common.h> #include <google/protobuf/stubs/common.h>
#include <google/protobuf/stubs/stringpiece.h>
#include <google/protobuf/stubs/strutil.h> #include <google/protobuf/stubs/strutil.h>
#include <string>
#ifndef GOOGLE_PROTOBUF_STUBS_SUBSTITUTE_H_ #ifndef GOOGLE_PROTOBUF_STUBS_SUBSTITUTE_H_
#define GOOGLE_PROTOBUF_STUBS_SUBSTITUTE_H_ #define GOOGLE_PROTOBUF_STUBS_SUBSTITUTE_H_
@ -92,6 +94,8 @@ class SubstituteArg {
: text_(value), size_(strlen(text_)) {} : text_(value), size_(strlen(text_)) {}
inline SubstituteArg(const std::string& value) inline SubstituteArg(const std::string& value)
: text_(value.data()), size_(value.size()) {} : text_(value.data()), size_(value.size()) {}
inline SubstituteArg(const StringPiece value)
: text_(value.data()), size_(value.size()) {}
// Indicates that no argument was given. // Indicates that no argument was given.
inline explicit SubstituteArg() inline explicit SubstituteArg()
@ -140,7 +144,7 @@ class SubstituteArg {
} // namespace internal } // namespace internal
PROTOBUF_EXPORT std::string Substitute( PROTOBUF_EXPORT std::string Substitute(
const char* format, const std::string& format,
const internal::SubstituteArg& arg0 = internal::SubstituteArg(), const internal::SubstituteArg& arg0 = internal::SubstituteArg(),
const internal::SubstituteArg& arg1 = internal::SubstituteArg(), const internal::SubstituteArg& arg1 = internal::SubstituteArg(),
const internal::SubstituteArg& arg2 = internal::SubstituteArg(), const internal::SubstituteArg& arg2 = internal::SubstituteArg(),

@ -189,13 +189,13 @@ failure:
(void) cached_has_bits; (void) cached_has_bits;
// int64 seconds = 1; // int64 seconds = 1;
if (this->seconds() != 0) { if (this->_internal_seconds() != 0) {
target = stream->EnsureSpace(target); target = stream->EnsureSpace(target);
target = ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::WriteInt64ToArray(1, this->_internal_seconds(), target); target = ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::WriteInt64ToArray(1, this->_internal_seconds(), target);
} }
// int32 nanos = 2; // int32 nanos = 2;
if (this->nanos() != 0) { if (this->_internal_nanos() != 0) {
target = stream->EnsureSpace(target); target = stream->EnsureSpace(target);
target = ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::WriteInt32ToArray(2, this->_internal_nanos(), target); target = ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::WriteInt32ToArray(2, this->_internal_nanos(), target);
} }
@ -217,14 +217,14 @@ size_t Timestamp::ByteSizeLong() const {
(void) cached_has_bits; (void) cached_has_bits;
// int64 seconds = 1; // int64 seconds = 1;
if (this->seconds() != 0) { if (this->_internal_seconds() != 0) {
total_size += 1 + total_size += 1 +
::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::Int64Size( ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::Int64Size(
this->_internal_seconds()); this->_internal_seconds());
} }
// int32 nanos = 2; // int32 nanos = 2;
if (this->nanos() != 0) { if (this->_internal_nanos() != 0) {
total_size += 1 + total_size += 1 +
::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::Int32Size( ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::Int32Size(
this->_internal_nanos()); this->_internal_nanos());
@ -258,10 +258,10 @@ void Timestamp::MergeFrom(const Timestamp& from) {
::PROTOBUF_NAMESPACE_ID::uint32 cached_has_bits = 0; ::PROTOBUF_NAMESPACE_ID::uint32 cached_has_bits = 0;
(void) cached_has_bits; (void) cached_has_bits;
if (from.seconds() != 0) { if (from._internal_seconds() != 0) {
_internal_set_seconds(from._internal_seconds()); _internal_set_seconds(from._internal_seconds());
} }
if (from.nanos() != 0) { if (from._internal_nanos() != 0) {
_internal_set_nanos(from._internal_nanos()); _internal_set_nanos(from._internal_nanos());
} }
_internal_metadata_.MergeFrom<::PROTOBUF_NAMESPACE_ID::UnknownFieldSet>(from._internal_metadata_); _internal_metadata_.MergeFrom<::PROTOBUF_NAMESPACE_ID::UnknownFieldSet>(from._internal_metadata_);

@ -527,7 +527,7 @@ failure:
(void) cached_has_bits; (void) cached_has_bits;
// string name = 1; // string name = 1;
if (!this->name().empty()) { if (!this->_internal_name().empty()) {
::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::VerifyUtf8String( ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::VerifyUtf8String(
this->_internal_name().data(), static_cast<int>(this->_internal_name().length()), this->_internal_name().data(), static_cast<int>(this->_internal_name().length()),
::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::SERIALIZE, ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::SERIALIZE,
@ -563,7 +563,7 @@ failure:
} }
// .google.protobuf.SourceContext source_context = 5; // .google.protobuf.SourceContext source_context = 5;
if (this->has_source_context()) { if (this->_internal_has_source_context()) {
target = stream->EnsureSpace(target); target = stream->EnsureSpace(target);
target = ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite:: target = ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::
InternalWriteMessage( InternalWriteMessage(
@ -571,7 +571,7 @@ failure:
} }
// .google.protobuf.Syntax syntax = 6; // .google.protobuf.Syntax syntax = 6;
if (this->syntax() != 0) { if (this->_internal_syntax() != 0) {
target = stream->EnsureSpace(target); target = stream->EnsureSpace(target);
target = ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::WriteEnumToArray( target = ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::WriteEnumToArray(
6, this->_internal_syntax(), target); 6, this->_internal_syntax(), target);
@ -616,21 +616,21 @@ size_t Type::ByteSizeLong() const {
} }
// string name = 1; // string name = 1;
if (!this->name().empty()) { if (!this->_internal_name().empty()) {
total_size += 1 + total_size += 1 +
::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::StringSize( ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::StringSize(
this->_internal_name()); this->_internal_name());
} }
// .google.protobuf.SourceContext source_context = 5; // .google.protobuf.SourceContext source_context = 5;
if (this->has_source_context()) { if (this->_internal_has_source_context()) {
total_size += 1 + total_size += 1 +
::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::MessageSize( ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::MessageSize(
*source_context_); *source_context_);
} }
// .google.protobuf.Syntax syntax = 6; // .google.protobuf.Syntax syntax = 6;
if (this->syntax() != 0) { if (this->_internal_syntax() != 0) {
total_size += 1 + total_size += 1 +
::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::EnumSize(this->_internal_syntax()); ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::EnumSize(this->_internal_syntax());
} }
@ -666,13 +666,13 @@ void Type::MergeFrom(const Type& from) {
fields_.MergeFrom(from.fields_); fields_.MergeFrom(from.fields_);
oneofs_.MergeFrom(from.oneofs_); oneofs_.MergeFrom(from.oneofs_);
options_.MergeFrom(from.options_); options_.MergeFrom(from.options_);
if (!from.name().empty()) { if (!from._internal_name().empty()) {
_internal_set_name(from._internal_name()); _internal_set_name(from._internal_name());
} }
if (from.has_source_context()) { if (from._internal_has_source_context()) {
_internal_mutable_source_context()->PROTOBUF_NAMESPACE_ID::SourceContext::MergeFrom(from._internal_source_context()); _internal_mutable_source_context()->PROTOBUF_NAMESPACE_ID::SourceContext::MergeFrom(from._internal_source_context());
} }
if (from.syntax() != 0) { if (from._internal_syntax() != 0) {
_internal_set_syntax(from._internal_syntax()); _internal_set_syntax(from._internal_syntax());
} }
_internal_metadata_.MergeFrom<::PROTOBUF_NAMESPACE_ID::UnknownFieldSet>(from._internal_metadata_); _internal_metadata_.MergeFrom<::PROTOBUF_NAMESPACE_ID::UnknownFieldSet>(from._internal_metadata_);
@ -934,27 +934,27 @@ failure:
(void) cached_has_bits; (void) cached_has_bits;
// .google.protobuf.Field.Kind kind = 1; // .google.protobuf.Field.Kind kind = 1;
if (this->kind() != 0) { if (this->_internal_kind() != 0) {
target = stream->EnsureSpace(target); target = stream->EnsureSpace(target);
target = ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::WriteEnumToArray( target = ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::WriteEnumToArray(
1, this->_internal_kind(), target); 1, this->_internal_kind(), target);
} }
// .google.protobuf.Field.Cardinality cardinality = 2; // .google.protobuf.Field.Cardinality cardinality = 2;
if (this->cardinality() != 0) { if (this->_internal_cardinality() != 0) {
target = stream->EnsureSpace(target); target = stream->EnsureSpace(target);
target = ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::WriteEnumToArray( target = ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::WriteEnumToArray(
2, this->_internal_cardinality(), target); 2, this->_internal_cardinality(), target);
} }
// int32 number = 3; // int32 number = 3;
if (this->number() != 0) { if (this->_internal_number() != 0) {
target = stream->EnsureSpace(target); target = stream->EnsureSpace(target);
target = ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::WriteInt32ToArray(3, this->_internal_number(), target); target = ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::WriteInt32ToArray(3, this->_internal_number(), target);
} }
// string name = 4; // string name = 4;
if (!this->name().empty()) { if (!this->_internal_name().empty()) {
::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::VerifyUtf8String( ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::VerifyUtf8String(
this->_internal_name().data(), static_cast<int>(this->_internal_name().length()), this->_internal_name().data(), static_cast<int>(this->_internal_name().length()),
::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::SERIALIZE, ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::SERIALIZE,
@ -964,7 +964,7 @@ failure:
} }
// string type_url = 6; // string type_url = 6;
if (!this->type_url().empty()) { if (!this->_internal_type_url().empty()) {
::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::VerifyUtf8String( ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::VerifyUtf8String(
this->_internal_type_url().data(), static_cast<int>(this->_internal_type_url().length()), this->_internal_type_url().data(), static_cast<int>(this->_internal_type_url().length()),
::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::SERIALIZE, ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::SERIALIZE,
@ -974,13 +974,13 @@ failure:
} }
// int32 oneof_index = 7; // int32 oneof_index = 7;
if (this->oneof_index() != 0) { if (this->_internal_oneof_index() != 0) {
target = stream->EnsureSpace(target); target = stream->EnsureSpace(target);
target = ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::WriteInt32ToArray(7, this->_internal_oneof_index(), target); target = ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::WriteInt32ToArray(7, this->_internal_oneof_index(), target);
} }
// bool packed = 8; // bool packed = 8;
if (this->packed() != 0) { if (this->_internal_packed() != 0) {
target = stream->EnsureSpace(target); target = stream->EnsureSpace(target);
target = ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::WriteBoolToArray(8, this->_internal_packed(), target); target = ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::WriteBoolToArray(8, this->_internal_packed(), target);
} }
@ -994,7 +994,7 @@ failure:
} }
// string json_name = 10; // string json_name = 10;
if (!this->json_name().empty()) { if (!this->_internal_json_name().empty()) {
::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::VerifyUtf8String( ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::VerifyUtf8String(
this->_internal_json_name().data(), static_cast<int>(this->_internal_json_name().length()), this->_internal_json_name().data(), static_cast<int>(this->_internal_json_name().length()),
::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::SERIALIZE, ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::SERIALIZE,
@ -1004,7 +1004,7 @@ failure:
} }
// string default_value = 11; // string default_value = 11;
if (!this->default_value().empty()) { if (!this->_internal_default_value().empty()) {
::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::VerifyUtf8String( ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::VerifyUtf8String(
this->_internal_default_value().data(), static_cast<int>(this->_internal_default_value().length()), this->_internal_default_value().data(), static_cast<int>(this->_internal_default_value().length()),
::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::SERIALIZE, ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::SERIALIZE,
@ -1037,61 +1037,61 @@ size_t Field::ByteSizeLong() const {
} }
// string name = 4; // string name = 4;
if (!this->name().empty()) { if (!this->_internal_name().empty()) {
total_size += 1 + total_size += 1 +
::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::StringSize( ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::StringSize(
this->_internal_name()); this->_internal_name());
} }
// string type_url = 6; // string type_url = 6;
if (!this->type_url().empty()) { if (!this->_internal_type_url().empty()) {
total_size += 1 + total_size += 1 +
::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::StringSize( ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::StringSize(
this->_internal_type_url()); this->_internal_type_url());
} }
// string json_name = 10; // string json_name = 10;
if (!this->json_name().empty()) { if (!this->_internal_json_name().empty()) {
total_size += 1 + total_size += 1 +
::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::StringSize( ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::StringSize(
this->_internal_json_name()); this->_internal_json_name());
} }
// string default_value = 11; // string default_value = 11;
if (!this->default_value().empty()) { if (!this->_internal_default_value().empty()) {
total_size += 1 + total_size += 1 +
::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::StringSize( ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::StringSize(
this->_internal_default_value()); this->_internal_default_value());
} }
// .google.protobuf.Field.Kind kind = 1; // .google.protobuf.Field.Kind kind = 1;
if (this->kind() != 0) { if (this->_internal_kind() != 0) {
total_size += 1 + total_size += 1 +
::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::EnumSize(this->_internal_kind()); ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::EnumSize(this->_internal_kind());
} }
// .google.protobuf.Field.Cardinality cardinality = 2; // .google.protobuf.Field.Cardinality cardinality = 2;
if (this->cardinality() != 0) { if (this->_internal_cardinality() != 0) {
total_size += 1 + total_size += 1 +
::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::EnumSize(this->_internal_cardinality()); ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::EnumSize(this->_internal_cardinality());
} }
// int32 number = 3; // int32 number = 3;
if (this->number() != 0) { if (this->_internal_number() != 0) {
total_size += 1 + total_size += 1 +
::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::Int32Size( ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::Int32Size(
this->_internal_number()); this->_internal_number());
} }
// int32 oneof_index = 7; // int32 oneof_index = 7;
if (this->oneof_index() != 0) { if (this->_internal_oneof_index() != 0) {
total_size += 1 + total_size += 1 +
::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::Int32Size( ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::Int32Size(
this->_internal_oneof_index()); this->_internal_oneof_index());
} }
// bool packed = 8; // bool packed = 8;
if (this->packed() != 0) { if (this->_internal_packed() != 0) {
total_size += 1 + 1; total_size += 1 + 1;
} }
@ -1124,31 +1124,31 @@ void Field::MergeFrom(const Field& from) {
(void) cached_has_bits; (void) cached_has_bits;
options_.MergeFrom(from.options_); options_.MergeFrom(from.options_);
if (!from.name().empty()) { if (!from._internal_name().empty()) {
_internal_set_name(from._internal_name()); _internal_set_name(from._internal_name());
} }
if (!from.type_url().empty()) { if (!from._internal_type_url().empty()) {
_internal_set_type_url(from._internal_type_url()); _internal_set_type_url(from._internal_type_url());
} }
if (!from.json_name().empty()) { if (!from._internal_json_name().empty()) {
_internal_set_json_name(from._internal_json_name()); _internal_set_json_name(from._internal_json_name());
} }
if (!from.default_value().empty()) { if (!from._internal_default_value().empty()) {
_internal_set_default_value(from._internal_default_value()); _internal_set_default_value(from._internal_default_value());
} }
if (from.kind() != 0) { if (from._internal_kind() != 0) {
_internal_set_kind(from._internal_kind()); _internal_set_kind(from._internal_kind());
} }
if (from.cardinality() != 0) { if (from._internal_cardinality() != 0) {
_internal_set_cardinality(from._internal_cardinality()); _internal_set_cardinality(from._internal_cardinality());
} }
if (from.number() != 0) { if (from._internal_number() != 0) {
_internal_set_number(from._internal_number()); _internal_set_number(from._internal_number());
} }
if (from.oneof_index() != 0) { if (from._internal_oneof_index() != 0) {
_internal_set_oneof_index(from._internal_oneof_index()); _internal_set_oneof_index(from._internal_oneof_index());
} }
if (from.packed() != 0) { if (from._internal_packed() != 0) {
_internal_set_packed(from._internal_packed()); _internal_set_packed(from._internal_packed());
} }
_internal_metadata_.MergeFrom<::PROTOBUF_NAMESPACE_ID::UnknownFieldSet>(from._internal_metadata_); _internal_metadata_.MergeFrom<::PROTOBUF_NAMESPACE_ID::UnknownFieldSet>(from._internal_metadata_);
@ -1382,7 +1382,7 @@ failure:
(void) cached_has_bits; (void) cached_has_bits;
// string name = 1; // string name = 1;
if (!this->name().empty()) { if (!this->_internal_name().empty()) {
::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::VerifyUtf8String( ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::VerifyUtf8String(
this->_internal_name().data(), static_cast<int>(this->_internal_name().length()), this->_internal_name().data(), static_cast<int>(this->_internal_name().length()),
::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::SERIALIZE, ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::SERIALIZE,
@ -1408,7 +1408,7 @@ failure:
} }
// .google.protobuf.SourceContext source_context = 4; // .google.protobuf.SourceContext source_context = 4;
if (this->has_source_context()) { if (this->_internal_has_source_context()) {
target = stream->EnsureSpace(target); target = stream->EnsureSpace(target);
target = ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite:: target = ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::
InternalWriteMessage( InternalWriteMessage(
@ -1416,7 +1416,7 @@ failure:
} }
// .google.protobuf.Syntax syntax = 5; // .google.protobuf.Syntax syntax = 5;
if (this->syntax() != 0) { if (this->_internal_syntax() != 0) {
target = stream->EnsureSpace(target); target = stream->EnsureSpace(target);
target = ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::WriteEnumToArray( target = ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::WriteEnumToArray(
5, this->_internal_syntax(), target); 5, this->_internal_syntax(), target);
@ -1453,21 +1453,21 @@ size_t Enum::ByteSizeLong() const {
} }
// string name = 1; // string name = 1;
if (!this->name().empty()) { if (!this->_internal_name().empty()) {
total_size += 1 + total_size += 1 +
::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::StringSize( ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::StringSize(
this->_internal_name()); this->_internal_name());
} }
// .google.protobuf.SourceContext source_context = 4; // .google.protobuf.SourceContext source_context = 4;
if (this->has_source_context()) { if (this->_internal_has_source_context()) {
total_size += 1 + total_size += 1 +
::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::MessageSize( ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::MessageSize(
*source_context_); *source_context_);
} }
// .google.protobuf.Syntax syntax = 5; // .google.protobuf.Syntax syntax = 5;
if (this->syntax() != 0) { if (this->_internal_syntax() != 0) {
total_size += 1 + total_size += 1 +
::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::EnumSize(this->_internal_syntax()); ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::EnumSize(this->_internal_syntax());
} }
@ -1502,13 +1502,13 @@ void Enum::MergeFrom(const Enum& from) {
enumvalue_.MergeFrom(from.enumvalue_); enumvalue_.MergeFrom(from.enumvalue_);
options_.MergeFrom(from.options_); options_.MergeFrom(from.options_);
if (!from.name().empty()) { if (!from._internal_name().empty()) {
_internal_set_name(from._internal_name()); _internal_set_name(from._internal_name());
} }
if (from.has_source_context()) { if (from._internal_has_source_context()) {
_internal_mutable_source_context()->PROTOBUF_NAMESPACE_ID::SourceContext::MergeFrom(from._internal_source_context()); _internal_mutable_source_context()->PROTOBUF_NAMESPACE_ID::SourceContext::MergeFrom(from._internal_source_context());
} }
if (from.syntax() != 0) { if (from._internal_syntax() != 0) {
_internal_set_syntax(from._internal_syntax()); _internal_set_syntax(from._internal_syntax());
} }
_internal_metadata_.MergeFrom<::PROTOBUF_NAMESPACE_ID::UnknownFieldSet>(from._internal_metadata_); _internal_metadata_.MergeFrom<::PROTOBUF_NAMESPACE_ID::UnknownFieldSet>(from._internal_metadata_);
@ -1681,7 +1681,7 @@ failure:
(void) cached_has_bits; (void) cached_has_bits;
// string name = 1; // string name = 1;
if (!this->name().empty()) { if (!this->_internal_name().empty()) {
::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::VerifyUtf8String( ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::VerifyUtf8String(
this->_internal_name().data(), static_cast<int>(this->_internal_name().length()), this->_internal_name().data(), static_cast<int>(this->_internal_name().length()),
::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::SERIALIZE, ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::SERIALIZE,
@ -1691,7 +1691,7 @@ failure:
} }
// int32 number = 2; // int32 number = 2;
if (this->number() != 0) { if (this->_internal_number() != 0) {
target = stream->EnsureSpace(target); target = stream->EnsureSpace(target);
target = ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::WriteInt32ToArray(2, this->_internal_number(), target); target = ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::WriteInt32ToArray(2, this->_internal_number(), target);
} }
@ -1728,14 +1728,14 @@ size_t EnumValue::ByteSizeLong() const {
} }
// string name = 1; // string name = 1;
if (!this->name().empty()) { if (!this->_internal_name().empty()) {
total_size += 1 + total_size += 1 +
::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::StringSize( ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::StringSize(
this->_internal_name()); this->_internal_name());
} }
// int32 number = 2; // int32 number = 2;
if (this->number() != 0) { if (this->_internal_number() != 0) {
total_size += 1 + total_size += 1 +
::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::Int32Size( ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::Int32Size(
this->_internal_number()); this->_internal_number());
@ -1770,10 +1770,10 @@ void EnumValue::MergeFrom(const EnumValue& from) {
(void) cached_has_bits; (void) cached_has_bits;
options_.MergeFrom(from.options_); options_.MergeFrom(from.options_);
if (!from.name().empty()) { if (!from._internal_name().empty()) {
_internal_set_name(from._internal_name()); _internal_set_name(from._internal_name());
} }
if (from.number() != 0) { if (from._internal_number() != 0) {
_internal_set_number(from._internal_number()); _internal_set_number(from._internal_number());
} }
_internal_metadata_.MergeFrom<::PROTOBUF_NAMESPACE_ID::UnknownFieldSet>(from._internal_metadata_); _internal_metadata_.MergeFrom<::PROTOBUF_NAMESPACE_ID::UnknownFieldSet>(from._internal_metadata_);
@ -1944,7 +1944,7 @@ failure:
(void) cached_has_bits; (void) cached_has_bits;
// string name = 1; // string name = 1;
if (!this->name().empty()) { if (!this->_internal_name().empty()) {
::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::VerifyUtf8String( ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::VerifyUtf8String(
this->_internal_name().data(), static_cast<int>(this->_internal_name().length()), this->_internal_name().data(), static_cast<int>(this->_internal_name().length()),
::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::SERIALIZE, ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::SERIALIZE,
@ -1954,7 +1954,7 @@ failure:
} }
// .google.protobuf.Any value = 2; // .google.protobuf.Any value = 2;
if (this->has_value()) { if (this->_internal_has_value()) {
target = stream->EnsureSpace(target); target = stream->EnsureSpace(target);
target = ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite:: target = ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::
InternalWriteMessage( InternalWriteMessage(
@ -1978,14 +1978,14 @@ size_t Option::ByteSizeLong() const {
(void) cached_has_bits; (void) cached_has_bits;
// string name = 1; // string name = 1;
if (!this->name().empty()) { if (!this->_internal_name().empty()) {
total_size += 1 + total_size += 1 +
::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::StringSize( ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::StringSize(
this->_internal_name()); this->_internal_name());
} }
// .google.protobuf.Any value = 2; // .google.protobuf.Any value = 2;
if (this->has_value()) { if (this->_internal_has_value()) {
total_size += 1 + total_size += 1 +
::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::MessageSize( ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::MessageSize(
*value_); *value_);
@ -2019,10 +2019,10 @@ void Option::MergeFrom(const Option& from) {
::PROTOBUF_NAMESPACE_ID::uint32 cached_has_bits = 0; ::PROTOBUF_NAMESPACE_ID::uint32 cached_has_bits = 0;
(void) cached_has_bits; (void) cached_has_bits;
if (!from.name().empty()) { if (!from._internal_name().empty()) {
_internal_set_name(from._internal_name()); _internal_set_name(from._internal_name());
} }
if (from.has_value()) { if (from._internal_has_value()) {
_internal_mutable_value()->PROTOBUF_NAMESPACE_ID::Any::MergeFrom(from._internal_value()); _internal_mutable_value()->PROTOBUF_NAMESPACE_ID::Any::MergeFrom(from._internal_value());
} }
_internal_metadata_.MergeFrom<::PROTOBUF_NAMESPACE_ID::UnknownFieldSet>(from._internal_metadata_); _internal_metadata_.MergeFrom<::PROTOBUF_NAMESPACE_ID::UnknownFieldSet>(from._internal_metadata_);

@ -1581,9 +1581,15 @@ inline PROTOBUF_NAMESPACE_ID::SourceContext* Type::release_source_context() {
PROTOBUF_NAMESPACE_ID::SourceContext* temp = source_context_; PROTOBUF_NAMESPACE_ID::SourceContext* temp = source_context_;
source_context_ = nullptr; source_context_ = nullptr;
#ifdef PROTOBUF_FORCE_COPY_IN_RELEASE
auto* old = reinterpret_cast<::PROTOBUF_NAMESPACE_ID::MessageLite*>(temp);
temp = ::PROTOBUF_NAMESPACE_ID::internal::DuplicateIfNonNull(temp);
if (GetArenaForAllocation() == nullptr) { delete old; }
#else // PROTOBUF_FORCE_COPY_IN_RELEASE
if (GetArenaForAllocation() != nullptr) { if (GetArenaForAllocation() != nullptr) {
temp = ::PROTOBUF_NAMESPACE_ID::internal::DuplicateIfNonNull(temp); temp = ::PROTOBUF_NAMESPACE_ID::internal::DuplicateIfNonNull(temp);
} }
#endif // !PROTOBUF_FORCE_COPY_IN_RELEASE
return temp; return temp;
} }
inline PROTOBUF_NAMESPACE_ID::SourceContext* Type::unsafe_arena_release_source_context() { inline PROTOBUF_NAMESPACE_ID::SourceContext* Type::unsafe_arena_release_source_context() {
@ -2139,9 +2145,15 @@ inline PROTOBUF_NAMESPACE_ID::SourceContext* Enum::release_source_context() {
PROTOBUF_NAMESPACE_ID::SourceContext* temp = source_context_; PROTOBUF_NAMESPACE_ID::SourceContext* temp = source_context_;
source_context_ = nullptr; source_context_ = nullptr;
#ifdef PROTOBUF_FORCE_COPY_IN_RELEASE
auto* old = reinterpret_cast<::PROTOBUF_NAMESPACE_ID::MessageLite*>(temp);
temp = ::PROTOBUF_NAMESPACE_ID::internal::DuplicateIfNonNull(temp);
if (GetArenaForAllocation() == nullptr) { delete old; }
#else // PROTOBUF_FORCE_COPY_IN_RELEASE
if (GetArenaForAllocation() != nullptr) { if (GetArenaForAllocation() != nullptr) {
temp = ::PROTOBUF_NAMESPACE_ID::internal::DuplicateIfNonNull(temp); temp = ::PROTOBUF_NAMESPACE_ID::internal::DuplicateIfNonNull(temp);
} }
#endif // !PROTOBUF_FORCE_COPY_IN_RELEASE
return temp; return temp;
} }
inline PROTOBUF_NAMESPACE_ID::SourceContext* Enum::unsafe_arena_release_source_context() { inline PROTOBUF_NAMESPACE_ID::SourceContext* Enum::unsafe_arena_release_source_context() {
@ -2399,9 +2411,15 @@ inline PROTOBUF_NAMESPACE_ID::Any* Option::release_value() {
PROTOBUF_NAMESPACE_ID::Any* temp = value_; PROTOBUF_NAMESPACE_ID::Any* temp = value_;
value_ = nullptr; value_ = nullptr;
#ifdef PROTOBUF_FORCE_COPY_IN_RELEASE
auto* old = reinterpret_cast<::PROTOBUF_NAMESPACE_ID::MessageLite*>(temp);
temp = ::PROTOBUF_NAMESPACE_ID::internal::DuplicateIfNonNull(temp);
if (GetArenaForAllocation() == nullptr) { delete old; }
#else // PROTOBUF_FORCE_COPY_IN_RELEASE
if (GetArenaForAllocation() != nullptr) { if (GetArenaForAllocation() != nullptr) {
temp = ::PROTOBUF_NAMESPACE_ID::internal::DuplicateIfNonNull(temp); temp = ::PROTOBUF_NAMESPACE_ID::internal::DuplicateIfNonNull(temp);
} }
#endif // !PROTOBUF_FORCE_COPY_IN_RELEASE
return temp; return temp;
} }
inline PROTOBUF_NAMESPACE_ID::Any* Option::unsafe_arena_release_value() { inline PROTOBUF_NAMESPACE_ID::Any* Option::unsafe_arena_release_value() {

@ -339,7 +339,7 @@ failure:
(void) cached_has_bits; (void) cached_has_bits;
// double value = 1; // double value = 1;
if (!(this->value() <= 0 && this->value() >= 0)) { if (!(this->_internal_value() <= 0 && this->_internal_value() >= 0)) {
target = stream->EnsureSpace(target); target = stream->EnsureSpace(target);
target = ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::WriteDoubleToArray(1, this->_internal_value(), target); target = ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::WriteDoubleToArray(1, this->_internal_value(), target);
} }
@ -361,7 +361,7 @@ size_t DoubleValue::ByteSizeLong() const {
(void) cached_has_bits; (void) cached_has_bits;
// double value = 1; // double value = 1;
if (!(this->value() <= 0 && this->value() >= 0)) { if (!(this->_internal_value() <= 0 && this->_internal_value() >= 0)) {
total_size += 1 + 8; total_size += 1 + 8;
} }
@ -393,7 +393,7 @@ void DoubleValue::MergeFrom(const DoubleValue& from) {
::PROTOBUF_NAMESPACE_ID::uint32 cached_has_bits = 0; ::PROTOBUF_NAMESPACE_ID::uint32 cached_has_bits = 0;
(void) cached_has_bits; (void) cached_has_bits;
if (!(from.value() <= 0 && from.value() >= 0)) { if (!(from._internal_value() <= 0 && from._internal_value() >= 0)) {
_internal_set_value(from._internal_value()); _internal_set_value(from._internal_value());
} }
_internal_metadata_.MergeFrom<::PROTOBUF_NAMESPACE_ID::UnknownFieldSet>(from._internal_metadata_); _internal_metadata_.MergeFrom<::PROTOBUF_NAMESPACE_ID::UnknownFieldSet>(from._internal_metadata_);
@ -522,7 +522,7 @@ failure:
(void) cached_has_bits; (void) cached_has_bits;
// float value = 1; // float value = 1;
if (!(this->value() <= 0 && this->value() >= 0)) { if (!(this->_internal_value() <= 0 && this->_internal_value() >= 0)) {
target = stream->EnsureSpace(target); target = stream->EnsureSpace(target);
target = ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::WriteFloatToArray(1, this->_internal_value(), target); target = ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::WriteFloatToArray(1, this->_internal_value(), target);
} }
@ -544,7 +544,7 @@ size_t FloatValue::ByteSizeLong() const {
(void) cached_has_bits; (void) cached_has_bits;
// float value = 1; // float value = 1;
if (!(this->value() <= 0 && this->value() >= 0)) { if (!(this->_internal_value() <= 0 && this->_internal_value() >= 0)) {
total_size += 1 + 4; total_size += 1 + 4;
} }
@ -576,7 +576,7 @@ void FloatValue::MergeFrom(const FloatValue& from) {
::PROTOBUF_NAMESPACE_ID::uint32 cached_has_bits = 0; ::PROTOBUF_NAMESPACE_ID::uint32 cached_has_bits = 0;
(void) cached_has_bits; (void) cached_has_bits;
if (!(from.value() <= 0 && from.value() >= 0)) { if (!(from._internal_value() <= 0 && from._internal_value() >= 0)) {
_internal_set_value(from._internal_value()); _internal_set_value(from._internal_value());
} }
_internal_metadata_.MergeFrom<::PROTOBUF_NAMESPACE_ID::UnknownFieldSet>(from._internal_metadata_); _internal_metadata_.MergeFrom<::PROTOBUF_NAMESPACE_ID::UnknownFieldSet>(from._internal_metadata_);
@ -705,7 +705,7 @@ failure:
(void) cached_has_bits; (void) cached_has_bits;
// int64 value = 1; // int64 value = 1;
if (this->value() != 0) { if (this->_internal_value() != 0) {
target = stream->EnsureSpace(target); target = stream->EnsureSpace(target);
target = ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::WriteInt64ToArray(1, this->_internal_value(), target); target = ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::WriteInt64ToArray(1, this->_internal_value(), target);
} }
@ -727,7 +727,7 @@ size_t Int64Value::ByteSizeLong() const {
(void) cached_has_bits; (void) cached_has_bits;
// int64 value = 1; // int64 value = 1;
if (this->value() != 0) { if (this->_internal_value() != 0) {
total_size += 1 + total_size += 1 +
::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::Int64Size( ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::Int64Size(
this->_internal_value()); this->_internal_value());
@ -761,7 +761,7 @@ void Int64Value::MergeFrom(const Int64Value& from) {
::PROTOBUF_NAMESPACE_ID::uint32 cached_has_bits = 0; ::PROTOBUF_NAMESPACE_ID::uint32 cached_has_bits = 0;
(void) cached_has_bits; (void) cached_has_bits;
if (from.value() != 0) { if (from._internal_value() != 0) {
_internal_set_value(from._internal_value()); _internal_set_value(from._internal_value());
} }
_internal_metadata_.MergeFrom<::PROTOBUF_NAMESPACE_ID::UnknownFieldSet>(from._internal_metadata_); _internal_metadata_.MergeFrom<::PROTOBUF_NAMESPACE_ID::UnknownFieldSet>(from._internal_metadata_);
@ -890,7 +890,7 @@ failure:
(void) cached_has_bits; (void) cached_has_bits;
// uint64 value = 1; // uint64 value = 1;
if (this->value() != 0) { if (this->_internal_value() != 0) {
target = stream->EnsureSpace(target); target = stream->EnsureSpace(target);
target = ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::WriteUInt64ToArray(1, this->_internal_value(), target); target = ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::WriteUInt64ToArray(1, this->_internal_value(), target);
} }
@ -912,7 +912,7 @@ size_t UInt64Value::ByteSizeLong() const {
(void) cached_has_bits; (void) cached_has_bits;
// uint64 value = 1; // uint64 value = 1;
if (this->value() != 0) { if (this->_internal_value() != 0) {
total_size += 1 + total_size += 1 +
::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::UInt64Size( ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::UInt64Size(
this->_internal_value()); this->_internal_value());
@ -946,7 +946,7 @@ void UInt64Value::MergeFrom(const UInt64Value& from) {
::PROTOBUF_NAMESPACE_ID::uint32 cached_has_bits = 0; ::PROTOBUF_NAMESPACE_ID::uint32 cached_has_bits = 0;
(void) cached_has_bits; (void) cached_has_bits;
if (from.value() != 0) { if (from._internal_value() != 0) {
_internal_set_value(from._internal_value()); _internal_set_value(from._internal_value());
} }
_internal_metadata_.MergeFrom<::PROTOBUF_NAMESPACE_ID::UnknownFieldSet>(from._internal_metadata_); _internal_metadata_.MergeFrom<::PROTOBUF_NAMESPACE_ID::UnknownFieldSet>(from._internal_metadata_);
@ -1075,7 +1075,7 @@ failure:
(void) cached_has_bits; (void) cached_has_bits;
// int32 value = 1; // int32 value = 1;
if (this->value() != 0) { if (this->_internal_value() != 0) {
target = stream->EnsureSpace(target); target = stream->EnsureSpace(target);
target = ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::WriteInt32ToArray(1, this->_internal_value(), target); target = ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::WriteInt32ToArray(1, this->_internal_value(), target);
} }
@ -1097,7 +1097,7 @@ size_t Int32Value::ByteSizeLong() const {
(void) cached_has_bits; (void) cached_has_bits;
// int32 value = 1; // int32 value = 1;
if (this->value() != 0) { if (this->_internal_value() != 0) {
total_size += 1 + total_size += 1 +
::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::Int32Size( ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::Int32Size(
this->_internal_value()); this->_internal_value());
@ -1131,7 +1131,7 @@ void Int32Value::MergeFrom(const Int32Value& from) {
::PROTOBUF_NAMESPACE_ID::uint32 cached_has_bits = 0; ::PROTOBUF_NAMESPACE_ID::uint32 cached_has_bits = 0;
(void) cached_has_bits; (void) cached_has_bits;
if (from.value() != 0) { if (from._internal_value() != 0) {
_internal_set_value(from._internal_value()); _internal_set_value(from._internal_value());
} }
_internal_metadata_.MergeFrom<::PROTOBUF_NAMESPACE_ID::UnknownFieldSet>(from._internal_metadata_); _internal_metadata_.MergeFrom<::PROTOBUF_NAMESPACE_ID::UnknownFieldSet>(from._internal_metadata_);
@ -1260,7 +1260,7 @@ failure:
(void) cached_has_bits; (void) cached_has_bits;
// uint32 value = 1; // uint32 value = 1;
if (this->value() != 0) { if (this->_internal_value() != 0) {
target = stream->EnsureSpace(target); target = stream->EnsureSpace(target);
target = ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::WriteUInt32ToArray(1, this->_internal_value(), target); target = ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::WriteUInt32ToArray(1, this->_internal_value(), target);
} }
@ -1282,7 +1282,7 @@ size_t UInt32Value::ByteSizeLong() const {
(void) cached_has_bits; (void) cached_has_bits;
// uint32 value = 1; // uint32 value = 1;
if (this->value() != 0) { if (this->_internal_value() != 0) {
total_size += 1 + total_size += 1 +
::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::UInt32Size( ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::UInt32Size(
this->_internal_value()); this->_internal_value());
@ -1316,7 +1316,7 @@ void UInt32Value::MergeFrom(const UInt32Value& from) {
::PROTOBUF_NAMESPACE_ID::uint32 cached_has_bits = 0; ::PROTOBUF_NAMESPACE_ID::uint32 cached_has_bits = 0;
(void) cached_has_bits; (void) cached_has_bits;
if (from.value() != 0) { if (from._internal_value() != 0) {
_internal_set_value(from._internal_value()); _internal_set_value(from._internal_value());
} }
_internal_metadata_.MergeFrom<::PROTOBUF_NAMESPACE_ID::UnknownFieldSet>(from._internal_metadata_); _internal_metadata_.MergeFrom<::PROTOBUF_NAMESPACE_ID::UnknownFieldSet>(from._internal_metadata_);
@ -1445,7 +1445,7 @@ failure:
(void) cached_has_bits; (void) cached_has_bits;
// bool value = 1; // bool value = 1;
if (this->value() != 0) { if (this->_internal_value() != 0) {
target = stream->EnsureSpace(target); target = stream->EnsureSpace(target);
target = ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::WriteBoolToArray(1, this->_internal_value(), target); target = ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::WriteBoolToArray(1, this->_internal_value(), target);
} }
@ -1467,7 +1467,7 @@ size_t BoolValue::ByteSizeLong() const {
(void) cached_has_bits; (void) cached_has_bits;
// bool value = 1; // bool value = 1;
if (this->value() != 0) { if (this->_internal_value() != 0) {
total_size += 1 + 1; total_size += 1 + 1;
} }
@ -1499,7 +1499,7 @@ void BoolValue::MergeFrom(const BoolValue& from) {
::PROTOBUF_NAMESPACE_ID::uint32 cached_has_bits = 0; ::PROTOBUF_NAMESPACE_ID::uint32 cached_has_bits = 0;
(void) cached_has_bits; (void) cached_has_bits;
if (from.value() != 0) { if (from._internal_value() != 0) {
_internal_set_value(from._internal_value()); _internal_set_value(from._internal_value());
} }
_internal_metadata_.MergeFrom<::PROTOBUF_NAMESPACE_ID::UnknownFieldSet>(from._internal_metadata_); _internal_metadata_.MergeFrom<::PROTOBUF_NAMESPACE_ID::UnknownFieldSet>(from._internal_metadata_);
@ -1635,7 +1635,7 @@ failure:
(void) cached_has_bits; (void) cached_has_bits;
// string value = 1; // string value = 1;
if (!this->value().empty()) { if (!this->_internal_value().empty()) {
::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::VerifyUtf8String( ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::VerifyUtf8String(
this->_internal_value().data(), static_cast<int>(this->_internal_value().length()), this->_internal_value().data(), static_cast<int>(this->_internal_value().length()),
::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::SERIALIZE, ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::SERIALIZE,
@ -1661,7 +1661,7 @@ size_t StringValue::ByteSizeLong() const {
(void) cached_has_bits; (void) cached_has_bits;
// string value = 1; // string value = 1;
if (!this->value().empty()) { if (!this->_internal_value().empty()) {
total_size += 1 + total_size += 1 +
::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::StringSize( ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::StringSize(
this->_internal_value()); this->_internal_value());
@ -1695,7 +1695,7 @@ void StringValue::MergeFrom(const StringValue& from) {
::PROTOBUF_NAMESPACE_ID::uint32 cached_has_bits = 0; ::PROTOBUF_NAMESPACE_ID::uint32 cached_has_bits = 0;
(void) cached_has_bits; (void) cached_has_bits;
if (!from.value().empty()) { if (!from._internal_value().empty()) {
_internal_set_value(from._internal_value()); _internal_set_value(from._internal_value());
} }
_internal_metadata_.MergeFrom<::PROTOBUF_NAMESPACE_ID::UnknownFieldSet>(from._internal_metadata_); _internal_metadata_.MergeFrom<::PROTOBUF_NAMESPACE_ID::UnknownFieldSet>(from._internal_metadata_);
@ -1834,7 +1834,7 @@ failure:
(void) cached_has_bits; (void) cached_has_bits;
// bytes value = 1; // bytes value = 1;
if (!this->value().empty()) { if (!this->_internal_value().empty()) {
target = stream->WriteBytesMaybeAliased( target = stream->WriteBytesMaybeAliased(
1, this->_internal_value(), target); 1, this->_internal_value(), target);
} }
@ -1856,7 +1856,7 @@ size_t BytesValue::ByteSizeLong() const {
(void) cached_has_bits; (void) cached_has_bits;
// bytes value = 1; // bytes value = 1;
if (!this->value().empty()) { if (!this->_internal_value().empty()) {
total_size += 1 + total_size += 1 +
::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::BytesSize( ::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::BytesSize(
this->_internal_value()); this->_internal_value());
@ -1890,7 +1890,7 @@ void BytesValue::MergeFrom(const BytesValue& from) {
::PROTOBUF_NAMESPACE_ID::uint32 cached_has_bits = 0; ::PROTOBUF_NAMESPACE_ID::uint32 cached_has_bits = 0;
(void) cached_has_bits; (void) cached_has_bits;
if (!from.value().empty()) { if (!from._internal_value().empty()) {
_internal_set_value(from._internal_value()); _internal_set_value(from._internal_value());
} }
_internal_metadata_.MergeFrom<::PROTOBUF_NAMESPACE_ID::UnknownFieldSet>(from._internal_metadata_); _internal_metadata_.MergeFrom<::PROTOBUF_NAMESPACE_ID::UnknownFieldSet>(from._internal_metadata_);

Loading…
Cancel
Save