From 8fc05442285a08d91f05995123fb02374d8b925e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Harald=20Kj=C3=A6r=20Nielsen?= Date: Tue, 26 Sep 2023 20:10:40 -0700 Subject: [PATCH] Support non ascii commandline args (#14197) Using none ASCII chars for protoc on Windows are not handled well. This adresses argument file at a location where either directory, or filename contains Unicode chars. Specifically because MsBuild tool saves argument file in with the UserName appended to the .rsp file. https://github.com/dotnet/msbuild/pull/9232 But in general we should really handle if none ascii chars are in the path. Closes #14197 COPYBARA_INTEGRATE_REVIEW=https://github.com/protocolbuffers/protobuf/pull/14197 from hknielsen:support-non-ascii-commandline-args 673d5756652f67892f54cd0f1f23d5d54b132f36 PiperOrigin-RevId: 568722987 --- build_defs/cpp_opts.bzl | 1 + 1 file changed, 1 insertion(+) diff --git a/build_defs/cpp_opts.bzl b/build_defs/cpp_opts.bzl index 5a32371dac..03106df951 100644 --- a/build_defs/cpp_opts.bzl +++ b/build_defs/cpp_opts.bzl @@ -35,6 +35,7 @@ LINK_OPTS = select({ "//build_defs:config_msvc": [ # Suppress linker warnings about files with no symbols defined. "-ignore:4221", + "/utf-8", ], "@platforms//os:macos": [ "-lpthread",