Put NDEBUG in upb, not in CFLAGS.

pull/8006/head
Joshua Haberman 5 years ago
parent e1b42ab946
commit 8ea38263ec
  1. 2
      php/ext/google/protobuf/php-upb.h
  2. 2
      php/tests/compile_extension.sh

@ -1,3 +1,5 @@
#define NDEBUG
/* Amalgamated source file */ /* Amalgamated source file */
#include <stdint.h>/* #include <stdint.h>/*
* This is where we define macros used across upb. * This is where we define macros used across upb.

@ -10,7 +10,7 @@ rm -f configure.in configure.ac
php make-preload.php php make-preload.php
phpize phpize
if [ "$1" = "--release" ]; then if [ "$1" = "--release" ]; then
./configure --with-php-config=$(which php-config) CFLAGS="-DNDEBUG" ./configure --with-php-config=$(which php-config)
else else
# To get debugging symbols in PHP itself, build PHP with: # To get debugging symbols in PHP itself, build PHP with:
# $ ./configure --enable-debug CFLAGS='-g -O0' # $ ./configure --enable-debug CFLAGS='-g -O0'

Loading…
Cancel
Save