1, Add comments for include<algorithm> we added for min/max on VS2013. 2, Add #if/#endif to wrap #undef

10 years ago · 83964a9ab4
parent 7db9c098df
commit 83964a9ab4
3 changed files with 4 additions and 0 deletions
--- a/src/google/protobuf/repeated_field.h
+++ b/src/google/protobuf/repeated_field.h
@ -47,6 +47,7 @@
 #define GOOGLE_PROTOBUF_REPEATED_FIELD_H__

 #ifdef _MSC_VER
+// This is required for min/max on VS2013 only.
 #include <algorithm>
 #endif

--- a/src/google/protobuf/stubs/atomicops.h
+++ b/src/google/protobuf/stubs/atomicops.h
@ -120,7 +120,9 @@ Atomic32 Release_CompareAndSwap(volatile Atomic32* ptr,
                                Atomic32 old_value,
                                Atomic32 new_value);

+#if defined(__MINGW32__) && defined(MemoryBarrier)
 #undef MemoryBarrier
+#endif
 void MemoryBarrier();
 void NoBarrier_Store(volatile Atomic32* ptr, Atomic32 value);
 void Acquire_Store(volatile Atomic32* ptr, Atomic32 value);
--- a/src/google/protobuf/wire_format_lite_inl.h
+++ b/src/google/protobuf/wire_format_lite_inl.h
@ -37,6 +37,7 @@
 #define GOOGLE_PROTOBUF_WIRE_FORMAT_LITE_INL_H__

 #ifdef _MSC_VER
+// This is required for min/max on VS2013 only.
 #include <algorithm>
 #endif