Merge pull request #185 from mzhaom/remove-unused

Remove unused methods:
pull/150/merge
Jisi Liu 10 years ago
commit 7e9020fb0e
  1. 4
      src/google/protobuf/compiler/cpp/cpp_message.cc
  2. 23
      src/google/protobuf/compiler/javanano/javanano_primitive_field.cc

@ -280,10 +280,6 @@ void OptimizePadding(vector<const FieldDescriptor*>* fields) {
}
}
string MessageTypeProtoName(const FieldDescriptor* field) {
return field->message_type()->full_name();
}
// Emits an if-statement with a condition that evaluates to true if |field| is
// considered non-default (will be sent over the wire), for message types
// without true field presence. Should only be called if

@ -155,28 +155,6 @@ int FixedSize(FieldDescriptor::Type type) {
return -1;
}
// Return true if the type is a that has variable length
// for instance String's.
bool IsVariableLenType(JavaType type) {
switch (type) {
case JAVATYPE_INT : return false;
case JAVATYPE_LONG : return false;
case JAVATYPE_FLOAT : return false;
case JAVATYPE_DOUBLE : return false;
case JAVATYPE_BOOLEAN: return false;
case JAVATYPE_STRING : return true;
case JAVATYPE_BYTES : return true;
case JAVATYPE_ENUM : return false;
case JAVATYPE_MESSAGE: return true;
// No default because we want the compiler to complain if any new
// JavaTypes are added.
}
GOOGLE_LOG(FATAL) << "Can't get here.";
return false;
}
bool AllAscii(const string& text) {
for (int i = 0; i < text.size(); i++) {
if ((text[i] & 0x80) != 0) {
@ -186,6 +164,7 @@ bool AllAscii(const string& text) {
return true;
}
void SetPrimitiveVariables(const FieldDescriptor* descriptor, const Params params,
map<string, string>* variables) {
(*variables)["name"] =

Loading…
Cancel
Save