`#ifdef` out `clang`-specific pragmas to avoid unknown pragma warnings when compiling with non-`clang` (#18241)

Closes #18241

COPYBARA_INTEGRATE_REVIEW=https://github.com/protocolbuffers/protobuf/pull/18241 from tempoz:tempoz-fix-unknown-pragma e67f358885
PiperOrigin-RevId: 676625555
pull/18428/head
Zoey Greer 2 months ago committed by Copybara-Service
parent 9580af32d1
commit 7d3e80ce9c
  1. 4
      src/google/protobuf/wire_format_lite.cc

@ -671,9 +671,11 @@ static size_t VarintSize(const T* data, const int n) {
if (x > 0x1FFFFF) sum++; if (x > 0x1FFFFF) sum++;
if (x > 0xFFFFFFF) sum++; if (x > 0xFFFFFFF) sum++;
} }
#ifdef __clang__
// Clang is not smart enough to see that this loop doesn't run many times // Clang is not smart enough to see that this loop doesn't run many times
// NOLINTNEXTLINE(google3-runtime-pragma-loop-hint): b/315043579 // NOLINTNEXTLINE(google3-runtime-pragma-loop-hint): b/315043579
#pragma clang loop vectorize(disable) unroll(disable) interleave(disable) #pragma clang loop vectorize(disable) unroll(disable) interleave(disable)
#endif
for (; i < n; i++) { for (; i < n; i++) {
uint32_t x = data[i]; uint32_t x = data[i];
if (ZigZag) { if (ZigZag) {
@ -713,9 +715,11 @@ static size_t VarintSize64(const T* data, const int n) {
if (x > 0x1FFFFF) sum++; if (x > 0x1FFFFF) sum++;
if (x > 0xFFFFFFF) sum++; if (x > 0xFFFFFFF) sum++;
} }
#ifdef __clang__
// Clang is not smart enough to see that this loop doesn't run many times // Clang is not smart enough to see that this loop doesn't run many times
// NOLINTNEXTLINE(google3-runtime-pragma-loop-hint): b/315043579 // NOLINTNEXTLINE(google3-runtime-pragma-loop-hint): b/315043579
#pragma clang loop vectorize(disable) unroll(disable) interleave(disable) #pragma clang loop vectorize(disable) unroll(disable) interleave(disable)
#endif
for (; i < n; i++) { for (; i < n; i++) {
uint64_t x = data[i]; uint64_t x = data[i];
if (ZigZag) { if (ZigZag) {

Loading…
Cancel
Save