From e211ad3300d27e6e270d322ad8652471e7e8b9e7 Mon Sep 17 00:00:00 2001 From: Adam Cozzette Date: Fri, 7 May 2021 11:34:04 -0700 Subject: [PATCH 01/10] Updated CHANGES.txt and PHP changelog for 3.17.0 (#8583) --- CHANGES.txt | 22 ++++++++++++++++++++-- php/ext/google/protobuf/package.xml | 2 +- 2 files changed, 21 insertions(+), 3 deletions(-) diff --git a/CHANGES.txt b/CHANGES.txt index 405bd4961b..6589b7e498 100644 --- a/CHANGES.txt +++ b/CHANGES.txt @@ -1,10 +1,12 @@ - -Unreleased Changes (C++/Java/Python/PHP/Objective-C/C#/Ruby/JavaScript) +2021-05-07 version 3.17.0 (C++/Java/Python/PHP/Objective-C/C#/Ruby/JavaScript) Protocol Compiler * Fix the generated source information for reserved values in Enums. C++ + * Fix -Wunused-parameter in map fields (fixes #8494) (#8500) + * Use byteswap.h when building against musl libc (#8503) + * Fix -Wundefined-inline error when using SharedCtor() or SharedDtor() (#8532) * Fix bug where `Descriptor::DebugString()` printed proto3 synthetic oneofs. * Provide stable versions of `SortAndUnique()`. * Make sure to cache proto3 optional message fields when they are cleared. @@ -15,6 +17,7 @@ Unreleased Changes (C++/Java/Python/PHP/Objective-C/C#/Ruby/JavaScript) * Restrict extension setter and getter operators to non-nullable T. Java + * updating GSON and Guava to more recent versions (#8524) * Reduce the time spent evaluating isExtensionNumber by storing the extension ranges in a TreeMap for faster queries. This is particularly relevant for protos which define a large number of extension ranges, for example when @@ -23,13 +26,28 @@ Unreleased Changes (C++/Java/Python/PHP/Objective-C/C#/Ruby/JavaScript) * Optimize Descriptor.isExtensionNumber. Python + * [python-runtime] Add MethodDescriptor.CopyToProto() (#8327) + * Remove unused python_protobuf.{cc,h} (#8513) + * Start publishing python aarch64 manylinux wheels normally (#8530) + * Fix constness issue detected by MSVC standard conforming mode (#8568) * Make JSON parsing match C++ and Java when multiple fields from the same oneof are present and all but one is null. + Ruby + * Ruby: Add support for proto3 json_name in compiler and field definitions (#8356) + * Fixed memory leak of Ruby arena objects. (#8461) + * Fix source gem compilation (#8471) + * fix(ruby): Fix various exceptions in Ruby on 64-bit Windows (#8563) + * fix(ruby): Fix crash when calculating Message hash values on 64-bit Windows (#8565) + Conformance Tests * Added a conformance test for the case of multiple fields from the same oneof. + Other + * Opensourcing kotlin protos (#8272) + * Use a newer version of rules_proto, with the new rule `proto_descriptor_set` (#8469) + 3.16.0 (C++/Java/Python/PHP/Objective-C/C#/Ruby/JavaScript) C++ diff --git a/php/ext/google/protobuf/package.xml b/php/ext/google/protobuf/package.xml index 1a585c6be3..e612885e8e 100644 --- a/php/ext/google/protobuf/package.xml +++ b/php/ext/google/protobuf/package.xml @@ -22,7 +22,7 @@ 3-Clause BSD License - No new changes in 3.15.8 + No new changes in 3.17.0 From 3546d29a001e772a51274914f876f1ada65117ec Mon Sep 17 00:00:00 2001 From: Adam Cozzette Date: Mon, 10 May 2021 13:36:33 -0700 Subject: [PATCH 02/10] Add the kotlin and kotlin-lite directories to the main pom.xml (#8585) * Add the kotlin and kotlin-lite directories to the main pom.xml * Updated Kotlin versions to 3.17.0-rc1 * Fix Mac CI tests by resolving brew package conflict --- java/kotlin-lite/pom.xml | 2 +- java/kotlin/pom.xml | 2 +- java/pom.xml | 2 ++ kokoro/macos/prepare_build_macos_rc | 5 +++++ 4 files changed, 9 insertions(+), 2 deletions(-) diff --git a/java/kotlin-lite/pom.xml b/java/kotlin-lite/pom.xml index 80b4c4ffae..685e98ea46 100644 --- a/java/kotlin-lite/pom.xml +++ b/java/kotlin-lite/pom.xml @@ -4,7 +4,7 @@ com.google.protobuf protobuf-parent - 3.15.6 + 3.17.0-rc-1 protobuf-kotlin-lite diff --git a/java/kotlin/pom.xml b/java/kotlin/pom.xml index 5f28125175..e7ddedcc07 100644 --- a/java/kotlin/pom.xml +++ b/java/kotlin/pom.xml @@ -4,7 +4,7 @@ com.google.protobuf protobuf-parent - 3.15.6 + 3.17.0-rc-1 protobuf-kotlin diff --git a/java/pom.xml b/java/pom.xml index b62b406675..4409f1ad63 100644 --- a/java/pom.xml +++ b/java/pom.xml @@ -238,6 +238,8 @@ lite core util + kotlin + kotlin-lite diff --git a/kokoro/macos/prepare_build_macos_rc b/kokoro/macos/prepare_build_macos_rc index d94dd543fd..dcd17f330c 100755 --- a/kokoro/macos/prepare_build_macos_rc +++ b/kokoro/macos/prepare_build_macos_rc @@ -45,6 +45,11 @@ sudo rm -rf \ git -C /usr/local/Homebrew/Library/Taps/homebrew/homebrew-core fetch --unshallow git -C /usr/local/Homebrew/Library/Taps/homebrew/homebrew-cask fetch --unshallow +# This is needed to fix a conflict between the ilmbase and imath packages, +# which seem to conflict with each other by both trying to install +# libImath.dylib. +brew unlink ilmbase + brew update brew upgrade From 90d4f31438da1852a1f6f2e420d861b7cd272ba1 Mon Sep 17 00:00:00 2001 From: Yuriy Chernyshov Date: Tue, 11 May 2021 01:50:15 +0500 Subject: [PATCH 03/10] Fix newly appeared -Wunused-parameter (#8587) This is #8584 applied to 3.17.x --- src/google/protobuf/arena.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/google/protobuf/arena.h b/src/google/protobuf/arena.h index f84e505ebb..e5d79d163f 100644 --- a/src/google/protobuf/arena.h +++ b/src/google/protobuf/arena.h @@ -709,7 +709,7 @@ class PROTOBUF_EXPORT PROTOBUF_ALIGNAS(8) Arena final { } template PROTOBUF_ALWAYS_INLINE static Arena* GetOwningArenaInternal( - const T* value, std::false_type) { + const T* /* value */, std::false_type) { return nullptr; } From f807c02226ce9e1595ddb2c57ee34fc444aee893 Mon Sep 17 00:00:00 2001 From: Adam Cozzette Date: Mon, 10 May 2021 15:31:35 -0700 Subject: [PATCH 04/10] Update protobuf version to 3.17.0-rc2 (#8586) * Update protobuf version * Updated Kotlin versions and updated script to handle them --- Protobuf-C++.podspec | 2 +- Protobuf.podspec | 2 +- configure.ac | 2 +- csharp/Google.Protobuf.Tools.nuspec | 2 +- .../Google.Protobuf/Google.Protobuf.csproj | 2 +- java/bom/pom.xml | 2 +- java/core/pom.xml | 2 +- java/kotlin-lite/pom.xml | 2 +- java/kotlin/pom.xml | 2 +- java/lite/pom.xml | 2 +- java/pom.xml | 2 +- java/util/pom.xml | 2 +- js/package.json | 2 +- php/ext/google/protobuf/package.xml | 21 ++++++++++++++++--- php/ext/google/protobuf/protobuf.h | 2 +- protoc-artifacts/pom.xml | 2 +- python/google/protobuf/__init__.py | 2 +- ruby/google-protobuf.gemspec | 2 +- src/google/protobuf/port_def.inc | 2 +- src/google/protobuf/stubs/common.h | 2 +- update_version.py | 10 +++++++++ 21 files changed, 47 insertions(+), 22 deletions(-) diff --git a/Protobuf-C++.podspec b/Protobuf-C++.podspec index c36c0f4053..7a68c6eae8 100644 --- a/Protobuf-C++.podspec +++ b/Protobuf-C++.podspec @@ -1,6 +1,6 @@ Pod::Spec.new do |s| s.name = 'Protobuf-C++' - s.version = '3.17.0-rc1' + s.version = '3.17.0-rc2' s.summary = 'Protocol Buffers v3 runtime library for C++.' s.homepage = 'https://github.com/google/protobuf' s.license = '3-Clause BSD License' diff --git a/Protobuf.podspec b/Protobuf.podspec index 399ed65b2a..9b8be5aed2 100644 --- a/Protobuf.podspec +++ b/Protobuf.podspec @@ -5,7 +5,7 @@ # dependent projects use the :git notation to refer to the library. Pod::Spec.new do |s| s.name = 'Protobuf' - s.version = '3.17.0-rc1' + s.version = '3.17.0-rc2' s.summary = 'Protocol Buffers v.3 runtime library for Objective-C.' s.homepage = 'https://github.com/protocolbuffers/protobuf' s.license = '3-Clause BSD License' diff --git a/configure.ac b/configure.ac index df125d9c94..2e7462240e 100644 --- a/configure.ac +++ b/configure.ac @@ -17,7 +17,7 @@ AC_PREREQ(2.59) # In the SVN trunk, the version should always be the next anticipated release # version with the "-pre" suffix. (We used to use "-SNAPSHOT" but this pushed # the size of one file name in the dist tarfile over the 99-char limit.) -AC_INIT([Protocol Buffers],[3.17.0-rc-1],[protobuf@googlegroups.com],[protobuf]) +AC_INIT([Protocol Buffers],[3.17.0-rc-2],[protobuf@googlegroups.com],[protobuf]) AM_MAINTAINER_MODE([enable]) diff --git a/csharp/Google.Protobuf.Tools.nuspec b/csharp/Google.Protobuf.Tools.nuspec index c9a89f4349..78e61a12c7 100644 --- a/csharp/Google.Protobuf.Tools.nuspec +++ b/csharp/Google.Protobuf.Tools.nuspec @@ -5,7 +5,7 @@ Google Protocol Buffers tools Tools for Protocol Buffers - Google's data interchange format. See project site for more info. - 3.17.0-rc1 + 3.17.0-rc2 Google Inc. protobuf-packages https://github.com/protocolbuffers/protobuf/blob/master/LICENSE diff --git a/csharp/src/Google.Protobuf/Google.Protobuf.csproj b/csharp/src/Google.Protobuf/Google.Protobuf.csproj index c3a171b531..f80a1a5669 100644 --- a/csharp/src/Google.Protobuf/Google.Protobuf.csproj +++ b/csharp/src/Google.Protobuf/Google.Protobuf.csproj @@ -4,7 +4,7 @@ C# runtime library for Protocol Buffers - Google's data interchange format. Copyright 2015, Google Inc. Google Protocol Buffers - 3.17.0-rc1 + 3.17.0-rc2 7.2 Google Inc. diff --git a/java/bom/pom.xml b/java/bom/pom.xml index 372917c275..51bd520c73 100644 --- a/java/bom/pom.xml +++ b/java/bom/pom.xml @@ -4,7 +4,7 @@ com.google.protobuf protobuf-bom - 3.17.0-rc-1 + 3.17.0-rc-2 pom Protocol Buffers [BOM] diff --git a/java/core/pom.xml b/java/core/pom.xml index ca3255ef3f..59abf96c82 100644 --- a/java/core/pom.xml +++ b/java/core/pom.xml @@ -4,7 +4,7 @@ com.google.protobuf protobuf-parent - 3.17.0-rc-1 + 3.17.0-rc-2 protobuf-java diff --git a/java/kotlin-lite/pom.xml b/java/kotlin-lite/pom.xml index 685e98ea46..17ea465423 100644 --- a/java/kotlin-lite/pom.xml +++ b/java/kotlin-lite/pom.xml @@ -4,7 +4,7 @@ com.google.protobuf protobuf-parent - 3.17.0-rc-1 + 3.17.0-rc-2 protobuf-kotlin-lite diff --git a/java/kotlin/pom.xml b/java/kotlin/pom.xml index e7ddedcc07..fef8550783 100644 --- a/java/kotlin/pom.xml +++ b/java/kotlin/pom.xml @@ -4,7 +4,7 @@ com.google.protobuf protobuf-parent - 3.17.0-rc-1 + 3.17.0-rc-2 protobuf-kotlin diff --git a/java/lite/pom.xml b/java/lite/pom.xml index da7ee82d6d..f66c2162ce 100644 --- a/java/lite/pom.xml +++ b/java/lite/pom.xml @@ -4,7 +4,7 @@ com.google.protobuf protobuf-parent - 3.17.0-rc-1 + 3.17.0-rc-2 protobuf-javalite diff --git a/java/pom.xml b/java/pom.xml index 4409f1ad63..5a58455324 100644 --- a/java/pom.xml +++ b/java/pom.xml @@ -4,7 +4,7 @@ com.google.protobuf protobuf-parent - 3.17.0-rc-1 + 3.17.0-rc-2 pom Protocol Buffers [Parent] diff --git a/java/util/pom.xml b/java/util/pom.xml index 2b38d8cb3c..5232b54c9c 100644 --- a/java/util/pom.xml +++ b/java/util/pom.xml @@ -4,7 +4,7 @@ com.google.protobuf protobuf-parent - 3.17.0-rc-1 + 3.17.0-rc-2 protobuf-java-util diff --git a/js/package.json b/js/package.json index c5e8674d55..16686a5e86 100644 --- a/js/package.json +++ b/js/package.json @@ -1,6 +1,6 @@ { "name": "google-protobuf", - "version": "3.17.0-rc.1", + "version": "3.17.0-rc.2", "description": "Protocol Buffers for JavaScript", "main": "google-protobuf.js", "files": [ diff --git a/php/ext/google/protobuf/package.xml b/php/ext/google/protobuf/package.xml index e612885e8e..2bdf30a9dd 100644 --- a/php/ext/google/protobuf/package.xml +++ b/php/ext/google/protobuf/package.xml @@ -10,10 +10,10 @@ protobuf-opensource@google.com yes - 2021-05-06 - + 2021-05-07 + - 3.17.0RC1 + 3.17.0RC2 3.17.0 @@ -932,5 +932,20 @@ G A release. + + + 3.17.0RC2 + 3.17.0 + + + beta + beta + + 2021-05-07 + + 3-Clause BSD License + + + diff --git a/php/ext/google/protobuf/protobuf.h b/php/ext/google/protobuf/protobuf.h index 2f3bddc03f..a9b7dbb90b 100644 --- a/php/ext/google/protobuf/protobuf.h +++ b/php/ext/google/protobuf/protobuf.h @@ -76,7 +76,7 @@ ZEND_BEGIN_ARG_INFO_EX(arginfo_setter, 0, 0, 1) ZEND_ARG_INFO(0, value) ZEND_END_ARG_INFO() -#define PHP_PROTOBUF_VERSION "3.17.0RC1" +#define PHP_PROTOBUF_VERSION "3.17.0RC2" // ptr -> PHP object cache. This is a weak map that caches lazily-created // wrapper objects around upb types: diff --git a/protoc-artifacts/pom.xml b/protoc-artifacts/pom.xml index 6922d6413c..d20c60958f 100644 --- a/protoc-artifacts/pom.xml +++ b/protoc-artifacts/pom.xml @@ -8,7 +8,7 @@ com.google.protobuf protoc - 3.17.0-rc-1 + 3.17.0-rc-2 pom Protobuf Compiler diff --git a/python/google/protobuf/__init__.py b/python/google/protobuf/__init__.py index 04d921d5eb..64799d7b79 100644 --- a/python/google/protobuf/__init__.py +++ b/python/google/protobuf/__init__.py @@ -30,4 +30,4 @@ # Copyright 2007 Google Inc. All Rights Reserved. -__version__ = '3.17.0rc1' +__version__ = '3.17.0rc2' diff --git a/ruby/google-protobuf.gemspec b/ruby/google-protobuf.gemspec index e87bcc94ed..5ffb74736a 100644 --- a/ruby/google-protobuf.gemspec +++ b/ruby/google-protobuf.gemspec @@ -1,6 +1,6 @@ Gem::Specification.new do |s| s.name = "google-protobuf" - s.version = "3.17.0.rc.1" + s.version = "3.17.0.rc.2" git_tag = "v#{s.version.to_s.sub('.rc.', '-rc')}" # Converts X.Y.Z.rc.N to vX.Y.Z-rcN, used for the git tag s.licenses = ["BSD-3-Clause"] s.summary = "Protocol Buffers" diff --git a/src/google/protobuf/port_def.inc b/src/google/protobuf/port_def.inc index c257553ea7..d7d51e99f9 100644 --- a/src/google/protobuf/port_def.inc +++ b/src/google/protobuf/port_def.inc @@ -122,7 +122,7 @@ #ifdef PROTOBUF_VERSION_SUFFIX #error PROTOBUF_VERSION_SUFFIX was previously defined #endif -#define PROTOBUF_VERSION_SUFFIX "-rc1" +#define PROTOBUF_VERSION_SUFFIX "-rc2" #if defined(PROTOBUF_NAMESPACE) || defined(PROTOBUF_NAMESPACE_ID) #error PROTOBUF_NAMESPACE or PROTOBUF_NAMESPACE_ID was previously defined diff --git a/src/google/protobuf/stubs/common.h b/src/google/protobuf/stubs/common.h index 25078afffb..9772b5a69c 100644 --- a/src/google/protobuf/stubs/common.h +++ b/src/google/protobuf/stubs/common.h @@ -85,7 +85,7 @@ namespace internal { #define GOOGLE_PROTOBUF_VERSION 3017000 // A suffix string for alpha, beta or rc releases. Empty for stable releases. -#define GOOGLE_PROTOBUF_VERSION_SUFFIX "-rc1" +#define GOOGLE_PROTOBUF_VERSION_SUFFIX "-rc2" // The minimum header version which works with the current version of // the library. This constant should only be used by protoc's C++ code diff --git a/update_version.py b/update_version.py index 470e4251e6..447772c0e3 100755 --- a/update_version.py +++ b/update_version.py @@ -228,6 +228,16 @@ def UpdateJava(): Find(Find(document.documentElement, 'parent'), 'version'), GetFullVersion())) + RewriteXml('java/kotlin/pom.xml', + lambda document : ReplaceText( + Find(Find(document.documentElement, 'parent'), 'version'), + GetFullVersion())) + + RewriteXml('java/kotlin-lite/pom.xml', + lambda document : ReplaceText( + Find(Find(document.documentElement, 'parent'), 'version'), + GetFullVersion())) + RewriteXml('protoc-artifacts/pom.xml', lambda document : ReplaceText( Find(document.documentElement, 'version'), GetFullVersion())) From ca7f54aa1a690c804bbd1ed1a754baf8a8686191 Mon Sep 17 00:00:00 2001 From: Yuriy Chernyshov Date: Wed, 12 May 2021 02:58:29 +0500 Subject: [PATCH 05/10] Fix -Wunused-parameter in java_names.h (#8601) * Fix -Wunused-parameter in java_names.h * Apply review comments --- src/google/protobuf/compiler/java/java_helpers.h | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/google/protobuf/compiler/java/java_helpers.h b/src/google/protobuf/compiler/java/java_helpers.h index 13dd903567..5dc25d6c93 100644 --- a/src/google/protobuf/compiler/java/java_helpers.h +++ b/src/google/protobuf/compiler/java/java_helpers.h @@ -155,6 +155,7 @@ std::string GetOneofStoredType(const FieldDescriptor* field); // Whether we should generate multiple java files for messages. inline bool MultipleJavaFiles(const FileDescriptor* descriptor, bool immutable) { + (void) immutable; return descriptor->options().java_multiple_files(); } @@ -244,15 +245,15 @@ bool IsDefaultValueJavaDefault(const FieldDescriptor* field); bool IsByteStringWithCustomDefaultValue(const FieldDescriptor* field); // Does this message class have descriptor and reflection methods? -inline bool HasDescriptorMethods(const Descriptor* descriptor, +inline bool HasDescriptorMethods(const Descriptor* /* descriptor */, bool enforce_lite) { return !enforce_lite; } -inline bool HasDescriptorMethods(const EnumDescriptor* descriptor, +inline bool HasDescriptorMethods(const EnumDescriptor* /* descriptor */, bool enforce_lite) { return !enforce_lite; } -inline bool HasDescriptorMethods(const FileDescriptor* descriptor, +inline bool HasDescriptorMethods(const FileDescriptor* /* descriptor */, bool enforce_lite) { return !enforce_lite; } From a4866d34f90f134d06a085ed433a3863dd4f5f31 Mon Sep 17 00:00:00 2001 From: Adam Cozzette Date: Tue, 11 May 2021 11:44:39 -0700 Subject: [PATCH 06/10] Updated .gitignore to include Kotlin directories --- .gitignore | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/.gitignore b/.gitignore index 4880c495de..d38133b822 100644 --- a/.gitignore +++ b/.gitignore @@ -82,10 +82,7 @@ src/**/*.log src/**/*.trs # JavaBuild output. -java/core/target -java/lite/target -java/util/target -javanano/target +java/**/target java/.idea java/**/*.iml From 5a9367ac5718abef6083d480d3bd3cb5f79b7b70 Mon Sep 17 00:00:00 2001 From: Adam Cozzette Date: Tue, 11 May 2021 12:07:45 -0700 Subject: [PATCH 07/10] Update tests.sh to skip the Kotlin tests on Oracle 7 --- tests.sh | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/tests.sh b/tests.sh index 972e64f960..e6369eb80d 100755 --- a/tests.sh +++ b/tests.sh @@ -208,7 +208,13 @@ build_java() { # Java build needs `protoc`. internal_build_cpp cp -r java $dir - cd $dir && $MVN clean && $MVN test + cd $dir && $MVN clean + # Skip the Kotlin tests on Oracle 7 + if [ "$version" == "oracle7" ]; then + $MVN test -pl bom,lite,core,util + else + $MVN test + fi cd ../.. } From 0aabf89420644976de2f94238c6e6e65ae3cf657 Mon Sep 17 00:00:00 2001 From: Adam Cozzette Date: Tue, 11 May 2021 12:09:56 -0700 Subject: [PATCH 08/10] Remove some redundant language prefixes from the changelog for 3.17 --- CHANGES.txt | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/CHANGES.txt b/CHANGES.txt index 6589b7e498..f9446b2035 100644 --- a/CHANGES.txt +++ b/CHANGES.txt @@ -26,7 +26,7 @@ * Optimize Descriptor.isExtensionNumber. Python - * [python-runtime] Add MethodDescriptor.CopyToProto() (#8327) + * Add MethodDescriptor.CopyToProto() (#8327) * Remove unused python_protobuf.{cc,h} (#8513) * Start publishing python aarch64 manylinux wheels normally (#8530) * Fix constness issue detected by MSVC standard conforming mode (#8568) @@ -34,11 +34,11 @@ oneof are present and all but one is null. Ruby - * Ruby: Add support for proto3 json_name in compiler and field definitions (#8356) + * Add support for proto3 json_name in compiler and field definitions (#8356) * Fixed memory leak of Ruby arena objects. (#8461) * Fix source gem compilation (#8471) - * fix(ruby): Fix various exceptions in Ruby on 64-bit Windows (#8563) - * fix(ruby): Fix crash when calculating Message hash values on 64-bit Windows (#8565) + * Fix various exceptions in Ruby on 64-bit Windows (#8563) + * Fix crash when calculating Message hash values on 64-bit Windows (#8565) Conformance Tests * Added a conformance test for the case of multiple fields from the same From ca295506c5b812122b8bdd3dd6b4e6a6875ee1b7 Mon Sep 17 00:00:00 2001 From: Adam Cozzette Date: Wed, 12 May 2021 14:42:15 -0700 Subject: [PATCH 09/10] Make the dist_install test use Java 8 (#8609) This is necessary because the Kotlin support requires Java 8 or higher. Making this test use Java 8 required switching it to the java_stretch Docker image and updating that image to include some Python dependencies. --- kokoro/linux/dist_install/build.sh | 4 ++-- .../linux/dockerfile/test/java_stretch/Dockerfile | 13 ++++++------- tests.sh | 2 +- 3 files changed, 9 insertions(+), 10 deletions(-) diff --git a/kokoro/linux/dist_install/build.sh b/kokoro/linux/dist_install/build.sh index 81a0516aa8..c456ee81fa 100755 --- a/kokoro/linux/dist_install/build.sh +++ b/kokoro/linux/dist_install/build.sh @@ -7,8 +7,8 @@ set -ex # exit immediately on error # Change to repo root cd $(dirname $0)/../../.. -# Run tests under release docker image. -export DOCKERFILE_DIR=kokoro/linux/64-bit +export DOCKERHUB_ORGANIZATION=protobuftesting +export DOCKERFILE_DIR=kokoro/linux/dockerfile/test/java_stretch export DOCKER_RUN_SCRIPT=kokoro/linux/pull_request_in_docker.sh export OUTPUT_DIR=testoutput export TEST_SET="dist_install" diff --git a/kokoro/linux/dockerfile/test/java_stretch/Dockerfile b/kokoro/linux/dockerfile/test/java_stretch/Dockerfile index fc5e82abdb..3e72046f47 100644 --- a/kokoro/linux/dockerfile/test/java_stretch/Dockerfile +++ b/kokoro/linux/dockerfile/test/java_stretch/Dockerfile @@ -1,6 +1,6 @@ FROM debian:stretch -# Install dependencies. We start with the basic ones require to build protoc +# Install dependencies. We start with the basic ones required to build protoc # and the C++ build RUN apt-get update && apt-get install -y \ autoconf \ @@ -20,12 +20,11 @@ RUN apt-get update && apt-get install -y \ parallel \ time \ wget \ - && apt-get clean - -# Java dependencies -RUN apt-get install -y \ - # -- For all Java builds -- \ + # Java dependencies maven \ - # -- For java_linkage_monitor \ openjdk-8-jdk \ + # Python dependencies + python-setuptools \ + python-pip \ + virtualenv \ && apt-get clean diff --git a/tests.sh b/tests.sh index e6369eb80d..923201a821 100755 --- a/tests.sh +++ b/tests.sh @@ -104,7 +104,7 @@ build_dist_install() { # Try to install Java pushd java - use_java jdk7 + use_java jdk8 $MVN install popd From 652d99a8ee8aa6b801e11977951fbf444cfccc8f Mon Sep 17 00:00:00 2001 From: Adam Cozzette Date: Wed, 12 May 2021 16:20:18 -0700 Subject: [PATCH 10/10] Update protobuf version (#8606) --- Protobuf-C++.podspec | 2 +- Protobuf.podspec | 2 +- configure.ac | 2 +- csharp/Google.Protobuf.Tools.nuspec | 2 +- .../Google.Protobuf/Google.Protobuf.csproj | 2 +- java/bom/pom.xml | 2 +- java/core/pom.xml | 2 +- java/kotlin-lite/pom.xml | 2 +- java/kotlin/pom.xml | 2 +- java/lite/pom.xml | 2 +- java/pom.xml | 2 +- java/util/pom.xml | 2 +- js/package.json | 2 +- php/ext/google/protobuf/package.xml | 25 +++++++++++++++---- php/ext/google/protobuf/protobuf.h | 2 +- protoc-artifacts/pom.xml | 2 +- python/google/protobuf/__init__.py | 2 +- ruby/google-protobuf.gemspec | 2 +- src/google/protobuf/port_def.inc | 2 +- src/google/protobuf/stubs/common.h | 2 +- 20 files changed, 39 insertions(+), 24 deletions(-) diff --git a/Protobuf-C++.podspec b/Protobuf-C++.podspec index 7a68c6eae8..57d58f42bb 100644 --- a/Protobuf-C++.podspec +++ b/Protobuf-C++.podspec @@ -1,6 +1,6 @@ Pod::Spec.new do |s| s.name = 'Protobuf-C++' - s.version = '3.17.0-rc2' + s.version = '3.17.0' s.summary = 'Protocol Buffers v3 runtime library for C++.' s.homepage = 'https://github.com/google/protobuf' s.license = '3-Clause BSD License' diff --git a/Protobuf.podspec b/Protobuf.podspec index 9b8be5aed2..1c2b1984a2 100644 --- a/Protobuf.podspec +++ b/Protobuf.podspec @@ -5,7 +5,7 @@ # dependent projects use the :git notation to refer to the library. Pod::Spec.new do |s| s.name = 'Protobuf' - s.version = '3.17.0-rc2' + s.version = '3.17.0' s.summary = 'Protocol Buffers v.3 runtime library for Objective-C.' s.homepage = 'https://github.com/protocolbuffers/protobuf' s.license = '3-Clause BSD License' diff --git a/configure.ac b/configure.ac index 2e7462240e..c36328cd8d 100644 --- a/configure.ac +++ b/configure.ac @@ -17,7 +17,7 @@ AC_PREREQ(2.59) # In the SVN trunk, the version should always be the next anticipated release # version with the "-pre" suffix. (We used to use "-SNAPSHOT" but this pushed # the size of one file name in the dist tarfile over the 99-char limit.) -AC_INIT([Protocol Buffers],[3.17.0-rc-2],[protobuf@googlegroups.com],[protobuf]) +AC_INIT([Protocol Buffers],[3.17.0],[protobuf@googlegroups.com],[protobuf]) AM_MAINTAINER_MODE([enable]) diff --git a/csharp/Google.Protobuf.Tools.nuspec b/csharp/Google.Protobuf.Tools.nuspec index 78e61a12c7..fc01d7617c 100644 --- a/csharp/Google.Protobuf.Tools.nuspec +++ b/csharp/Google.Protobuf.Tools.nuspec @@ -5,7 +5,7 @@ Google Protocol Buffers tools Tools for Protocol Buffers - Google's data interchange format. See project site for more info. - 3.17.0-rc2 + 3.17.0 Google Inc. protobuf-packages https://github.com/protocolbuffers/protobuf/blob/master/LICENSE diff --git a/csharp/src/Google.Protobuf/Google.Protobuf.csproj b/csharp/src/Google.Protobuf/Google.Protobuf.csproj index f80a1a5669..dcc88eff12 100644 --- a/csharp/src/Google.Protobuf/Google.Protobuf.csproj +++ b/csharp/src/Google.Protobuf/Google.Protobuf.csproj @@ -4,7 +4,7 @@ C# runtime library for Protocol Buffers - Google's data interchange format. Copyright 2015, Google Inc. Google Protocol Buffers - 3.17.0-rc2 + 3.17.0 7.2 Google Inc. diff --git a/java/bom/pom.xml b/java/bom/pom.xml index 51bd520c73..43717f721b 100644 --- a/java/bom/pom.xml +++ b/java/bom/pom.xml @@ -4,7 +4,7 @@ com.google.protobuf protobuf-bom - 3.17.0-rc-2 + 3.17.0 pom Protocol Buffers [BOM] diff --git a/java/core/pom.xml b/java/core/pom.xml index 59abf96c82..12fcdc1b9e 100644 --- a/java/core/pom.xml +++ b/java/core/pom.xml @@ -4,7 +4,7 @@ com.google.protobuf protobuf-parent - 3.17.0-rc-2 + 3.17.0 protobuf-java diff --git a/java/kotlin-lite/pom.xml b/java/kotlin-lite/pom.xml index 17ea465423..5a70770167 100644 --- a/java/kotlin-lite/pom.xml +++ b/java/kotlin-lite/pom.xml @@ -4,7 +4,7 @@ com.google.protobuf protobuf-parent - 3.17.0-rc-2 + 3.17.0 protobuf-kotlin-lite diff --git a/java/kotlin/pom.xml b/java/kotlin/pom.xml index fef8550783..a1e50188d9 100644 --- a/java/kotlin/pom.xml +++ b/java/kotlin/pom.xml @@ -4,7 +4,7 @@ com.google.protobuf protobuf-parent - 3.17.0-rc-2 + 3.17.0 protobuf-kotlin diff --git a/java/lite/pom.xml b/java/lite/pom.xml index f66c2162ce..6bd4653f20 100644 --- a/java/lite/pom.xml +++ b/java/lite/pom.xml @@ -4,7 +4,7 @@ com.google.protobuf protobuf-parent - 3.17.0-rc-2 + 3.17.0 protobuf-javalite diff --git a/java/pom.xml b/java/pom.xml index 5a58455324..5bf80cd11d 100644 --- a/java/pom.xml +++ b/java/pom.xml @@ -4,7 +4,7 @@ com.google.protobuf protobuf-parent - 3.17.0-rc-2 + 3.17.0 pom Protocol Buffers [Parent] diff --git a/java/util/pom.xml b/java/util/pom.xml index 5232b54c9c..911acdd348 100644 --- a/java/util/pom.xml +++ b/java/util/pom.xml @@ -4,7 +4,7 @@ com.google.protobuf protobuf-parent - 3.17.0-rc-2 + 3.17.0 protobuf-java-util diff --git a/js/package.json b/js/package.json index 16686a5e86..f92a1a3a93 100644 --- a/js/package.json +++ b/js/package.json @@ -1,6 +1,6 @@ { "name": "google-protobuf", - "version": "3.17.0-rc.2", + "version": "3.17.0", "description": "Protocol Buffers for JavaScript", "main": "google-protobuf.js", "files": [ diff --git a/php/ext/google/protobuf/package.xml b/php/ext/google/protobuf/package.xml index 2bdf30a9dd..4d7d451623 100644 --- a/php/ext/google/protobuf/package.xml +++ b/php/ext/google/protobuf/package.xml @@ -10,15 +10,15 @@ protobuf-opensource@google.com yes - 2021-05-07 - + 2021-05-11 + - 3.17.0RC2 + 3.17.0 3.17.0 - beta - beta + stable + stable 3-Clause BSD License @@ -947,5 +947,20 @@ G A release. + + + 3.17.0 + 3.17.0 + + + stable + stable + + 2021-05-11 + + 3-Clause BSD License + + + diff --git a/php/ext/google/protobuf/protobuf.h b/php/ext/google/protobuf/protobuf.h index a9b7dbb90b..858b520a7f 100644 --- a/php/ext/google/protobuf/protobuf.h +++ b/php/ext/google/protobuf/protobuf.h @@ -76,7 +76,7 @@ ZEND_BEGIN_ARG_INFO_EX(arginfo_setter, 0, 0, 1) ZEND_ARG_INFO(0, value) ZEND_END_ARG_INFO() -#define PHP_PROTOBUF_VERSION "3.17.0RC2" +#define PHP_PROTOBUF_VERSION "3.17.0" // ptr -> PHP object cache. This is a weak map that caches lazily-created // wrapper objects around upb types: diff --git a/protoc-artifacts/pom.xml b/protoc-artifacts/pom.xml index d20c60958f..00fe9ff988 100644 --- a/protoc-artifacts/pom.xml +++ b/protoc-artifacts/pom.xml @@ -8,7 +8,7 @@ com.google.protobuf protoc - 3.17.0-rc-2 + 3.17.0 pom Protobuf Compiler diff --git a/python/google/protobuf/__init__.py b/python/google/protobuf/__init__.py index 64799d7b79..2f5ad27453 100644 --- a/python/google/protobuf/__init__.py +++ b/python/google/protobuf/__init__.py @@ -30,4 +30,4 @@ # Copyright 2007 Google Inc. All Rights Reserved. -__version__ = '3.17.0rc2' +__version__ = '3.17.0' diff --git a/ruby/google-protobuf.gemspec b/ruby/google-protobuf.gemspec index 5ffb74736a..2ba7eab6f0 100644 --- a/ruby/google-protobuf.gemspec +++ b/ruby/google-protobuf.gemspec @@ -1,6 +1,6 @@ Gem::Specification.new do |s| s.name = "google-protobuf" - s.version = "3.17.0.rc.2" + s.version = "3.17.0" git_tag = "v#{s.version.to_s.sub('.rc.', '-rc')}" # Converts X.Y.Z.rc.N to vX.Y.Z-rcN, used for the git tag s.licenses = ["BSD-3-Clause"] s.summary = "Protocol Buffers" diff --git a/src/google/protobuf/port_def.inc b/src/google/protobuf/port_def.inc index d7d51e99f9..811d75edad 100644 --- a/src/google/protobuf/port_def.inc +++ b/src/google/protobuf/port_def.inc @@ -122,7 +122,7 @@ #ifdef PROTOBUF_VERSION_SUFFIX #error PROTOBUF_VERSION_SUFFIX was previously defined #endif -#define PROTOBUF_VERSION_SUFFIX "-rc2" +#define PROTOBUF_VERSION_SUFFIX "" #if defined(PROTOBUF_NAMESPACE) || defined(PROTOBUF_NAMESPACE_ID) #error PROTOBUF_NAMESPACE or PROTOBUF_NAMESPACE_ID was previously defined diff --git a/src/google/protobuf/stubs/common.h b/src/google/protobuf/stubs/common.h index 9772b5a69c..4faf238b78 100644 --- a/src/google/protobuf/stubs/common.h +++ b/src/google/protobuf/stubs/common.h @@ -85,7 +85,7 @@ namespace internal { #define GOOGLE_PROTOBUF_VERSION 3017000 // A suffix string for alpha, beta or rc releases. Empty for stable releases. -#define GOOGLE_PROTOBUF_VERSION_SUFFIX "-rc2" +#define GOOGLE_PROTOBUF_VERSION_SUFFIX "" // The minimum header version which works with the current version of // the library. This constant should only be used by protoc's C++ code