Removed specific MSVC settings when installing (#17285)
When installing protobuf, it creates a different directory for CMake's config files when compiling with MSVC.  _gRPC build on Windows_  _gRPC build on Linux and macOS_ This is problematic because it requires conditionally setting its `protobuf_DIR` for different platforms: ```cmake if(MSVC) set(Protobuf_DIR "${PROTOBUF_PREFIX}/cmake") else() set(Protobuf_DIR "${PROTOBUF_PREFIX}/lib/cmake/protobuf") endif() ``` [The original commit that made this](pull/17364/head7d79458fc5
) based its choice on CMake's version 3.4, which not only is deprecated but is also based on a CMake version [less than the one defined in the master file](https://github.com/protocolbuffers/protobuf/blob/main/CMakeLists.txt#L3). Since then, CMake changed its behaviour, making this distinction unnecessary. Closes #17285 COPYBARA_INTEGRATE_REVIEW=https://github.com/protocolbuffers/protobuf/pull/17285 from EduMenges:maina6f2e375ce
PiperOrigin-RevId: 650455064
parent
fba8024963
commit
770090e901
1 changed files with 3 additions and 9 deletions
Loading…
Reference in new issue