diff --git a/csharp/src/Google.Protobuf/Reflection/FeatureSetDescriptor.g.cs b/csharp/src/Google.Protobuf/Reflection/FeatureSetDescriptor.g.cs deleted file mode 100644 index 208ce1fcb6..0000000000 --- a/csharp/src/Google.Protobuf/Reflection/FeatureSetDescriptor.g.cs +++ /dev/null @@ -1,17 +0,0 @@ -#region Copyright notice and license -// Protocol Buffers - Google's data interchange format -// Copyright 2008 Google Inc. All rights reserved. -// -// Use of this source code is governed by a BSD-style -// license that can be found in the LICENSE file or at -// https://developers.google.com/open-source/licenses/bsd -#endregion - -namespace Google.Protobuf.Reflection; - -internal sealed partial class FeatureSetDescriptor -{ - // Canonical serialized form of the edition defaults, generated by embed_edition_defaults. - private const string DefaultsBase64 = - "ChMYhAciACoMCAEQAhgCIAMoATACChMY5wciACoMCAIQARgBIAIoATABChMY6AciDAgBEAEYASACKAEwASoAIOYHKOgH"; -} diff --git a/upb/message/accessors.h b/upb/message/accessors.h index 2183b6640f..f262609277 100644 --- a/upb/message/accessors.h +++ b/upb/message/accessors.h @@ -169,7 +169,6 @@ UPB_API_INLINE void upb_Message_SetBaseFieldUInt64(struct upb_Message* msg, uint64_t value); // Extension Getters /////////////////////////////////////////////////////////// -// TODO: b/374976899 - Add support for non scalars UPB_API_INLINE bool upb_Message_GetExtensionBool( const upb_Message* msg, const upb_MiniTableExtension* f, bool default_val); @@ -196,6 +195,10 @@ UPB_API_INLINE uint64_t upb_Message_GetExtensionUInt64( const upb_Message* msg, const upb_MiniTableExtension* f, uint64_t default_val); +UPB_API_INLINE upb_StringView upb_Message_GetExtensionString( + const upb_Message* msg, const upb_MiniTableExtension* f, + upb_StringView default_val); + UPB_API_INLINE upb_Message* upb_Message_GetExtensionMessage( const upb_Message* msg, const upb_MiniTableExtension* f, struct upb_Message* default_val); diff --git a/upb/message/internal/accessors.h b/upb/message/internal/accessors.h index 4748a3a23d..b289dad07c 100644 --- a/upb/message/internal/accessors.h +++ b/upb/message/internal/accessors.h @@ -994,6 +994,18 @@ UPB_API_INLINE uint64_t upb_Message_GetExtensionUInt64( return ret; } +UPB_API_INLINE upb_StringView upb_Message_GetExtensionString( + const struct upb_Message* msg, const upb_MiniTableExtension* e, + upb_StringView default_val) { + UPB_ASSUME(upb_MiniTableExtension_CType(e) == kUpb_CType_String || + upb_MiniTableExtension_CType(e) == kUpb_CType_Bytes); + UPB_ASSUME(UPB_PRIVATE(_upb_MiniTableExtension_GetRep)(e) == + kUpb_FieldRep_StringView); + upb_StringView ret; + _upb_Message_GetExtensionField(msg, e, &default_val, &ret); + return ret; +} + UPB_API_INLINE struct upb_Message* upb_Message_GetExtensionMessage( const struct upb_Message* msg, const upb_MiniTableExtension* e, struct upb_Message* default_val) {