Automated rollback of commit f60f478f45.

PiperOrigin-RevId: 503231538
pull/11555/head
Mike Kruskal 2 years ago committed by Copybara-Service
parent 84d8b0037b
commit 71ff3fea2e
  1. 12
      src/google/protobuf/descriptor.cc
  2. 2
      src/google/protobuf/descriptor_unittest.cc

@ -5626,8 +5626,16 @@ void DescriptorBuilder::CheckFieldJsonNameUniqueness(
this_type, field.name(), details.orig_name, existing_type,
match.field->name(), name_suffix);
AddError(message_name, field, DescriptorPool::ErrorCollector::NAME,
error_message);
bool involves_default = !details.is_custom || !match.is_custom;
if (syntax == FileDescriptor::SYNTAX_PROTO2 && involves_default) {
// TODO(b/261750676) Upgrade this to an error once downstream protos have
// been fixed.
AddWarning(message_name, field, DescriptorPool::ErrorCollector::NAME,
error_message);
} else {
AddError(message_name, field, DescriptorPool::ErrorCollector::NAME,
error_message);
}
}
}

@ -7016,7 +7016,7 @@ TEST_F(ValidationErrorTest, ValidateJsonNameConflictProto3) {
}
TEST_F(ValidationErrorTest, ValidateJsonNameConflictProto2) {
BuildFileWithErrors(
BuildFileWithWarnings(
"name: 'foo.proto' "
"syntax: 'proto2' "
"message_type {"

Loading…
Cancel
Save