Fixed VERSION_SUFFIX logic in update_version.py

This commit makes a couple of fixes:
- Make sure we always update the suffix, since even for a non-RC release
  we need to clear the suffix.
- Make sure the suffix is properly quoted and begins with -rc
pull/7840/head
Adam Cozzette 4 years ago
parent 4b93993ac7
commit 6da79e94b0
  1. 11
      update_version.py

@ -101,6 +101,9 @@ def UpdateConfigure():
def UpdateCpp(): def UpdateCpp():
cpp_version = '%d%03d%03d' % ( cpp_version = '%d%03d%03d' % (
NEW_VERSION_INFO[0], NEW_VERSION_INFO[1], NEW_VERSION_INFO[2]) NEW_VERSION_INFO[0], NEW_VERSION_INFO[1], NEW_VERSION_INFO[2])
version_suffix = ''
if RC_VERSION != -1:
version_suffix = '-rc%s' % RC_VERSION
def RewriteCommon(line): def RewriteCommon(line):
line = re.sub( line = re.sub(
r'^#define GOOGLE_PROTOBUF_VERSION .*$', r'^#define GOOGLE_PROTOBUF_VERSION .*$',
@ -110,14 +113,13 @@ def UpdateCpp():
r'^#define PROTOBUF_VERSION .*$', r'^#define PROTOBUF_VERSION .*$',
'#define PROTOBUF_VERSION %s' % cpp_version, '#define PROTOBUF_VERSION %s' % cpp_version,
line) line)
if RC_VERSION != -1:
line = re.sub( line = re.sub(
r'^#define GOOGLE_PROTOBUF_VERSION_SUFFIX .*$', r'^#define GOOGLE_PROTOBUF_VERSION_SUFFIX .*$',
'#define GOOGLE_PROTOBUF_VERSION_SUFFIX %s' % RC_VERSION, '#define GOOGLE_PROTOBUF_VERSION_SUFFIX "%s"' % version_suffix,
line) line)
line = re.sub( line = re.sub(
r'^#define PROTOBUF_VERSION_SUFFIX .*$', r'^#define PROTOBUF_VERSION_SUFFIX .*$',
'#define PROTOBUF_VERSION_SUFFIX %s' % RC_VERSION, '#define PROTOBUF_VERSION_SUFFIX "%s"' % version_suffix,
line) line)
if NEW_VERSION_INFO[2] == 0: if NEW_VERSION_INFO[2] == 0:
line = re.sub( line = re.sub(
@ -143,10 +145,9 @@ def UpdateCpp():
r'^#define PROTOBUF_VERSION .*$', r'^#define PROTOBUF_VERSION .*$',
'#define PROTOBUF_VERSION %s' % cpp_version, '#define PROTOBUF_VERSION %s' % cpp_version,
line) line)
if RC_VERSION != -1:
line = re.sub( line = re.sub(
r'^#define PROTOBUF_VERSION_SUFFIX .*$', r'^#define PROTOBUF_VERSION_SUFFIX .*$',
'#define PROTOBUF_VERSION_SUFFIX %s' % RC_VERSION, '#define PROTOBUF_VERSION_SUFFIX "%s"' % version_suffix,
line) line)
if NEW_VERSION_INFO[2] == 0: if NEW_VERSION_INFO[2] == 0:
line = re.sub( line = re.sub(

Loading…
Cancel
Save