Chiebot-Mirror
/
protobuf
8
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Converted skips to expected failures where possible.

Browse Source
pull/13171/head
Joshua Haberman 3 years ago
parent 575522c23a
commit 6826cc9ea0
4 changed files with 20 additions and 33 deletions
Whitespace
Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL
Split View
Diff Options
Show Stats Download Patch File Download Diff File
  1. 4
      python/pb_unit_tests/descriptor_test_wrapper.py
  2. 4
      python/pb_unit_tests/message_test_wrapper.py
  3. 12
      python/pb_unit_tests/reflection_test_wrapper.py
  4. 33
      python/pb_unit_tests/unknown_fields_test_wrapper.py

4
python/pb_unit_tests/descriptor_test_wrapper.py
Unescape View File

@ -47,9 +47,9 @@ descriptor_test.MakeDescriptorTest.testMakeDescriptorWithUnsignedIntField.__unit
# We must skip these tests entirely (rather than running them with
# __unittest_expecting_failure__) because they error out in setUp():
#
# NotImplementedError: unset repeated
# AttributeError: 'google.protobuf.pyext._message.DescriptorPool' object has no attribute 'Add'
#
# TODO: change to __unittest_expecting_failure__ when repeated fields are checked in.
# TODO: change to __unittest_expecting_failure__ when DescriptorPool.Add() is implemented
descriptor_test.DescriptorTest.testAggregateOptions.__unittest_skip__ = True
descriptor_test.DescriptorTest.testComplexExtensionOptions.__unittest_skip__ = True
descriptor_test.DescriptorTest.testContainingServiceFixups.__unittest_skip__ = True

4
python/pb_unit_tests/message_test_wrapper.py
Unescape View File

@ -126,9 +126,9 @@ message_test.Proto3Test.testSubmessageMap.__unittest_expecting_failure__ = True
# We must skip these tests entirely (rather than running them with
# __unittest_expecting_failure__) because they error out in setUpClass():
#
# NotImplementedError: unset repeated
# AttributeError: 'google.protobuf.pyext._message.DescriptorPool' object has no attribute 'Add'
#
# TODO: change to __unittest_expecting_failure__ when repeated fields are available
# TODO: change to __unittest_expecting_failure__ when DescriptorPoo.Add is implemented
message_test.OversizeProtosTest.__unittest_skip__ = True
if __name__ == '__main__':

12
python/pb_unit_tests/reflection_test_wrapper.py
Unescape View File

@ -137,14 +137,10 @@ reflection_test.SerializationTest.testSerializeUninitialized.__unittest_expectin
reflection_test.SerializationTest.testSerializeUninitializedSubMessage.__unittest_expecting_failure__ = True
reflection_test.SerializationTest.testSerializeWithOptionalGroup.__unittest_expecting_failure__ = True
reflection_test.TestAllTypesEqualityTest.testEmptyProtosEqual.__unittest_expecting_failure__ = True
# We must skip these tests entirely (rather than running them with
# __unittest_expecting_failure__) because they error out in setUp():
#
# NotImplementedError: access repeated
#
# TODO: change to __unittest_expecting_failure__ when repeated fields are available.
reflection_test.FullProtosEqualityTest.__unittest_skip__ = True
reflection_test.FullProtosEqualityTest.testAllFieldsFilledEquality.__unittest_expecting_failure__ = True
reflection_test.FullProtosEqualityTest.testNonRepeatedComposite.__unittest_expecting_failure__ = True
reflection_test.FullProtosEqualityTest.testNonRepeatedCompositeHasBits.__unittest_expecting_failure__ = True
reflection_test.FullProtosEqualityTest.testRepeatedComposite.__unittest_expecting_failure__ = True
if __name__ == '__main__':
unittest.main(module=reflection_test, verbosity=2)

33
python/pb_unit_tests/unknown_fields_test_wrapper.py
Unescape View File

@ -32,27 +32,18 @@ import unittest
# NotImplementedError: access repeated
#
# TODO: change to __unittest_expecting_failure__ when repeated fields are available
unknown_fields_test.UnknownEnumValuesTest.testCheckUnknownFieldValueForEnum.__unittest_skip__ = True
unknown_fields_test.UnknownEnumValuesTest.testRoundTrip.__unittest_skip__ = True
unknown_fields_test.UnknownEnumValuesTest.testUnknownEnumValue.__unittest_skip__ = True
unknown_fields_test.UnknownEnumValuesTest.testUnknownPackedEnumValue.__unittest_skip__ = True
unknown_fields_test.UnknownEnumValuesTest.testUnknownParseMismatchEnumValue.__unittest_skip__ = True
unknown_fields_test.UnknownEnumValuesTest.testUnknownRepeatedEnumValue.__unittest_skip__ = True
unknown_fields_test.UnknownFieldsAccessorsTest.testCheckUnknownFieldValue.__unittest_skip__ = True
unknown_fields_test.UnknownFieldsAccessorsTest.testClear.__unittest_skip__ = True
unknown_fields_test.UnknownFieldsAccessorsTest.testCopyFrom.__unittest_skip__ = True
unknown_fields_test.UnknownFieldsAccessorsTest.testMergeFrom.__unittest_skip__ = True
unknown_fields_test.UnknownFieldsAccessorsTest.testSubUnknownFields.__unittest_skip__ = True
unknown_fields_test.UnknownFieldsAccessorsTest.testUnknownExtensions.__unittest_skip__ = True
unknown_fields_test.UnknownFieldsAccessorsTest.testUnknownField.__unittest_skip__ = True
unknown_fields_test.UnknownFieldsAccessorsTest.testUnknownFieldsNoMemoryLeak.__unittest_skip__ = True
unknown_fields_test.UnknownFieldsTest.testByteSize.__unittest_skip__ = True
unknown_fields_test.UnknownFieldsTest.testDiscardUnknownFields.__unittest_skip__ = True
unknown_fields_test.UnknownFieldsTest.testEquals.__unittest_skip__ = True
unknown_fields_test.UnknownFieldsTest.testListFields.__unittest_skip__ = True
unknown_fields_test.UnknownFieldsTest.testSerialize.__unittest_skip__ = True
unknown_fields_test.UnknownFieldsTest.testSerializeMessageSetWireFormatUnknownExtension.__unittest_skip__ = True
unknown_fields_test.UnknownFieldsTest.testSerializeProto3.__unittest_skip__ = True
unknown_fields_test.UnknownEnumValuesTest.testCheckUnknownFieldValueForEnum.__unittest_expecting_failure__ = True
unknown_fields_test.UnknownEnumValuesTest.testRoundTrip.__unittest_expecting_failure__ = True
unknown_fields_test.UnknownFieldsAccessorsTest.testCheckUnknownFieldValue.__unittest_expecting_failure__ = True
unknown_fields_test.UnknownFieldsAccessorsTest.testClear.__unittest_expecting_failure__ = True
unknown_fields_test.UnknownFieldsAccessorsTest.testMergeFrom.__unittest_expecting_failure__ = True
unknown_fields_test.UnknownFieldsAccessorsTest.testSubUnknownFields.__unittest_expecting_failure__ = True
unknown_fields_test.UnknownFieldsAccessorsTest.testUnknownExtensions.__unittest_expecting_failure__ = True
unknown_fields_test.UnknownFieldsAccessorsTest.testUnknownField.__unittest_expecting_failure__ = True
unknown_fields_test.UnknownFieldsAccessorsTest.testUnknownFieldsNoMemoryLeak.__unittest_expecting_failure__ = True
unknown_fields_test.UnknownFieldsTest.testDiscardUnknownFields.__unittest_expecting_failure__ = True
unknown_fields_test.UnknownFieldsTest.testEquals.__unittest_expecting_failure__ = True
unknown_fields_test.UnknownFieldsTest.testSerializeMessageSetWireFormatUnknownExtension.__unittest_expecting_failure__ = True
if __name__ == '__main__':
unittest.main(module=unknown_fields_test, verbosity=2)

Write Preview
Loading…
Cancel
Save