From 662497f1d3dcced2bba1620cea9aae8b484bd3cd Mon Sep 17 00:00:00 2001 From: Mike Kruskal Date: Thu, 2 Feb 2023 18:49:36 -0800 Subject: [PATCH] Removing non-deterministic pointer sort. We're already doing a proper string sort in SortedEnums as of cl/503574792, but then we follow it up with a sort on the char* pointers. PiperOrigin-RevId: 506778694 --- upbc/protoc-gen-upb.cc | 4 ---- 1 file changed, 4 deletions(-) diff --git a/upbc/protoc-gen-upb.cc b/upbc/protoc-gen-upb.cc index b284c9670f..0433eccf00 100644 --- a/upbc/protoc-gen-upb.cc +++ b/upbc/protoc-gen-upb.cc @@ -869,10 +869,6 @@ void WriteHeader(const DefPoolPair& pools, upb::FileDefPtr file, } std::vector this_file_enums = SortedEnums(file); - std::sort(this_file_enums.begin(), this_file_enums.end(), - [](upb::EnumDefPtr a, upb::EnumDefPtr b) { - return a.full_name() < b.full_name(); - }); for (auto enumdesc : this_file_enums) { output("typedef enum {\n");