Merge pull request #1217 from jhump/jh/make-warning-useful

make 'no syntax' warning useful by showing which file
pull/1229/head
Joshua Haberman 9 years ago
commit 655a9d667f
  1. 6
      src/google/protobuf/compiler/parser.cc

@ -544,9 +544,9 @@ bool Parser::Parse(io::Tokenizer* input, FileDescriptorProto* file) {
// Store the syntax into the file. // Store the syntax into the file.
if (file != NULL) file->set_syntax(syntax_identifier_); if (file != NULL) file->set_syntax(syntax_identifier_);
} else if (!stop_after_syntax_identifier_) { } else if (!stop_after_syntax_identifier_) {
GOOGLE_LOG(WARNING) << "No syntax specified for the proto file. " GOOGLE_LOG(WARNING) << "No syntax specified for the proto file: "
<< "Please use 'syntax = \"proto2\";' or " << file->name() << ". Please use 'syntax = \"proto2\";' "
<< "'syntax = \"proto3\";' to specify a syntax " << "or 'syntax = \"proto3\";' to specify a syntax "
<< "version. (Defaulted to proto2 syntax.)"; << "version. (Defaulted to proto2 syntax.)";
syntax_identifier_ = "proto2"; syntax_identifier_ = "proto2";
} }

Loading…
Cancel
Save