Date and time need to be before version (#5777)

pull/5778/head
Paul Yang 6 years ago committed by GitHub
parent 580e1890a6
commit 5d8cd3b895
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 4
      php/ext/google/protobuf/package.xml
  2. 6
      update_version.py

@ -10,6 +10,8 @@
<email>protobuf-opensource@google.com</email>
<active>yes</active>
</lead>
<date>2019-02-22</date>
<time>11:31:21</time>
<version>
<release>3.7.0RC3</release>
<api>3.7.0</api>
@ -18,8 +20,6 @@
<release>beta</release>
<api>beta</api>
</stability>
<date>2019-02-22</date>
<time>11:31:21</time>
<license uri="https://opensource.org/licenses/BSD-3-Clause">3-Clause BSD License</license>
<notes>GA release.</notes>
<contents>

@ -213,6 +213,9 @@ def UpdatePhp():
return elem
root = document.documentElement
now = datetime.datetime.now()
ReplaceText(Find(root, 'date'), now.strftime('%Y-%m-%d'))
ReplaceText(Find(root, 'time'), now.strftime('%H:%M:%S'))
version = Find(root, 'version')
ReplaceText(Find(version, 'release'), GetFullVersion(rc_suffix = 'RC'))
ReplaceText(Find(version, 'api'), NEW_VERSION)
@ -220,9 +223,6 @@ def UpdatePhp():
ReplaceText(Find(stability, 'release'),
'stable' if RC_VERSION == 0 else 'beta')
ReplaceText(Find(stability, 'api'), 'stable' if RC_VERSION == 0 else 'beta')
now = datetime.datetime.now()
ReplaceText(Find(root, 'date'), now.strftime('%Y-%m-%d'))
ReplaceText(Find(root, 'time'), now.strftime('%H:%M:%S'))
changelog = Find(root, 'changelog')
for old_version in changelog.getElementsByTagName('version'):
if Find(old_version, 'release').firstChild.nodeValue == NEW_VERSION:

Loading…
Cancel
Save