Removed obsolete exemption for closed enums

The referenced bug was fixed long ago: https://github.com/protocolbuffers/upb/issues/541

PiperOrigin-RevId: 478870590
pull/13171/head
Joshua Haberman 2 years ago committed by Copybara-Service
parent 32c6e9baab
commit 5d0833f48c
  1. 7
      upb/reflection/field_def.c

@ -250,13 +250,6 @@ bool _upb_FieldDef_IsClosedEnum(const upb_FieldDef* f) {
if (UPB_TREAT_PROTO2_ENUMS_LIKE_PROTO3) return false; if (UPB_TREAT_PROTO2_ENUMS_LIKE_PROTO3) return false;
if (f->type_ != kUpb_FieldType_Enum) return false; if (f->type_ != kUpb_FieldType_Enum) return false;
// TODO(https://github.com/protocolbuffers/upb/issues/541):
// fix map enum values to check for unknown enum values and put
// them in the unknown field set.
if (upb_MessageDef_IsMapEntry(upb_FieldDef_ContainingType(f))) {
return false;
}
// TODO: Maybe make is_proto2 a bool at creation? // TODO: Maybe make is_proto2 a bool at creation?
const upb_FileDef* file = upb_EnumDef_File(f->sub.enumdef); const upb_FileDef* file = upb_EnumDef_File(f->sub.enumdef);
return upb_FileDef_Syntax(file) == kUpb_Syntax_Proto2; return upb_FileDef_Syntax(file) == kUpb_Syntax_Proto2;

Loading…
Cancel
Save