Fix MapAllocator::destroy() bug.

destroy() should always call the destructor because the caller may rely on
the destructor to do clean-ups.
pull/444/head
Feng Xiao 10 years ago
parent 802e1848ad
commit 5a9be2c6f6
  1. 14
      src/google/protobuf/map.h

@ -176,14 +176,12 @@ class Map {
template<class NodeType> template<class NodeType>
void destroy(NodeType* p) { void destroy(NodeType* p) {
if (arena_ == NULL) p->~NodeType(); p->~NodeType();
} }
#else #else
void construct(pointer p, const_reference t) { new (p) value_type(t); } void construct(pointer p, const_reference t) { new (p) value_type(t); }
void destroy(pointer p) { void destroy(pointer p) { p->~value_type(); }
if (arena_ == NULL) p->~value_type();
}
#endif #endif
template <typename X> template <typename X>
@ -201,10 +199,10 @@ class Map {
return arena_ != other.arena_; return arena_ != other.arena_;
} }
// To support Visual Studio 2008 // To support Visual Studio 2008
size_type max_size() const { size_type max_size() const {
return std::numeric_limits<size_type>::max(); return std::numeric_limits<size_type>::max();
} }
private: private:
Arena* arena_; Arena* arena_;

Loading…
Cancel
Save