From 595cb359c0317885ec05d88a85ae5e4287f6eac4 Mon Sep 17 00:00:00 2001 From: Keith Moyer Date: Thu, 27 Dec 2018 13:42:08 -0800 Subject: [PATCH] Rely on no-writable-strings synonym The -Wno-writable-strings warning flag is Clang-specific. GCC's equivalent is -Wno-write-strings, which Clang also supports as a synonym. So, -Wno-write strings is more compatible and there is no need to specify both. https://clang.llvm.org/docs/DiagnosticsReference.html#wwrite-strings https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html --- BUILD | 1 - 1 file changed, 1 deletion(-) diff --git a/BUILD b/BUILD index 253bc3edb2..1664621e95 100644 --- a/BUILD +++ b/BUILD @@ -54,7 +54,6 @@ COPTS = select({ "-Wno-sign-compare", "-Wno-unused-function", # Prevents ISO C++ const string assignment warnings for pyext sources. - "-Wno-writable-strings", "-Wno-write-strings", ], })