Fix hash computation for JRuby's RubyMessage

`System.identityHashCode` returns a hash that does not consider a
Message's values. This means two Messages with identical values will not
have identical hashCodes.

This patch uses the pattern from RubyMap to combine the hashCodes from
all values in a given message and produce a unique, consistent,
value-based hash.
pull/2163/head
Brendan Ribera 9 years ago committed by Bo Yang
parent b8e7e892c8
commit 525c6327ab
  1. 19
      ruby/src/main/java/com/google/protobuf/jruby/RubyMessage.java

@ -41,6 +41,8 @@ import org.jruby.runtime.ThreadContext;
import org.jruby.runtime.builtin.IRubyObject; import org.jruby.runtime.builtin.IRubyObject;
import org.jruby.util.ByteList; import org.jruby.util.ByteList;
import java.security.MessageDigest;
import java.security.NoSuchAlgorithmException;
import java.util.HashMap; import java.util.HashMap;
import java.util.Map; import java.util.Map;
@ -164,8 +166,21 @@ public class RubyMessage extends RubyObject {
*/ */
@JRubyMethod @JRubyMethod
public IRubyObject hash(ThreadContext context) { public IRubyObject hash(ThreadContext context) {
int hashCode = System.identityHashCode(this); try {
return context.runtime.newFixnum(hashCode); MessageDigest digest = MessageDigest.getInstance("SHA-256");
for (RubyMap map : maps.values()) {
digest.update((byte) map.hashCode());
}
for (RubyRepeatedField repeatedField : repeatedFields.values()) {
digest.update((byte) repeatedFields.hashCode());
}
for (IRubyObject field : fields.values()) {
digest.update((byte) field.hashCode());
}
return context.runtime.newString(new ByteList(digest.digest()));
} catch (NoSuchAlgorithmException ignore) {
return context.runtime.newFixnum(System.identityHashCode(this));
}
} }
/* /*

Loading…
Cancel
Save