From 5027ab288149d4aca8014c91368c0b2268f546e4 Mon Sep 17 00:00:00 2001 From: Adam Cozzette Date: Tue, 23 Jan 2024 16:08:46 -0800 Subject: [PATCH] Add TODO related to runtime dependency on Rake It's a little bit awkward that we currently have to take a runtime dependency on rake even though it is a build tool. This CL adds a TODO to explore moving the Rakefile logic to extconf.rb so that we can drop the rake dependency. PiperOrigin-RevId: 600936420 --- ruby/google-protobuf.gemspec | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/ruby/google-protobuf.gemspec b/ruby/google-protobuf.gemspec index 951df63000..372f290d6e 100644 --- a/ruby/google-protobuf.gemspec +++ b/ruby/google-protobuf.gemspec @@ -32,6 +32,10 @@ Gem::Specification.new do |s| s.add_development_dependency "rake-compiler-dock", "= 1.2.1" end s.required_ruby_version = '>= 2.7' + # TODO: evaluate removing Rakefile and moving logic to extconf.rb, so that we + # can remove this runtime dependency on rake. See the discussion here for + # more details: + # https://github.com/protocolbuffers/protobuf/pull/15203 s.add_dependency "rake", ">= 13" s.add_development_dependency "ffi", "~>1" s.add_development_dependency "ffi-compiler", "~>1"