Merge pull request #499 from haberman/python-pkg
Added a Bazel rule to build a binary wheel for Pythonpull/13171/head
Joshua Haberman
3 years ago
committed by
GitHub
commit
4b15cf3da2
5 changed files with 218 additions and 8 deletions
@ -0,0 +1,134 @@ |
||||
# Copyright (c) 2009-2021, Google LLC |
||||
# All rights reserved. |
||||
# |
||||
# Redistribution and use in source and binary forms, with or without |
||||
# modification, are permitted provided that the following conditions are met: |
||||
# * Redistributions of source code must retain the above copyright |
||||
# notice, this list of conditions and the following disclaimer. |
||||
# * Redistributions in binary form must reproduce the above copyright |
||||
# notice, this list of conditions and the following disclaimer in the |
||||
# documentation and/or other materials provided with the distribution. |
||||
# * Neither the name of Google LLC nor the |
||||
# names of its contributors may be used to endorse or promote products |
||||
# derived from this software without specific prior written permission. |
||||
# |
||||
# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND |
||||
# ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED |
||||
# WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE |
||||
# DISCLAIMED. IN NO EVENT SHALL Google LLC BE LIABLE FOR ANY |
||||
# DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES |
||||
# (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; |
||||
# LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND |
||||
# ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT |
||||
# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS |
||||
# SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. |
||||
|
||||
"""An implementation of py_proto_library(). |
||||
|
||||
We have to implement this ourselves because there is currently no reasonable |
||||
py_proto_library() rule available for Bazel. |
||||
|
||||
Our py_proto_library() is similar to how a real py_proto_library() should work. |
||||
But it hasn't been deeply tested or reviewed, and upb should not be in the |
||||
business of vending py_proto_library(), so we keep it private to upb. |
||||
""" |
||||
|
||||
load("@bazel_skylib//lib:paths.bzl", "paths") |
||||
load("@rules_proto//proto:defs.bzl", "ProtoInfo") # copybara:strip_for_google3 |
||||
|
||||
# Generic support code ######################################################### |
||||
|
||||
def _get_real_short_path(file): |
||||
# For some reason, files from other archives have short paths that look like: |
||||
# ../com_google_protobuf/google/protobuf/descriptor.proto |
||||
short_path = file.short_path |
||||
if short_path.startswith("../"): |
||||
second_slash = short_path.index("/", 3) |
||||
short_path = short_path[second_slash + 1:] |
||||
|
||||
# Sometimes it has another few prefixes like: |
||||
# _virtual_imports/any_proto/google/protobuf/any.proto |
||||
# benchmarks/_virtual_imports/100_msgs_proto/benchmarks/100_msgs.proto |
||||
# We want just google/protobuf/any.proto. |
||||
virtual_imports = "_virtual_imports/" |
||||
if virtual_imports in short_path: |
||||
short_path = short_path.split(virtual_imports)[1].split("/", 1)[1] |
||||
return short_path |
||||
|
||||
def _get_real_root(file): |
||||
real_short_path = _get_real_short_path(file) |
||||
return file.path[:-len(real_short_path) - 1] |
||||
|
||||
def _generate_output_file(ctx, src, extension): |
||||
real_short_path = _get_real_short_path(src) |
||||
real_short_path = paths.relativize(real_short_path, ctx.label.package) |
||||
output_filename = paths.replace_extension(real_short_path, extension) |
||||
ret = ctx.actions.declare_file(output_filename) |
||||
return ret |
||||
|
||||
# py_proto_library() ########################################################### |
||||
|
||||
def _py_proto_library_rule_impl(ctx): |
||||
# A real py_proto_library() should enforce this constraint. |
||||
# We don't bother for now, since it saves us some effort not to. |
||||
# |
||||
# if len(ctx.attr.deps) != 1: |
||||
# fail("only one deps dependency allowed.") |
||||
|
||||
files = [] |
||||
for dep in ctx.attr.deps: |
||||
files += dep[PyInfo].transitive_sources.to_list() |
||||
return [ |
||||
DefaultInfo(files = depset(direct = files)), |
||||
] |
||||
|
||||
def _py_proto_library_aspect_impl(target, ctx): |
||||
proto_info = target[ProtoInfo] |
||||
proto_sources = proto_info.direct_sources |
||||
srcs = [_generate_output_file(ctx, name, "_pb2.py") for name in proto_sources] |
||||
transitive_sets = proto_info.transitive_descriptor_sets.to_list() |
||||
ctx.actions.run( |
||||
inputs = depset( |
||||
direct = [proto_info.direct_descriptor_set], |
||||
transitive = [proto_info.transitive_descriptor_sets], |
||||
), |
||||
outputs = srcs, |
||||
executable = ctx.executable._protoc, |
||||
arguments = [ |
||||
"--python_out=" + _get_real_root(srcs[0]), |
||||
"--descriptor_set_in=" + ctx.configuration.host_path_separator.join([f.path for f in transitive_sets]), |
||||
] + |
||||
[_get_real_short_path(file) for file in proto_sources], |
||||
progress_message = "Generating Python protos for :" + ctx.label.name, |
||||
) |
||||
outs_depset = depset(srcs) |
||||
return [ |
||||
PyInfo(transitive_sources = outs_depset) |
||||
] |
||||
|
||||
_py_proto_library_aspect = aspect( |
||||
attrs = { |
||||
"_protoc": attr.label( |
||||
executable = True, |
||||
cfg = "exec", |
||||
default = "@com_google_protobuf//:protoc", |
||||
), |
||||
}, |
||||
implementation = _py_proto_library_aspect_impl, |
||||
provides = [ |
||||
PyInfo, |
||||
], |
||||
attr_aspects = ["deps"], |
||||
) |
||||
|
||||
py_proto_library = rule( |
||||
output_to_genfiles = True, |
||||
implementation = _py_proto_library_rule_impl, |
||||
attrs = { |
||||
"deps": attr.label_list( |
||||
aspects = [_py_proto_library_aspect], |
||||
allow_rules = ["proto_library"], |
||||
providers = [ProtoInfo], |
||||
), |
||||
}, |
||||
) |
||||
Loading…
Reference in new issue