From 47a84cdde81fbd519b8d7aab9cd77bb8a18ac4b8 Mon Sep 17 00:00:00 2001 From: Parikshit Adhikari <83907047+parikshitadhikari@users.noreply.github.com> Date: Fri, 13 Oct 2023 14:10:34 -0700 Subject: [PATCH] fix: typo inside docs/upb/design.md and docs/design/editions/edition-zero-features.md (#14385) Multiple typos has been fixed. - docs/upb/design.md -> line no 291: changed 'newMessageAccesor' to 'newMessageAccessor ' - docs/design/editions/edition-zero-features.md -> line no 149: changed 'implict' to 'implicit' Closes #14385 COPYBARA_INTEGRATE_REVIEW=https://github.com/protocolbuffers/protobuf/pull/14385 from parikshitadhikari:patch d9bf9f91bef1fb1187471db6f0e70bf9bc4de5d6 PiperOrigin-RevId: 573315890 --- docs/design/editions/edition-zero-features.md | 2 +- docs/upb/design.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/design/editions/edition-zero-features.md b/docs/design/editions/edition-zero-features.md index 655a59b3cf..f43f173b1a 100644 --- a/docs/design/editions/edition-zero-features.md +++ b/docs/design/editions/edition-zero-features.md @@ -146,7 +146,7 @@ We also make some semantic changes: * `proto3_optional` is rejected as a parse error (use the feature instead). Migrating from proto2/3 involves deleting all `optional`/`required` labels and -adding `IMPLICT` and `LEGACY_REQUIURED` annotations where necessary. +adding `IMPLICIT` and `LEGACY_REQUIURED` annotations where necessary. #### Alternatives diff --git a/docs/upb/design.md b/docs/upb/design.md index a46364af02..1192e6ccab 100644 --- a/docs/upb/design.md +++ b/docs/upb/design.md @@ -288,7 +288,7 @@ Dart for a message with only primitive fields currently looks something like: _accessor = $pb.instance.registry.newMessageAccessor(desc); ``` -The implementation of `newMessageAccesor()` is mainly just a wrapper around +The implementation of `newMessageAccessor()` is mainly just a wrapper around `upb_MiniTable_Build()`, which builds a MiniTable from a MiniDescriptor. In the code generator, the MiniDescriptor can be obtained from the `upb_MessageDef_MiniDescriptorEncode()` API; users should never need to encode a