From 455440fc47c2ff232a9ee796343a637c1c7f5f52 Mon Sep 17 00:00:00 2001
From: Paul Yang <TeBoring@users.noreply.github.com>
Date: Tue, 23 Jul 2019 15:07:26 -0700
Subject: [PATCH] Add binary conformance test for enum fields. (#6434)

* Add binary conformance test for enum fields.

* Add failed conformance test to js failure list
---
 conformance/binary_json_conformance_suite.cc | 7 ++++++-
 conformance/failure_list_js.txt              | 1 +
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/conformance/binary_json_conformance_suite.cc b/conformance/binary_json_conformance_suite.cc
index 96012a10b0..7c982f9312 100644
--- a/conformance/binary_json_conformance_suite.cc
+++ b/conformance/binary_json_conformance_suite.cc
@@ -804,11 +804,16 @@ void BinaryAndJsonConformanceSuite::RunSuiteImpl() {
     {delim("\xfb"), "\"\xfb\""},
     {delim(""), "\"\""},
   });
+  TestValidDataForType(FieldDescriptor::TYPE_ENUM, {
+    {varint(0), "FOO"},
+    {varint(1), "BAR"},
+    {varint(2), "BAZ"},
+    {varint(-1), "NEG"},
+  });
 
   // TODO(haberman):
   // TestValidDataForType(FieldDescriptor::TYPE_GROUP
   // TestValidDataForType(FieldDescriptor::TYPE_MESSAGE
-  // TestValidDataForType(FieldDescriptor::TYPE_ENUM
 
   RunValidJsonTest("HelloWorld", REQUIRED,
                    "{\"optionalString\":\"Hello, World!\"}",
diff --git a/conformance/failure_list_js.txt b/conformance/failure_list_js.txt
index f8f6a578fa..df70a9b02e 100644
--- a/conformance/failure_list_js.txt
+++ b/conformance/failure_list_js.txt
@@ -11,3 +11,4 @@ Required.Proto3.ProtobufInput.ValidDataRepeated.SINT32.ProtobufOutput
 Required.Proto3.ProtobufInput.ValidDataRepeated.SINT64.ProtobufOutput
 Required.Proto3.ProtobufInput.ValidDataRepeated.UINT32.ProtobufOutput
 Required.Proto3.ProtobufInput.ValidDataRepeated.UINT64.ProtobufOutput
+Required.Proto3.ProtobufInput.ValidDataRepeated.ENUM.ProtobufOutput